STINNER Victor added the comment:
Note: bench_scandir2.py is a micro-benchmark. Ben's benchmark using walk() is
more realistic, but I'm interested by micro-benchmark results.
scandir-2.patch is faster than scandir-6.patch, much fast on Windows.
Result of bench (cached): scandir-6.patch =
STINNER Victor added the comment:
Hi Ben,
2015-02-13 4:51 GMT+01:00 Ben Hoyt rep...@bugs.python.org:
Hi Victor, I thank you for your efforts here, especially your addition of
DirEntry.inode() and your work on the tests.
The addition of inode() should still be discussed on python-dev. The
Changes by STINNER Victor victor.stin...@gmail.com:
--
versions: +Python 2.7 -Python 3.4, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23458
___
Changes by Alexei Romanov drednout...@gmail.com:
--
nosy: +alexei.romanov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22524
___
___
Roundup Robot added the comment:
New changeset 8e2388b1e875 by Serhiy Storchaka in branch '2.7':
Issue #21840: Fixed expanding unicode variables of form $var in
https://hg.python.org/cpython/rev/8e2388b1e875
--
nosy: +python-dev
___
Python tracker
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
dependencies: -Fix unicodeless build of Python
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 544c5d4f4084 by Serhiy Storchaka in branch '2.7':
Issue #21840: Fixed a typo.
https://hg.python.org/cpython/rev/544c5d4f4084
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21840
Ivailo Monev added the comment:
Can you please apply fix-root-prefix.patch? Or the updated version fof
issue9674.patch that I've attached?
sysconfig tests will still fail and it will return bogus paths with double
slash (e.g. //lib/python2.7) but at least Python will be installable with
New submission from STINNER Victor:
Attached patch tries to make the private random file descriptor non-inheritable.
It should fix the following issue:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197376
I tried to write an unit test, but since the PEP 446 is not implemented,
unexpected
Changes by STINNER Victor victor.stin...@gmail.com:
Added file: http://bugs.python.org/file38127/test_fd_status.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23458
___
Serhiy Storchaka added the comment:
The patch is updated to current sources. Also optimized writing ASCII strings
and fixed tests.
--
versions: +Python 3.5 -Python 3.3
Added file: http://bugs.python.org/file38128/fix_bad_persid_2.patch
___
Python
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +koobs
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23458
___
___
Python-bugs-list
Ned Deily added the comment:
So the real problem here is configuring with --prefix=/ and then using make
install DESTDIR to install to a temporary location. This is a duplicate of
Issue9674; the problem is that --prefix=/ results in build variable the start
with '//', like '//lib', and that
STINNER Victor added the comment:
Result of bench (cached): scandir-6.patch = scandir-2.patch
(...)
laptop using SSD and ext4: 1.3x faster = 2.8x faster
desktop PC using HDD and ext4: 1.4x faster = 1.4x faster
Oops, I copied the wrong numbers. scandir-2.patch is faster than that!
* laptop
Serhiy Storchaka added the comment:
Ping.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23148
___
___
Python-bugs-list mailing list
Serhiy Storchaka added the comment:
Ping.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23147
___
___
Python-bugs-list mailing list
Roundup Robot added the comment:
New changeset a4a3a8b3f37f by Serhiy Storchaka in branch '2.7':
Issue #21849: Fixed xmlrpclib serialization of non-ASCII unicode strings in
https://hg.python.org/cpython/rev/a4a3a8b3f37f
New changeset 908533d5a427 by Serhiy Storchaka in branch '3.4':
Issue
Steve Dower added the comment:
int_overflows.patch looks good to me.
I really appreciate that these patches have been done properly too - I've seen
far too much code where people just throw in casts to silence the warnings.
This is why I like working on Python :)
--
Steve Dower added the comment:
I can't reproduce this easily. Could you delete the externals/tcltk folder and
the Debug_VC12 folders under tk.../win, tix.../win and tcl-core.../win, rebuild
and capture the output from the VS Output window? Apparently something in one
of these external
Changes by Steve Dower steve.do...@microsoft.com:
--
nosy: +steve.dower
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9566
___
___
Steve Dower added the comment:
I don't even know what pgen is or why I'd want to build it...
If running it updates a file that would trigger a rebuild, then I'd really like
it to copy what _freeze_importlib currently does as far as writing to a
temporary file and conditionally overwriting the
Demian Brecht added the comment:
Thanks for the review Martin, I've addressed your comments.
The length of an encoded Latin-1 string should equal the length of the
unencoded text string, since it is a one-to-one character-to-byte encoding.
Once in a while, I want to stop what I'm doing, put
Antoine Pitrou added the comment:
I'm not sure what the point is - there are many child descriptors which may
inherited, why care about this one?
The right way to avoid this on 2.7 is to call subprocess.Popen(...,
close_fds=True).
--
___
Python
New submission from Ian Kelly:
'{:g}'.format(D('0.01'))
'0.01'
Formatted with '{:e}', the exponent would be -6, so per the formatting rules
described under the 'g' specifier at
https://docs.python.org/3/library/string.html#format-specification-mini-language
the above should be
STINNER Victor added the comment:
I'm not sure what the point is - there are many child descriptors which may
inherited, why care about this one?
The bug report comes from FreeBSD,
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197376
They use os.system(), at least in the bug report.
Steve Dower added the comment:
Already reported at https://github.com/pypa/pip/issues/1889
--
resolution: - third party
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21568
Steve Dower added the comment:
expanduser() sounds like the better choice here.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20523
___
___
Steve Dower added the comment:
Other than my one query on the review, code_ssize_t_2.patch.patch looks good to
me.
--
nosy: +steve.dower
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18295
Zachary Ware added the comment:
I don't even know what pgen is or why I'd want to build it...
pgen is the parser generator, taking Grammar/Grammar as input and generating
Include/graminit.h and Python/graminit.c. Only useful when you're changing
Python's grammar, but without the ability to
Davin Potts added the comment:
This issue was marked as not a bug by OP a while back but for whatever reason
it did not also get marked as closed. Going ahead with closing it now.
--
nosy: +davin
stage: needs patch - resolved
status: open - closed
Changes by Demian Brecht demianbre...@gmail.com:
--
nosy: -demian.brecht
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17229
___
___
R. David Murray added the comment:
This is either related to or effectively a duplicate of issue 10466, which
contains a fair amount of discussion of the underlying problems.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
Changes by Demian Brecht demianbre...@gmail.com:
--
nosy: +demian.brecht
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23440
___
___
Brett Cannon added the comment:
Dead code deletion should be a separate issue, so I'm going to close this as
fixed.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15914
Changes by Demian Brecht demianbre...@gmail.com:
--
nosy: +demian.brecht
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23410
___
___
Brett Cannon added the comment:
If you want to take a stab at it, Steven, go for it and I will review the
patch, but as you pointed out this is such an edge case that I'm personally not
going to worry about fixing it and still don't consider it a bug.
--
title: Relative imports with
Demian Brecht added the comment:
LGTM.
+1
--
nosy: +demian.brecht
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23418
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset d2dbec7d74d0 by Berker Peksag in branch '3.4':
Issue #23418: Add missing entries to http.server.__all__.
https://hg.python.org/cpython/rev/d2dbec7d74d0
New changeset 03e3e78014ea by Berker Peksag in branch 'default':
Issue #23418: Add missing
R. David Murray added the comment:
Since that library is not part of the stdlib, this is not an appropriate patch
for CPython.
Note that this issue is also relevant to the email library, which intends to
support RFC2616 header parsing/generation, and therefore should also be
enhanced to
Berker Peksag added the comment:
Thanks for the review, Serhiy. I'll take a look at the zipfile patch tomorrow.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21717
___
Berker Peksag added the comment:
LGTM.
--
nosy: +berker.peksag
stage: - commit review
versions: +Python 2.7, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17527
___
Berker Peksag added the comment:
I'm not sure this needs to be fixed in 2.7. I would only use demo_app to test
WSGI servers. Otherwise, you need to create your own application. However, the
code is correct in Python 3:
R. David Murray added the comment:
Sorry, when I said effectively a duplicate I didn't mean *actually* a
duplicate, I meant that fixing one will either result in or require fixing the
other (same core cause: the disconnect between the Windows names and the unix
names and the need for a
Berker Peksag added the comment:
Fixed. Thanks Martin (also thanks to Demian for the review).
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23418
Roundup Robot added the comment:
New changeset ed9e9e6b3c1e by Berker Peksag in branch 'default':
Issue #21717: tarfile.open() now supports 'x' (exclusive creation) mode.
https://hg.python.org/cpython/rev/ed9e9e6b3c1e
--
nosy: +python-dev
___
Python
Berker Peksag added the comment:
Here is an updated patch. For InputWrapper.read(), see issue 18610.
--
nosy: +berker.peksag
stage: - patch review
versions: +Python 3.4, Python 3.5 -Python 3.3
Added file: http://bugs.python.org/file38131/issue14652.diff
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17852
___
___
Python-bugs-list
Eric Snow added the comment:
This implies to me that someone didn't include importlib.h in their commit when
they changed something that required it to be rebuilt. However, if it's a
Windows-only thing then perhaps there is something else afoot. Steve?
--
nosy: +brett.cannon,
albertjan added the comment:
I agree that the two issues are related, but I don't see how they could be
duplicates. But maybe that's because I do not know the underlying code.
issue 10466 is mostly about getdefaultlocale() and whether it's desirable or
not that its return value is always
Steve Dower added the comment:
Hmm, so maybe it only happens after you build the 64-bit version first. But
apparently it's more complex than that, since that doesn't repro either. When I
get some more time I'll run though and double check all the rebuild conditions,
but it has worked fine for
Zachary Ware added the comment:
What does the diff to importlib.h look like? Does it look like a real change
to importlib or is it something innocuous like a change in whitespace or the
path separator in the heading?
--
components: +Build, Windows
nosy: +tim.golden, zach.ware
New submission from Paul Moore:
When building Python (cpython repository, tip revision on the default branch)
using Visual Studio 2015 (version downloaded 12/02/2015) I get a message in the
build:
C:\Work\Projects\cpython\PCbuild\_freeze_importlib.vcxproj(98,5): error :
importlib.h has been
Roundup Robot added the comment:
New changeset 99302634d756 by Berker Peksag in branch 'default':
Issue #14910: Add allow_abbrev parameter to argparse.ArgumentParser.
https://hg.python.org/cpython/rev/99302634d756
--
nosy: +python-dev
___
Python
Martin Panter added the comment:
It looks like the C _io close() implementations delegate to the wrapped
object’s undocumented _dealloc_warn() method to emit the warning if
“self-finalizing” is set. For wrapped objects like BytesIO that do not have
it, I guess the error due to the missing
Steve Dower added the comment:
Windows is probably the only platform that detects when _freeze_importlib makes
a change and aborts the build :)
I'd be interested to see what the diff is though. My guess is some of the
recent marshal changes may have affected the output.
--
Mark Lawrence added the comment:
I don't have externals/tcltk, only externals/tcltk64. There is a Debug_VC12
folder under tix.../win. There is no Debug_VC12 folder under tk.../win,
tcl-core.../win or for that matter tcl.../win, only Debug_AMD64_VC12.
--
Akira Li added the comment:
As I've mentioned in http://bugs.python.org/issue22524#msg231703
os.walk size 7925376343, scandir.walk size 5534939617 -- NOT EQUAL!
os.walk and scandir.walk do a different work here.
I don't see that it is acknowledged so I assume the benchmark is not fixed.
If
Changes by Terry J. Reedy tjre...@udel.edu:
--
resolution: - duplicate
stage: - resolved
status: open - closed
superseder: - windows console doesn't print or input Unicode
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23424
Paul Moore added the comment:
Ah. It's 4K lines of everything changing. Looks like it might be an EOL issue.
The build seems to be changing it from LF line endings to CRLF line endings.
--
___
Python tracker rep...@bugs.python.org
Berker Peksag added the comment:
Committed. Thank you all for patches and reviews :)
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14910
eryksun added the comment:
-setlocale should return nothing. It's a setter
-getlocale should return a platform-specific locale specification,
probably what is currently returned by setlocale. The output
should be ready for consumption by setlocale.
These functions are well documented, so
Zachary Ware added the comment:
Ah ha. Do you have the hg eol extension enabled? If not, you
probably should; it makes for far fewer headaches on Windows, and
should make this issue go away.
We should probably try to mitigate the problem anyway; Steve, how hard
would it be to change the 'see
Berker Peksag added the comment:
The binascii documentation already says
``a2b_*`` functions accept Unicode strings containing only ASCII characters.
[...]
.. versionchanged:: 3.3
ASCII-only unicode strings are now accepted by the ``a2b_*`` functions.
I think we can just remove
Steve Dower added the comment:
It's possible, but the eol extension is the best way to handle it.
Doing the comparison is relatively easy (we can just strip all '\r' and '\n'
characters and compare), but if it has changed, it's much harder to update the
new file to match whatever the old file
Paul Moore added the comment:
I'm just about finished for the night but I'll try the eol extension tomorrow.
I don't really use it much, though, my practice is generally to make all my
tools use LF. I certainly didn't do anything that would change that file, so
something in the build must be
Martin Panter added the comment:
That’s another option. Someone might wonder why a2b_hex() and a2b_qp() actually
accept text strings in Python 3.1 when the documentation says you need 3.3, but
I guess that’s not such a big deal. Posting patch v3 which removes the 3.2
notices.
--
Zachary Ware added the comment:
The other option would be to change _freeze_importlib to force it to
use \n instead of \r\n; I'm not sure which change would be harder to
do.
Paul: fair enough; I've just found that keeping eol enabled reduces
headaches due to line endings to almost nothing, just
Mark Lawrence added the comment:
I noticed a few days ago that this file had changed as I got a merge conflict
using the tortoisehg sychronize command. At the time I didn't think much of it
and believe I simply let hg sort it out. The changeset was 8ab6b404248c #21295.
--
nosy:
Demian Brecht added the comment:
Here's a patch addressing the potential vulnerability as reported. The patch
should also bring the implementation up to date with the most recent standards
around header names and values.
There could be potential for breaking compatibility if people are
Ben Hoyt added the comment:
Akari: yes, I'm aware of this, and it's definitely a concern to me -- it may be
that scandir has a bug with counting the size of certain non-file directory
entries, or my implementation of os.walk() via scandir is not quite correct.
I'll look at it before too long!
Demian Brecht added the comment:
LGTM
--
versions: +Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23440
___
___
Python-bugs-list
Demian Brecht added the comment:
Minor comment in Rietveld, otherwise LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23410
___
___
New submission from STINNER Victor:
execveat() was added to Linux in kernel 3.19:
http://man7.org/linux/man-pages/man2/execveat.2.html
It may be interesting to expose it in Python.
The primary aim of adding an execveat syscall is to allow an
implementation of fexecve(3) that does not rely on
Martin Panter added the comment:
Posting a new patch which closes the file object, and also does the same for
the SSL class.
--
Added file: http://bugs.python.org/file38137/issue22351_nntp_fail_3.patch
___
Python tracker rep...@bugs.python.org
Martin Panter added the comment:
New patch looks good I think. Making the encoding code more consistent is nice.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23350
___
Martin Panter added the comment:
One option would be for any wrapper-type class (e.g. BufferedReader, SocketIO)
to override __del__(). Instead of calling close(), it should call detach() or
equivalent, and delete the returned reference to the underlying wrapped object
without explicitly
Martin Panter added the comment:
I believe this still leaves the socket open via the “file” object. Just that
there is no ResourceWarning generated due to the way IOBase.__del__() works.
--
___
Python tracker rep...@bugs.python.org
Changes by Martin Panter vadmium...@gmail.com:
Removed file: http://bugs.python.org/file38135/del-flush.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19829
___
Martin Panter added the comment:
If we’re in the realm of 3.5 only changes, it might make sense to remove the
multi-argument mode of putheader() altogether, and document it only generates a
single line. (Currently still says it generates multiple lines.)
--
Demian Brecht added the comment:
I think that keeping the public API as-is is the better way to go, at
least for the shorter term given it won't require users to have to make
code changes. Thanks for the catch on the docs though, will update that.
--
Martin Panter added the comment:
Good point. Maybe join them with tabs rather than spaces then, since it was
previously \r\n\t. This way it is even closer to before.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22928
Martin Panter added the comment:
Posting del-flush.patch, which only calls flush() instead of close() from
__del__(), except for the FileIO class. Quick analysis of resulting test
failures:
These tests fail because they are obviously written to test that __del__ calls
close():
*
Changes by Martin Panter vadmium...@gmail.com:
Added file: http://bugs.python.org/file38136/del-flush.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19829
___
Paul Moore added the comment:
No, enabling the eol extension didn't fix it :-(
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23461
___
___
Paul Moore added the comment:
Correction. Looks like if I enable the eol extension, then hg revert
importlib.h, then rebuild, the problem then goes away.
So basically you need the eol extension enabled *before* you update/clone your
checkout.
--
85 matches
Mail list logo