Roundup Robot added the comment:
New changeset 585e555247ac by Steve Dower in branch 'default':
Issue #23765: Remove IsBadStringPtr calls in ctypes
https://hg.python.org/cpython/rev/585e555247ac
--
nosy: +python-dev
___
Python tracker
Steve Dower added the comment:
I haven't seen any of these in a while, and the buildbot at
http://buildbot.python.org/all/builders/AMD64%20Windows8%203.x (the only one
running VS 2015 right now AFAIK) hasn't either, so I'm calling this fixed.
--
resolution: - fixed
status: open -
Serhiy Storchaka added the comment:
I think it would be safer to defer automatically chaining exceptions to 3.6.
After releasing 3.5 we can got reports about exceptions ignored by mistake.
After fixing all bugs not covered by the testsuite, we could try automatically
chain exceptions. May be
Changes by Ned Deily n...@acm.org:
--
nosy: +brett.cannon
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23773
___
___
Steve Dower added the comment:
I've committed a change that adds a submenu for IDLE almost exactly like Liam's
mockup.
Thanks for pushing me on this, I probably wouldn't have worked this hard to get
something as robust otherwise :)
--
___
Python
Changes by Steve Dower steve.do...@microsoft.com:
--
resolution: - fixed
stage: needs patch - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23765
___
Changes by Steve Dower steve.do...@microsoft.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23465
___
Roundup Robot added the comment:
New changeset d094eeeb1496 by Steve Dower in branch 'default':
Closes #9445: Removes detection of GetFinalPathNameByHandle
https://hg.python.org/cpython/rev/d094eeeb1496
--
nosy: +python-dev
stage: patch review - resolved
status: open - closed
Steve Dower added the comment:
Migrated the test failures to #23774 and closing this.
--
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23619
Steve Dower added the comment:
I'm not exactly sure how msiexec does its parsing, but it's possible that
ALLUSERS=1 may not actually be the same as ALLUSERS=1. I use the latter
regularly with most versions of Python in existence and it works fine.
There may also be problems upgrading from the
New submission from Steve Dower:
The following tests fail when run in an all-users installation because they
cannot write to the install directory:
test_compileall test_tcl test_tools test_zipfile
See the attached file for traces.
From Ned Deily:
Regarding tests trying to write into the
Ned Deily added the comment:
Slavek, this issue and its superseder are both closed so comments here will
likely not be acted on.
--
nosy: +ned.deily
stage: needs patch - resolved
___
Python tracker rep...@bugs.python.org
Changes by Ned Deily n...@acm.org:
--
nosy: +doko
stage: - patch review
versions: +Python 2.7, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23767
___
Serhiy Storchaka added the comment:
Many thanks Victor for fixing crashes. Unfortunately I couldn't reproduce a
crash on my computers, perhaps it is was 64-bit only.
Yes, I'll look how the code can be optimized.
--
___
Python tracker
Steve Dower added the comment:
I've seen some module paths be registered there, but no, it doesn't really get
used much (maybe because it's been broken?) os.name is certainly the right test
here.
FWIW, I'd rather be prioritising file system over registry for finding packages
anyway. It makes
Roundup Robot added the comment:
New changeset b2a8c30d8ddb by Serhiy Storchaka in branch 'default':
Issue #21717: The zipfile.ZipFile.open function now supports 'x' (exclusive
https://hg.python.org/cpython/rev/b2a8c30d8ddb
--
___
Python tracker
Serhiy Storchaka added the comment:
The only difference is in error message.
For now:
unicodedata.name(123)
Traceback (most recent call last):
File stdin, line 1, in module
TypeError: must be str, not int
unicodedata.name('123')
Traceback (most recent call last):
File stdin, line 1, in
Serhiy Storchaka added the comment:
There is a guard for zipfile tests (requiresWriteAccess). The question is why
it doesn't work for this test but works for other tests.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
New submission from Serhiy Storchaka:
Currently pprint prints the repr of OrderedDict if it fits in one line, and
prints the repr of dict if it is wrapped.
import collections, pprint
pprint.pprint(collections.OrderedDict([(4, 3), (2, 1)]))
OrderedDict([(4, 3), (2, 1)])
Larry Hastings added the comment:
I read it quickly. It looks basically okay, but I have one issue to discuss
right now. Changing from the format unit 'O!' and calling getuchar to the
format unit 'C' means a change in semantics. The text in the exception will
change. Unfortunately, people
STINNER Victor added the comment:
Le mercredi 25 mars 2015, Serhiy Storchaka rep...@bugs.python.org a
écrit :
I think it would be safer to defer automatically chaining exceptions to
3.6. After releasing 3.5 we can got reports about exceptions ignored by
mistake.
Hum, what change can ignore
Berker Peksag added the comment:
LGTM. I left two minor comments on Rietveld. Sorry for the delay.
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21717
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21717
___
Robert Kuska added the comment:
I tried leak2.py with valgrind, I've uncommented the lines you mentioned.
$ valgrind python3 leak2.py
Serhiy Storchaka added the comment:
Similar issues are issue8361 and issue17840.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23776
___
___
New submission from SpaceOne:
parser.add_subparsers(dest='arguments', action='append')
will raise the following exception:
File /usr/lib/python2.7/argparse.py, line 1675, in add_subparsers
action = parsers_class(option_strings=[], **kwargs)
TypeError: __init__() got an unexpected keyword
Paul Moore added the comment:
I think the main (only?) user of having sys.path entries in the registry is
pywin32. It might be worth asking them if they can switch to a more mainstream
approach, and then maybe the whole registry finder thing can be removed
completely.
--
nosy:
Antoine Pitrou added the comment:
Given interned strings can already be compared by pointer, I'd recommend people
call sys.intern() on their strings if they want really fast equality
comparisons.
--
nosy: +pitrou, tim.peters
___
Python tracker
Changes by Alexei Romanov drednout...@gmail.com:
--
nosy: +alexei.romanov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23775
___
___
eryksun added the comment:
c_char_p.__repr__ (defined in __init__.py) also checks IsBadStringPtrA via FFI.
Defining the repr differently on Windows is a wart, IMO. The following repr
should be used on all platforms for c_char_p:
%s(%s) % (self.__class__.__name__,
New submission from Serhiy Storchaka:
The assert statement should be used only for checking internal logic, and not
for checking user data. These assertions should be either removed or converted
into explicit raising ValueError.
--
components: Library (Lib)
messages: 239241
nosy:
Changes by Serhiy Storchaka storch...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file38685/pprint_args_check.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23776
Berker Peksag added the comment:
Looks good. Two things:
* I'd apply this only to the default branch. Changing exceptions from
AssertionError to ValueError in bugfix releases may break third party code. I
couldn't find a similar bug report in the tracker, so it's probably not worth
to take
Martin Panter added the comment:
Another behaviour change in v7 is the seekable() return value is now inherited
from underlying file, instead of always being True. I mentioned on Reitveld why
this could be a bad idea, but as it is undocumented and untested and will leave
the new behaviour
Marc-Andre Lemburg added the comment:
I wouldn't make this the default, since the probability is small, but not zero.
However, it may be worth exploring this as dict sub-type for applications to
use which could benefit from it.
For internal strings, we already use interning, so no win there.
R. David Murray added the comment:
Well, clearly you are the interested party that solved it :) Thanks.
Unfortunately I don't know that we have a place where this could be documented,
since currently mingw isn't a fully supported platform. Perhaps in the
distutils docs somewhere?
Bob added the comment:
What I see is that structs lager that 8 bytes are not passed correctly to a
callback funtion.
I've attached a patchfile that includes my fix and a test to demonstrate the
problem.
--
Added file: http://bugs.python.org/file38687/large_struct_callback.patch
Changes by R. David Murray rdmur...@bitdance.com:
--
resolution: - duplicate
stage: - resolved
status: open - closed
superseder: - json encoder does not support JSONP/JavaScript safe escaping
___
Python tracker rep...@bugs.python.org
Steve Dower added the comment:
Thanks, I forgot to scan .py files.
--
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23765
___
Serhiy Storchaka added the comment:
In case of class or module dicts attribute names usually are interned. So no
string comparison is needed if the key is found. It is needed only when the key
is not found, but found a key with the same hash (with the chance 5e-28). The
benefit of
Changes by Brett Cannon br...@python.org:
--
assignee: - brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23773
___
___
Cyd Haselton added the comment:
Ryan,
From where do you want me to download Python for testing?
I'm assuming I need to test by a) downloading an unpatched 3.4.2, b) applying
patches, c) running ./configure make make install.. If this is not
correct let me know
--
Nick Coghlan added the comment:
Correctly processing a function's signature involves following the __wrapped__
chains to get to the underlying callable (or to a callable that defines an
explicitly modified __signature__ value).
inspect.signature follows these chains automatically, and in 3.4+
R. David Murray added the comment:
I think you need to explain exactly what it is you are looking for, because it
doesn't seem to me that you can change the argspec of a function. What is it
that decorator is doing that is helpful?
--
___
Python
R. David Murray added the comment:
We need a buildbot that runs tests on an installed python. The general problem
is not windows-only.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23774
Roundup Robot added the comment:
New changeset 9f4d2bdced9c by Serhiy Storchaka in branch '2.7':
Issue #23742: ntpath.expandvars() no longer loses unbalanced single quotes.
https://hg.python.org/cpython/rev/9f4d2bdced9c
New changeset 613c4bd1c29c by Serhiy Storchaka in branch '3.4':
Issue
New submission from Demian Brecht:
This came up during #2211, where a multiline versionchanged entry was
suggested. Currently, there is no visual distinction between any but the first
line of the description and the rest of the body of the docs. The attached
patch adds a consistent level of
Demian Brecht added the comment:
it would be better to consolidate the three adjacent versionchanged entries
into one
I created the three versionchanged items because there's no visual distinction
between the second and third lines and the rest of the doc tests in the
rendered output. I've
Demian Brecht added the comment:
FWIW, I created #23778 to address the indentation issue.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
Steve Dower added the comment:
I think these days as soon as a repro includes import distutils or import
setuptools the docs go straight to http://pypa.io :)
--
nosy: +ncoghlan
___
Python tracker rep...@bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23742
___
Tim Golden added the comment:
I think they stopped using them a while back in favour of a pywin32.pth
file.
I don't think I even knew you could use the registry for sys.path.
If no-one's shouted since the changes to importlib (which was 3.3?) I
think we can quietly drop this and hope no-one
Tim Golden added the comment:
Adding Mark Hammond in case I'm wrong about the (lack of) impact on pywin32
--
nosy: +mhammond
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21319
___
R. David Murray added the comment:
The body of the versionchanged has to be a single paragraph (no blank lines).
Usually we start each sentence on a newline in the source, but it comes out
rendered as a single flowed paragraph. Perhaps eventually someone will add
support to Sphinx for
Ryan Gonzalez added the comment:
No; you need the CPython tip. You can use https://github.com/python/cpython.
Other than that, it's the configure+make thing.
As I said before, the pyconfig.h changes aren't there yet. Trying to figure out
how I want to approach those.
--
R. David Murray added the comment:
Heh, you clearly know more about docutils/css than I do.
I don't think we want multiple blank delimited paragraphs under a
versionchanged directive, though, from a style point of view. A compact
unordered list would be best.
--
nosy: +georg.brandl,
Changes by Dan O'Reilly oreil...@gmail.com:
--
nosy: +dan.oreilly
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8800
___
___
Python-bugs-list
Liam Marsh added the comment:
thank you for all this hard work.
really.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23546
___
___
paul j3 added the comment:
OK, so you are thinking about what happens to the subparsers `dest` when the
user names a command. That isn't handled by the `store` action, but by the
call of the subparsers action
class _SubParsersAction(Action):
def __call__
Demian Brecht added the comment:
Sounds good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23778
___
___
Python-bugs-list mailing list
Demian Brecht added the comment:
I noted in #2211 that nested lists are supported by Sphinx, so that solves that
specific issue. Perhaps it /may/ still be useful to have this though in order
to support multiple paragraphs for more detailed change descriptions when
needed? That said, I'm not
paul j3 added the comment:
As to the nature of the error when 'add_subparsers' is given an 'action'
parameter:
'add_subparsers' does several things to 'kwargs' before it passes them to the
relevant Action class.
def add_subparsers(self, **kwargs):
# adds 'parser_class'
#
Berker Peksag added the comment:
I think David's suggestion in msg239260 was good enough for now :) You'll need
to create a custom versionchanged directive to generate a valid and semantic
markup for the usage in http_cookies_morsel_deprecated_set_2.patch. I also left
a couple comments on
R. David Murray added the comment:
Yes, exactly, they are supposed to be terse. So I think we should reject this.
--
resolution: - rejected
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
Demian Brecht added the comment:
Problem (pretty much) solved. Nested unordered lists are supported. I've
updated the versionchanged information to use the list.
--
Added file:
http://bugs.python.org/file38690/http_cookies_morsel_deprecated_set_2.patch
Tim Graham added the comment:
Will this regression be fixed in Python 2.7, 3.2, and 3.3? If not, Django may
need to vendor Python's cookie class to workaround this bug to prevent users
from losing sessions and/or being unable to login to Django powered sites as
reported in
Changes by paul j3 ajipa...@gmail.com:
--
assignee: - docs@python
components: +Documentation
nosy: +docs@python
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23487
___
Josiah Carlson added the comment:
I'm going to be honest; seeing None being returned from a pipe read feels
*really* broken to me. When I get None returned from an IO read operation, my
first instinct is there can't be anything else coming, why else would it
return None?
After changing
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22364
___
Serhiy Storchaka added the comment:
Here is a patch for UserDict, that keep current behavior, but allows to pass
keys self and dict if positional parameter dict is specified.
UserDict(self=42)
{'self': 42}
UserDict({}, dict=42)
{'dict': 42}
UserDict(dict={'a': 42})
{'a': 42}
--
Roundup Robot added the comment:
New changeset 068365acbe73 by Serhiy Storchaka in branch 'default':
Issue #22364: Improved some re error messages using regex for hints.
https://hg.python.org/cpython/rev/068365acbe73
--
nosy: +python-dev
___
Python
Akira Li added the comment:
I'm going to be honest; seeing None being returned from a pipe read feels
*really* broken to me. When I get None returned from an IO read operation, my
first instinct is there can't be anything else coming, why else would it
return None?
It is how it is done
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag
versions: +Python 3.5 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17305
___
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file38693/re_scoped_flags_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue433028
___
Serhiy Storchaka added the comment:
Updated to the tip.
Could anyone please help with documentation?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue433028
___
Berker Peksag added the comment:
LGTM. Added minor comments on Rietveld.
--
nosy: +berker.peksag
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23775
___
Changes by Eric V. Smith e...@trueblade.com:
--
stage: - test needed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23779
___
___
Python-bugs-list
eryksun added the comment:
So the repr that's there for c_char_p is currently::
%s(%s) % (self.__class__.__name__, cast(self, c_void_p).value)
I suggested switching to using from_buffer:
c_void_p.from_buffer(self).value
from_buffer is more efficient. cast() is imlemented as an FFI
Steve Dower added the comment:
So the repr that's there for c_char_p is currently::
%s(%s) % (self.__class__.__name__, cast(self, c_void_p).value)
But if I remove the override then it renders the value as b'abc'. Basically, we
can have one of:
from ctypes import *
Changes by Eric V. Smith e...@trueblade.com:
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23779
___
___
Python-bugs-list
Nick Coghlan added the comment:
Backport proposal: https://github.com/aliles/funcsigs/issues/12
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23764
___
STINNER Victor added the comment:
Returning None for non blocking I/O is standard in Python.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1191964
___
Demian Brecht added the comment:
Updated patch should address review comments. I did run with David's suggestion
as I also noticed that my initial assessment was wrong (thanks for the
note/review Berker).
--
Added file:
New submission from Craig Holmquist:
If the authenticator object passed to the IMAP authenticate method tries to
abort the handshake by returning None, TypeError is raised instead of sending
the * line to the server.
import imaplib
imap = imaplib.IMAP4_SSL('imap.gmail.com')
Nick Coghlan added the comment:
Regarding the PyPI decorator module, the difference there is between using a
def f(*args, **kwargs) wrapper (which requires following wrapper chains to
read the signature correctly) and using functools.partial (which reports the
correct surface signature
Nick Coghlan added the comment:
Right, I started asking myself the same question, and then began poking around
in the functools.partial implementation
(https://hg.python.org/cpython/file/9be2405385ec/Modules/_functoolsmodule.c#l12)
--
resolution: not a bug -
stage: resolved -
Nick Coghlan added the comment:
pypa.io hosts the internal dev docs for PyPA, I believe you meant
packaging.python.org, and that would indeed be the right home.
However, this kind of C/C++ linker related problem is way too advanced for the
current state of the binary extension docs which
productivememberofsociety666 added the comment:
def wrapper(func):
return functools.wraps(func)(functools.partial(func))
^ doesn't that just return something that is completely equivalent to func
itself? Where do I put the actual wrapper functionality, i.e. code that is
executed with each
Nick Coghlan added the comment:
Well, there's an expected keyboard shortcut (accidentally hitting Shift-Enter
submits the page...)
Anyway, the idea I came up with after looking at that is potentially adjusting
functools.partial to accept a call_target parameter, which would allow it to
productivememberofsociety666 added the comment:
Sounds good! I think the docs on functools.wraps already list precisely which
data is updated, but maybe mentioning explicitly that it can not affect the
argspec could indeed make it clearer.
Either way, thank you for your help!
--
Nikolaus Rath added the comment:
Except for the pointless 'myfileobj' stuff in gzip.py, rev 8 of the patch looks
good to me.
(Btw, I'm not actually in favor of e.g. the seekable() change. The previous
patch was intended as a proof-of-concept to see what would be necessary to
inherit more
Nick Coghlan added the comment:
Full example showing the functools.partial based implementation:
def wrapper(func):
... return functools.wraps(func)(functools.partial(func))
...
def to_be_wrapped(x):
... pass
...
Nick Coghlan added the comment:
Ah, unfortunately, on closer inspection, even partial itself ends up suffering
from the same problem as the current inspect.wraps - validation ultimately
happens at the point of calling the original wrapper function, so if you don't
actually call it, you won't
Martin Panter added the comment:
Josiah’s code now seems to handle the four special cases like this:
* Reading a closed pipe raises BrokenPipeError. This is novel to me, and bends
the current definition of the exception. But it appears to be the way Windows
works at a lower level, and does
productivememberofsociety666 added the comment:
Sorry, did not mean to change the Components and Versions thingies...
--
components: +Documentation -Library (Lib)
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
Demian Brecht added the comment:
As I understand it, the change should also be applied to security releases
as the regression manifested by a security related patch being applied.
That said, there may be some debate as there apparently isn't much (if
anything) in the way of precedence here.
productivememberofsociety666 added the comment:
You're probably right and it's next to impossible to implement what I want in a
clean manner. I'll get back to that at the end, but first for completeness's
sake two examples to illustrate what this issue is even about.
import functools
Nick Coghlan added the comment:
I double checked the current behaviour, and rediscovered something I had
forgotten: when inspect.getargspec and inspect.getfullargspec were converted to
be based on the inspect.signature machinery, we had to decide whether or not to
follow wrapper chains to
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag, spaceone
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23487
___
___
Berker Peksag added the comment:
Thanks for the report. This is a duplicate of issue 23487.
--
nosy: +berker.peksag
resolution: - duplicate
stage: - resolved
status: open - closed
superseder: - argparse: add_subparsers 'action' broken
type: crash - behavior
1 - 100 of 104 matches
Mail list logo
