[issue26576] Tweak wording of decorator docos

2016-03-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: Guido, the discrepancy between the decorator doc's 'equivalent code' and actual, optimized, behavior with regard to skipping an intermediate binding of the function to the name came up soon after decorators were added. I cannot find the issue, but as I

[issue18140] urlparse, urlsplit confused when password includes fragment (#), query (?)

2016-03-19 Thread Martin Panter
Changes by Martin Panter : -- title: urlparse.urlsplit confused to fragment when password include # -> urlparse, urlsplit confused when password includes fragment (#), query (?) versions: +Python 3.5, Python 3.6 ___ Python

[issue26575] lambda not closed on specific value in comprehension

2016-03-19 Thread Martin Panter
Martin Panter added the comment: https://docs.python.org/3.5/faq/programming.html#why-do-lambdas-defined-in-a-loop-with-different-values-all-return-the-same-result -- nosy: +martin.panter resolution: -> not a bug status: open -> closed ___ Python

[issue26569] pyclbr.readmodule() and pyclbr.readmodule_ex() don't support namespace packages

2016-03-19 Thread Eric Snow
Eric Snow added the comment: Yeah, I've opened issue26584 to keep the matters separate. We can address a more comprehensive cleanup there. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue26250] no document for sqlite3.Cursor.connection

2016-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 52660878c833 by Ezio Melotti in branch '3.5': #26250: document the sqlite3.Cursor.connection attribute. Initial patches by Aviv Palivoda and Varpu Rantala. https://hg.python.org/cpython/rev/52660878c833 New changeset 6fed752fd88e by Ezio Melotti

[issue26396] Create json.JSONType

2016-03-19 Thread Brett Cannon
Brett Cannon added the comment: Here is a preliminary patch with docs. I didn't do any tests because I just don't know what kind of test we would want. Use isinstance() to make sure it covers the types we expect? And I'm not sure how to test the key type for mappings. -- keywords:

[issue26553] Write HTTP in uppercase

2016-03-19 Thread Aatish Neupane
Changes by Aatish Neupane : Added file: http://bugs.python.org/file42197/fix_2.7.patch ___ Python tracker ___

[issue26567] ResourceWarning: Use tracemalloc to display the traceback where an object was allocated when a ResourceWarning is emitted

2016-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2428d794b0e1 by Victor Stinner in branch 'default': On ResourceWarning, log traceback where the object was allocated https://hg.python.org/cpython/rev/2428d794b0e1 -- nosy: +python-dev ___ Python tracker

[issue26257] Eliminate buffer_tests.py

2016-03-19 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti, serhiy.storchaka ___ Python tracker ___

[issue22758] Regression in Python 3.2 cookie parsing

2016-03-19 Thread Berker Peksag
Berker Peksag added the comment: I will commit this to the 3.2 branch today. -- status: closed -> open ___ Python tracker ___

[issue26583] test_timestamp_overflow of test_importlib fails if PYTHONDONTWRITEBYTECODE is set

2016-03-19 Thread Ned Deily
Ned Deily added the comment: Ah, setting PYTHONDONTWRITEBYTECODE explains it. When running the tests via "make test", python is invoked with -E to avoid issues like that. But here's a patch that skips test_timestamp_overflow if bytecode files cannot be written (Issue20796 documents a

[issue26040] Improve coverage and rigour of test.test_math

2016-03-19 Thread Jeff Allen
Changes by Jeff Allen : Added file: http://bugs.python.org/file42191/extra_cmath_testcases.py ___ Python tracker ___

[issue26581] Double coding cookie

2016-03-19 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: When Python source file contains double coding cookies on different lines, the first wins. When it contains double coding cookies on the same line, the last wins. PEP 263 was sufficiently vague about this. Now this is clarified (22490711c870). The first

[issue26572] urlparse does not handle passwords with ? in them.

2016-03-19 Thread Martin Panter
Martin Panter added the comment: I think this is the same as Issue 18140. Perhaps you can answer my question at the bottom there about why the question mark is not encoded, and why splitting at the at (@) symbol should be higher priority than the query (?) symbol. -- nosy:

[issue26588] _tracemalloc: add support for multiple address spaces (domains)

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: Patch version 2: - modify _tracemalloc._get_traces() to include domain in traces - add tracemalloc.DomainFilter(domain) - add domain optional parameter to tracemalloc.Filter constructor Currently, Snapshot._group_by() ignores domain information. I don't know

[issue26252] Add an example to importlib docs on setting up an importer

2016-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset dc24ab548e2b by Brett Cannon in branch 'default': Issue #26252: Add an example on how to register a finder https://hg.python.org/cpython/rev/dc24ab548e2b -- nosy: +python-dev ___ Python tracker

[issue25720] Fix curses module compilation with ncurses6

2016-03-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I suspect that the patch can break build with non-ncurses implementations or with old ncurses (when is_pad() was added?). Needed more direct feature check. -- ___ Python tracker

[issue26530] tracemalloc: add C API to manually track/untrack memory allocations

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: > So you guarantee tracemalloc itself won't use such a hack for other purposes? ;-) Hum, maybe we can make the "hack" "official": add two C macro to store and retrieve the domain from a pointer. The macro can validate that the domain is smaller or equal to 8

[issue26583] test_timestamp_overflow fails

2016-03-19 Thread SilentGhost
Changes by SilentGhost : -- components: +Macintosh, Tests nosy: +ned.deily, ronaldoussoren type: -> behavior ___ Python tracker ___

[issue26543] imaplib noop Debug

2016-03-19 Thread gigaplastik
Changes by gigaplastik : -- nosy: +gigaplastik ___ Python tracker ___ ___

[issue26040] Improve coverage and rigour of test.test_math

2016-03-19 Thread Jeff Allen
Changes by Jeff Allen : Removed file: http://bugs.python.org/file42190/stat_math.py ___ Python tracker ___

[issue26574] replace_interleave can be optimized for single character byte strings

2016-03-19 Thread Josh Snider
New submission from Josh Snider: replace_interleave in Objects/bytesobject.c and Objects/bytearrayobject.c can be optimized for the special case where the interleaving byte string is a single character. Here's some quick results from timeit showing that it's about three times faster for the

[issue26257] Eliminate buffer_tests.py

2016-03-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It looks to me that all tests from CommonTest except test_capitalize_nonascii can be merged into BaseTest. A number of tests from MixinStrUnicodeUserStringTest could be applied to bytes and bytearray too. I think we should left only two classes in

[issue26587] Possible duplicate entries in sys.path if .pth files are used with zip's

2016-03-19 Thread Mandeep Singh Grang
Mandeep Singh Grang added the comment: Here is a testcase to reproduce the issue: > cat test.py import site, sys site.addsitedir('/foo/bar') print (sys.path) This prints just a single instance of '/foo/bar': ['/local/mnt/workspace/python/tst', '/foo/bar', '/usr/local/lib/python36.zip',

[issue26578] Bad BaseHTTPRequestHandler response when using HTTP/0.9

2016-03-19 Thread Xiang Zhang
Xiang Zhang added the comment: I think you are right. Simply run http.server.test() and then telnet to send "GET /", the client hangs. Or add a timeout to BaseHTTPRequestHandler, you can see the timeout error on server output. -- ___ Python tracker

[issue17603] AC_LIBOBJ replacement of fileblocks

2016-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset acbeb33dc76a by Martin Panter in branch '2.7': Issue #17603: Check for st_blocks field without requiring fileblocks.o https://hg.python.org/cpython/rev/acbeb33dc76a New changeset 0774398c3433 by Martin Panter in branch '3.5': Issue #17603: Check

[issue26576] Tweak wording of decorator docos

2016-03-19 Thread Georg Brandl
Georg Brandl added the comment: (Also, toggled your "is committer" bit so you get the Python logo next to your name.) -- ___ Python tracker ___

[issue26470] Make OpenSSL module compatible with OpenSSL 1.1.0

2016-03-19 Thread Christian Heimes
Christian Heimes added the comment: Here is a first working patch. It requires 1.1.0-pre4. The failing ALPN test is caused by a regression in OpenSSL. -- keywords: +patch stage: needs patch -> patch review versions: +Python 3.6 Added file:

[issue26567] ResourceWarning: Use tracemalloc to display the traceback where an object was allocated when a ResourceWarning is emitted

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: It looks like io.FileIO has a strong implementation of the destructor. If the object becomes alive again because of random code called in the destructor, the object is not removed. socket and os.scandir have a classical unsafe destructor. Moreover, I'm no

[issue26577] inspect.getclosurevars returns incorrect variable when using class member with the same name as other variable

2016-03-19 Thread Ryan Fox
New submission from Ryan Fox: If a variable 'x' exists in the global or local scope, and a function (also defined in the same scope as 'x', or lower) refers only to a member named 'x' of an object, inspect.getclosurevars will include a reference to the variable, rather than the member. Okay,

[issue26553] Write HTTP in uppercase

2016-03-19 Thread Aatish Neupane
Changes by Aatish Neupane : Added file: http://bugs.python.org/file42198/fix_3.5.patch ___ Python tracker ___

[issue26519] Cython doesn't work anymore on Python 3.6

2016-03-19 Thread Stefan Behnel
Stefan Behnel added the comment: Our CI build server says it's all fine. The fix will eventually be released, certainly before Py3.6 comes out. -- ___ Python tracker

[issue26567] ResourceWarning: Use tracemalloc to display the traceback where an object was allocated when a ResourceWarning is emitted

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: I used this patch to identify a ResourceWarning in test_faulthandler when the test is interrupted by CTRL+c: it's really efficient! I will be very useful to identify all ResourceWarning that I saw in test_asyncio, like the ones seen on the AIX buildbot.

[issue26567] ResourceWarning: Use tracemalloc to display the traceback where an object was allocated when a ResourceWarning is emitted

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: When warnings._showwarnmsg(), the io.FileIO object is not closed yet, so all attributes are accessible, which can be useful. Hopefully, the file is closed even if it is kept alive by the warning logger. So maybe it's ok to keep the Python object alive, if the

[issue26578] Bad BaseHTTPRequestHandler response when using HTTP/0.9

2016-03-19 Thread Xiang Zhang
Xiang Zhang added the comment: can should be can not. And not only HTTPConnection, support for HTTP/0.9 seems to have been totally abandoned since Python3.4 in http.client. -- ___ Python tracker

[issue10721] Remove HTTP 0.9 server support

2016-03-19 Thread Martin Panter
Martin Panter added the comment: Also I guess documentation should be added somewhere, even if there is no deprecation step. -- ___ Python tracker ___

[issue26270] Support for read()/write()/select() on asyncio

2016-03-19 Thread Paulo Costa
Paulo Costa added the comment: Thanks for the replies. What I'm actually trying to do is to access from a character file from /dev/input/event*. Streams are pretty much what I want to use but (as far as I can tell) asyncio's streams only support network and unix sockets. Files are left

[issue26588] _tracemalloc: add support for multiple address spaces (domains)

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: > Also, Numba allows use of the Numpy API (part thereof, anyway) on GPUs. Do you mean that Numba requires supporting multiple address spaces to be able to use tracemalloc? Or that supporting multiple address spaces would also to *also* track GPU memory

[issue26556] Update expat to 2.2.1

2016-03-19 Thread Christian Heimes
Christian Heimes added the comment: No, the other problem is CVE-2016-0718. We are still looking into the matter. -- ___ Python tracker ___

[issue26563] PyMem_Malloc(): check that the GIL is hold in debug hooks

2016-03-19 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue26246] Code output toggle button uses removed jQuery method

2016-03-19 Thread Ezio Melotti
Ezio Melotti added the comment: Thanks both for spotting the bug and fixing it! -- ___ Python tracker ___ ___

[issue26313] ssl.py _load_windows_store_certs fails if windows cert store is empty

2016-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset eb2c2671e7d6 by Steve Dower in branch '3.5': Issue #26313: ssl.py _load_windows_store_certs fails if windows cert store is empty. Patch by Baji. https://hg.python.org/cpython/rev/eb2c2671e7d6 New changeset 97cd199944c3 by Steve Dower in branch

[issue26530] tracemalloc: add C API to manually track/untrack memory allocations

2016-03-19 Thread Antoine Pitrou
Antoine Pitrou added the comment: Le 18/03/2016 04:57, Nathaniel Smith a écrit : > > What I'm talking about is different: I think it should be possible > to re-use the tracemalloc infrastructure to track other resources besides "heap allocations". So for my use case, it's crucial that we index

[issue26586] Simple enhancement to BaseHTTPRequestHandler

2016-03-19 Thread Xiang Zhang
Xiang Zhang added the comment: Thanks for your review. I have made some changes according to it. Status code 431 is returned when the header line is too long or there are too many headers. And I think the short message is OK and we can provide the exception message in the content message. As

[issue26530] tracemalloc: add C API to manually track/untrack memory allocations

2016-03-19 Thread Nathaniel Smith
Nathaniel Smith added the comment: There are other leakable resources besides heap and GPU memory -- shmem segments and file descriptors are two that I thought of earlier, but there are probably others too. (Note that not all file descriptors are associated with a python file object.) I guess

[issue26519] Cython doesn't work anymore on Python 3.6

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: > Our CI build server says it's all fine. The fix will eventually be released, > certainly before Py3.6 comes out. Ok, fine :-) -- resolution: -> third party status: open -> closed ___ Python tracker

[issue26563] PyMem_Malloc(): check that the GIL is hold in debug hooks

2016-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset ce62df22f3bf by Victor Stinner in branch '3.5': Py_FatalError: disable faulthandler earlier https://hg.python.org/cpython/rev/ce62df22f3bf -- ___ Python tracker

[issue26585] Use html.escape to replace _quote_html in http.server

2016-03-19 Thread Xiang Zhang
Xiang Zhang added the comment: make some change to test for html escape in SimpleHTTPRequestHandler -- Added file: http://bugs.python.org/file42205/_quote_html_to_html_escape_v3.patch ___ Python tracker

[issue26553] Write HTTP in uppercase

2016-03-19 Thread Aatish Neupane
Aatish Neupane added the comment: I found some other similar errors with the suggestion from the patch review. I have uploaded the new patches as 2_fix* . -- ___ Python tracker

[issue26573] Method Parameters can be Accepted as Keyword Arguments?

2016-03-19 Thread G Young
New submission from G Young: This issue arose as we were making changes to the 'pandas' library. I am not sure if this is a bug or feature, but it definitely did not cross anyone's minds when discussing the PR at hand. I have attached a code sample to illustrate the "bug" that I have run

[issue23239] SSL match_hostname does not accept IP Address

2016-03-19 Thread Marc Abramowitz
Marc Abramowitz added the comment: Patch to update the comment to remove "IP addresses are not accepted for *hostname*", because supported for IP addresses was added earlier by @pitrou in https://hg.python.org/cpython/rev/b15a5f239e8a -- nosy: +Marc.Abramowitz Added file:

[issue26252] Add an example to importlib docs on setting up an importer

2016-03-19 Thread Brett Cannon
Brett Cannon added the comment: I added an example on how to register both a meta path and path entry finder. It's a rather simple example, but hopefully using the classes that importlib uses will help also point people towards the appropriate classes to learn about for their own needs.

[issue26586] Simple enhancement to BaseHTTPRequestHandler

2016-03-19 Thread Xiang Zhang
New submission from Xiang Zhang: This patch propose several simple enhancement to BaseHTTPRequestHandler. It removes some redundant code and add handler for too many headers. -- components: Library (Lib) files: simple_enhancement.patch keywords: patch messages: 261946 nosy: xiang.zhang

[issue26570] comma-separated cookies with expires header do not parse properly

2016-03-19 Thread SilentGhost
SilentGhost added the comment: This is not a regression and you can see that if you do print(SimpleCookie('A=B; expires=Thu, 01-Jan-1970 00:00:00 GMT, C=D')) The values of expires and Path attribute were parsed incorrectly, even though you got two cookies. The problem as far as I can see is a

[issue26580] Documentation for ftplib still references ftpmirror.py

2016-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 23ad18068814 by Berker Peksag in branch '3.5': Issue #26580: Remove outdated reference to ftpmirror https://hg.python.org/cpython/rev/23ad18068814 New changeset 48e106bf2add by Berker Peksag in branch 'default': Issue #26580: Remove outdated

[issue26585] Use html.escape to replace _quote_html in http.server

2016-03-19 Thread Xiang Zhang
Xiang Zhang added the comment: The uploaded patch is updated. Hope you have time to review. -- Added file: http://bugs.python.org/file42218/_quote_html_to_html_escape_v4.patch ___ Python tracker

[issue10721] Remove HTTP 0.9 server support

2016-03-19 Thread Mark Lawrence
Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue26569] pyclbr.readmodule() and pyclbr.readmodule_ex() don't support packages

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: >Hmm. These two should be equivalent: > if spec.loader.is_package(fullmodule): ... The problem is that spec.loader is None when test is a package. It's easy to reproduce the issue: $ rm -f Lib/test/__init__.py Lib/test/__pycache__/__init__.cpython-36.pyc $

[issue26576] Tweak wording of decorator docos

2016-03-19 Thread Chris Angelico
Chris Angelico added the comment: The remaining difference that's actually of use, perhaps. But the decoration itself happens before the name is bound. It's impossible to describe in Python code; but it can be probed - you can monkeypatch a class using a decorator: def monkeypatch(cls):

[issue26585] Use html.escape to replace _quote_html in http.server

2016-03-19 Thread Xiang Zhang
Xiang Zhang added the comment: At first I also want to use html.escape(..., quote=False) since the spec only asks to escape quote signs in attribute. But after some search on Google, there are articles recommends escaping quote in content too:

[issue25609] Add a ContextManager ABC and type

2016-03-19 Thread Guido van Rossum
Guido van Rossum added the comment: Agreed on all points with Nick. We can add ContextManager (not ContextManagerType) to typing.py in 3.5.2 (it's provisional). -- ___ Python tracker

[issue24959] unittest swallows part of stack trace when raising AssertionError in a TestCase

2016-03-19 Thread Robert Collins
Changes by Robert Collins : -- stage: needs patch -> test needed ___ Python tracker ___

[issue26581] Double coding cookie

2016-03-19 Thread Guido van Rossum
Guido van Rossum added the comment: Right. Please go ahead with both. I am fine with defining the current behavior correct. --Guido (mobile) On Mar 19, 2016 9:37 AM, "Serhiy Storchaka" wrote: > > Serhiy Storchaka added the comment: > > Yes, I have. But I were not sure

[issue26546] Provide translated french translation on docs.python.org

2016-03-19 Thread Julien
Julien added the comment: You're right Terry, I posted on python ideas in case someone comes with a good idea, I also explained my vision in a lot of details to gather the widest feedback possible on each point that came to my mind:

[issue21042] ctypes.util.find_library() should return full pathname instead of filename in linux

2016-03-19 Thread Martin Panter
Martin Panter added the comment: I reverted the change until we can come up with something more consistent. -- stage: commit review -> needs patch ___ Python tracker

[issue26581] Double coding cookie

2016-03-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Yes, I have. But I were not sure what behavior should be correct in Python. On one side, always choosing the first declaration (on the same or on different lines) looks more consistent. On other side, current behavior was in CPython from the initial

[issue26240] Docstring of the subprocess module should be cleaned up

2016-03-19 Thread Ezio Melotti
Changes by Ezio Melotti : -- keywords: +easy nosy: +ezio.melotti type: -> enhancement ___ Python tracker ___

[issue26581] Double coding cookie

2016-03-19 Thread Guido van Rossum
Guido van Rossum added the comment: Do you have write permission to the PEP? Just update it. -- ___ Python tracker ___

[issue25720] Fix curses module compilation with ncurses6

2016-03-19 Thread Ismail Donmez
Ismail Donmez added the comment: ping? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue26588] _tracemalloc: add support for multiple address spaces (domains)

2016-03-19 Thread STINNER Victor
New submission from STINNER Victor: The tracemalloc module uses a hashtable: pointer (void*) => trace. Some embedded devices use multiple address spaces. Each GPU also has its own address space. CUDA, OpenCL and OpenGL should also be seen as different address spaces. In the issue #26530, it

[issue17167] python man page contains $Date$ in page footer

2016-03-19 Thread Charalampos Stratakis
Changes by Charalampos Stratakis : -- versions: +Python 3.5 ___ Python tracker ___ ___

[issue26581] Double coding cookie

2016-03-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I just tested with Emacs, and it looks that when specify different codings on two different lines, the first coding wins, but when specify different codings on the same line, the last coding wins. Therefore current CPython behavior can be correct, and the

[issue26584] pyclbr module needs to be more flexible on loader support

2016-03-19 Thread Eric Snow
New submission from Eric Snow: (see issue26569) The pyclbr module is showing its age (born 1995). It assumes there are only 2 module types (builtin and source-based), particularly in readmodule() and readmodule_ex(). Really it should be source-based and "everything else". For instance, it

[issue26331] Tokenizer: allow underscores for grouping in numeric literals

2016-03-19 Thread Stefan Behnel
Stefan Behnel added the comment: Ah, thanks. Here's my implementation then: https://github.com/cython/cython/pull/499/files It seems that tests for valid complex literals are missing. I've added these to the end of the list: '1_00_00.5j', '1_00_00.5e5', '1_00_00j',

[issue26583] test_timestamp_overflow fails

2016-03-19 Thread Ned Deily
Ned Deily added the comment: Sorry, I am unable to reproduce this on either 10.9.5 or current 10.11.3 OS X systems. Is there something unusual about the working directory you are running the tests from, like residing on an NFS or other networked file system? Any special ./configure options?

[issue26283] zipfile can not handle the path build by os.path.join()

2016-03-19 Thread Ezio Melotti
Ezio Melotti added the comment: I don't think this is a bug. The ZIP format specification requires the use of forward slashes[0]: 4.4.17 file name: (Variable) 4.4.17.1 The name of the file, with optional relative path. The path stored MUST not contain a drive or

[issue26569] pyclbr.readmodule() and pyclbr.readmodule_ex() don't support namespace packages

2016-03-19 Thread Eric Snow
Eric Snow added the comment: And thanks for addressing this here. :) -- ___ Python tracker ___ ___

[issue26592] _warnings.warn_explicit() should try to import the warnings module

2016-03-19 Thread STINNER Victor
New submission from STINNER Victor: The issue #26567 enhanced the warnings module to pass the destroyed object on ResourceWarning. The implementation to log the traceback where the object was allocated is non trivial, so I chose to only implement it in Python. Problem:

[issue26590] socket destructor: implement finalizer

2016-03-19 Thread Antoine Pitrou
Antoine Pitrou added the comment: Le 19/03/2016 14:07, STINNER Victor a écrit : > > Example: > --- > import socket > s=socket.socket() > s=None > --- > > With this code, sock_finalize() is called before sock_dealloc(): > > #0 sock_finalize (s=0x70730c28) at >

[issue26590] socket destructor: implement finalizer

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: Antoine Pitrou added the comment: > Ah, that's probably because socket.socket is a Python subclass. > What happens if you use _socket.socket directly instead? Oh, I forgot this sublte implementation detail, _socket.socket base class vs socket.socket sublcass.

[issue26580] Documentation for ftplib still references ftpmirror.py

2016-03-19 Thread SilentGhost
SilentGhost added the comment: This patch removes the offending paragraph. -- keywords: +patch nosy: +SilentGhost stage: -> patch review type: -> behavior versions: +Python 3.6 Added file: http://bugs.python.org/file42187/issue26580.diff ___ Python

[issue13601] sys.stderr should always be line-buffered

2016-03-19 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue26590] socket destructor: implement finalizer

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: @Antoine: Since you wrote the PEP 442, would you reviewing sock_finalize.patch? I'm only interested to modify Python 3.6, the bug was only trigerred when I changed the code to log a warning. Before, the socket object was not passed to the warning logger so it

[issue26590] socket destructor: implement finalizer

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: 2016-03-19 11:05 GMT+01:00 Antoine Pitrou : > sock_finalize() is only called explicitly if there is a reference cycle. This > is why sock_dealloc() has to call it. I'm fine with keeping sock_dealloc() to call sock_finalize(), but I

[issue26569] pyclbr.readmodule() and pyclbr.readmodule_ex() don't support namespace packages

2016-03-19 Thread Eric Snow
Eric Snow added the comment: Well, your patch is correct even if not ideal. :) Landing it as a short-term solution is fine. Just keep this issue open so we can address the problem more completely later. -- components: +Interpreter Core stage: -> commit review type: -> behavior

[issue25609] Add a ContextManager ABC and type

2016-03-19 Thread Nick Coghlan
Nick Coghlan added the comment: * the ABC should have a structural __issubclass__ check looking for __enter__ and __exit__ methods * I agree with making __exit__ abstract (if you don't define it, you don't need a context manager), but does __enter__ need to be abstract? The "return self"

[issue26585] Use html.escape to replace _quote_html in http.server

2016-03-19 Thread Xiang Zhang
Xiang Zhang added the comment: Oops. You have already left new comment. No notify either. :( I like the idea that extract the actual encoding from response header. I will update my patch then. -- ___ Python tracker

[issue26331] Tokenizer: allow underscores for grouping in numeric literals

2016-03-19 Thread Georg Brandl
Georg Brandl added the comment: The last patch isn't up to date with the PEP; Serhiy's patch is the closest one. -- ___ Python tracker ___

[issue26579] Support pickling slots in subclasses of common classes

2016-03-19 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker ___ ___

[issue26583] test_timestamp_overflow of test_importlib fails if PYTHONDONTWRITEBYTECODE is set

2016-03-19 Thread Ned Deily
Ned Deily added the comment: Pushed for release in 3.5.2 and 3.6.0. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue26271] freeze.py makefile uses the wrong flags variables

2016-03-19 Thread Brett Cannon
Brett Cannon added the comment: Thanks for the patch, Daniel! Added you to the ACKS file. -- stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue19265] Increased test coverage for datetime pickling

2016-03-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: These lines should be removed again after applying the patch for issue26579. -- nosy: +serhiy.storchaka ___ Python tracker

[issue26538] regrtest: setup_tests() must not replace module.__path__ (_NamespacePath) with a simple list // importlib & abspath

2016-03-19 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue26546] Provide translated french translation on docs.python.org

2016-03-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: I agree on the url. It can always redirect to a CCTLD if there is one. You *might* want to discuss the how on python-ideas list. -- nosy: +terry.reedy ___ Python tracker

[issue26569] pyclbr.readmodule() and pyclbr.readmodule_ex() don't support namespace packages

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: > However, you should be able to leave the is_package() call alone. I don't really care how the issue is fixed. As I wrote, I don't know well the importlib module. Feel free to propose a better patch :-) My main concern is to fix test_pyclbr when test becomes

[issue24959] unittest swallows par t of stack trace when raising AssertionError in a TestCase

2016-03-19 Thread Robert Collins
Robert Collins added the comment: I'm fairly sure its eating the stack frames because the calling frames are annotated __unittest__ - its technically a feature :/. -- title: unittest swallows part of stack trace when raising AssertionError in a TestCase -> unittest swallows par t of

[issue17605] mingw-meta: build interpeter core

2016-03-19 Thread Martin Panter
Changes by Martin Panter : -- dependencies: +mingw: detect REPARSE_DATA_BUFFER ___ Python tracker ___

[issue21423] concurrent.futures.ThreadPoolExecutor/ProcessPoolExecutor should accept an initializer argument

2016-03-19 Thread Alexander Mohr
Alexander Mohr added the comment: any chance if this getting into 3.5.2? I have some gross code to get around it (setting global properties) -- nosy: +thehesiod ___ Python tracker

[issue26560] Error in assertion in wsgiref.handlers.BaseHandler.start_response

2016-03-19 Thread Peter Inglesby
Peter Inglesby added the comment: I found it while reading the source. Patch attached. -- keywords: +patch Added file: http://bugs.python.org/file42188/issue26560.patch ___ Python tracker

[issue26585] Use html.escape to replace _quote_html in http.server

2016-03-19 Thread Xiang Zhang
Xiang Zhang added the comment: OK. You left the comment preferring using ascii or utf-8 to encode the filename in test. But actually the response SimpeHTTPRequestHandler send is explicitly encoded in filesystemdefaultencoding. So in such a case, am I doing right? --

  1   2   >