[issue29138] No __hash__() inheritance warning with -Werror

Martin Panter added the comment: Thanks, I will try to look at that some time -- stage: needs patch -> resolved status: open -> closed ___ Python tracker ___

[issue29130] Exit code 120 returned from Python unit test testing SystemExit

Serhiy Storchaka added the comment: > Having said all that, perhaps it would be reasonable to tolerate a missing > flush() method, and not treat this as an error. In all cases the flush() method is called unconditionally. I think it can be considered as mandatory part of the writer protocol.

[issue29138] No __hash__() inheritance warning with -Werror

Serhiy Storchaka added the comment: This is a duplicate of issue8627. -- nosy: +serhiy.storchaka resolution: -> duplicate superseder: -> Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c ___ Python tracker

[issue29137] Fix fpectl-induced ABI breakage

Nick Coghlan added the comment: Ah, cool - I didn't know that Debian built with fpectl enabled by default. In that case, +1 for: - low maintenance ABI and API compatibility shims that are kept around indefinitely (since they leaked into the limited API/stable ABI) but don't actually do anythi

[issue29138] No __hash__() inheritance warning with -Werror

New submission from Martin Panter: Normally there is a Python 3 compatibility warning emitted when a class is based on object, implements __eq__(), but does not define __hash__(): $ python -3 -c 'class C(object): __eq__ = lambda self, other: True' -c:1: DeprecationWarning: Overriding __eq__ blo

[issue28518] execute("begin immediate") throwing OperationalError

Ma Lin added the comment: I'm trying to catch up with you. Does it mean, if I want execute VACUUM, I have to commit manually? Like this: if conn.in_transaction: conn.commit() conn.execute("vacuum") -- ___ Python tracker

[issue28180] sys.getfilesystemencoding() should default to utf-8

Nick Coghlan added the comment: Updated patch adds some tests showing that this change should also help with cases where SSH environment forwarding results in an unknown locale being requested in the server environment. -- Added file: http://bugs.python.org/file46121/pep538_coerce_leg

[issue29130] Exit code 120 returned from Python unit test testing SystemExit

Martin Panter added the comment: David is right. The 120 code was added in Issue 5319, as a way of indicating a problem in the final stages of the interpreter exiting. The two conditions that trigger this are calling the flush() method on sys.stdout and sys.stderr. If you add a dummy flush() i

[issue28864] Add devnull file-like object

Martin Panter added the comment: Example where an implementation like Serhiy’s was not good enough: . In that case, the lack of flush() method causes a subtle problem. -- ___ Python tracker

[issue29130] Exit code 120 returned from Python unit test testing SystemExit

Xiang Zhang added the comment: Behaviour changed in #5319. Add author Martin. -- nosy: +martin.panter, xiang.zhang ___ Python tracker ___

[issue29131] Calling printf from the cdll does not print the full string

Eryk Sun added the comment: > I am following the "Gray Hat Python - Python Programming for Hackers and > Reverse Engineers" >From what I've seen in Stack Overflow questions asked by people reading that >book, its ctypes code is generally of poor quality. It only works in 32-bit >Python 2 beca

[issue29137] Fix fpectl-induced ABI breakage

Nathaniel Smith added the comment: > At that point, does it actually make sense to provide the shims? Or should we > instead just add the deprecation warnings and say "Don't use the > --with-fpectl option, as it doesn't work properly, and breaks ABI > compatibility for extension modules built

[issue29133] Minor inaccuracy in shlex.shlex punctuation_chars example

Evan added the comment: Sorry for not being more clear in the original report - the error is in the code, not in the output. The old behavior is punct=False, the new is punct=True. -- ___ Python tracker __

[issue29131] Calling printf from the cdll does not print the full string

mike peremsky added the comment: I appreciate the feedback, but as I had originally mentioned. I am following the "Gray Hat Python - Python Programming for Hackers and Reverse Engineers" book and was attempting to use Python 3 instead of Python 2 (as was used in the book). The cdll code is tak

[issue29137] Fix fpectl-induced ABI breakage

Nick Coghlan added the comment: - 3.4 is already in security-fix only mode so we can safely ignore it for this purpose - 3.5.3 is likely to be the last general bugfix release of 3.5, so we can probably skip that as well - that would mean the ABI compability shims would only go in 3.6.1 and th

[issue28870] Reduce stack consumption of PyObject_CallFunctionObjArgs() and like

STINNER Victor added the comment: In Python 3.5, PyObject_CallFunctionObjArgs() calls objargs_mktuple() which uses Py_VA_COPY(countva, va) and creates a tuple. The tuple constructor uses a free list to reduce the cost of heap memory allocations. --

[issue28870] Reduce stack consumption of PyObject_CallFunctionObjArgs() and like

STINNER Victor added the comment: no_small_stack.patch: And now something completely different, a patch to remove the "small stack" alllocated on the C stack, always use the heap memory. FYI I created no_small_stack.patch from less_stack.patch. As expected, the stack usage is lower: * less_st

[issue29131] Calling printf from the cdll does not print the full string

Eryk Sun added the comment: > from ctypes import * > msvcrt = cdll.msvcrt > message_string = "Hello World!\n" > msvcrt.printf("Testing: %s", message_string) Avoid using libraries as attributes of cdll and windll. They get cached, and in turn they cache function pointers. Thus all modules conten

[issue29131] Calling printf from the cdll does not print the full string

Changes by Eryk Sun : -- Removed message: http://bugs.python.org/msg284525 ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue29131] Calling printf from the cdll does not print the full string

Eryk Sun added the comment: > from ctypes import * > msvcrt = cdll.msvcrt > message_string = "Hello World!\n" > msvcrt.printf("Testing: %s", message_string) Avoid using libraries as attributes of cdll and windll. They get cached, and in turn they cache function pointers. Thus all modules conten

[issue28870] Reduce stack consumption of PyObject_CallFunctionObjArgs() and like

STINNER Victor added the comment: testcapi_stacksize.patch: add _testcapi.pyobjectl_callfunctionobjargs_stacksize(), function used to measure the stack consumption. -- Added file: http://bugs.python.org/file46119/testcapi_stacksize.patch ___ Python

[issue29137] Fix fpectl-induced ABI breakage

Changes by Nick Coghlan : -- nosy: +ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue28839] _PyFunction_FastCallDict(): replace PyTuple_New() with PyMem_Malloc()

STINNER Victor added the comment: fastcalldict-4.patch: Rebased patch. kw1: Median +- std dev: [ref] 290 ns +- 3 ns -> [patch] 253 ns +- 21 ns: 1.14x faster (-13%) kw5: Median +- std dev: [ref] 438 ns +- 33 ns -> [patch] 394 ns +- 27 ns: 1.11x faster (-10%) kw10: Median +- std dev: [ref] 663 n

[issue28839] _PyFunction_FastCallDict(): replace PyTuple_New() with PyMem_Malloc()

STINNER Victor added the comment: I pushed the two obvious and safe optimization of fastcalldict-3.patch. -- ___ Python tracker ___ __

[issue28839] _PyFunction_FastCallDict(): replace PyTuple_New() with PyMem_Malloc()

Roundup Robot added the comment: New changeset 5f7cd3b6c9b1 by Victor Stinner in branch 'default': Issue #28839: Optimize function_call() https://hg.python.org/cpython/rev/5f7cd3b6c9b1 New changeset f9dd607dc04c by Victor Stinner in branch 'default': Optimize _PyFunction_FastCallDict() when kwar

[issue27200] make doctest in CPython has failures

Berker Peksag added the comment: I agree with Ezio. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue29135] run_proces logs the command without escaping parmaeters such that the coammns logged are not valid

Changes by R. David Murray : -- resolution: not a bug -> third party stage: -> resolved ___ Python tracker ___ ___ Python-bugs-list m

[issue29013] zipfile: inconsistent doc for ZIP64 file size

Berker Peksag added the comment: Right, that's my fault. Apparently I missed the "[...] zipfile will create [...]" part :) What do you think about Monte's suggested changes Serhiy? Should we just revert 4685cd33087b (1) or do both (1) and (2)? -- stage: -> needs patch ___

[issue28839] _PyFunction_FastCallDict(): replace PyTuple_New() with PyMem_Malloc()

STINNER Victor added the comment: Quick update on the fastcall work. > I pushed th echange b9c9691c72c5 to replace PyObject_CallFunctionObjArgs() > with _PyObject_CallNoArg() or _PyObject_CallArg1(). These functions are > simpler and don't allocate memory on the C stack. Using _PyObject_CallA

[issue15812] inspect.getframeinfo() cannot show first line

Berker Peksag added the comment: You're right. Thanks for the review, Serhiy! -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue15812] inspect.getframeinfo() cannot show first line

Roundup Robot added the comment: New changeset 2b6bdd6cd3f8 by Berker Peksag in branch '3.5': Issue #15812: Delete redundant max(start, 0) https://hg.python.org/cpython/rev/2b6bdd6cd3f8 New changeset 7cbcee0c53e3 by Berker Peksag in branch '3.6': Issue #15812: Merge from 3.5 https://hg.python.or

[issue29035] regrtest: simplify regex to match test names for the --fromfile option

STINNER Victor added the comment: > I don't understand the use case of it ;) When I modify a codec or something related to text codecs, I would like to run all codec tests, not the fully Python test suite. So I use "ls Lib/test/test_*codec*py", the list is quite list, it's annoying to have to

[issue29035] regrtest: simplify regex to match test names for the --fromfile option

Roundup Robot added the comment: New changeset a9fe5bee892b by Victor Stinner in branch 'default': Issue #29035: Simplify a regex in libregrtest https://hg.python.org/cpython/rev/a9fe5bee892b -- nosy: +python-dev ___ Python tracker

[issue29012] __bases__ is a tuple (possibly empty or a singleton)

Berker Peksag added the comment: Good point, Serhiy. Thanks for the patch, Jim. I've now removed the "possible a singleton" part. -- ___ Python tracker ___ _

[issue29012] __bases__ is a tuple (possibly empty or a singleton)

Roundup Robot added the comment: New changeset 1aba7cbbcc27 by Berker Peksag in branch '3.5': Issue #29012: Remove another outdated information https://hg.python.org/cpython/rev/1aba7cbbcc27 New changeset 7ef5b02b228a by Berker Peksag in branch '3.6': Issue #29012: Merge from 3.5 https://hg.pyth

[issue29137] Fix fpectl-induced ABI breakage

New submission from Nathaniel Smith: It turns out that CPython built with --with-fpectl has a different ABI than CPython built without --with-fpectl (which is the default). Specifically, if you have an extension module built against a --with-fpectl CPython, and it uses the PyFPE_{START,END}_PR

[issue29012] __bases__ is a tuple (possibly empty or a singleton)

Jim Fasarakis-Hilliard added the comment: Yes, I agree with that it seems redundant after the change. I'm attaching another small patch based on the committed one to trim that off. -- Added file: http://bugs.python.org/file46117/fixbasesdoc2.patch __

[issue29136] Add OP_NO_TLSv1_3

Benjamin Peterson added the comment: I think that's fine for 2.7. On Mon, Jan 2, 2017, at 13:07, Christian Heimes wrote: > > New submission from Christian Heimes: > > OpenSSL 1.1.1 is going to provide TLS 1.3. The preferred protocols > PROTOCOL_TLS (old name PROTOCOL_SSLv23), PROTOCOL_TLS_CLIE

[issue29135] run_proces logs the command without escaping parmaeters such that the coammns logged are not valid

William Gianopoulos added the comment: It seems it is part of the Mozilla build system. I closed this issue. -- resolution: -> not a bug status: open -> closed ___ Python tracker _

[issue29135] run_proces logs the command without escaping parmaeters such that the coammns logged are not valid

William Gianopoulos added the comment: I would like to keep this open until I figure this out so I can provide a pointer to where the real issue is being tracked. I should have time to do that tomorrow. SOunds like this is part of some third-party add-on python library that is normally provide

[issue29135] run_proces logs the command without escaping parmaeters such that the coammns logged are not valid

William Gianopoulos added the comment: OK i t appears it might be a third party python utility library. I will try to trak this down and report it there and close this issue once i sort it out. On Mon, Jan 2, 2017 at 4:07 PM, William Gianopoulos wrote: > > William Gianopoulos added the commen

[issue29136] Add OP_NO_TLSv1_3

New submission from Christian Heimes: OpenSSL 1.1.1 is going to provide TLS 1.3. The preferred protocols PROTOCOL_TLS (old name PROTOCOL_SSLv23), PROTOCOL_TLS_CLIENT and PROTOCOL_TLS_SERVER are going to have TLS 1.3 enabled by default. In order to disable TLS 1.3, let's add OP_NO_TLSv1_3 to _s

[issue29135] run_proces logs the command without escaping parmaeters such that the coammns logged are not valid

William Gianopoulos added the comment: well i could be screwed up perhaps it is something provided in the mozilla python environment i was going by the fact that google searches on python run-process returned things, including other reported issues, that made me think it was not. On Mon, Jan 2,

[issue29135] run_proces logs the command without escaping parmaeters such that the coammns logged are not valid

R. David Murray added the comment: What is run_process? I'm not getting any hits from grep on the standard library. -- nosy: +r.david.murray ___ Python tracker ___

[issue28945] get_boundary (and get_filename) invokes unquote twice

bpoaugust added the comment: The patch is incomplete. There is another unquote call: 336 return unquote(text) -- ___ Python tracker ___

[issue29020] collapse_rfc2231_value has inconsistent unquoting

bpoaugust added the comment: If there are concerns about 3rd party code relying on the current behaviour of the function, then just create a new function without the unquoting, and deprecate the original function. The existing function does not always unquote, so any code which relies on it i

[issue27200] make doctest in CPython has failures

Ezio Melotti added the comment: I left a few comments on rietveld, In general, if making the doctest pass entails adding superfluous code (e.g. sorted(), , #doctest: +SKIP (if visible), setups/teardowns, or even whole files) or removing details that might be useful (ids or filenames in reprs),

[issue29053] Implement >From_ decoding on input from mbox

bpoaugust added the comment: The patch can be simplified by just looking for b'\n' in the last 6 chars, and caching from b'\n' if found. This would mean more file seeking in exchange for less buffer matching. -- ___ Python tracker

[issue29135] run_proces logs the command without escaping parmaeters such that the coammns logged are not valid

New submission from William Gianopoulos: So, the arguments to run_process are not escaped when logged such that the logged command is un-parsable. The following call: self.run_process(['notify-send', '--app-name', 'Mozilla Build System', 'Mozilla Build System', msg]) where msg='Build complete

[issue29134] contextlib doc bug

YoSTEALTH added the comment: typo: def ContextBase: to class ContextBase: -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29134] contextlib doc bug

YoSTEALTH added the comment: @SilentGhost You are right, I see it now! If this is the case maybe "ContextBaseClass" should be changed to "UserDefinedContextClass" (or something...) having "Base" in the class name was confusing, since module "io" has IOBase class that refer to its "base class"

[issue29134] contextlib doc bug

Marco Buttu added the comment: Going a bit OT, in the contextlib doc there are two examples that have both normal code and shell code in the same code block. In this way we loose the prompt syntax highlight, and the code block can also confuse the reader. In the patch attached the two example

[issue29054] pty.py: pty.spawn hangs after client disconnect over nc (netcat)

Cornelius Diekmann added the comment: Status change: I proposed a generic test suite for pty.spawn() in issue29070. Once we have agreed on the current behavior of pty.spawn() and the test suite is merged, I would like to come back to this issue which requests for a change in behavior of pty.sp

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x

Cornelius Diekmann added the comment: I just tested pty.spawn() on OS X 10.6.8 and FreeBSD 11 and it also hangs. It works on Linux. Your patch solves the problem. I proposed a test suite for pty.spawn() in issue29070. The test suite currently only exposes the problem, as suggested by Martin.

[issue29070] Integration tests for pty.spawn on Linux and all other platforms

Cornelius Diekmann added the comment: I did a larger update to my proposed patch. I read the pty man pages and posix standard and designed a test suite which documents the expected behavior of the pty module. The test suite is biased towards my Linux system, but I respect the posix standard. T

[issue29134] contextlib doc bug

SilentGhost added the comment: ContextBaseClass is meant to represent a user-defined class that is a parent of mycontext. -- nosy: +SilentGhost ___ Python tracker ___ __

[issue29133] Minor inaccuracy in shlex.shlex punctuation_chars example

Marco Buttu added the comment: Thank you. The patch fixes it and makes the example under doctest. -- keywords: +patch nosy: +marco.buttu Added file: http://bugs.python.org/file46114/issue29133.patch ___ Python tracker

[issue29134] contextlib doc bug

Changes by Chris Warrick : -- nosy: +Kwpolska ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue29134] contextlib doc bug

New submission from YoSTEALTH: Link: https://docs.python.org/3/library/contextlib.html#contextlib.ContextDecorator "from contextlib import ContextDecorator class mycontext(ContextBaseClass, ContextDecorator):" "ContextBaseClass" is referenced but its no where to be found in source. -

[issue29128] No way to instsall win32com on python 3.6

Changes by Zachary Ware : -- resolution: -> third party stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-

[issue29125] Shell injection via TIX_LIBRARY when using tkinter.tix

Serhiy Storchaka added the comment: Here is a fix. -- keywords: +patch Added file: http://bugs.python.org/file46113/tix_library_shell_injection.patch ___ Python tracker ___ _

[issue29125] Shell injection via TIX_LIBRARY when using tkinter.tix

Changes by Serhiy Storchaka : -- stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue29125] Shell injection via TIX_LIBRARY when using tkinter.tix

Serhiy Storchaka added the comment: I agreed that this security issue has low severity. Only applications that use Tix are vulnerable, and this is very small number of applications. -- ___ Python tracker _

[issue29125] Shell injection via TIX_LIBRARY when using tkinter.tix

Christian Heimes added the comment: yeah, sounds totally fine to me. It's a low risk change and the issue has a small attack surface. I set the priority to release blocker to draw your attention. -- ___ Python tracker

[issue29125] Shell injection via TIX_LIBRARY when using tkinter.tix

Larry Hastings added the comment: This code hasn't changed in years. So while I believe it's a security bug and should be fixed, I don't know if I agree it's a bad enough security bug to stop Python 3.5.3rc1, which is literally in the middle of the release process. I'm guessing this is easily

[issue29132] shlex.shlex with punctuation_chars and posix doesn't handle punctuation next to quotes

Evan added the comment: I've attached a simplistic patch which fixes the problem. I suspect a better fix might be to shuffle the elif branches around so the extra condition isn't necessary. Vinay, what are your thoughts? -- keywords: +patch Added file: http://bugs.python.org/file46112/

[issue29124] Freeze fails to compile on windows

Steve Dower added the comment: Ah, I was thinking of platform.machine(). -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue29131] Calling printf from the cdll does not print the full string

Changes by R. David Murray : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python

[issue29125] Shell injection via TIX_LIBRARY when using tkinter.tix

Changes by Christian Heimes : -- nosy: +benjamin.peterson, christian.heimes, larry, ned.deily priority: normal -> release blocker ___ Python tracker ___ _

[issue28595] shlex.shlex should not augment wordchars

Evan added the comment: I've attached a more complete patch. This takes the conservative approach of retaining all functionality of 3.6 and treating this as a new feature for 3.7. I don't think this is suitable for 3.6.1 given this new behavior contradicts what is currently written in the docu

[issue29133] Minor inaccuracy in shlex.shlex punctuation_chars example

New submission from Evan: https://docs.python.org/3/library/shlex.html#improved-compatibility-with-shells The code sample here does not match the output - the first line is labelled 'New' and the second line 'Old'. -- assignee: docs@python components: Documentation messages: 284481 nos

[issue29132] shlex.shlex with punctuation_chars and posix doesn't handle punctuation next to quotes

New submission from Evan: When both punctuation_chars and posix are used, any punctuation directly next to quoted characters is interpreted as a single token. >>> from shlex import shlex >>> list(shlex('>"a"', posix=True)) ['>', 'a'] >>> list(shlex('>"a"', punctuation_chars=True)) ['>', '"a"']

[issue29071] IDLE doesn't highlight f-strings properly

Terry J. Reedy added the comment: The doc appears to be carefully accurate, but the second sentence especially is a bit awkward. I will open a new issue. -- ___ Python tracker

[issue29006] 2.7.13 _sqlite more prone to "database table is locked"

Marc-Andre Lemburg added the comment: As general comment, I think you'd have to check which operation modes SQLite supports for the case of a transaction commit/rollback in the light of open cursors. ODBC defines the following cases and each data source can specify a different behavior (https

[issue29128] No way to instsall win32com on python 3.6

Chi Hsuan Yen added the comment: https://github.com/pywin32/pypiwin32/pull/2 Anyway this is not a Python issue but pywin32's. -- nosy: +Chi Hsuan Yen ___ Python tracker ___

[issue29128] No way to instsall win32com on python 3.6

Evan added the comment: This package doesn't yet have a wheel for Python 3.6, so it falls back on the source distribution, and the setup.py file doesn't run under Python 3. You can either wait for the maintainer to upload the new wheel to PyPI, or take one of the recently built installers from

[issue29013] zipfile: inconsistent doc for ZIP64 file size

Monte Davidoff added the comment: Serhiy, thank you for the correction and the additional information. I tried reading a zip file larger than 4 GiB with allowZip64=False, and it worked, so it looks like allowZip64 only applies to writing. I suggest we fix the inconsistency in the documentation

[issue24725] test_socket testFDPassEmpty fails on OS X 10.11+ with "Cannot allocate memory"

Ned Deily added the comment: This issue slipped off the radar (so to speak) after being closed. For one, the tests also fail on 3.5.x (and probably earlier systems) and fail on macOS 10.12, not just 10.11. And, two, I'm not sure if anyone opened an issue with Apple about it. I'm re-opening