[issue34410] Segfault/TimeoutError: itertools.tee of multiprocessing.pool.imap_unordered

2018-08-15 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the script. I can reproduce this on master and Python 3.6 too. Sometimes the attached script causes timeout error. Running it under gdb gives me below : [New Thread 0x18ab of process 10682] [New Thread 0x1903 of process 10682] [New

[issue34410] Segfault/TimeoutError: itertools.tee of multiprocessing.pool.imap_unordered

2018-08-15 Thread Carlo Rosati
Carlo Rosati added the comment: You'll also need to lock when modifying the manager's list. Does anyone know how to do this using the multiprocessing.Queues without deadlocking? -- ___ Python tracker

[issue34395] memory leaks in error handling in csv and pickle modules

2018-08-15 Thread miss-islington
miss-islington added the comment: New changeset b14ab447ee3f47d479d899b4001d870569a76c44 by Miss Islington (bot) in branch '3.6': bpo-34395: Fix memory leaks caused by incautious usage of PyMem_Resize(). (GH-8756)

[issue34395] memory leaks in error handling in csv and pickle modules

2018-08-15 Thread miss-islington
miss-islington added the comment: New changeset 962051eeb0ba486b8ffe4082779b4fa432e3dfb2 by Miss Islington (bot) in branch '3.7': bpo-34395: Fix memory leaks caused by incautious usage of PyMem_Resize(). (GH-8756)

[issue34395] memory leaks in error handling in csv and pickle modules

2018-08-15 Thread miss-islington
Change by miss-islington : -- pull_requests: +8253 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34395] memory leaks in error handling in csv and pickle modules

2018-08-15 Thread miss-islington
Change by miss-islington : -- pull_requests: +8254 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34395] memory leaks in error handling in csv and pickle modules

2018-08-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 67b9cc8e6072a919d2ed7e7ecc8124c8acfb3733 by Serhiy Storchaka (Sergey Fedoseev) in branch 'master': bpo-34395: Fix memory leaks caused by incautious usage of PyMem_Resize(). (GH-8756)

[issue34410] Segfault/TimeoutError: itertools.tee of multiprocessing.pool.imap_unordered

2018-08-15 Thread Carlo Rosati
Carlo Rosati added the comment: Okay I needed to do .pop(0) instead of .pop(-1) which is probably O(N) -- ___ Python tracker ___

[issue34410] Segfault/TimeoutError: itertools.tee of multiprocessing.pool.imap_unordered

2018-08-15 Thread Carlo Rosati
Carlo Rosati added the comment: I figured out that the problem is itertools.tee does not use a multiprocessing.Manager proxied object for shared state. I was able to create a workaround tee as follows. def multiprocessing_tee(iterable, n=2): """Write a multiprocessing safe

[issue34217] windows: cross compilation fails due to headers with uppercase

2018-08-15 Thread Steve Dower
Steve Dower added the comment: Are those bugs? On Windows, they are spelled with that casing (and while NTFS is case-insensitive, it *is* case-preserving). Whatever package you have used for cross-compiling may have renamed them (similarly Shlwapi.h). In which case, perhaps you could

[issue1529353] Squeezer - squeeze large output in IDLE

2018-08-15 Thread ppperry
Change by ppperry : -- title: Squeezer - squeeze large output in the interpreter -> Squeezer - squeeze large output in IDLE ___ Python tracker ___

[issue34405] Upgrade to OpenSSL 1.1.0i / 1.0.2p

2018-08-15 Thread miss-islington
miss-islington added the comment: New changeset 64336dc0a5907b04fe85a911cd1b8be9b663587e by Miss Islington (bot) in branch '3.7': bpo-34405: Updated to OpenSSL 1.1.0i for Windows builds. (GH-8775) https://github.com/python/cpython/commit/64336dc0a5907b04fe85a911cd1b8be9b663587e --

[issue34405] Upgrade to OpenSSL 1.1.0i / 1.0.2p

2018-08-15 Thread Steve Dower
Steve Dower added the comment: New changeset 864a892af38afefb0a0464af298cf09d2e1195f7 by Steve Dower in branch 'master': bpo-34405: Updated to OpenSSL 1.1.0i for Windows builds. (GH-8775) https://github.com/python/cpython/commit/864a892af38afefb0a0464af298cf09d2e1195f7 --

[issue34405] Upgrade to OpenSSL 1.1.0i / 1.0.2p

2018-08-15 Thread miss-islington
Change by miss-islington : -- pull_requests: +8252 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34405] Upgrade to OpenSSL 1.1.0i / 1.0.2p

2018-08-15 Thread Steve Dower
Steve Dower added the comment: New changeset eeca87cf3ce5b866dbb210548e23ee91ec5411f2 by Steve Dower in branch '3.6': bpo-34405: Updated to OpenSSL 1.0.2p for Windows builds. (GH-8776) https://github.com/python/cpython/commit/eeca87cf3ce5b866dbb210548e23ee91ec5411f2 --

[issue34405] Upgrade to OpenSSL 1.1.0i / 1.0.2p

2018-08-15 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +8251 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34405] Upgrade to OpenSSL 1.1.0i / 1.0.2p

2018-08-15 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +8250 stage: -> patch review ___ Python tracker ___ ___

[issue34217] windows: cross compilation fails due to headers with uppercase

2018-08-15 Thread Erik Janssens
Erik Janssens added the comment: Attached a small helper script to detect camelcase windows headers, 2 more occurences found : Modules/socketmodule.c versionhelpers.h 306 #include Tools/msi/bundle/bootstrap/pch.h uxtheme.h 18 #include -- status: closed -> open Added file:

[issue30811] A venv created and activated from within a virtualenv uses the outer virtualenv's site-packages rather than its own.

2018-08-15 Thread Tzu-ping Chung
Tzu-ping Chung added the comment: Unfortunately it is not a viable solution. If you run the virtualenv python without activation, e.g. virtualenv --python=python3.7 foo foo/bin/python -m venv bar The VIRTUAL_ENV environment variable wouldn’t be set in this situation, but the created

[issue30811] A venv created and activated from within a virtualenv uses the outer virtualenv's site-packages rather than its own.

2018-08-15 Thread Ilya Kulakov
Ilya Kulakov added the comment: Also hit this issue while trying to run venv on Travis. Perhaps venv should detect if it's running under virtualenv (e.g. the VIRTUAL_ENV env is present) and issue a warning? -- nosy: +Kentzo ___ Python tracker

[issue34411] ProactorEventLoop should use implement GetAddrInfo, GetNameInfo

2018-08-15 Thread Yury Selivanov
Yury Selivanov added the comment: > Is netdb_lock the GIL? No, it's a lock used by getaddrinfo specifically on *some* platforms. It doesn't look like it's used on Windows. > If the thread pooling was effective, the slowdown wouldn't be linear, but it > does indeed appear to be. How can

[issue34411] ProactorEventLoop should use implement GetAddrInfo, GetNameInfo

2018-08-15 Thread ysangkok+launchpad
ysangkok+launchpad added the comment: The lock I was referring to is https://github.com/python/cpython/blob/e0b5b2096ead4cc094a129ce7602ac5c0e998086/Modules/socketmodule.c#L222 Is netdb_lock the GIL? If the thread pooling was effective, the slowdown wouldn't be linear, but it does indeed

[issue34372] Parenthesized expression has incorrect line numbers

2018-08-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: If the proposed solution for issue12458 be merged, this issue will be closed as a duplicate. Otherwise I have a simpler solution for this particular case (and few other cases, but not all cases in issue12458). --

[issue12458] Tracebacks should contain the first line of continuation lines

2018-08-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Seems PR 8774 fixes all mentioned examples (as well as examples in issue34372), except that tracebacks show the single line number of the first line of the multiline expression instead of the range of lines as was suggested. Showing the range of lines

[issue12458] Tracebacks should contain the first line of continuation lines

2018-08-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +8249 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue34411] ProactorEventLoop should use implement GetAddrInfo, GetNameInfo

2018-08-15 Thread Yury Selivanov
Yury Selivanov added the comment: > As far as our experiments show, the requests are blocking each other > irrespective of thread pool size. Which is expected since the lock is global > across threads. It looks like you don't understand how GIL works in Python (sorry if I'm mistaken). The

[issue34411] ProactorEventLoop should use implement GetAddrInfo, GetNameInfo

2018-08-15 Thread ysangkok+launchpad
ysangkok+launchpad added the comment: As far as our experiments show, the requests are blocking each other irrespective of thread pool size. Which is expected since the lock is global across threads. Am I correct in assuming that an implementation for the ProactorEventLoop with IOCP would

[issue34411] ProactorEventLoop should use implement GetAddrInfo, GetNameInfo

2018-08-15 Thread Yury Selivanov
Yury Selivanov added the comment: > so that they wouldn't block the whole event loop. The aren't blocking it now as they are executed in a thread pool. -- ___ Python tracker

[issue34411] ProactorEventLoop should use implement GetAddrInfo, GetNameInfo

2018-08-15 Thread ysangkok+launchpad
New submission from ysangkok+launchpad : Since socket.getaddrinfo and socket.getnameinfo take a lock on Windows, it would be nice to have their corresponding methods in asyncio.ProactorEventLoop use IOCP, so that they wouldn't block the whole event loop. Overlapped I/O flags are available,

[issue2122] mmap.flush does not check for errors on windows

2018-08-15 Thread Steve Dower
Steve Dower added the comment: I agree. We should definitely document it as a change, but I don't think there's anything useful you can do in the case of a flush failing anyway, so it seems unlikely that anyone could depend on the return value. Returning None for success and exception on

[issue27026] async/await keywords are missing from reference docs

2018-08-15 Thread Berker Peksag
Berker Peksag added the comment: The list has been updated in https://github.com/python/cpython/commit/bf9d317626eebcf79bd0756b4dd43df82d5cc186 (Issue 31810 Closing this as 'outdated'. Thanks for the report and for the patch. -- nosy: +berker.peksag resolution: -> out of date

[issue34398] Docs search does not index glossary items

2018-08-15 Thread Berker Peksag
Berker Peksag added the comment: Ammar's pull request looks good to me, but it would be nice to include the item's title in the box. I will add my comments about the design and implementation in the pull request. -- resolution: third party ->

[issue34398] Docs search does not index glossary items

2018-08-15 Thread Jonathan Fine
Jonathan Fine added the comment: Thank you for this, Ammar. Proof of concept solution is good progress. I'm well impressed. The screen shots convince me that it's well worth doing. For me, the one thing that's missing is a link just above the glossary item. Something like "Glossary:

[issue33255] json.dumps has different behaviour if encoding='utf-8' or encoding='utf8'

2018-08-15 Thread Matej Cepl
Change by Matej Cepl : -- nosy: +mcepl ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34398] Docs search does not index glossary items

2018-08-15 Thread Ammar Askar
Ammar Askar added the comment: I think showing glossary results up top in the search page is a good idea, so I wrote up a quick proof of concept sphinx extension to do so. The diff isn't very big or complicated but it does need a bit of cleanup, especially the javascript and presentation

[issue34398] Docs search does not index glossary items

2018-08-15 Thread Ammar Askar
Change by Ammar Askar : -- keywords: +patch pull_requests: +8248 stage: -> patch review ___ Python tracker ___ ___

[issue34406] Typo in documentation

2018-08-15 Thread Steve Dower
Steve Dower added the comment: Yeah, it definitely shouldn't be a backslash there. The @ isn't my invention, but last time someone questioned it I couldn't find any public examples, so it may be an internal Microsoft thing? I'm not totally attached to it, but if you want to fix it it'll

[issue24218] Also support SMTPUTF8 in smtplib's send_message method.

2018-08-15 Thread R. David Murray
R. David Murray added the comment: Sorry, I haven't had time to look at it yet :( Not sure when I will, things are more than a bit busy for me right now. Ping me again in two weeks if I haven't responded, please. The proposed solution sounds reasonable, though, so you could also propose

[issue34401] [SOLUTION] Make test_gdb work on HP-UX

2018-08-15 Thread Michael Osipov
Change by Michael Osipov <1983-01...@gmx.net>: -- title: [solution] Make test_gdb work on HP-UX -> [SOLUTION] Make test_gdb work on HP-UX ___ Python tracker ___

[issue34381] Make tests with outbound connection optional

2018-08-15 Thread Michael Osipov
Michael Osipov <1983-01...@gmx.net> added the comment: That looks promising, I figured out that there is "./python -m test -h". make test TESTOPTS="-uall,-network" works flawlessly. I would have expected a link to https://devguide.python.org/runtests/ from

[issue2122] mmap.flush does not check for errors on windows

2018-08-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: If we break compatibility in any case, what if return None instead of 0? The function always returning 0 looks strange. The function always returning None is common. -- nosy: +serhiy.storchaka versions: +Python 3.8 -Python 2.7, Python 3.4, Python

[issue17180] shutil copy* unsafe on POSIX - they preserve setuid/setgit bits

2018-08-15 Thread Michael Felt
Michael Felt added the comment: my bad: forgot the snippet I mentioned in the previous post: try: lookup("chmod")(dst, mode, follow_symlinks=follow) except NotImplementedError: # if we got a NotImplementedError, it's because # * follow_symlinks=False,

[issue17180] shutil copy* unsafe on POSIX - they preserve setuid/setgit bits

2018-08-15 Thread Michael Felt
Michael Felt added the comment: I am looking at this. Based on the comments from a historical perspective - copyfile() needs to be calling the copy_mode function before any copying actually occurs. As the dest is already open for writing it does not matter (on posix) what mode it has later

[issue34372] Parenthesized expression has incorrect line numbers

2018-08-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- assignee: -> serhiy.storchaka nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list

[issue34384] os.readlink does not accept pathlib.Path on Windows

2018-08-15 Thread Berker Peksag
Berker Peksag added the comment: New changeset e0b5b2096ead4cc094a129ce7602ac5c0e998086 by Berker Peksag in branch 'master': bpo-34384: Fix os.readlink() on Windows (GH-8740) https://github.com/python/cpython/commit/e0b5b2096ead4cc094a129ce7602ac5c0e998086 --

[issue24218] Also support SMTPUTF8 in smtplib's send_message method.

2018-08-15 Thread Jens Troeger
Jens Troeger added the comment: @David, any thoughts on this? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34370] Tkinter scroll issues on macOS

2018-08-15 Thread Vlad Tudorache
Vlad Tudorache added the comment: It seems that Kevin's fix solves the issues. -- ___ Python tracker ___ ___ Python-bugs-list

[issue34398] Docs search does not index glossary items

2018-08-15 Thread Jonathan Fine
Jonathan Fine added the comment: You're right! Thank you. However, there's still a problem. A user searches for a technical term, and the carefully written glossary entry defining it does not appear. For my search term (iterable), there was a single entry with a link to the Glossary page,

[issue34406] Typo in documentation

2018-08-15 Thread Berker Peksag
Change by Berker Peksag : -- nosy: +steve.dower ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34372] Parenthesized expression has incorrect line numbers

2018-08-15 Thread Ammar Askar
Change by Ammar Askar : -- title: Compiler could output more accurate line numbers -> Parenthesized expression has incorrect line numbers ___ Python tracker ___

[issue34372] Compiler could output more accurate line numbers

2018-08-15 Thread Ammar Askar
Ammar Askar added the comment: Note that even just adding an extra arithmetic in your first expression breaks the line numbers: >>> code = """( ... [ ... call1(), ...

[issue34399] [TLS] Update test keys to >= 2048bit

2018-08-15 Thread Christian Heimes
Change by Christian Heimes : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34399] [TLS] Update test keys to >= 2048bit

2018-08-15 Thread Christian Heimes
Christian Heimes added the comment: New changeset 5e9551b4090095fa94cc2dd4afa5bd2177aa3d09 by Christian Heimes in branch '3.6': [3.6] bpo-34399: 2048 bits RSA keys and DH params (GH-8762) (GH-8764) https://github.com/python/cpython/commit/5e9551b4090095fa94cc2dd4afa5bd2177aa3d09 --

[issue33570] OpenSSL 1.1.1 / TLS 1.3 cipher suite changes

2018-08-15 Thread Christian Heimes
Change by Christian Heimes : -- pull_requests: +8247 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34398] Docs search does not index glossary

2018-08-15 Thread Ammar Askar
Ammar Askar added the comment: Hmm, are you sure its not indexed? Look at this search result: https://docs.python.org/3/search.html?q=__slots__ The glossary page shows up in the results for me. Or are you suggesting that if you search for a term defined in the glossary, it be prominently

[issue34400] Undefined behavior in Parser/parsetok.c

2018-08-15 Thread miss-islington
miss-islington added the comment: New changeset 981aa46dce926ce54ec1a2adbb73d1f405ef66ff by Miss Islington (bot) in branch '3.6': closes bpo-34400: Fix undefined behavior in parsetok(). (GH-4439) https://github.com/python/cpython/commit/981aa46dce926ce54ec1a2adbb73d1f405ef66ff --

[issue33570] OpenSSL 1.1.1 / TLS 1.3 cipher suite changes

2018-08-15 Thread Christian Heimes
Christian Heimes added the comment: New changeset 3e630c541b35c96bfe5619165255e559f577ee71 by Christian Heimes in branch '3.6': bpo-33570: TLS 1.3 ciphers for OpenSSL 1.1.1 (GH-6976) (GH-8760) https://github.com/python/cpython/commit/3e630c541b35c96bfe5619165255e559f577ee71 --

[issue34400] Undefined behavior in Parser/parsetok.c

2018-08-15 Thread miss-islington
miss-islington added the comment: New changeset 00aebabc7139741fadfe877372c733a2160c7dbd by Miss Islington (bot) in branch '2.7': closes bpo-34400: Fix undefined behavior in parsetok(). (GH-4439) https://github.com/python/cpython/commit/00aebabc7139741fadfe877372c733a2160c7dbd --

[issue34406] Typo in documentation

2018-08-15 Thread Ammar Askar
Ammar Askar added the comment: For what its worth, window's reg command also makes a distinction between the registry key and value: C:\Users\ammar>reg.exe QUERY HKLM\Software\Microsoft\.NETFramework\Enable64Bit ERROR: The system was unable to find the specified registry key or value.

[issue34400] Undefined behavior in Parser/parsetok.c

2018-08-15 Thread miss-islington
miss-islington added the comment: New changeset 2275b773ebfacb94f6a9c81d6a8b9d54771a68e8 by Miss Islington (bot) in branch '3.7': closes bpo-34400: Fix undefined behavior in parsetok(). (GH-4439) https://github.com/python/cpython/commit/2275b773ebfacb94f6a9c81d6a8b9d54771a68e8 --

[issue34400] Undefined behavior in Parser/parsetok.c

2018-08-15 Thread miss-islington
Change by miss-islington : -- pull_requests: +8246 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34400] Undefined behavior in Parser/parsetok.c

2018-08-15 Thread Benjamin Peterson
Benjamin Peterson added the comment: New changeset 7c4ab2afb17b99eb3f61f9c73cbd548b5e0ad2c0 by Benjamin Peterson (Zackery Spytz) in branch 'master': closes bpo-34400: Fix undefined behavior in parsetok(). (GH-4439)

[issue34400] Undefined behavior in Parser/parsetok.c

2018-08-15 Thread miss-islington
Change by miss-islington : -- pull_requests: +8245 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34400] Undefined behavior in Parser/parsetok.c

2018-08-15 Thread miss-islington
Change by miss-islington : -- pull_requests: +8244 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: