[issue7994] object.__format__ should reject format strings

2010-02-25 Thread Meador Inge
Meador Inge added the comment: The patch looks reasonable. I built on it with the following changes: 1. Added some extra test cases to cover Unicode format strings, since the code was changed to handle these as well. 2. Changed test_builtin.py by s/m[0].message.message/str

[issue7232] Support of 'with' statement fo TarFile class

2010-02-24 Thread Meador Inge
Meador Inge added the comment: Built on Brian's patch by adding the following items: * Added a unit test case to cover exceptional conditions. * Added doc strings on __enter__ and __exit__ (more consistent with the surrounding code). * Spelling error in doc update: s/man

[issue7958] test_platform failure on OS X 10.6

2010-02-23 Thread Meador Inge
Meador Inge added the comment: I am seeing the same problem with 32-bit on OS X 10.5: euclid:trunk minge$ ./python.exe Lib/test/regrtest.py -uall test_platform test_platform 'import site' failed; use -v for traceback Traceback (most recent call last): File "", line 1

[issue7902] relative import broken

2010-02-23 Thread Meador Inge
Meador Inge added the comment: > So doing the import manually through __import__('os', globals(), > locals(), ['walk'], 1) does not work. I get the same behavior for this reproduction case regardless of whether I use: import .os import walk or: __import

[issue3132] implement PEP 3118 struct changes

2010-02-21 Thread Meador Inge
Meador Inge added the comment: > The main thing that I realized from this is that unpacking as a ctypes long > double isn't all that useful for someone who wants to be able to do arithmetic > on the unpacked result. I agree. Especially since ctypes 'long double' ma

[issue5211] Fix complex type to avoid coercion in 2.7.

2010-02-21 Thread Meador Inge
Meador Inge added the comment: > I added a ".. versionchanged" note to the documentation, and fixed a > couple of whitespace issues; Thanks. I checked out the changes you made so that I will know what to do next time :). > Fixed now, with apologies to Meador. No w

[issue3132] implement PEP 3118 struct changes

2010-02-18 Thread Meador Inge
Meador Inge added the comment: Mark, > I think a lot of this discussion needs to go back to python-dev; with > luck, we can get some advice and clarifications from the PEP authors > there. So the next step is to kick off a thread on python-dev summarizing the questions\problem

[issue3132] implement PEP 3118 struct changes

2010-02-16 Thread Meador Inge
Meador Inge added the comment: Hi All, On Sat, Feb 13, 2010 at 5:07 AM, Mark Dickinson wrote: > > Mark Dickinson added the comment: > > Some of the proposed struct module additions look far from straightforward; > I find that section of the PEP significantly lacking

[issue3132] implement PEP 3118 struct changes

2010-02-12 Thread Meador Inge
Meador Inge added the comment: Is anyone working on implementing these new struct modifiers? If not, then I would love to take a shot at it. -- nosy: +minge ___ Python tracker <http://bugs.python.org/issue3

[issue2537] re.compile(r'((x|y+)*)*') should fail

2010-02-11 Thread Meador Inge
Meador Inge added the comment: > The re module is addressed in issue #2636. Wow, that issue thread is massive... What about the 're' module is addressed? Is 'regex' replacing 're'? Is 'regex' being rolled into 're'? Are they b

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

2010-02-11 Thread Meador Inge
Meador Inge added the comment: On Thu, Feb 11, 2010 at 7:16 AM, Ronald Oussoren wrote: > > I've added the tests to the 2.6 branch and have ported the #ifdef guard > around the prototype for completion_matches to the trunk and 3.2. > Verified in trunk. Thanks Ronald!

[issue2537] re.compile(r'((x|y+)*)*') should fail

2010-02-10 Thread Meador Inge
Meador Inge added the comment: > Ruby's behavior seems best to me. We can obtain the Ruby behavior easily. There is one check in sre_compile.py in the '_simple' function that needs to be removed (see attached patch). Whether or not the Ruby behavior is the "correct&q

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

2010-02-07 Thread Meador Inge
Meador Inge added the comment: > That bit is not in the trunk, should it be forward ported to the trunk? FWIW, I would really like to have it. > The actual prototype on 10.5 and 10.6 is: > > char **completion_matches(const char *, CPFunction *); > > Wouldn't

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

2010-02-06 Thread Meador Inge
Meador Inge added the comment: > If not, then we need to make a choice of #ifdef __FreeBSD__ as I > suggested in issue4204, or #ifndef __APPLE__ as I used in my first > personal version of the patch. In the off chance that this same problem were to occur on another platform, wo

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

2010-02-06 Thread Meador Inge
Meador Inge added the comment: > Can you please try inserting that include and see if 10.5 > builds readline? This does not work out of trunk for me: euclid:trunk minge$ sw_vers ProductName:Mac OS X ProductVersion: 10.5.7 BuildVersion: 9J61 euclid:trunk minge$ svn diff Index: M

[issue5211] Fix complex type to avoid coercion in 2.7.

2010-02-06 Thread Meador Inge
Meador Inge added the comment: > if complex were made 'new-style' in 2.7, then it *would* be possible to > > write fairly obvious code (not using coerce or __coerce__) that operated > in > the same way in both 2.7 and 3.2. So I still think it's worth > consi

[issue5211] Fix complex type to avoid coercion in 2.7.

2010-02-03 Thread Meador Inge
Meador Inge added the comment: > Mark > > Yes, that was what I was proposing. As you pointed out in issue 3734, the patch is basically: === --- Objects/complexobject.c (revision 77909) +++ Objects/complexobject.c

[issue5211] Fix complex type to avoid coercion in 2.7.

2010-02-01 Thread Meador Inge
Meador Inge added the comment: Mark, Is this still of interest? I found the relevant changes in py3k, but I am not sure it is the behavior that gumtree is expecting. Since py3k removes coercion completely, the test case from issue 3734 would just issue: Traceback (most recent call last

[issue7266] test_lib2to3 failure under Windows

2010-02-01 Thread Meador Inge
Meador Inge added the comment: This looks to be fixed now [1]. The log shows 'test_lib2to3' passing. BTW, why do we run through Cygwin? I think to test on Windows as most Windows developers do things we need to use the native cmd.exe shell. [1] http://www.python.org/dev/buildbo

[issue2454] sha and md5 fixer

2010-01-31 Thread Meador Inge
Meador Inge added the comment: Attached a patch that provides a (sha | md5) -> hashlib fixer, covering test cases, and updated documentation. -- keywords: +patch nosy: +minge Added file: http://bugs.python.org/file16079/issue-2454.patch ___ Pyt

[issue5664] 2to3 wont convert Cookie.Cookie properly

2010-01-31 Thread Meador Inge
Meador Inge added the comment: There is already a fixer for this in 'Lib/lib2to3/fixes/fix_imports.py'. It was merged to the trunk in r64286. -- nosy: +minge ___ Python tracker <http://bugs.python.

[issue5077] 2to3 fixer for the removal of operator functions

2010-01-31 Thread Meador Inge
Meador Inge added the comment: Attached an updated patch with: (1) The two review issues fixed. (2) Merged the functionality of the initial patch into the existing fixer in 'Lib/lib2to3/fixes/fix_operator.py' + a little refactoring. (3) Added matching test c

[issue6899] Base.replace breaks tree

2010-01-30 Thread Meador Inge
Meador Inge added the comment: I updated the patch with a few unit tests: euclid:trunk minge$ ./python.exe Lib/test/test_lib2to3.py ... == FAIL: test_replace (lib2to3.tests.test_pytree.TestNodes

[issue6978] compiler.transformer dict key bug d[1,] = 1

2010-01-29 Thread Meador Inge
Meador Inge added the comment: I think this should be closed out, since the compiler package was deprecated in 2.6. -- nosy: +minge ___ Python tracker <http://bugs.python.org/issue6

[issue1562308] uninitialized memory read in parsetok()

2010-01-29 Thread Meador Inge
Meador Inge added the comment: This is the same as 3367, which Benjamin just closed out. -- nosy: +benjamin.peterson, minge ___ Python tracker <http://bugs.python.org/issue1562

[issue3367] Uninitialized value read in parsetok.c

2010-01-26 Thread Meador Inge
Changes by Meador Inge : Added file: http://bugs.python.org/file16021/revert-76139-76689.patch ___ Python tracker <http://bugs.python.org/issue3367> ___ ___ Python-bug

[issue3367] Uninitialized value read in parsetok.c

2010-01-26 Thread Meador Inge
Meador Inge added the comment: I think this was fixed with checkins r76689 and r76230, made by Benjamin. Since we are using "exec ''" as the reproduction case, the token state is setup in 'PyTokenizer_FromString', which causes 'tok->inp == ""&

[issue7773] platform._parse_release_file() can cause UnboundLocalError

2010-01-24 Thread Meador Inge
Meador Inge added the comment: Updated the patch to add a test case in 'test_platform'. I also added a comment explaining the change and removed a redundant assignment. -- nosy: +minge Added file: http://bugs.python.org/file15997/issue-

[issue7108] test_commands.py failing on OS X 10.5.7 due to '@' in ls output

2009-10-11 Thread Meador Inge
New submission from Meador Inge : I am testing this out of the trunk on OS X 10.5.7: uclid:trunk minge$ uname -a Darwin euclid.local 9.7.0 Darwin Kernel Version 9.7.0: Tue Mar 31 22:52:17 PDT 2009; root:xnu-1228.12.14~1/RELEASE_I386 i386 euclid:trunk minge$ ./python.exe Lib/test

<    2   3   4   5   6   7