[issue14905] zipimport needs to support namespace packages when no 'directory' entry exists

2020-08-13 Thread Phil Connell
Phil Connell added the comment: One version of the bug described here (and fixed in the old implementation under issue17633) exists in the Python implementation of zipimport: $ unzip -l namespace1.zip Archive: namespace1.zip Length DateTimeName

[issue33608] Add a cross-interpreter-safe mechanism to indicate that an object may be destroyed.

2019-11-21 Thread Phil Connell
Phil Connell added the comment: The attached patch (wrap_threadstate.diff) is enough to stop the crash. It's a slightly dirty proof-of-concept, but equally could be the basis for a solution. The main functional issue is that there's still a race on the Py_BLOCK_THREADS side: it's possible

[issue33608] Add a cross-interpreter-safe mechanism to indicate that an object may be destroyed.

2019-11-21 Thread Phil Connell
Phil Connell added the comment: Just to summarise, I'm fairly sure this is exactly what Victor saw: a daemon thread attempts to reacquire the GIL via Py_END_ALLOW_THREADS after interpreter finalisation. Obviously the threadstate pointer held by the thread is then invalid...so we crash. So

[issue33608] Add a cross-interpreter-safe mechanism to indicate that an object may be destroyed.

2019-11-21 Thread Phil Connell
Phil Connell added the comment: Based on Victor's info from https://bugs.python.org/issue36114#msg337090 I believe the crash is essentially what's reproduced in the attached program. >From the root of a (built) cpython clone run: gcc -c -o fini_crash.o -IInclude -I. fini_crash.c &&

[issue33608] Add a cross-interpreter-safe mechanism to indicate that an object may be destroyed.

2019-11-12 Thread Phil Connell
Change by Phil Connell : -- nosy: +pconnell ___ Python tracker <https://bugs.python.org/issue33608> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38778] Document that os.fork is not allowed in subinterpreters

2019-11-12 Thread Phil Connell
New submission from Phil Connell : Add a comment to the os.fork docs to note that forking from a subinterpreter is no longer allowed (see issue34651) -- assignee: docs@python components: Documentation messages: 356459 nosy: docs@python, eric.snow, pconnell priority: normal severity

[issue36723] Unittest Discovery for namespace subpackages dot notation fails

2019-10-28 Thread Phil Connell
Change by Phil Connell : -- nosy: +pconnell ___ Python tracker <https://bugs.python.org/issue36723> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25597] unittest.mock does not wrap dunder methods (__getitem__ etc)

2019-10-28 Thread Phil Connell
Change by Phil Connell : -- nosy: +pconnell ___ Python tracker <https://bugs.python.org/issue25597> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25299] argparse: TypeError: __init__() takes at least 4 arguments (4 given)

2019-10-28 Thread Phil Connell
Change by Phil Connell : -- nosy: +pconnell ___ Python tracker <https://bugs.python.org/issue25299> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35617] unittest discover does not work with implicit namespaces

2019-10-28 Thread Phil Connell
Change by Phil Connell : -- nosy: +pconnell ___ Python tracker <https://bugs.python.org/issue35617> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38505] Mock.call_args and Mock.call_args_list not propagated to parent Mock

2019-10-28 Thread Phil Connell
Change by Phil Connell : -- nosy: +pconnell ___ Python tracker <https://bugs.python.org/issue38505> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37052] Add examples for mocking async for and async context manager in unittest.mock docs

2019-10-28 Thread Phil Connell
Change by Phil Connell : -- nosy: +pconnell ___ Python tracker <https://bugs.python.org/issue37052> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23882] unittest discovery doesn't detect namespace packages when given no parameters

2019-10-28 Thread Phil Connell
Change by Phil Connell : -- nosy: +pconnell ___ Python tracker <https://bugs.python.org/issue23882> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18108] shutil.chown should support dir_fd and follow_symlinks keyword arguments

2019-10-28 Thread Phil Connell
Change by Phil Connell : -- nosy: +pconnell ___ Python tracker <https://bugs.python.org/issue18108> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38494] Add assert_not_called_with

2019-10-28 Thread Phil Connell
Change by Phil Connell : -- nosy: +pconnell ___ Python tracker <https://bugs.python.org/issue38494> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38122] AsyncMock force always creating an AsyncMock for child mocks

2019-10-28 Thread Phil Connell
Change by Phil Connell : -- nosy: +pconnell ___ Python tracker <https://bugs.python.org/issue38122> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38384] An assertion failure in test_pickle

2019-10-28 Thread Phil Connell
Change by Phil Connell : -- nosy: +pconnell ___ Python tracker <https://bugs.python.org/issue38384> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue7897] Support parametrized tests in unittest

2019-10-28 Thread Phil Connell
Change by Phil Connell : -- nosy: +pconnell ___ Python tracker <https://bugs.python.org/issue7897> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38091] Import deadlock detection causes deadlock

2019-10-28 Thread Phil Connell
Change by Phil Connell : -- nosy: +pconnell ___ Python tracker <https://bugs.python.org/issue38091> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30587] Mock with spec object does not ensure method call signatures

2019-10-28 Thread Phil Connell
Change by Phil Connell : -- nosy: +pconnell ___ Python tracker <https://bugs.python.org/issue30587> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32092] mock.patch with autospec does not consume self / cls argument

2019-10-28 Thread Phil Connell
Change by Phil Connell : -- nosy: +pconnell ___ Python tracker <https://bugs.python.org/issue32092> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1152248] Add support for reading records with arbitrary separators to the standard IO stack

2014-07-26 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1152248 ___ ___ Python-bugs-list

[issue21999] shlex: bug in posix more handling of empty strings

2014-07-18 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21999 ___ ___ Python-bugs-list

[issue9232] Allow trailing comma in any function argument list.

2014-07-09 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9232 ___ ___ Python-bugs-list mailing

[issue7757] sys.path is incorrect when prefix is

2014-04-23 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7757 ___ ___ Python-bugs-list mailing

[issue19533] Unloading docstrings from memory if -OO is given

2014-04-23 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19533 ___ ___ Python-bugs-list

[issue17277] incorrect line numbers in backtrace after removing a trace function

2014-04-23 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17277 ___ ___ Python-bugs-list

[issue12154] PyDoc Partial Functions

2014-04-23 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12154 ___ ___ Python-bugs-list

[issue2292] Missing *-unpacking generalizations

2014-02-07 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2292 ___ ___ Python-bugs-list mailing

[issue20217] Build failure in posixmodule.c with SCHED_SPORADIC available

2014-01-10 Thread Phil Connell
Phil Connell added the comment: Where I actually mean changeset 71704:89e92e684b37 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20217

[issue20217] Build failure in posixmodule.c with SCHED_SPORADIC available

2014-01-10 Thread Phil Connell
New submission from Phil Connell: Typo in revision 71704 that causes build failures on systems with SCHED_SPORADIC available. See attached patch. (Can reproduce by #defining SCHED_SPORADIC just above where it's used in posixmodule.c) -- components: Extension Modules files

[issue16669] Docstrings for namedtuple

2013-12-05 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16669 ___ ___ Python-bugs-list

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

2013-11-23 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___ ___ Python-bugs-list

[issue13907] test_pprint relies on set/dictionary repr() ordering

2013-11-23 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13907 ___ ___ Python-bugs-list

[issue16596] Skip stack unwinding when next, until and return pdb commands executed in generator context

2013-11-23 Thread Phil Connell
Phil Connell added the comment: It looks like call_exc_trace is leaking refs to Py_None. I believe the attached patch fixes the issue (it certainly fixes Antoine's failing invokation :) -- Added file: http://bugs.python.org/file32794/issue16596_leak.diff

[issue16596] Skip stack unwinding when next, until and return pdb commands executed in generator context

2013-11-23 Thread Phil Connell
Phil Connell added the comment: Full run of the test suite was clean, so the fix is ready to go. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16596

[issue18036] How do I create a .pyc file? FAQ entry is out of date

2013-11-23 Thread Phil Connell
Phil Connell added the comment: I've had a stab at creating a patch for this. As well as mentioning __pycache__, I've tweaked some wording to reflect the fact that .pyc files are regenerated if the source file's length changes (as per issue13645). -- Added file: http

[issue13344] closed sockets don't raise EBADF anymore

2013-11-23 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13344 ___ ___ Python-bugs-list

[issue19291] Add docs for asyncio package (Tulip, PEP 3156)

2013-11-23 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19291 ___ ___ Python-bugs-list

[issue16596] Skip stack unwinding when next, until and return pdb commands executed in generator context

2013-11-16 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16596 ___ ___ Python-bugs-list

[issue14157] time.strptime without a year fails on Feb 29

2013-10-23 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14157 ___ ___ Python-bugs-list

[issue16195] Difficult or impossible to figure out how garbage collector and weak references should interact for user-defined extension types

2013-10-04 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16195 ___ ___ Python-bugs-list

[issue1565525] tracebacks eat up memory by holding references to locals and globals when they are not wanted

2013-08-29 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1565525 ___ ___ Python-bugs-list

[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

2013-08-03 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18566 ___ ___ Python-bugs-list

[issue18594] C accelerator for collections.Counter is slow

2013-08-03 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18594 ___ ___ Python-bugs-list

[issue17669] Segfault caused by weird combination of imports and yield from

2013-07-29 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17669 ___ ___ Python-bugs-list

[issue18565] Test for closing delegating generator with cleared frame (Issue17669)

2013-07-27 Thread Phil Connell
Phil Connell added the comment: Good suggestion, updated patch attached. -- Added file: http://bugs.python.org/file31055/gen_close_with_cleared_frame.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18565

[issue18565] Test for closing delegating generator with cleared frame (Issue17669)

2013-07-26 Thread Phil Connell
New submission from Phil Connell: This is a testcase for issue17669 - it passes against the latest default (and hits the same segfault under 3.3.0). I came up with this while tracking down a thorny generator finalisation crash that turned out to be a variant on 17669. The root cause

[issue18208] Wrong bytecode generated for 'in' operation

2013-06-14 Thread Phil Connell
New submission from Phil Connell: The following two expressions should have the same value: Python 3.4.0a0 (default:fae92309c3be, Jun 14 2013, 09:29:54) [GCC 4.8.0] on linux Type help, copyright, credits or license for more information. 1 in [2] == False False (1 in [2]) == False True

[issue18208] Wrong bytecode generated for 'in' operation

2013-06-14 Thread Phil Connell
Phil Connell added the comment: Thanks Amaury. That's quite surprising, but I wouldn't advocate changing such long standing behaviour. I'm closing the issue. -- status: pending - closed ___ Python tracker rep...@bugs.python.org http

[issue18111] Add a default argument to min max

2013-06-08 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18111 ___ ___ Python-bugs-list

[issue18112] PEP 442 implementation

2013-06-08 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +isoschiz, pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18112 ___ ___ Python-bugs

[issue18129] Fatal Python error: Cannot recover from stack overflow.

2013-06-08 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18129 ___ ___ Python-bugs-list

[issue17792] Unhelpful UnboundLocalError due to del'ing of exception target

2013-05-30 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17792 ___ ___ Python-bugs-list

[issue18032] set methods should specify whether they consume iterators lazily

2013-05-25 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18032 ___ ___ Python-bugs-list

[issue18033] Example for Profile Module shows incorrect method

2013-05-25 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18033 ___ ___ Python-bugs-list

[issue18035] telnetlib incorrectly assumes that select.error has an errno attribute

2013-05-25 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18035 ___ ___ Python-bugs-list

[issue18036] How do I create a .pyc file? FAQ entry is out of date

2013-05-25 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18036 ___ ___ Python-bugs-list

[issue18043] No mention of `match.regs` in `re` documentation

2013-05-25 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18043 ___ ___ Python-bugs-list

[issue18042] Provide enum.unique class decorator

2013-05-25 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18042 ___ ___ Python-bugs-list

[issue18047] Descriptors get invoked in old-style objects and classes

2013-05-25 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18047 ___ ___ Python-bugs-list

[issue17947] Code, test, and doc review for PEP-0435 Enum

2013-05-13 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +isoschiz, pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17947 ___ ___ Python-bugs

[issue17908] Unittest runner needs an option to call gc.collect() after each test

2013-05-11 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17908 ___ ___ Python-bugs-list

[issue17927] Argument copied into cell still referenced by frame

2013-05-08 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17927 ___ ___ Python-bugs-list

[issue17927] Argument copied into cell still referenced by frame

2013-05-08 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +isoschiz ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17927 ___ ___ Python-bugs-list

[issue6028] Interpreter aborts when chaining an infinite number of exceptions

2013-04-25 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6028 ___ ___ Python-bugs-list mailing

[issue7475] codecs missing: base64 bz2 hex zlib hex_codec ...

2013-04-22 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7475 ___ ___ Python-bugs-list mailing

[issue17807] Generator cleanup without tp_del

2013-04-21 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +isoschiz, pconnell -pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17807

[issue17807] Generator cleanup without tp_del

2013-04-21 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17807 ___ ___ Python-bugs-list mailing

[issue17804] streaming struct unpacking

2013-04-20 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17804 ___ ___ Python-bugs-list

[issue17123] Add OCSP support to ssl module

2013-04-19 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17123 ___ ___ Python-bugs-list

[issue15992] Strict aliasing violations in Objects/unicodeobject.c

2013-04-19 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15992 ___ ___ Python-bugs-list

[issue12489] email.errors.HeaderParseError if base64url is used

2013-04-19 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12489 ___ ___ Python-bugs-list

[issue16394] Reducing tee() memory footprint

2013-04-19 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16394 ___ ___ Python-bugs-list

[issue11549] Build-out an AST optimizer, moving some functionality out of the peephole optimizer

2013-04-19 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11549 ___ ___ Python-bugs-list

[issue11698] Improve repr for structseq objects to show named, but unindexed fields

2013-04-19 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11698 ___ ___ Python-bugs-list

[issue17306] Improve the way abstract base classes are shown in help()

2013-04-19 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17306 ___ ___ Python-bugs-list

[issue16863] Python 2 error in Argparse tutorial

2013-04-19 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16863 ___ ___ Python-bugs-list

[issue17633] zipimport's handling of namespace packages is incorrect

2013-04-18 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: Removed file: http://bugs.python.org/file29679/zipimport_ns.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17633

[issue17633] zipimport's handling of namespace packages is incorrect

2013-04-18 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: Removed file: http://bugs.python.org/file29696/test.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17633

[issue17633] zipimport's handling of namespace packages is incorrect

2013-04-18 Thread Phil Connell
Phil Connell added the comment: The attached patch is ready for review. -- Added file: http://bugs.python.org/file29925/issue17633.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17633

[issue15852] typos in curses argument error messages

2013-04-18 Thread Phil Connell
Phil Connell added the comment: The patch looks correct and complete, and still patches and passes the tests. So, as far as I can see, this can be committed. -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue16355] inspect.getcomments() does not work in the interactive shell

2013-04-18 Thread Phil Connell
Phil Connell added the comment: Here's a patch that updates getcomments to match the behaviour of getsource, raising OSError if the source file can't be found and TypeError when passed a built-in. Since this is a backwards-incompatible change, presumably it can only be applied to 3.4

[issue17633] zipimport's handling of namespace packages is incorrect

2013-04-18 Thread Phil Connell
Phil Connell added the comment: Updated patch with markups suggested by Serhiy. -- Added file: http://bugs.python.org/file29927/issue17633-2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17633

[issue9341] allow argparse subcommands to be grouped

2013-04-13 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9341 ___ ___ Python-bugs-list mailing

[issue17633] zipimport's handling of namespace packages is incorrect

2013-04-06 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: Removed file: http://bugs.python.org/file29679/zipimport_ns.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17633

[issue17633] zipimport's handling of namespace packages is incorrect

2013-04-06 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: Added file: http://bugs.python.org/file29679/zipimport_ns.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17633

[issue17633] zipimport's handling of namespace packages is incorrect

2013-04-06 Thread Phil Connell
Phil Connell added the comment: Here's a test that fails without the patch and succeeds with the patch. -- Added file: http://bugs.python.org/file29696/test.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17633

[issue12820] Tests for Lib/xml/dom/minicompat.py

2013-04-06 Thread Phil Connell
Phil Connell added the comment: I happened to spot this issue languishing, and the markups looked pretty straightforward, so I just went ahead and did them. Updated patch attached. -- nosy: +pconnell Added file: http://bugs.python.org/file29698/minicompat_tests_markedup.diff

[issue17636] Modify IMPORT_FROM to fallback on sys.modules

2013-04-05 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17636 ___ ___ Python-bugs-list

[issue17633] zipimport's handling of namespace packages is incorrect

2013-04-04 Thread Phil Connell
New submission from Phil Connell: Only one level of namespace package nesting is handled correctly: $ unzip -l foo.zip Archive: foo.zip Length DateTimeName - -- - 0 2013-04-03 17:28 a/b/c/foo.py 0 2013-04-03 17:34 a/ 0

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

2013-04-04 Thread Phil Connell
Phil Connell added the comment: I've raised issue17633 to track the issue in my last message. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14905

[issue17633] zipimport's handling of namespace packages is incorrect

2013-04-04 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +isoschiz ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17633 ___ ___ Python-bugs-list

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

2013-04-03 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14905 ___ ___ Python-bugs-list

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

2013-04-03 Thread Phil Connell
Phil Connell added the comment: The problem appears to be more general. zipimport fails for deeper hierarchies, even with directory entries. With the supplied patch (zipimport-issue14905-2.patch) I see the following: $ unzip -l foo.zip Archive: foo.zip Length DateTimeName

[issue17630] Create a pure Python zipfile importer

2013-04-03 Thread Phil Connell
Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17630 ___ ___ Python-bugs-list

[issue17577] Add lookahead/peek wrapper to itertools

2013-03-31 Thread Phil Connell
Phil Connell added the comment: I like the suggested API: iterator with indexing is a good articulation of the request. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17577

[issue17577] Add lookahead/peek wrapper to itertools

2013-03-29 Thread Phil Connell
New submission from Phil Connell: A recipe often requested on the likes of stackoverflow and activestate is a way to look 'ahead' in an iterator, without altering the values returned for subsequent next() calls. Last time this came up on python-ideas, it got a reasonable reception: http

[issue16449] RotatingFileHandler rollover doesn't work on QNX shmem filesystems

2012-11-11 Thread Phil Connell
Phil Connell added the comment: I'm not convinced that it matters whether the rename or move is atomic. Can anyone come up with a quick concrete example? I see two scenarios: 1. The process crashes during a copy in shutils.move(). In this case, some logs will be duplicated across the files

[issue16449] RotatingFileHandler rollover doesn't work on QNX shmem filesystems

2012-11-11 Thread Phil Connell
Phil Connell added the comment: Serhiy, there are also calls to os.rename in RotatingFileHandler.doRollover -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16449

  1   2   >