Phil Connell added the comment:
One version of the bug described here (and fixed in the old implementation
under issue17633) exists in the Python implementation of zipimport:
$ unzip -l namespace1.zip
Archive: namespace1.zip
Length DateTimeName
Phil Connell added the comment:
The attached patch (wrap_threadstate.diff) is enough to stop the crash. It's a
slightly dirty proof-of-concept, but equally could be the basis for a solution.
The main functional issue is that there's still a race on the Py_BLOCK_THREADS
side: it's possible
Phil Connell added the comment:
Just to summarise, I'm fairly sure this is exactly what Victor saw: a daemon
thread attempts to reacquire the GIL via Py_END_ALLOW_THREADS after interpreter
finalisation. Obviously the threadstate pointer held by the thread is then
invalid...so we crash.
So
Phil Connell added the comment:
Based on Victor's info from https://bugs.python.org/issue36114#msg337090 I
believe the crash is essentially what's reproduced in the attached program.
>From the root of a (built) cpython clone run:
gcc -c -o fini_crash.o -IInclude -I. fini_crash.c &&
Change by Phil Connell :
--
nosy: +pconnell
___
Python tracker
<https://bugs.python.org/issue33608>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Phil Connell :
Add a comment to the os.fork docs to note that forking from a subinterpreter is
no longer allowed (see issue34651)
--
assignee: docs@python
components: Documentation
messages: 356459
nosy: docs@python, eric.snow, pconnell
priority: normal
severity
Change by Phil Connell :
--
nosy: +pconnell
___
Python tracker
<https://bugs.python.org/issue36723>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Phil Connell :
--
nosy: +pconnell
___
Python tracker
<https://bugs.python.org/issue25597>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Phil Connell :
--
nosy: +pconnell
___
Python tracker
<https://bugs.python.org/issue25299>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Phil Connell :
--
nosy: +pconnell
___
Python tracker
<https://bugs.python.org/issue35617>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Phil Connell :
--
nosy: +pconnell
___
Python tracker
<https://bugs.python.org/issue38505>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Phil Connell :
--
nosy: +pconnell
___
Python tracker
<https://bugs.python.org/issue37052>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Phil Connell :
--
nosy: +pconnell
___
Python tracker
<https://bugs.python.org/issue23882>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Phil Connell :
--
nosy: +pconnell
___
Python tracker
<https://bugs.python.org/issue18108>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Phil Connell :
--
nosy: +pconnell
___
Python tracker
<https://bugs.python.org/issue38494>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Phil Connell :
--
nosy: +pconnell
___
Python tracker
<https://bugs.python.org/issue38122>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Phil Connell :
--
nosy: +pconnell
___
Python tracker
<https://bugs.python.org/issue38384>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Phil Connell :
--
nosy: +pconnell
___
Python tracker
<https://bugs.python.org/issue7897>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Phil Connell :
--
nosy: +pconnell
___
Python tracker
<https://bugs.python.org/issue38091>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Phil Connell :
--
nosy: +pconnell
___
Python tracker
<https://bugs.python.org/issue30587>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Phil Connell :
--
nosy: +pconnell
___
Python tracker
<https://bugs.python.org/issue32092>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1152248
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21999
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9232
___
___
Python-bugs-list mailing
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7757
___
___
Python-bugs-list mailing
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19533
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17277
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12154
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2292
___
___
Python-bugs-list mailing
Phil Connell added the comment:
Where I actually mean changeset 71704:89e92e684b37
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20217
New submission from Phil Connell:
Typo in revision 71704 that causes build failures on systems with
SCHED_SPORADIC available. See attached patch.
(Can reproduce by #defining SCHED_SPORADIC just above where it's used in
posixmodule.c)
--
components: Extension Modules
files
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16669
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18864
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13907
___
___
Python-bugs-list
Phil Connell added the comment:
It looks like call_exc_trace is leaking refs to Py_None.
I believe the attached patch fixes the issue (it certainly fixes Antoine's
failing invokation :)
--
Added file: http://bugs.python.org/file32794/issue16596_leak.diff
Phil Connell added the comment:
Full run of the test suite was clean, so the fix is ready to go.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16596
Phil Connell added the comment:
I've had a stab at creating a patch for this.
As well as mentioning __pycache__, I've tweaked some wording to reflect the
fact that .pyc files are regenerated if the source file's length changes (as
per issue13645).
--
Added file: http
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13344
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19291
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16596
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14157
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16195
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1565525
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18566
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18594
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17669
___
___
Python-bugs-list
Phil Connell added the comment:
Good suggestion, updated patch attached.
--
Added file: http://bugs.python.org/file31055/gen_close_with_cleared_frame.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18565
New submission from Phil Connell:
This is a testcase for issue17669 - it passes against the latest default (and
hits the same segfault under 3.3.0).
I came up with this while tracking down a thorny generator finalisation crash
that turned out to be a variant on 17669.
The root cause
New submission from Phil Connell:
The following two expressions should have the same value:
Python 3.4.0a0 (default:fae92309c3be, Jun 14 2013, 09:29:54)
[GCC 4.8.0] on linux
Type help, copyright, credits or license for more information.
1 in [2] == False
False
(1 in [2]) == False
True
Phil Connell added the comment:
Thanks Amaury. That's quite surprising, but I wouldn't advocate changing such
long standing behaviour.
I'm closing the issue.
--
status: pending - closed
___
Python tracker rep...@bugs.python.org
http
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18111
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +isoschiz, pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18112
___
___
Python-bugs
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18129
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17792
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18032
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18033
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18035
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18036
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18043
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18042
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18047
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +isoschiz, pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17947
___
___
Python-bugs
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17908
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17927
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +isoschiz
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17927
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6028
___
___
Python-bugs-list mailing
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7475
___
___
Python-bugs-list mailing
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +isoschiz, pconnell -pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17807
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17807
___
___
Python-bugs-list mailing
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17804
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17123
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15992
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12489
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16394
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11549
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11698
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17306
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16863
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
Removed file: http://bugs.python.org/file29679/zipimport_ns.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
Changes by Phil Connell pconn...@gmail.com:
Removed file: http://bugs.python.org/file29696/test.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
Phil Connell added the comment:
The attached patch is ready for review.
--
Added file: http://bugs.python.org/file29925/issue17633.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
Phil Connell added the comment:
The patch looks correct and complete, and still patches and passes the tests.
So, as far as I can see, this can be committed.
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Phil Connell added the comment:
Here's a patch that updates getcomments to match the behaviour of getsource,
raising OSError if the source file can't be found and TypeError when passed a
built-in.
Since this is a backwards-incompatible change, presumably it can only be
applied to 3.4
Phil Connell added the comment:
Updated patch with markups suggested by Serhiy.
--
Added file: http://bugs.python.org/file29927/issue17633-2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9341
___
___
Python-bugs-list mailing
Changes by Phil Connell pconn...@gmail.com:
Removed file: http://bugs.python.org/file29679/zipimport_ns.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
Changes by Phil Connell pconn...@gmail.com:
Added file: http://bugs.python.org/file29679/zipimport_ns.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
Phil Connell added the comment:
Here's a test that fails without the patch and succeeds with the patch.
--
Added file: http://bugs.python.org/file29696/test.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
Phil Connell added the comment:
I happened to spot this issue languishing, and the markups looked pretty
straightforward, so I just went ahead and did them.
Updated patch attached.
--
nosy: +pconnell
Added file: http://bugs.python.org/file29698/minicompat_tests_markedup.diff
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17636
___
___
Python-bugs-list
New submission from Phil Connell:
Only one level of namespace package nesting is handled correctly:
$ unzip -l foo.zip
Archive: foo.zip
Length DateTimeName
- -- -
0 2013-04-03 17:28 a/b/c/foo.py
0 2013-04-03 17:34 a/
0
Phil Connell added the comment:
I've raised issue17633 to track the issue in my last message.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14905
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +isoschiz
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17633
___
___
Python-bugs-list
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14905
___
___
Python-bugs-list
Phil Connell added the comment:
The problem appears to be more general. zipimport fails for deeper hierarchies,
even with directory entries.
With the supplied patch (zipimport-issue14905-2.patch) I see the following:
$ unzip -l foo.zip
Archive: foo.zip
Length DateTimeName
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17630
___
___
Python-bugs-list
Phil Connell added the comment:
I like the suggested API: iterator with indexing is a good articulation of
the request.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17577
New submission from Phil Connell:
A recipe often requested on the likes of stackoverflow and activestate is a way
to look 'ahead' in an iterator, without altering the values returned for
subsequent next() calls.
Last time this came up on python-ideas, it got a reasonable reception:
http
Phil Connell added the comment:
I'm not convinced that it matters whether the rename or move is atomic. Can
anyone come up with a quick concrete example?
I see two scenarios:
1. The process crashes during a copy in shutils.move(). In this case, some logs
will be duplicated across the files
Phil Connell added the comment:
Serhiy, there are also calls to os.rename in RotatingFileHandler.doRollover
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16449
1 - 100 of 103 matches
Mail list logo