[issue35855] IDLE squeezer: improve unsqueezing and autosqueeze default

2019-01-31 Thread Tal Einat
Tal Einat added the comment: In my opinion, everything here is relatively minor compared to some other current issues with IDLE, e.g. some of those mentioned by Raymond Hettinger in his comments on #35196. That being said, a few comments: > E1. Add 'Expand' at the top of the context m

[issue35771] IDLE: Fix tooltip Hovertiptest failure

2019-01-19 Thread Tal Einat
Tal Einat added the comment: This is due to the test using a 50ms delay on hover, and checking "immediately" after generating an "" event that it hasn't triggered yet. Note that this isn't actually "immediately": The Tk root's update() is called in between

[issue35196] IDLE text squeezer is too aggressive and is slow

2019-01-17 Thread Tal Einat
Tal Einat added the comment: The recently merged PR GH-10454 significantly reduced the overhead of Squeezer's write() interception. The overhead should now be entirely insignificant. IMO that deals with the "... and is slow" part of this issue. We've still to decide whethe

[issue35730] IDLE: Fix squeezer test_reload.

2019-01-16 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +11272, 11273, 11274 ___ Python tracker <https://bugs.python.org/issue35730> ___ ___ Python-bugs-list mailing list Unsub

[issue35730] IDLE: Fix squeezer test_reload.

2019-01-16 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +11272, 11273 ___ Python tracker <https://bugs.python.org/issue35730> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35730] IDLE: Fix squeezer test_reload.

2019-01-16 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +11272 ___ Python tracker <https://bugs.python.org/issue35730> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35701] [uuid] 3.8 breaks weak references for UUIDs

2019-01-14 Thread Tal Einat
Tal Einat added the comment: Indeed, a PR for this should include a test that weakrefs work. -- ___ Python tracker <https://bugs.python.org/issue35701> ___ ___

[issue35730] IDLE: Fix squeezer test_reload.

2019-01-14 Thread Tal Einat
Tal Einat added the comment: > What if the old and the new font have the same width? The font is set to Courier 10 in the test's setup, and it is then set to Courier 20 by the test before calling reload(). The zero character should certainly not have the same width in both cases. I

[issue35730] IDLE: Fix squeezer test_reload.

2019-01-14 Thread Tal Einat
Tal Einat added the comment: > The test rely on a specific font name and specific font size: maybe this > specific font is not available. Can you help by checking this? Is there another font known to be universally available? > Instead of skipping the test, would it make same

[issue35196] IDLE text squeezer is too aggressive and is slow

2019-01-13 Thread Tal Einat
Tal Einat added the comment: New changeset 39a33e99270848d34628cdbb1fdb727f9ede502a by Tal Einat in branch 'master': bpo-35196: Optimize Squeezer's write() interception (GH-10454) https://github.com/python/cpython/commit/39a33e99270848d34628cdbb1fdb727f9ede502a

[issue34512] Document platform-specific strftime() behavior for non-ASCII format strings

2019-01-12 Thread Tal Einat
Change by Tal Einat : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.5, Python 3.6 ___ Python tracker <https://bugs.python.or

[issue34512] Document platform-specific strftime() behavior for non-ASCII format strings

2019-01-12 Thread Tal Einat
Change by Tal Einat : -- pull_requests: -11135, 11137 ___ Python tracker <https://bugs.python.org/issue34512> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34512] Document platform-specific strftime() behavior for non-ASCII format strings

2019-01-12 Thread Tal Einat
Change by Tal Einat : -- pull_requests: -11135, 11137, 11139 ___ Python tracker <https://bugs.python.org/issue34512> ___ ___ Python-bugs-list mailing list Unsub

[issue34512] Document platform-specific strftime() behavior for non-ASCII format strings

2019-01-12 Thread Tal Einat
Change by Tal Einat : -- pull_requests: -11135 ___ Python tracker <https://bugs.python.org/issue34512> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34512] Document platform-specific strftime() behavior for non-ASCII format strings

2019-01-12 Thread Tal Einat
Tal Einat added the comment: New changeset 1cffd0eed313011c0c2bb071c8affeb4a7ed05c7 by Tal Einat (Alexey Izbyshev) in branch 'master': bpo-34512: Document platform-specific strftime() behavior for non-ASCII format strings (GH-8948) https://github.com/python/cpython/commit

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2019-01-05 Thread Tal Einat
Tal Einat added the comment: Thanks Serhiy! The compiler doesn't warn about that on Windows. See PR GH-11444 with a fix. -- ___ Python tracker <https://bugs.python.org/issue20

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2019-01-05 Thread Tal Einat
Change by Tal Einat : -- pull_requests: -10894 ___ Python tracker <https://bugs.python.org/issue20182> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2019-01-05 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +10892, 10893, 10894 ___ Python tracker <https://bugs.python.org/issue20182> ___ ___ Python-bugs-list mailing list Unsub

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2019-01-05 Thread Tal Einat
Change by Tal Einat : -- pull_requests: -10893 ___ Python tracker <https://bugs.python.org/issue20182> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2019-01-05 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +10892, 10893 ___ Python tracker <https://bugs.python.org/issue20182> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2019-01-05 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +10892 ___ Python tracker <https://bugs.python.org/issue20182> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35641] IDLE: calltips not properly formatted for functions without doc-strings

2019-01-03 Thread Tal Einat
Tal Einat added the comment: Thanks for the report, Dan! Thanks for the fix, Emmanuel! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue35641] IDLE: calltips not properly formatted for functions without doc-strings

2019-01-03 Thread Tal Einat
Change by Tal Einat : -- pull_requests: -10831 ___ Python tracker <https://bugs.python.org/issue35641> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35641] IDLE: calltips not properly formatted for functions without doc-strings

2019-01-03 Thread Tal Einat
Change by Tal Einat : -- pull_requests: -10830, 10831 ___ Python tracker <https://bugs.python.org/issue35641> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35525] Incorrect keyword name in NNTP.starttls() documentation

2019-01-02 Thread Tal Einat
Change by Tal Einat : -- pull_requests: -10818, 10819, 10821, 10822 ___ Python tracker <https://bugs.python.org/issue35525> ___ ___ Python-bugs-list mailin

[issue35525] Incorrect keyword name in NNTP.starttls() documentation

2019-01-02 Thread Tal Einat
Change by Tal Einat : -- pull_requests: -10818, 10819 ___ Python tracker <https://bugs.python.org/issue35525> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35525] Incorrect keyword name in NNTP.starttls() documentation

2019-01-02 Thread Tal Einat
Change by Tal Einat : -- pull_requests: -10818, 10819, 10822 ___ Python tracker <https://bugs.python.org/issue35525> ___ ___ Python-bugs-list mailing list Unsub

[issue35525] Incorrect keyword name in NNTP.starttls() documentation

2019-01-02 Thread Tal Einat
Change by Tal Einat : -- pull_requests: -10818 ___ Python tracker <https://bugs.python.org/issue35525> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35525] Incorrect keyword name in NNTP.starttls() documentation

2019-01-02 Thread Tal Einat
Tal Einat added the comment: New changeset e9a044ec16989bd4b39763c0588c17200a925350 by Tal Einat (Harmandeep Singh) in branch 'master': bpo-35525: Correct the argument name for NNTP.starttls() (GH-11310) https://github.com/python/cpython/commit/e9a044ec16989bd4b39763c0588c17200a925350

[issue35525] Incorrect keyword name in NNTP.starttls() documentation

2019-01-02 Thread Tal Einat
Change by Tal Einat : -- pull_requests: -10554, 10555 ___ Python tracker <https://bugs.python.org/issue35525> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35525] Incorrect keyword name in NNTP.starttls() documentation

2019-01-02 Thread Tal Einat
Change by Tal Einat : -- pull_requests: -10554 ___ Python tracker <https://bugs.python.org/issue35525> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35500] Align expected and actual calls on mock.assert_called_with error message

2019-01-02 Thread Tal Einat
Tal Einat added the comment: Perhaps "expected" and "observed" or "detected"? -- nosy: +taleinat ___ Python tracker <https://bugs.python.org/issue35500> ___ __

[issue35641] IDLE: calltips not properly formatted for functions without doc-strings

2019-01-02 Thread Tal Einat
Change by Tal Einat : -- pull_requests: -10814, 10815 ___ Python tracker <https://bugs.python.org/issue35641> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35641] IDLE: calltips not properly formatted for functions without doc-strings

2019-01-02 Thread Tal Einat
Change by Tal Einat : -- pull_requests: -10814, 10815, 10816 ___ Python tracker <https://bugs.python.org/issue35641> ___ ___ Python-bugs-list mailing list Unsub

[issue35641] IDLE: calltips not properly formatted for functions without doc-strings

2019-01-02 Thread Tal Einat
Change by Tal Einat : -- pull_requests: -10814 ___ Python tracker <https://bugs.python.org/issue35641> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35641] IDLE: calltips not properly formatted for functions without doc-strings

2019-01-02 Thread Tal Einat
Tal Einat added the comment: I'm marking this as easy. Whoever works on this should make sure to add a new test case for this bug. -- assignee: taleinat -> keywords: +easy ___ Python tracker <https://bugs.python.org/issu

[issue35196] IDLE text squeezer is too aggressive and is slow

2019-01-02 Thread Tal Einat
Tal Einat added the comment: Hi Dan, Your report is unrelated to this Squeezer-related issue, but thanks for reporting it! I've created a new issue for what you've reported, see #35641. -- ___ Python tracker <https://bugs.python.org/issue35

[issue35641] IDLE: calltips not properly formatted for functions without doc-strings

2019-01-02 Thread Tal Einat
Change by Tal Einat : -- assignee: -> taleinat components: +IDLE nosy: +terry.reedy stage: -> needs patch type: -> behavior versions: +Python 3.7, Python 3.8 ___ Python tracker <https://bugs.python.or

[issue35641] IDLE: calltips not properly formatted for functions without doc-strings

2019-01-02 Thread Tal Einat
New submission from Tal Einat : IDLE usually wraps call-tips to 85 characters. However, for functions without a doc-string, this formatting is skipped. This is an issue for functions with long signatures, e.g. due to having many arguments or due to having default values with long repr-s

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2019-01-01 Thread Tal Einat
Change by Tal Einat : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2019-01-01 Thread Tal Einat
Change by Tal Einat : -- Removed message: https://bugs.python.org/msg332827 ___ Python tracker <https://bugs.python.org/issue20182> ___ ___ Python-bugs-list m

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2019-01-01 Thread Tal Einat
Change by Tal Einat : -- Removed message: https://bugs.python.org/msg332828 ___ Python tracker <https://bugs.python.org/issue20182> ___ ___ Python-bugs-list m

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-31 Thread Tal Einat
Tal Einat added the comment: New changeset ede0b6fae20290bf22b6ee1b9a1e1179d750f360 by Tal Einat in branch 'master': bpo-20182: AC convert Python/sysmodule.c (GH-11328) https://github.com/python/cpython/commit/ede0b6fae20290bf22b6ee1b9a1e1179d750f360

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-31 Thread Tal Einat
Tal Einat added the comment: New changeset ede0b6fae20290bf22b6ee1b9a1e1179d750f360 by Tal Einat in branch 'master': bpo-20182: AC convert Python/sysmodule.c (GH-11328) https://github.com/python/cpython/commit/ede0b6fae20290bf22b6ee1b9a1e1179d750f360

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-31 Thread Tal Einat
Tal Einat added the comment: AFAICT, this issue can finally be closed! -- ___ Python tracker <https://bugs.python.org/issue20182> ___ ___ Python-bugs-list mailin

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-31 Thread Tal Einat
Tal Einat added the comment: Note that the problematic part of the Modules/_hashopenssl.c AC conversion was reverted, as part of GH-11379. -- ___ Python tracker <https://bugs.python.org/issue20

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-31 Thread Tal Einat
Tal Einat added the comment: New changeset ede0b6fae20290bf22b6ee1b9a1e1179d750f360 by Tal Einat in branch 'master': bpo-20182: AC convert Python/sysmodule.c (GH-11328) https://github.com/python/cpython/commit/ede0b6fae20290bf22b6ee1b9a1e1179d750f360

[issue22703] Idle Code Context menu entrie(s)

2018-12-28 Thread Tal Einat
Tal Einat added the comment: Terry, I'm having trouble getting Tk to work on my Mac since the Mojave update, so I'm not yet able to check this. -- ___ Python tracker <https://bugs.python.org/issue22

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-28 Thread Tal Einat
Change by Tal Einat : -- Removed message: https://bugs.python.org/msg332590 Removed message: https://bugs.python.org/msg332607 Removed message: https://bugs.python.org/msg332661 ___ Python tracker <https://bugs.python.org/issue20

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-28 Thread Tal Einat
Change by Tal Einat : -- Removed message: https://bugs.python.org/msg332590 Removed message: https://bugs.python.org/msg332607 ___ Python tracker <https://bugs.python.org/issue20

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-28 Thread Tal Einat
Change by Tal Einat : -- Removed message: https://bugs.python.org/msg332590 ___ Python tracker <https://bugs.python.org/issue20182> ___ ___ Python-bugs-list m

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-28 Thread Tal Einat
Tal Einat added the comment: New changeset c6c7237272499b2c528acb5f62601421f329e92a by Tal Einat in branch 'master': bpo-20182: AC convert remaining functions/methods in _hashopenssl.c (GH-9213) https://github.com/python/cpython/commit/c6c7237272499b2c528acb5f62601421f329e92a

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-28 Thread Tal Einat
Change by Tal Einat : -- Removed message: https://bugs.python.org/msg332590 Removed message: https://bugs.python.org/msg332594 Removed message: https://bugs.python.org/msg332608 Removed message: https://bugs.python.org/msg332609 ___ Python tracker

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-28 Thread Tal Einat
Change by Tal Einat : -- Removed message: https://bugs.python.org/msg332608 Removed message: https://bugs.python.org/msg332609 ___ Python tracker <https://bugs.python.org/issue20

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-28 Thread Tal Einat
Change by Tal Einat : -- Removed message: https://bugs.python.org/msg332594 Removed message: https://bugs.python.org/msg332608 ___ Python tracker <https://bugs.python.org/issue20

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-28 Thread Tal Einat
Change by Tal Einat : -- Removed message: https://bugs.python.org/msg332609 ___ Python tracker <https://bugs.python.org/issue20182> ___ ___ Python-bugs-list m

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-27 Thread Tal Einat
Tal Einat added the comment: New changeset c6c7237272499b2c528acb5f62601421f329e92a by Tal Einat in branch 'master': bpo-20182: AC convert remaining functions/methods in _hashopenssl.c (GH-9213) https://github.com/python/cpython/commit/c6c7237272499b2c528acb5f62601421f329e92a

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-27 Thread Tal Einat
Tal Einat added the comment: New changeset c6c7237272499b2c528acb5f62601421f329e92a by Tal Einat in branch 'master': bpo-20182: AC convert remaining functions/methods in _hashopenssl.c (GH-9213) https://github.com/python/cpython/commit/c6c7237272499b2c528acb5f62601421f329e92a

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-27 Thread Tal Einat
Tal Einat added the comment: New changeset c6c7237272499b2c528acb5f62601421f329e92a by Tal Einat in branch 'master': bpo-20182: AC convert remaining functions/methods in _hashopenssl.c (GH-9213) https://github.com/python/cpython/commit/c6c7237272499b2c528acb5f62601421f329e92a

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-27 Thread Tal Einat
Tal Einat added the comment: See new PR GH-11328 with updated AC conversion of Python/sysmodule.c. -- ___ Python tracker <https://bugs.python.org/issue20

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-27 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +10591, 10592 ___ Python tracker <https://bugs.python.org/issue20182> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-27 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +10591, 10592, 10593 ___ Python tracker <https://bugs.python.org/issue20182> ___ ___ Python-bugs-list mailing list Unsub

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-27 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +10591 ___ Python tracker <https://bugs.python.org/issue20182> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-27 Thread Tal Einat
Tal Einat added the comment: New changeset c6c7237272499b2c528acb5f62601421f329e92a by Tal Einat in branch 'master': bpo-20182: AC convert remaining functions/methods in _hashopenssl.c (GH-9213) https://github.com/python/cpython/commit/c6c7237272499b2c528acb5f62601421f329e92a

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-27 Thread Tal Einat
Tal Einat added the comment: The conversion of Modules/_hashopenssl.c leaves just Python/sysmodule.c to be converted from this batch. There's an old patch here from 3.5 years ago that will likely need to be heavily updated. -- ___ Python tracker

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-27 Thread Tal Einat
Change by Tal Einat : -- Removed message: https://bugs.python.org/msg332588 ___ Python tracker <https://bugs.python.org/issue20182> ___ ___ Python-bugs-list m

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-27 Thread Tal Einat
Tal Einat added the comment: The conversion of Modules/_hashopenssh.c leaves just Python/sysmodule.c to be converted from this batch. There's an old patch here from 3.5 years ago that will likely need to be heavily updated. -- ___ Python tracker

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-12-27 Thread Tal Einat
Tal Einat added the comment: New changeset c6c7237272499b2c528acb5f62601421f329e92a by Tal Einat in branch 'master': bpo-20182: AC convert remaining functions/methods in _hashopenssl.c (GH-9213) https://github.com/python/cpython/commit/c6c7237272499b2c528acb5f62601421f329e92a

[issue35363] test_eintr: test_open() hangs randomly on x86-64 El Capitan 3.x buildbot

2018-12-24 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +10550 ___ Python tracker <https://bugs.python.org/issue35363> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33725] Python crashes on macOS after fork with no exec

2018-12-24 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +10551, 10552 ___ Python tracker <https://bugs.python.org/issue33725> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25234] test_eintr.test_os_open hangs under Xcode 7

2018-12-24 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +10548, 10549 ___ Python tracker <https://bugs.python.org/issue25234> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33725] Python crashes on macOS after fork with no exec

2018-12-24 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +10551 ___ Python tracker <https://bugs.python.org/issue33725> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25234] test_eintr.test_os_open hangs under Xcode 7

2018-12-24 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +10548 ___ Python tracker <https://bugs.python.org/issue25234> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35208] IDLE: Squeezed line count ignores wrapping before newline

2018-12-24 Thread Tal Einat
Tal Einat added the comment: New changeset 44a79cc5b3d1fb0c03c99077aa26def85ec26c67 by Tal Einat in branch 'master': bpo-35208: Fix IDLE Squeezer line counting (GH-10449) https://github.com/python/cpython/commit/44a79cc5b3d1fb0c03c99077aa26def85ec26c67

[issue35208] IDLE: Squeezed line count ignores wrapping before newline

2018-12-24 Thread Tal Einat
Change by Tal Einat : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue35208] IDLE: Squeezed lines count ignores window width

2018-12-23 Thread Tal Einat
Tal Einat added the comment: > Part of my thinking with the simple auto-squeeze formula, besides just > simplifying the code, it this. Raymond claimed that squeezing slows down > printing. If measurably true, one way to avoid a slow down would be to use a > simple heuri

[issue35208] IDLE: Squeezed lines count ignores window width

2018-12-15 Thread Tal Einat
Tal Einat added the comment: Terry, I'm not sure I follow your thinking, but it feels like over-thinking. This is a simple bug with a simple fix. Barring the current bug (which the attached PR fixes), the current logic counts lines, taking soft wrapping into account. This was chosen

[issue35208] IDLE: Squeezed lines count ignores window width

2018-12-13 Thread Tal Einat
Tal Einat added the comment: My mistake on the reproduction; try: print('a'*1+'\n'). It does not trigger auto-squeezing, though this is an obvious case where it should be triggered. (Manual squeezing also results in showing just 1 as the line count

[issue34313] Tkinter crashes with Tk-related error on macOS with ActiveTcl 8.6

2018-12-13 Thread Tal Einat
Tal Einat added the comment: We already have a warning about Tk versions on macOS, see macosx.tkVersionWarning(). It is currently printed in new shell windows.It would be straightforward to add warnings when using anything other than 8.5.18 or 8.6.8+. I suggest this approach

[issue34313] Tkinter crashes with Tk-related error on macOS with ActiveTcl 8.6

2018-12-13 Thread Tal Einat
Tal Einat added the comment: > Vlad says in msg323040 "on 8.6.8 I didn't see issues" and in msg326778 "The > issues appear with ... Tk 8.6.[:8]". Different 'issues'? Nope, same issues: Vlad was saying that 8.6.x versions of Tcl/Tk *before* 8.6.8 displayed these

[issue35208] IDLE: Squeezed lines count ignores window width

2018-12-13 Thread Tal Einat
Tal Einat added the comment: Note the lack of newline at the end; that triggers the problematic path in the current calculation. -- ___ Python tracker <https://bugs.python.org/issue35

[issue35208] IDLE: Squeezed lines count ignores window width

2018-12-13 Thread Tal Einat
Tal Einat added the comment: As I mentioned when opening this issue: 'a'*200 (or 'a'*1). -- ___ Python tracker <https://bugs.python.org/issue35208> ___ ___

[issue35208] IDLE: Squeezed lines count ignores window width

2018-12-13 Thread Tal Einat
Tal Einat added the comment: Squeezer currently does take wrapping into account, i.e. it does take IDLE's "soft" line wrapping into account when counting lines. Therefore the auto-squeeze criterion of "at least X lines" does lead to auto-squeezing for any mixtur

[issue31823] Opaque default value for close_fds argument in Popen.__init__

2018-12-12 Thread Tal Einat
Tal Einat added the comment: Gregory, this issue was about the docs, not the doc-string (help()). Are you sure it should be closed? -- ___ Python tracker <https://bugs.python.org/issue31

[issue35387] Dialogs on IDLE are accompanied by a small black window

2018-12-05 Thread Tal Einat
Tal Einat added the comment: Vlad, perhaps you could take a look at this? Note that Tcl/Tk 8.6.9 has recently been released (Nov 16th, 2018), which addresses several other issues pertaining to macOS Mojave. Can someone check this on Mojave with Tk 8.6.9? -- nosy: +vtudorache

[issue31823] Opaque default value for close_fds argument in Popen.__init__

2018-11-22 Thread Tal Einat
Tal Einat added the comment: Danish, see Martin's previous comment (msg314413): "... the signature at [the 3.6 docs] should not show close_fds=True, because that is not necessarily the default on Windows." -- ___ Python track

[issue21603] IDLE: Document SaveAs extension display on Mac

2018-11-11 Thread Tal Einat
Tal Einat added the comment: +1 for closing this either way, preferably with a note in the docs. I'd add the notes about extensions in one set of parenthesis at the end, but that's likely just a matter of taste. -- ___ Python tracker <ht

[issue33196] SEGV in mp.synchronize.Lock.__repr__ in spawn'ed proc if ctx mismatched

2018-11-11 Thread Tal Einat
Tal Einat added the comment: On Win10 I've also failed to reproduce the reported issue with the supplied script. I tried with Python versions 3.6.3, 3.7.0, and a recent build of the master branch (to be 3.8). Can someone try to reproduce this on Fedora

[issue35196] IDLE text squeezer is too aggressive and is slow

2018-11-11 Thread Tal Einat
Tal Einat added the comment: > By the way, I really appreciate the work you all are putting into IDLE. It > can definitely benefit from some love and attention. Thanks for the kind words, Raymond! -- ___ Python tracker <https://bugs.p

[issue34864] In Idle, Mac tabs make editor status line disappear.

2018-11-11 Thread Tal Einat
Tal Einat added the comment: See PR GH-10464, which warns if "Prefer tabs when opening documents" is set to "Always". -- ___ Python tracker <https://bug

[issue34864] In Idle, Mac tabs make editor status line disappear.

2018-11-11 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +9737 ___ Python tracker <https://bugs.python.org/issue34864> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34864] In Idle, Mac tabs make editor status line disappear.

2018-11-10 Thread Tal Einat
Tal Einat added the comment: Can we detect whether this system preference is enabled? If so, perhaps IDLE should display a prominent warning. -- ___ Python tracker <https://bugs.python.org/issue34

[issue35196] IDLE text squeezer is too aggressive and is slow

2018-11-10 Thread Tal Einat
Tal Einat added the comment: Raymond, thanks for bringing up all of these issues. This kind of input from people using IDLE extensively for teaching is extremely useful. I'll leave it to Terry to decide how to manage this list, but I promise to do my best (with my limited time) to resolve

[issue35196] IDLE text squeezer is too aggressive and is slow

2018-11-10 Thread Tal Einat
Change by Tal Einat : -- keywords: +patch pull_requests: +9729 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue35196> ___ ___ Python-

[issue34160] ElementTree not preserving attribute order

2018-11-10 Thread Tal Einat
Tal Einat added the comment: >> ISTM that the coverage tests as currently written aren't good tests. > Hi, I'd like to remind everyone to be open, respectful, and considerate. > There are ways to describe hos things that can be improved. There is no need > to denigrate othe

[issue35208] IDLE: Squeezed lines count ignores window width

2018-11-09 Thread Tal Einat
Tal Einat added the comment: See PR GH-10449 with a fix. -- ___ Python tracker <https://bugs.python.org/issue35208> ___ ___ Python-bugs-list mailing list Unsub

[issue35208] IDLE: Squeezed lines count ignores window width

2018-11-09 Thread Tal Einat
Change by Tal Einat : -- keywords: +patch pull_requests: +9724 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue35208> ___ ___ Python-

[issue35208] IDLE: Squeezed lines count ignores window width

2018-11-09 Thread Tal Einat
New submission from Tal Einat : Squeezing a single long line with a newline, e.g. 'a'*200, results in "Squeezed text (1 lines)". Also, changing the width of the window (even to very small widths) doesn't affect the number of lines reported when squeezing (when squeezing *after*

[issue35196] IDLE text squeezer is too aggressive and is slow

2018-11-09 Thread Tal Einat
Tal Einat added the comment: > On my machine, 2.7.15 (without squeezing) and 3.7.1 (with squeezing) IDLE > results (average seconds). > > from timeit import timeit > timeit("print('nnn '*500)", number=10) # Exp1: .0357, .0355 > timeit("for i in range(500): p

[issue35196] IDLE text squeezer is too aggressive and is slow

2018-11-09 Thread Tal Einat
Tal Einat added the comment: > Serhiy's first comment is about 500 very short lines (experiment 2) not being > squeezed. This surprised me. Tal? Indeed, this is not currently supported. This is possible, it would just complicate the write() interceptor and require the new a

<    2   3   4   5   6   7   8   9   10   11   >