[issue24185] Add Function for Sending File to Trash (or Recycling Bin)

2015-05-14 Thread Virgil Dupras
Virgil Dupras added the comment: For further references, there's also https://mail.python.org/pipermail/python-ideas/2014-December/030547.html which is a deeper discussion and brings even more arguments against it. Even though I'd love to have some of my code integrated int

[issue21643] "File exists" error during venv --upgrade

2014-06-03 Thread Virgil Dupras
Virgil Dupras added the comment: I could reproduce the bug on the v3.4.1 tag, on the 3.4 branch and on the default branch. I think that one of the conditions for the bug to arise is to have the "lib64" symlink created (as described in #21197). I reproduced the bug on Gento

[issue21643] "File exists" error during venv --upgrade

2014-06-02 Thread Virgil Dupras
New submission from Virgil Dupras: There seems to have been a regression in Python 3.4.1 with "pyvenv --upgrade", and this regression seems to be caused by #21197. It now seems impossible to use the "--upgrade" flag without getting a "File exists" error. Ste

[issue15051] Can't compile Python 3.3a4 on OS X

2012-06-12 Thread Virgil Dupras
New submission from Virgil Dupras : I try to compile Pyhton 3.3a4 on a OS X 10.7 with XCode 4.3.3 and it fails. I tried a few configuration options, but even with a basic "./configure && make", I get this: ./python.exe -SE -m sysconfig --generate-posix-vars Could not find

[issue11076] Iterable argparse Namespace

2011-02-10 Thread Virgil Dupras
Virgil Dupras added the comment: Here's a documentation-only patch which adds a section about using vars() to convert a namespace to a dict. If this becomes a documentation issue, can we target Python 3.2.1 instead of Python 3.3? -- Added file: http://bugs.python.org/file

[issue11076] Iterable argparse Namespace

2011-02-05 Thread Virgil Dupras
Virgil Dupras added the comment: I didn't know about vars() (well, I knew it existed, but never was quite sure what it did). Given that I'm not a Python newbie, I'm guessing I'm not alone in this situation. Maybe that instead of making the Namespace iterable, we should

[issue11076] Iterable argparse Namespace

2011-02-02 Thread Virgil Dupras
Virgil Dupras added the comment: I went ahead and created a patch (with test and doc) making argparse.Namespace iterable. -- keywords: +patch -easy Added file: http://bugs.python.org/file20648/issue11076.diff ___ Python tracker <h

[issue11076] Iterable argparse Namespace

2011-01-31 Thread Virgil Dupras
New submission from Virgil Dupras : Currently, there is no (documented) way to easily extract arguments in an argparse Namespace as a dictionary. This way, it would me easy to interface a function taking a lot of kwargs like this: >>> args = parser.parse_args() >>> my_fu

[issue10418] test_io hangs on 3.1.3rc1

2010-11-14 Thread Virgil Dupras
Virgil Dupras added the comment: Ooh, darn, that was it. I installed it and afterwards, the tests passed. Sorry for the fuss, I'll keep that gotcha in mind next time. -- resolution: -> invalid status: open -> closed ___ Python tra

[issue10418] test_io hangs on 3.1.3rc1

2010-11-14 Thread Virgil Dupras
Virgil Dupras added the comment: Nobody else can reproduce the bug? I'm not sure I can fix this (although I can try). I tried to re-compile 3.1.2 with the same flags and run test_io and it passes, so something happened between 3.1.2 and 3.1.3rc1. So, I'll give it a look, but if so

[issue10418] test_io hangs on 3.1.3rc1

2010-11-14 Thread Virgil Dupras
Virgil Dupras added the comment: I ran the test with the -v option flag. The malloc error don't happen at the same place the hang up happens. The first one happens at: test_readline (test.test_io.PyIOTest) ... ok test_unbounded_file (test.test_io.PyIOTest) ... skipped 'test can onl

[issue10418] test_io hangs on 3.1.3rc1

2010-11-14 Thread Virgil Dupras
New submission from Virgil Dupras : I downloaded Python 3.1.3rc1 this morning to do my civic duty of testing it. I don't know what I'm doing wrong, but for me, test_io hangs and never completed. I'm on OS X 10.6.5. I ran it with: $ ./python.exe Lib/test/regrtest.py tes

[issue8392] unit tests rather light on testing __import__(..., level)

2010-07-23 Thread Virgil Dupras
Virgil Dupras added the comment: Brett, I think there's a problem with the tweak you made to the patch. There was already a testcase called RelativeImportTests and you've hidden it (that I why I called it ImportlibRelativeImportTests

[issue7830] Flatten nested functools.partial

2010-07-23 Thread Virgil Dupras
Virgil Dupras added the comment: Oops, used it wrong (but it still works correctly). >>> p2 = partial(p1, 2) >>> p2.func, p2.args (, (1, 2)) -- ___ Python tracker <http://bugs

[issue7830] Flatten nested functools.partial

2010-07-23 Thread Virgil Dupras
Virgil Dupras added the comment: Applies cleanly on the py3k branch at r83069, the tests work correctly (fail before applying the patch, success afterwards), and, to the best of my C-API knowledge, the C code is alright. Oh, and it behaves as described... Python 3.2a0 (py3k:83069M, Jul 23

[issue8392] unit tests rather light on testing __import__(..., level)

2010-07-23 Thread Virgil Dupras
Virgil Dupras added the comment: Because importlib is already well tested and that it already has the machinery to test __import__ instead of the importlib code, I suggest that we re-use importlib's relative tests instead. Attached is a patch that does this. I made sure that __import_

[issue8392] unit tests rather light on testing __import__(..., level)

2010-07-23 Thread Virgil Dupras
Virgil Dupras added the comment: If I understand the patch correctly, this patch basically add a test for relative imports. I'm pretty sure this is already testes in importlib.test. Brett, am I right? If yes, there's no point in applying this patch. -- nosy

[issue839159] iterators broken for weak dicts

2010-07-23 Thread Virgil Dupras
Virgil Dupras added the comment: We might as well backport Antoine's patch rather than take this one (even if mine for 2.x already). It would be weird to have 2 wildly different patches to solve the same problem. Maybe close this ticket and flag issue7105 for backpo

[issue839159] iterators broken for weak dicts

2010-07-23 Thread Virgil Dupras
Virgil Dupras added the comment: It looks like this issue has been fixed in issue7105 already. Can we close this ticket? -- ___ Python tracker <http://bugs.python.org/issue839

[issue9043] 2to3 doesn't handle byte comparison well

2010-06-21 Thread Virgil Dupras
New submission from Virgil Dupras : If we run 2to3 on the following code: s = b' ' print s[0] == s we end up with this: s = b' ' print(s[0] == s) However, the first code, under python2 prints True while the converted code, under python3 prints False. Shouldn't 2to3

[issue6095] os.curdir as the default argument for os.listdir

2010-04-19 Thread Virgil Dupras
Virgil Dupras added the comment: Here's another one. I hadn't realized that it was useless to target the 2.x codebase. So I re-worked this on py3k. The change is non-trivial, since the non-windows/non-os2 part of the code has significantly changed in 3k. This time, since "ona

[issue6095] os.curdir as the default argument for os.listdir

2010-04-18 Thread Virgil Dupras
Virgil Dupras added the comment: Since I last submitted this patch, my leet C skills have improved. I'm submitting another patch, without the needless PyUnicode creation this time. (Moreover, I think the previous patch was wrong to insert code before variable declaration of the

[issue7350] csv doesn't handle escaped characters properly

2009-11-20 Thread Virgil Dupras
Virgil Dupras added the comment: You have to tell the reader how to handle escaping. In your case, you should send escapechar="\\" in reader()'s kwargs. -- nosy: +vdupras ___ Python tracker <http://bugs.py

[issue6095] os.curdir as the default argument for os.listdir

2009-06-14 Thread Virgil Dupras
Virgil Dupras added the comment: 1. Yeah, I know. At first, that's what I wanted to do, but it resulted in a lot of code duplication (alloc, memerror, copy), which I didn't much like. But then again, what I ended up writing (because I realized I had to decref the new "po

[issue6095] os.curdir as the default argument for os.listdir

2009-06-13 Thread Virgil Dupras
Virgil Dupras added the comment: I saw this ticket as a good way to get my feet wet (I almost never touched C) with Python's C API, so I went ahead and did the part for OS X. I also did the Windows part, but I'm not setup to compile Python on Windows, so I don't even know

[issue5679] cleanUp stack for unittest

2009-04-05 Thread Virgil Dupras
Virgil Dupras added the comment: So, we are talking about adding a feature that could cause problem whether cleanup is performed before tearDown or after tearDown. Don't we risk confusing developers who are not familiar with the cleanup order? Do we really want to add this feature? The

[issue1741130] struct.pack("I", "foo"); struct.pack("L", "foo") should fail

2009-04-01 Thread Virgil Dupras
Virgil Dupras added the comment: While the behavior cannot be reproduced in the trunk, in can be reproduced in the 2.6 release: $ python -W ignore Python 2.6.1 (r261:67515, Dec 6 2008, 16:42:21) [GCC 4.0.1 (Apple Computer, Inc. build 5370)] on darwin Type "help", "copyright

[issue5345] cStringIO class name typo

2009-02-22 Thread Virgil Dupras
Virgil Dupras added the comment: The documentation says: "Another difference from the StringIO module is that calling StringIO() with a string parameter creates a read-only object. Unlike an object created without a string parameter, it does not have write methods. These objects ar

[issue839159] iterators broken for weak dicts

2009-02-14 Thread Virgil Dupras
Virgil Dupras added the comment: Oh, that's me again not correctly reading my own tests. It's the *_are_not_held_* tests that test that no reference is kept. I agree about the *_flushed_dead_items_* being an implementation detail. ___ Python trac

[issue839159] iterators broken for weak dicts

2009-02-14 Thread Virgil Dupras
Virgil Dupras added the comment: About duplicated code and performance: When I look at the duplicated code, I don't see anything that remotely looks like a performance tweak. Just to make sure, I made a bench: #!/usr/bin/env python import sys sys.path.insert(0, 'Lib') impor

[issue2153] unittest.py modernization

2008-08-08 Thread Virgil Dupras
Virgil Dupras <[EMAIL PROTECTED]> added the comment: This patch has gone invalid due to some recent conflicting changes. I remade it and I'm resubmitting it hoping that it will get applied. Added file: http://bugs.python.org/file11086/unittest_m

[issue1117601] os.path.exists returns false negatives in MAC environments.

2008-08-08 Thread Virgil Dupras
Virgil Dupras <[EMAIL PROTECTED]> added the comment: Antoine, I think that when this bug was filed, the first "os.path.exists('foobar/baz')" in my example would return False. So it's not that this bug shouldn't be

[issue1117601] os.path.exists returns false negatives in MAC environments.

2008-08-08 Thread Virgil Dupras
Virgil Dupras <[EMAIL PROTECTED]> added the comment: hsoft-dev:~ hsoft$ mkdir foobar hsoft-dev:~ hsoft$ echo "baz" > foobar/baz hsoft-dev:~ hsoft$ chmod 000 foobar/baz hsoft-dev:~ hsoft$ python Python 2.5.2 (r252:60911, Feb 22 2008, 07:57:53) [GCC 4.0.1 (Apple Computer, I

[issue3189] Py3k DeprecationWarning in difflib

2008-06-24 Thread Virgil Dupras
Virgil Dupras <[EMAIL PROTECTED]> added the comment: It slipped out of my mind that performance was probably important for this module, so I ditched that nested get call and went if an if..else. Added file: http://bugs.python.org/file10718/difflib_py3k_deprecation

[issue3189] Py3k DeprecationWarning in difflib

2008-06-24 Thread Virgil Dupras
New submission from Virgil Dupras <[EMAIL PROTECTED]>: When running with the -3 flag, difflib creates DeprecationWarnings. I attach a patch fixing them. There was a note in the code saying "DOES NOT WORK for x in a". However, after my changes, tests still pass, so I removed t

[issue984219] hotspot.stats.load is very slow

2008-03-18 Thread Virgil Dupras
Virgil Dupras <[EMAIL PROTECTED]> added the comment: I had a 54 mb hotshot profile lying around, and it is indeed very long to load, so I ran a profiling session of hotshot.stats.load(MY_BIG_FILE) with python and stdlib of r61515, and here are the results (the resulting prof file is

[issue2387] cStringIO and unicode

2008-03-18 Thread Virgil Dupras
New submission from Virgil Dupras <[EMAIL PROTECTED]>: hsoft-dev:python hsoft$ python Python 2.5.1 (r251:54869, Apr 18 2007, 22:08:04) [GCC 4.0.1 (Apple Computer, Inc. build 5367)] on darwin Type "help", "copyright", "credits" or "license" f

[issue2162] unittest.findTestCases undocumented

2008-03-18 Thread Virgil Dupras
Virgil Dupras <[EMAIL PROTECTED]> added the comment: Can't we close this ticket? __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2162> __ ___ Python

[issue2127] sqlite3 docs should mention utf8 requirement

2008-02-28 Thread Virgil Dupras
Virgil Dupras added the comment: u':memory:'? That already worked before the patch because the implicit encoding with 'ascii' does not bump into any non-ascii character. Nope, one has to call connect with a filename containing non-ascii characters. __

[issue2127] sqlite3 docs should mention utf8 requirement

2008-02-28 Thread Virgil Dupras
Virgil Dupras added the comment: Ok then, we need a test for this. Patch attached. However, I don't know if I applied Amaury's patch wrong or if I miss a ./configure option or something, but even with the patch, the test fails. Another thing: Why isn't the sqlite3 test

[issue839159] iterators broken for weak dicts

2008-02-24 Thread Virgil Dupras
Virgil Dupras added the comment: I made a patch to fix the problem. The cleaning up of they weakref keys or values will be held until all references to iterators created by the weakdict are dead. I also couldn't resist removing code duplication of code in items(), keys() and values()

[issue1738] filecmp.dircmp does exact match only

2008-02-24 Thread Virgil Dupras
Virgil Dupras added the comment: The documentation doesn't say anything about dircmp being supposed to support pattern matching. This ticket is a feature request rather than a bug. -- components: +Library (Lib) -None nosy: +vdupras type: behavior -> feature

[issue2162] unittest.findTestCases undocumented

2008-02-22 Thread Virgil Dupras
Virgil Dupras added the comment: findTestCases is an obsolete function. From the code: # Expose obsolete functions for backwards compatibility __all__.extend(['getTestCaseNames', 'makeSuite', 'findTestCases']) -- nosy: +vdupras

[issue2156] TestCase.tmpdir(), TestCase.mock()

2008-02-21 Thread Virgil Dupras
Virgil Dupras added the comment: Oh, you meant hs.path? ah yeah, it's just for tmppath(), which is of no use except in my own stuff. __ Tracker <[EMAIL PROTECTED]> <http://bugs.python

[issue2156] TestCase.tmpdir(), TestCase.mock()

2008-02-21 Thread Virgil Dupras
Virgil Dupras added the comment: Well, yeah, but I'm the owner, it's not like if the copyright was a problem. I'd gladly release it (and the test unit that goes with it) under BSD. __ Tracker <[EMAIL PROTECTED]> <http://b

[issue2153] unittest.py modernization

2008-02-21 Thread Virgil Dupras
Virgil Dupras added the comment: Isn't it why KeyboardInterrupt is a subclass of BaseException instead of Exception (along with SystemExit)? so that "except Exception:" doesn't catch it? __ Tracker <[EMAIL PROTECTED]> <htt

[issue2127] sqlite3 docs should mention utf8 requirement

2008-02-21 Thread Virgil Dupras
Virgil Dupras added the comment: Shouldn't we apply this patch directly on pysqlite? Any change made to the sqlite3 module will be overwritten in the next "refresh", right? Anyway, I'm not 100% sure, but it might already be fixed: http://www.initd.org/tracker/pysqlite/chan

[issue2156] TestCase.tmpdir(), TestCase.mock()

2008-02-21 Thread Virgil Dupras
New submission from Virgil Dupras: I've been using unittest for quite a while. One thing I got tired with is the code duplication for file management and mocking. A few months ago I created this nifty little TestCase subclass and I've been using it ever since. It works quite well.

[issue2153] unittest.py modernization

2008-02-21 Thread Virgil Dupras
New submission from Virgil Dupras: What prompted me to do these changes is that "Backward compatibility" section for 2.1 and earlier. How long are we going to keep this? According to svn, no commit has been made on the 2.1 branch since 2003. Is it safe to assume no unittest chan

[issue2144] os.environ should inherit dict

2008-02-20 Thread Virgil Dupras
Virgil Dupras added the comment: The performance gain is rather good: hsoft-dev:python hsoft$ ./python.exe -m "timeit" -s "import os" "os.environ['HOME']" 100 loops, best of 3: 1.16 usec per loop hsoft-dev:python hsoft$ patch -p0 < environ

[issue1149798] hotshot.runctx: builtins missing

2008-02-19 Thread Virgil Dupras
Virgil Dupras added the comment: Well, since I brought that issue back, I might as well supply a patch. So if indeed it is decided that hotshot.Profile.runctx() should have __builtins__ in its globals by default, here is it. Added file: http://bugs.python.org/file9462

[issue1149798] hotshot.runctx: builtins missing

2008-02-19 Thread Virgil Dupras
Virgil Dupras added the comment: oh crap here goes my ego... pasted the wrong line. _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1149798> _ ___ Pyth

[issue1149798] hotshot.runctx: builtins missing

2008-02-19 Thread Virgil Dupras
Virgil Dupras added the comment: Python 2.5.1 (r251:54869, Apr 18 2007, 22:08:04) [GCC 4.0.1 (Apple Computer, Inc. build 5367)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> import hotshot >>> ho

[issue2127] sqlite3 docs should mention utf8 requirement

2008-02-19 Thread Virgil Dupras
Virgil Dupras added the comment: +1 I've been pulling my hair off over this one too. Try this on win32: Python 2.5.1 (r251:54863, Apr 18 2007, 08:51:08) [MSC v.1310 32 bit (Intel)] on win32 Type "help", "copyright", "credits" or "license" for more

[issue2124] xml.sax and xml.dom fetch DTDs by default

2008-02-17 Thread Virgil Dupras
Virgil Dupras added the comment: -1 on the systematic warnings too, but what I was talking about is a warning that would say "The server you are trying to fetch your resource from is refusing the connection. Don't cha think you misbehave?" only on 5xx and 4xx responses, not

[issue2124] xml.sax and xml.dom fetch DTDs by default

2008-02-16 Thread Virgil Dupras
Virgil Dupras added the comment: The blog page talked about 503 responses. What about issuing a warning on these responses? Maybe it would be enough to make developers aware of the problem? Or what about in-memory caching of the DTDs? Sure, it wouldn't be as good as a catalog or any

[issue1734234] Fast path for unicodedata.normalize()

2008-02-15 Thread Virgil Dupras
Virgil Dupras added the comment: It's a very interesting patch. I wonder why it fell into oblivion. stuff like "unicode.normalize('NFC', u'\xe9')" was more than twice as fast for me. Making sure that all unicode is normalized can be a bottleneck in a lot of

[issue1777134] minidom pretty xml output improvement

2008-02-15 Thread Virgil Dupras
Virgil Dupras added the comment: If the patch would have better styling ("if(onetextnode == True):"), correct the test it breaks, and even better, add new ones, I guess it would be an acceptable one. -- nosy: +vdupras _ Tracker <[EM

[issue1390] toxml generates output that is not well formed

2008-02-12 Thread Virgil Dupras
Virgil Dupras added the comment: I wanted to start contributing to python for quite a while, so here's my very first try (cleaning out old patchless open tickets). So, whatever is the final decision on this, here's a patch. CDATASection.writexml() already raises ValueError wh