[issue1172] Documentation for done attribute of FieldStorage class

2007-09-18 Thread Sean Reifschneider
Sean Reifschneider added the comment: Committed in trunk revision 58199 Committed in 25-maint revision 58200 Committed in py3k revision 58201 -- status: open -> closed __ Tracker <[EMAIL PROTECTED]> _

[issue1172] Documentation for done attribute of FieldStorage class

2007-09-18 Thread Bob Kline
Bob Kline added the comment: Sean Reifschneider wrote: > Assign your issue that has been ignored to me and I'll take a > look at it. I tried, but it doesn't look like I have sufficient permission to change the assignment. It's http://bugs.python.org/issue1541463 Thanks! _

[issue1172] Documentation for done attribute of FieldStorage class

2007-09-18 Thread Bob Kline
Bob Kline added the comment: Thanks for the very quick follow-up. I may be shooting myself in the foot here, but Sean's encouragement about getting patches to the actual code lead me to wonder if it might be better to go straight for the optimal solution here. As I implied in my original messag

[issue1172] Documentation for done attribute of FieldStorage class

2007-09-18 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: Looks good to me too. This should be committed. -- assignee: fdrake -> jafo resolution: -> accepted versions: +Python 2.5, Python 3.0 __ Tracker <[EMAIL PROTECTED]> ___

[issue1172] Documentation for done attribute of FieldStorage class

2007-09-18 Thread Sean Reifschneider
Sean Reifschneider added the comment: Patch looks good to me. Fred? Comments on "should I do more fixes": Just straight documentation changes are, in my experience, fairly likely to be processed quickly. Changes to the code may take quite a lot more discussion. Smaller, individual patches are

[issue1172] Documentation for done attribute of FieldStorage class

2007-09-17 Thread Bob Kline
New submission from Bob Kline: I have attached a patch which adds partial documentation for the done attribute of the cgi.FieldStorage class. This addition is needed in order to make it safe to rely on the current behavior of the class, which sets this attribute to the value -1 when an uploaded