Éric Araujo mer...@netwok.org added the comment:
No, thank you for contributing :) I don’t know all internals by heart either,
I just needed to step back from the patch and look hard at the tests to make
them look good.
I didn’t say that the patch was finished by the way, I haven’t covered
Éric Araujo mer...@netwok.org added the comment:
BTW, sorry I did not make a patch that could be applied on top of your repo; I
intended to, but your patch did not apply cleanly, so when merging conflicts I
also did other editions and then it was too late.
I hope you appreciate how I solved
Thomas Holmes tho...@devminded.com added the comment:
It's quite alright. Thanks for finishing it up. I realize I ended up a by out
of my depth with regards to packaging's internals and the nuance involved in
this fix. Thanks for all the help.
--
Éric Araujo mer...@netwok.org added the comment:
This patch has tests that look sensible and pass.
--
Added file:
http://bugs.python.org/file23395/d2-get_reinitialized_command-kwargs.diff
___
Python tracker rep...@bugs.python.org
Changes by Thomas Holmes tho...@devminded.com:
Added file: http://bugs.python.org/file23388/7db732ac6796.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12344
___
Changes by Thomas Holmes tho...@devminded.com:
Added file: http://bugs.python.org/file23390/1bb1132840e6.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12344
___
Thomas Holmes tho...@devminded.com added the comment:
Still working with Éric to determine the proper behavior of
get_reinitialized_commands. Latest patch is known incorrect but a step closer
to our destination.
--
___
Python tracker
Changes by Éric Araujo mer...@netwok.org:
--
priority: normal - high
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12344
___
___
Python-bugs-list
Éric Araujo mer...@netwok.org added the comment:
I’d like to commit this; do you need help to address the review I did, or do
you want me to take over if you don’t have the time?
--
___
Python tracker rep...@bugs.python.org
Thomas Holmes tho...@devminded.com added the comment:
I got a bit distracted and I think had some questions on the review. I will go
back over the state of this patch and get some feedback to you tonight or
tomorrow evening.
--
___
Python tracker
Éric Araujo mer...@netwok.org added the comment:
In Distributions.get_reinitialized_command should the
reinitialization of the subcommands also get passed the kwargs?
Yes, the kwargs need to be passed all the way.
Unfortunately my understanding of the (sub)command flow is not rock
solid.
Thomas Holmes tho...@devminded.com added the comment:
See also three comments about style on
http://bugs.python.org/review/8668/diff2/2845:3011/7845
I'm not sure I follow? The patch I attached does not violate the style
guidelines that you indicate in the comments. The only failing I see is
Éric Araujo mer...@netwok.org added the comment:
The patch I attached does not violate the style guidelines that you
indicate in the comments.
Then it’s good. I was hurrying for my train, so I didn’t check your patch but
wanted to reference my comments somewhere before I forgot them.
Thomas Holmes tho...@devminded.com added the comment:
I have added a test and made some additional modifications. I had to modify the
very simple MyCmd object in test_command_cmd.py so that it would have some user
options with default values and support finalization.
--
Changes by Thomas Holmes tho...@devminded.com:
Added file: http://bugs.python.org/file22624/7c61eba07f3f.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12344
___
Changes by Thomas Holmes tho...@devminded.com:
Removed file: http://bugs.python.org/file22624/7c61eba07f3f.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12344
___
Changes by Thomas Holmes tho...@devminded.com:
Added file: http://bugs.python.org/file22625/115c0c10b3ba.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12344
___
Éric Araujo mer...@netwok.org added the comment:
I don’t know if you’ve seen the review I made (there is a bug with user names
on the code review site, sometimes mail does not get sent).
--
___
Python tracker rep...@bugs.python.org
Thomas Holmes tho...@devminded.com added the comment:
I have made a patch based on your suggestions made to higery, Éric. I have two
questions:
1) In Distributions.get_reinitialized_command should the reinitialization of
the subcommands also get passed the kwargs? Unfortunately my
Changes by Thomas Holmes tho...@devminded.com:
Added file: http://bugs.python.org/file22615/d863f392c094.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12344
___
Éric Araujo mer...@netwok.org added the comment:
But can the get_reinitialized_command function reinitialize a command
with a key-value pair?
No, that’s why I did not close this report but asked you if you could make a
patch to update this method.
BTW,how to set the repository URI?
If there
higery shoulderhig...@gmail.com added the comment:
No, that’s why I did not close this report but asked you if you could make a
patch to update this method.
OK, I think I can try to fix it later.
--
___
Python tracker rep...@bugs.python.org
Changes by higery shoulderhig...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file22390/6b68c2835d6e.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12344
___
higery shoulderhig...@gmail.com added the comment:
Not yet tested.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12344
___
___
Python-bugs-list
24 matches
Mail list logo
