Ramchandra Apte added the comment:
On 31 October 2012 23:29, Mark Dickinson rep...@bugs.python.org wrote:
Mark Dickinson added the comment:
Fixed the unuse of decorator syntax. I think the dummy_threading changes
should be considered a separate issue.
With regards to the patch: I
Mark Dickinson added the comment:
I'm not quite sure why you're quoting the docs at me. What's the point you
want to make?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13701
___
Ramchandra Apte added the comment:
On 1 November 2012 14:09, Mark Dickinson rep...@bugs.python.org wrote:
Mark Dickinson added the comment:
I'm not quite sure why you're quoting the docs at me. What's the point
you want to make?
--
___
Mark Dickinson added the comment:
No.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13701
___
___
Python-bugs-list mailing list
Unsubscribe:
Stefan Krah added the comment:
Ramchandra Apte rep...@bugs.python.org wrote:
I'm not quite sure why you're quoting the docs at me. What's the point
you want to make?
Does decimal use the dummy_threading module where
deadlock might occur from a thread being created that blocks waiting
Ramchandra Apte added the comment:
On 1 November 2012 17:12, Stefan Krah rep...@bugs.python.org wrote:
Stefan Krah added the comment:
Ramchandra Apte rep...@bugs.python.org wrote:
I'm not quite sure why you're quoting the docs at me. What's the point
you want to make?
Does
Mark Dickinson added the comment:
I just wanted to ensure that there wouldn't be any bugs by my patch.
Okay, understood. Thanks.
Please note that this issue is now closed, though: the 2.3 compatibility
workarounds have been dealt with. The use or non-use of dummy_threading has
nothing to
Ramchandra Apte added the comment:
But my patch does use dummy_threading.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13701
___
___
Martin v. Löwis added the comment:
Ramchandra: Your patch wasn't actually used to resolve this issue. Please see
http://hg.python.org/cpython/rev/7ada0faded9b for the change that Mark
*actually* made to resolve the issue.
There were actually a number of problems with your patch, but there is
Ramchandra Apte added the comment:
Bmp
---
sent by an 11-year old
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13701
___
___
Ezio Melotti added the comment:
Can you provide a patch?
--
nosy: +ezio.melotti
stage: - needs patch
type: - enhancement
versions: +Python 3.4 -Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13701
Ramchandra Apte added the comment:
I'll give one now.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13701
___
___
Python-bugs-list mailing list
Ramchandra Apte added the comment:
Do you think this should be fixed - the comments say
This module is currently Py2.3 compatible and should be kept that way unless a
major compelling advantage arises. IOW, 2.3 compatibility is strongly
preferred, but not guaranteed.
--
Mark Dickinson added the comment:
It seems fine to me to change it for 3.4, assuming that the diff isn't huge.
Spec updates don't seem likely, and even if they did occur I'd expect them to
be small tweaks rather than major additions.
+0 from me.
--
Ezio Melotti added the comment:
That might be true for 2.7, but for 3.4 it can probably be changed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13701
___
Mark Dickinson added the comment:
BTW, in an earlier comment you said: now threading imports dummy_threading
when threading is not available.
Do you mean that 'import threading' will always succeed, even on platforms
built without thread support? Is this documented somewhere?
The docs at
Ramchandra Apte added the comment:
Is there an equivalent of _dummy_thread for threading?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13701
___
Ramchandra Apte added the comment:
Ignore earlier message.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13701
___
___
Python-bugs-list mailing
Ramchandra Apte added the comment:
@Mark
BTW, in an earlier comment you said: now threading imports dummy_threading
when threading is not available.
My comment only applies to _thread.
--
___
Python tracker rep...@bugs.python.org
Ramchandra Apte added the comment:
Sorry it doesn't apply to anything at all.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13701
___
___
Ramchandra Apte added the comment:
Odd.. I download decimal.py from
http://hg.python.org/cpython/file/fa959dc5c61d/Lib/decimal.py but it uses 1L
(isn't py3k compliant)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13701
Mark Dickinson added the comment:
Revision fa959dc5c61d comes from the 2.7 maintenance branch. Try:
http://hg.python.org/cpython/file/e5f39546989f/Lib/decimal.py
instead. Better still, get a clone of the Python repository. :-)
--
___
Python
Zachary Ware added the comment:
Odd.. I download decimal.py from
http://hg.python.org/cpython/file/fa959dc5c61d/Lib/decimal.py but it uses
1L (isn't py3k compliant)
Try http://hg.python.org/cpython/file/default/Lib/decimal.py
Clicking 'browse' from http://hg.python.org/cpython/ shows the
Ramchandra Apte added the comment:
On 31 October 2012 22:04, Mark Dickinson rep...@bugs.python.org wrote:
Mark Dickinson added the comment:
Revision fa959dc5c61d comes from the 2.7 maintenance branch. Try:
http://hg.python.org/cpython/file/e5f39546989f/Lib/decimal.py
instead.
Ramchandra Apte added the comment:
Attached is a patch.
I haven't tested it.
--
keywords: +patch
Added file: http://bugs.python.org/file27813/decimal.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13701
Ramchandra Apte added the comment:
I'm not sure whether the patch fixes everything.
Gone to sleep.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13701
___
Roundup Robot added the comment:
New changeset 7ada0faded9b by Mark Dickinson in branch 'default':
Issue #13701: Fix decorator avoidance (due to desire for Python 2.3
compatibility) in decimal module.
http://hg.python.org/cpython/rev/7ada0faded9b
--
nosy: +python-dev
Mark Dickinson added the comment:
Fixed the unuse of decorator syntax. I think the dummy_threading changes
should be considered a separate issue.
With regards to the patch: I assume you mean import dummy_threading as
threading rather than just import dummy_threading. Also, it looks to me
Ramchandra Apte maniandra...@gmail.com added the comment:
There is another problem with the code it creates a dummy module when threading
is not available but now threading imports dummy_threading when threading is
not available.
Thanks
--
___
Martin v. Löwis mar...@v.loewis.de added the comment:
I suggest to remove all mentionings of 2.3 compatibility from the file (I
actually could find only a single one), for 3.3. Changing 3.2 is out of scope,
as it isn't a bug fix (except that the one place referring to 2.3 claims that
there is
Raymond Hettinger raymond.hettin...@gmail.com added the comment:
Mark, do you think the C version of decimal is going to happen for 3.3?
If so, it make little sense to make any changes at all the current version of
the pure python code.
Another advantage to leaving the pure python code alone
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +facundobatista, mark.dickinson, rhettinger, skrah
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13701
___
Mark Dickinson dicki...@gmail.com added the comment:
Did you have specific changes in mind?
While we're still maintaining 2.x and 3.x code in parallel, there's a benefit
to not having the versions of decimal.py diverge too much. Given that the
2.3-compatible code isn't actually broken, I'm
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
assignee: - rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13701
___
___
New submission from Ramchandra Apte maniandra...@gmail.com:
Decimal has compatibility for Python 2.3 (such as not using decorators) as
mentioned in comments in the source code for it.
This compatibility should be removed in Python 3.3 and if possible, in Python
3.2.
--
components:
35 matches
Mail list logo
