[issue14804] Wrong defaults args notation in docs

Hynek Schlawack added the comment: The problematic cases have been outsourced to Issue14880 & Issue14870. Closing this one. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue14804] Wrong defaults args notation in docs

Roundup Robot added the comment: New changeset a3c52115 by Hynek Schlawack in branch '2.7': #14804: Remove [] around optional arguments with default values http://hg.python.org/cpython/rev/a3c52115 -- ___ Python tracker

[issue14804] Wrong defaults args notation in docs

Hynek Schlawack added the comment: I agree. I’ve committed the uncontroversial and mostly unrelated 3.x patch and will look at the special cases of 2.7 now. -- ___ Python tracker _

[issue14804] Wrong defaults args notation in docs

Roundup Robot added the comment: New changeset d13fdd97cc8e by Hynek Schlawack in branch '3.2': #14804: Remove [] around optional arguments with default values http://hg.python.org/cpython/rev/d13fdd97cc8e New changeset 2293eba03348 by Hynek Schlawack in branch 'default': #14804: Remove [] arou

[issue14804] Wrong defaults args notation in docs

Petri Lehtinen added the comment: The 3.x patch looks good to me. What comes to the 2.7 patch, there's at least the problem with fmtparam in the csv module (should be **fmtparams instead of [, fmtparam]). And that's were I stopped reviewing, so there may also be other errors. Maybe the proble

[issue14804] Wrong defaults args notation in docs

Hynek Schlawack added the comment: Now we’re all on the same page – any opinions on the patches themselves? :) -- ___ Python tracker ___

[issue14804] Wrong defaults args notation in docs

Ezio Melotti added the comment: Indeed. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue14804] Wrong defaults args notation in docs

Petri Lehtinen added the comment: This issue is about documentation style of function signatures, not about missing keyword arguments in C functions. -- ___ Python tracker ___

[issue14804] Wrong defaults args notation in docs

Éric Araujo added the comment: Yes. Close as duplicate? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue14804] Wrong defaults args notation in docs

Ezio Melotti added the comment: Are you referring to #8350? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14804] Wrong defaults args notation in docs

Éric Araujo added the comment: I think there’s already one report for this. -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue14804] Wrong defaults args notation in docs

Hynek Schlawack added the comment: Here's against 2.7 which proved to be a can of worms. I tried to be as unobstructive as possible. Please have a look at it, I'm sure I forgot some parenthesis somewhere. -- Added file: http://bugs.python.org/file25576/doc-default-args-v2-2.7.diff __

[issue14804] Wrong defaults args notation in docs

Hynek Schlawack added the comment: I had to expand the patch a bit by default args that weren't caught before. So here is still against default. It applies also against 3.2, only missing stuff fails AFAICT. (and yes, I checked the mknod device arg). 2.7 is in the works. -- Added file

[issue14804] Wrong defaults args notation in docs

Petri Lehtinen added the comment: Looking at the code of epoll.poll(), it seems that epoll.poll(timeout=-1, maxevents=-1) is correct and the old epoll.poll([timeout=-1[, maxevents=-1]]) is wrong, as there's no dependency between timeout and maxevents. -- nosy: +petri.lehtine

[issue14804] Wrong defaults args notation in docs

Ezio Melotti added the comment: The patch looks good to me, however in -.. method:: epoll.poll([timeout=-1[, maxevents=-1]]) +.. method:: epoll.poll(timeout=-1, maxevents=-1) it seems that maxevents can be passed only if timeout is specified, and this information is now lost in the signature.

[issue14804] Wrong defaults args notation in docs

New submission from Hynek Schlawack : After having been called out on wrong default arg notation in one of my patches (eg. function:: copyfile(src, dst[, symlinks=False])), I've done a "grep -RPi "\[\w+=" Doc/library" and fixed the cases I've found – many of them sadly from myself (all the sym