[issue1699259] replacing char* with const char* in sysmodule.c/.h

Sebastian Ramacher added the comment: Since the patches are not applicable to Py 3.x and Py 2.7 is stable I'm closing this bug. -- resolution: -> out of date status: open -> closed ___ Python tracker _

[issue1699259] replacing char* with const char* in sysmodule.c/.h

Alexander Belopolsky added the comment: In fact, it looks like const has been added in py3k as early as r57439. I am resetting "versions" to 2.7, but I am -0 on backporting. I am also unselecting "type" because with "feature request" type this should be closed while some may argue that this

[issue1699259] replacing char* with const char* in sysmodule.c/.h

Alexander Belopolsky added the comment: On Mon, Oct 18, 2010 at 11:17 AM, Sebastian Ramacher wrote: .. > Any news on that? Is this patch still relevant for 3.2? It looks like const has been added when char* was changed to wchar_t* in the affected functions. See r62178. -- __

[issue1699259] replacing char* with const char* in sysmodule.c/.h

Sebastian Ramacher added the comment: Any news on that? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue1699259] replacing char* with const char* in sysmodule.c/.h

Mark Lawrence added the comment: This is quite clearly marked as a feature request and hence is 3.2. If you wish to change it go ahead, but who's going to do the work? -- ___ Python tracker ___

[issue1699259] replacing char* with const char* in sysmodule.c/.h

Alexander Belopolsky added the comment: 2.7 is not gone. It has entered an extended maintenance period. During this period, 2.7.x releases will incorporate bug fixes but will not get any new features. This particular issue is arguably a bug. I think Christian should make a call on whethe

[issue1699259] replacing char* with const char* in sysmodule.c/.h

Mark Lawrence added the comment: Drop 2.7 as that's now gone. See also #6952. -- nosy: +BreamoreBoy versions: -Python 2.7 ___ Python tracker ___

[issue1699259] replacing char* with const char* in sysmodule.c/.h

R. David Murray added the comment: See also issue 6952, which seems to be a broader request of the same nature. Moving the 3.1 target to 3.2, since 3.1 is out. -- nosy: +r.david.murray versions: +Python 3.2 -Python 3.1 ___ Python tracker

[issue1699259] replacing char* with const char* in sysmodule.c/.h

Ulrich Eckhardt added the comment: Concerning the SetArgv( int, char**), that one will have to be changed to a SetArgv( int, char const* const*), i.e. applying the const on both levels. Otherwise, there is no implicit conversion between the two. The reason is a bit complicated: if the function

[issue1699259] replacing char* with const char* in sysmodule.c/.h

Alexander Belopolsky <[EMAIL PROTECTED]> added the comment: While technically this is an API change, in reality it is unlikely to break anyone's code because you can always pass char * to a function that expects const char* and the ABI does not change. (Also I cannot think why anyone would want

[issue1699259] replacing char* with const char* in sysmodule.c/.h

Christian Heimes <[EMAIL PROTECTED]> added the comment: Sorry, but it's too late to apply the patch. The issues don't count as "critical" and it changes the API, too. Only critical and important bugs are solved during the release candidate phase of 3.0. Python 2.6 is already out. I set the targe

[issue1699259] replacing char* with const char* in sysmodule.c/.h

Changes by Alexander Belopolsky <[EMAIL PROTECTED]>: -- nosy: +jhylton ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-lis

[issue1699259] replacing char* with const char* in sysmodule.c/.h

Alexander Belopolsky <[EMAIL PROTECTED]> added the comment: The new patch looks fine to me. It applies and compiles without warnings and the changes are now reflected in the docs. I guess someone would need to write a NEWS entry because it is a public API change, but otherwise I would say it s

[issue1699259] replacing char* with const char* in sysmodule.c/.h

Sebastian Ramacher <[EMAIL PROTECTED]> added the comment: At least a response, finally. > * Any reason why PySys_SetPath(char *) is left out? I guess it I just missed it. > * Same for PySys_SetArgv(int, char **) That one is non-trivial and requires some rewriting of PySys_SetArgv. And I did

[issue1699259] replacing char* with const char* in sysmodule.c/.h

Alexander Belopolsky <[EMAIL PROTECTED]> added the comment: The patch no longer applies to trunk, but that would be trivial to fix. Changes like these have been accepted with little resistance in the past (see e.g. issue651362), so I don't see why this patch has been pending for so long. (In

[issue1699259] replacing char* with const char* in sysmodule.c/.h

Changes by Christian Heimes: -- assignee: -> tiran nosy: +tiran type: -> rfe versions: +Python 2.6 _ Tracker <[EMAIL PROTECTED]> _