Weeble clockworksa...@gmail.com added the comment:
Is there any way to write code that's safe with or without this fix? If I have
code that currently does this:
subprocess.check_call('c:\some path with spaces arg1 arg2 a quoted arg',
shell=True)
...will it break when running on a version of
Tim Golden m...@timgolden.me.uk added the comment:
ReComitted as r83947, r83956, r83957 and this time the buildbots look happy.
(At least as regards this change).
--
resolution: - fixed
status: open - closed
___
Python tracker
Tim Golden m...@timgolden.me.uk added the comment:
Committed as r83830, r83831, r83832
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2304
Benjamin Peterson benja...@python.org added the comment:
Reverted because of test-breakage on unixes.
--
nosy: +benjamin.peterson
resolution: fixed -
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2304
Changes by Tim Golden m...@timgolden.me.uk:
--
assignee: - tim.golden
components: +Windows
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2304
___
Changes by David Stanek dsta...@dstanek.com:
--
nosy: +dstanek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2304
___
___
Python-bugs-list mailing
Mark Lawrence breamore...@yahoo.co.uk added the comment:
@Tim: @Gabriel: test_subprocess has changed a lot since the patch was done. If
one of you could provide a new patch for 2.7 and py3k I'll test it, thanks.
--
nosy: +BreamoreBoy
versions: -Python 2.6
Gabriel Genellina gagsl-...@yahoo.com.ar added the comment:
An up-to-date patch; same contents, but this one can be cleanly
applied to trunk (as of r76294)
--
versions: +Python 2.7, Python 3.1, Python 3.2
Added file: http://bugs.python.org/file15340/subprocess.diff
Changes by David Fraser dav...@sjsoft.com:
--
nosy: +davidfraser
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2304
___
___
Python-bugs-list
Changes by Tennessee Leeuwenburg tleeuwenb...@gmail.com:
--
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2304
___
___
Tim Golden [EMAIL PROTECTED] added the comment:
Updated patch against r61514. Test code now PEP8-compliant (I hope). New
tests cover spaces in command and parameter with and without shell=True,
both as simple command string and as list of command/args.
Added file:
Tim Golden [EMAIL PROTECTED] added the comment:
Gabriel Genellina wrote:
Gabriel Genellina [EMAIL PROTECTED] added the comment:
You aren't testing the modified code, the Popen call should say
shell=True.
I think that a more PEP8-compliant style would be nice (removing the
spaces after
Changes by Tim Golden [EMAIL PROTECTED]:
--
title: subprocess under windows fails to quote properly under Windows when
shell=True - subprocess under windows fails to quote properly when shell=True
__
Tracker [EMAIL PROTECTED]
Gabriel Genellina [EMAIL PROTECTED] added the comment:
You aren't testing the modified code, the Popen call should say
shell=True.
I think that a more PEP8-compliant style would be nice (removing the
spaces after open and read, and using consistent indentation)
--
nosy: +gagenellina
14 matches
Mail list logo
