[issue23908] Check path arguments of os functions for null character

Changes by Serhiy Storchaka : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue23908] Check path arguments of os functions for null character

Serhiy Storchaka added the comment: Thank you for noticing this. -- ___ Python tracker ___ ___

[issue23908] Check path arguments of os functions for null character

Roundup Robot added the comment: New changeset b0e8a2e7c361 by Serhiy Storchaka in branch '2.7': Fixed a test for issue23908 with C locale. https://hg.python.org/cpython/rev/b0e8a2e7c361 -- ___ Python tracker

[issue23908] Check path arguments of os functions for null character

koobs added the comment: == ERROR: test_path_with_null_unicode (test.test_posix.PosixTester) -- Traceback (most recent call last): File

[issue23908] Check path arguments of os functions for null character

koobs added the comment: koobs-freebsd{9,10,current) failing after 30099abdb3a46d0e306a4cf995b95fa8cfb8b78a merge to 2.7 -- nosy: +koobs resolution: fixed -> status: closed -> open ___ Python tracker

[issue23908] Check path arguments of os functions for null character

Serhiy Storchaka added the comment: Thank you Zachary. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue23908] Check path arguments of os functions for null character

Roundup Robot added the comment: New changeset 30099abdb3a4 by Serhiy Storchaka in branch '2.7': Issue #23908: os functions, open() and the io.FileIO constructor now reject https://hg.python.org/cpython/rev/30099abdb3a4 -- ___ Python tracker

[issue23908] Check path arguments of os functions for null character

Zachary Ware added the comment: I get one test failure: ERROR: test_u (__main__.Unicode_TestCase) -- Traceback (most recent call last): File "P:\ath\to\cpython\lib\test\test_getargs2.py", line 782, in test_u

[issue23908] Check path arguments of os functions for null character

Serhiy Storchaka added the comment: Ping. Can anybody please test the patch on Windows? -- ___ Python tracker ___

[issue23908] Check path arguments of os functions for null character

Serhiy Storchaka added the comment: Since the large part of code is Windows specific (and even is not compiled on Linux), the patch needs testing on Windows. -- ___ Python tracker

[issue23908] Check path arguments of os functions for null character

Serhiy Storchaka added the comment: Proposed patch fixes this issue and issue13848 in 2.7. -- nosy: +benjamin.peterson stage: needs patch -> patch review Added file: http://bugs.python.org/file43492/unicode_converter_null_char-2.7.patch ___ Python

[issue23908] Check path arguments of os functions for null character

Roundup Robot added the comment: New changeset cdadde8396a4 by Serhiy Storchaka in branch '3.4': Issue #23908: os functions now reject paths with embedded null character https://hg.python.org/cpython/rev/cdadde8396a4 New changeset bdf13c7dcf7f by Serhiy Storchaka in branch 'default': Issue

[issue23908] Check path arguments of os functions for null character

Serhiy Storchaka added the comment: The patch for 2.7 should be different and more complex. First at all, s and u format units don't check for null character (but et and es used in Unix implementations of os functions do). -- stage: patch review - needs patch versions: +Python 2.7

[issue23908] Check path arguments of os functions for null character

Serhiy Storchaka added the comment: I can't test the patch on UNIX, this branch of the code is executed only on Windows. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23908 ___

[issue23908] Check path arguments of os functions for null character

STINNER Victor added the comment: I can't test the patch on UNIX, this branch of the code is executed only on Windows. If you write a test which ensures that a path with a null character raises a TypeError, it should pass on UNIX on your PC. Then builbots will ensure that it also pass on

[issue23908] Check path arguments of os functions for null character

Serhiy Storchaka added the comment: I afraid not that builbots will fail, but that that test could pass without the fix. Tests should be tested without applying the fix. Writing right tests can require several iterations with running tests on patched and unpatched the os module. Here is a

[issue23908] Check path arguments of os functions for null character

STINNER Victor added the comment: The patch doesn't contain tests because I can't test them. But they should be simple, just pass a path with null character to os function. IMO this issue is a bug, so you must write an unit test to test for non regression. One test for FileIO, another for

[issue23908] Check path arguments of os functions for null character

Changes by Serhiy Storchaka storch...@gmail.com: -- components: +Windows nosy: +steve.dower, tim.golden, zach.ware ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23908 ___