[issue29094] Regression in zipfile writing in 2.7.13

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: backport needed -> resolved status: open -> closed ___ Python tracker ___ __

[issue29094] Regression in zipfile writing in 2.7.13

Serhiy Storchaka added the comment: New changeset c8faabce6ef318f3b425c6defd846e274d61e2ef by Serhiy Storchaka in branch '3.5': [3.5] Revert bpo-26293 for zipfile breakage. See also bpo-29094. (GH-1484). (#1486) https://github.com/python/cpython/commit/c8faabce6ef318f3b425c6defd846e274d61e2ef

[issue29094] Regression in zipfile writing in 2.7.13

Serhiy Storchaka added the comment: New changeset 70dc6a7a0b7f104d87512556fca242c2ca96a010 by Serhiy Storchaka in branch '3.6': [3.6] Revert bpo-26293 for zipfile breakage. See also bpo-29094. (GH-1484). (#1485) https://github.com/python/cpython/commit/70dc6a7a0b7f104d87512556fca242c2ca96a010

[issue29094] Regression in zipfile writing in 2.7.13

Changes by Serhiy Storchaka : -- pull_requests: +1589 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue29094] Regression in zipfile writing in 2.7.13

Changes by Serhiy Storchaka : -- pull_requests: +1587 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue29094] Regression in zipfile writing in 2.7.13

Serhiy Storchaka added the comment: New changeset 3763ea865cee5bbabcce11cd577811135e0fc747 by Serhiy Storchaka in branch 'master': Revert bpo-26293 for zipfile breakage. See also bpo-29094. (#1484) https://github.com/python/cpython/commit/3763ea865cee5bbabcce11cd577811135e0fc747 -- _

[issue29094] Regression in zipfile writing in 2.7.13

Changes by Serhiy Storchaka : -- pull_requests: +1585 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue29094] Regression in zipfile writing in 2.7.13

Changes by Serhiy Storchaka : -- stage: commit review -> backport needed versions: -Python 2.7 ___ Python tracker ___ ___ Python-bugs

[issue29094] Regression in zipfile writing in 2.7.13

Benjamin Peterson added the comment: New changeset ef4c6ba169ff59215442fc4047d83f7a3d39bf39 by Benjamin Peterson in branch '2.7': Revert "Issue #29094: Offsets in a ZIP file created with extern file object and modes" (#1467) https://github.com/python/cpython/commit/ef4c6ba169ff59215442fc4047d8

[issue29094] Regression in zipfile writing in 2.7.13

Changes by Benjamin Peterson : -- pull_requests: +1566 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue29094] Regression in zipfile writing in 2.7.13

Thomas Wouters added the comment: Well, what should the zipfile module do when you open a broken zipfile for appending in the first place? :) There are many ways in which it could be broken. I don't think a zipfile with incorrect offsets should be treated any differently. (I don't know *how*

[issue29094] Regression in zipfile writing in 2.7.13

Serhiy Storchaka added the comment: Thank you for raising this again and for your research Thomas. I now see that my understanding of the specification was wrong. I'll revert changes to zipfile. There is one question. If the zip file was concatenated to other file (and looks incorrect from the

[issue29094] Regression in zipfile writing in 2.7.13

Thomas Wouters added the comment: ... and yes, the changes to issue 26293 should be reverted; the changes attached to this issue merely revert part of issue 26293's changes. -- ___ Python tracker _

[issue29094] Regression in zipfile writing in 2.7.13

Thomas Wouters added the comment: The spec isn't very explicit about it, yes, but it does say this: 4.4.16 relative offset of local header: (4 bytes) This is the offset from the start of the first disk on which this file appears, to where the local header should be found.

[issue29094] Regression in zipfile writing in 2.7.13

Changes by Serhiy Storchaka : -- pull_requests: -911 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue29094] Regression in zipfile writing in 2.7.13

Serhiy Storchaka added the comment: https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT There is no explicit line, but offsets always are named relative: "relative offset of local header", "offset of start of central directory with respect to the starting disk number". This looks not p

[issue29094] Regression in zipfile writing in 2.7.13

Benjamin Peterson added the comment: Anything breaking 2.7 should be reverted. I take it, the change from #26293 should be as well as this one? Yhg1s, the commit message for #26293 included the sentence "Offsets in ZIP file now are relative to the start of the archive in conforming to the spe

[issue29094] Regression in zipfile writing in 2.7.13

Larry Hastings added the comment: What's to decide? If the new behavior is also broken, we should fix it. I'd like a fix in the next 3.5. -- ___ Python tracker ___ ___

[issue29094] Regression in zipfile writing in 2.7.13

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue29094] Regression in zipfile writing in 2.7.13

Gregory P. Smith added the comment: release managers need to decide. -- priority: normal -> release blocker ___ Python tracker ___ ___

[issue29094] Regression in zipfile writing in 2.7.13

Gregory P. Smith added the comment: re-opening since, though released, this behavior change broke existing code. -- nosy: +gregory.p.smith resolution: fixed -> stage: resolved -> commit review status: closed -> open ___ Python tracker

[issue29094] Regression in zipfile writing in 2.7.13

Thomas Wouters added the comment: For the record, this new behaviour is wrong. It's not immediately obvious from the ZIP spec, but offsets have to be from the start of the file, not the archive, or ZIP64 can't work. And yes, that means you can't blindly concatenate ZIP files to other files, yo

[issue29094] Regression in zipfile writing in 2.7.13

Changes by Donald Stufft : -- pull_requests: +911 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue29094] Regression in zipfile writing in 2.7.13

Roundup Robot added the comment: New changeset a80c14ace927 by Serhiy Storchaka in branch 'default': Issue #29094: Offsets in a ZIP file created with extern file object and modes https://hg.python.org/cpython/rev/a80c14ace927 -- ___ Python tracker

[issue29094] Regression in zipfile writing in 2.7.13

Changes by Serhiy Storchaka : -- priority: release blocker -> normal resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue29094] Regression in zipfile writing in 2.7.13

Larry Hastings added the comment: If this is fixed, can we close this issue? This release blocker is one of two issues blocking 3.5.3 rc1. -- ___ Python tracker ___ ___

[issue29094] Regression in zipfile writing in 2.7.13

Roundup Robot added the comment: New changeset f5aa1c9c2b7e by Serhiy Storchaka in branch '3.5': Issue #29094: Offsets in a ZIP file created with extern file object and modes https://hg.python.org/cpython/rev/f5aa1c9c2b7e New changeset 342bc734f523 by Serhiy Storchaka in branch '2.7': Issue #290

[issue29094] Regression in zipfile writing in 2.7.13

Serhiy Storchaka added the comment: Actually all offsets are relative to some point, just this point not always at the start of the file. If concatenate the ZIP file to other file, the unzip utility and the zipfile module are able to infer the starting point and correct offsets. Thus there is

[issue29094] Regression in zipfile writing in 2.7.13

Benjamin Peterson added the comment: Is there a reason to ever not use relative offsets? It seems that's strictly more general the absolute. -- ___ Python tracker ___ __

[issue29094] Regression in zipfile writing in 2.7.13

Serhiy Storchaka added the comment: The specification of ZIP files is not pretty clear, but the unzip utility first try to interpret offsets relatively to the start of the archive that can be different from the start of the file. Go's standard archive/zip package interprets offsets as absolute

[issue29094] Regression in zipfile writing in 2.7.13

Changes by Benjamin Peterson : -- assignee: -> serhiy.storchaka nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list m

[issue29094] Regression in zipfile writing in 2.7.13

New submission from Peter Ebden: In Python 2.7.13, using zipfile.ZipFile to write into a file with some initial preamble produces a zip file that cannot be read again by some zip implementations. Our use case is using pex (https://github.com/pantsbuild/pex) which writes a zip that begins with