[issue31702] Allow to specify the number of rounds for SHA-* hashing in crypt

Serhiy Storchaka added the comment: New changeset cede8c9edb408321b493d8d5e73be9e1018020e4 by Serhiy Storchaka in branch 'master': bpo-31702: Allow to specify rounds for SHA-2 hashing in crypt.mksalt(). (#4110)

[issue31702] Allow to specify the number of rounds for SHA-* hashing in crypt

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue31702] Allow to specify the number of rounds for SHA-* hashing in crypt

Gregory P. Smith added the comment: I'd stick with ValueError in that case as well. if someone dislikes the valueerrors because they _want_ to use an invalid one, they can file a bug and we'll reconsider only if they have a meaningful use case. On Wed, Oct 25, 2017 at 9:36 AM

[issue31702] Allow to specify the number of rounds for SHA-* hashing in crypt

Serhiy Storchaka added the comment: What to do with values outside of the valid range (2**4 to 2**31 for Blowfish, 1000 to 9 for SHA*). Raise ValueError, OverflowError, or bound it, or just generate an invalid salt and allow crypt() to handle it?

[issue31702] Allow to specify the number of rounds for SHA-* hashing in crypt

Gregory P. Smith added the comment: I'd raise a ValueError in that case. -- ___ Python tracker ___

[issue31702] Allow to specify the number of rounds for SHA-* hashing in crypt

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +4080 stage: -> patch review ___ Python tracker ___

[issue31702] Allow to specify the number of rounds for SHA-* hashing in crypt

New submission from Serhiy Storchaka : Blowfish salt should contain the binary logarithm of the number of rounds (from 4 to 31) (see issue31664). SHA-* salt can contain an explicit number of rounds in the form '$rounds={value}$'. It is bound to the range from 1000