[issue34212] Cygwin link failure with builtin modules since issue30860

STINNER Victor added the comment: What about modules compiled by setup.py? They don't have the issue? Only 2 modules are built by setup.py with Py_BUILD_CORE_BUILTIN (_json) or Py_BUILD_CORE (_xxsubinterpreters). By the way, it seems like Py_BUILD_CORE_BUILTIN should be used for modules, not

[issue34212] Cygwin link failure with builtin modules since issue30860

miss-islington added the comment: New changeset 716a8089b04095acaba493925751df194a4916bb by Miss Islington (bot) in branch '3.7': closes bpo-34212: Build core extension modules with Py_BUILD_CORE_BUILTIN. (GH-8712) https://github.com/python/cpython/commit/716a8089b04095acaba493925751df194a49

[issue34212] Cygwin link failure with builtin modules since issue30860

Change by miss-islington : -- pull_requests: +9982 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue34212] Cygwin link failure with builtin modules since issue30860

Benjamin Peterson added the comment: New changeset da324d53d420347344236ff64cf5eb9b675d6f86 by Benjamin Peterson (E. M. Bray) in branch 'master': closes bpo-34212: Build core extension modules with Py_BUILD_CORE_BUILTIN. (GH-8712) https://github.com/python/cpython/commit/da324d53d42034734423

[issue34212] Cygwin link failure with builtin modules since issue30860

Change by STINNER Victor : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue34212] Cygwin link failure with builtin modules since issue30860

Erik Bray added the comment: I added a new PR modifying makesetup and adding a new variable to Makefile.pre.in, PY_BUILTIN_MODULE_CFLAGS, explicitly for building built-in modules. I think this, or some version of it, is a cleaner solution than my previous brute-force approach. --

[issue34212] Cygwin link failure with builtin modules since issue30860

Change by Erik Bray : -- pull_requests: +8199 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue34212] Cygwin link failure with builtin modules since issue30860

Change by Erik Bray : -- keywords: +patch pull_requests: +7968 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list m

[issue34212] Cygwin link failure with builtin modules since issue30860

New submission from Erik Bray : Since issue30860, libpython is no longer able to be linked as a shared library, because built-in modules are not compiled with the correct external linkage flags. This is due to the removal of -DPy_BUILD_CORE, which in pyport.h is used to control wither __decl