[issue34421] Cannot install package with unicode module names on Windows

Change by Serhiy Storchaka : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list

[issue34421] Cannot install package with unicode module names on Windows

miss-islington added the comment: New changeset 0b67995bfa45393585e2e0017c82c706c4a04b04 by Miss Islington (bot) in branch '3.6': bpo-34421: Improve distutils logging for non-ASCII strings. (GH-9126) (GH-9506) https://github.com/python/cpython/commit/0b67995bfa45393585e2e0017c82c706c4a04b04

[issue34421] Cannot install package with unicode module names on Windows

Change by miss-islington : -- pull_requests: +8916 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34421] Cannot install package with unicode module names on Windows

Serhiy Storchaka added the comment: New changeset c73df53569f86d0c7742bafa55958c53d57a02e4 by Serhiy Storchaka in branch '3.7': bpo-34421: Improve distutils logging for non-ASCII strings. (GH-9126) (GH-9506) https://github.com/python/cpython/commit/c73df53569f86d0c7742bafa55958c53d57a02e4

[issue34421] Cannot install package with unicode module names on Windows

Change by Serhiy Storchaka : -- pull_requests: +8913 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34421] Cannot install package with unicode module names on Windows

Change by miss-islington : -- pull_requests: +8911 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34421] Cannot install package with unicode module names on Windows

Change by miss-islington : -- pull_requests: +8910 stage: commit review -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue34421] Cannot install package with unicode module names on Windows

Serhiy Storchaka added the comment: New changeset 4b860fd777e983f5d2a6bd1288e2b53099c6a803 by Serhiy Storchaka in branch 'master': bpo-34421: Improve distutils logging for non-ASCII strings. (GH-9126) https://github.com/python/cpython/commit/4b860fd777e983f5d2a6bd1288e2b53099c6a803

[issue34421] Cannot install package with unicode module names on Windows

Julien Malard added the comment: Thanks! Will give it a try and reference this conversation here as background. -- ___ Python tracker ___

[issue34421] Cannot install package with unicode module names on Windows

Jeremy Kloth added the comment: For pip, in call_subprocess() (given here in rough pseudo-code) is_python = (cmd[0] == sys.executable) kwds = {} if is_python: env['PYTHONIOENCODING'] = 'utf8' kwds['encoding'] = 'utf8' proc = Popen(..., **kwds) . . . if stdout is not None: while

[issue34421] Cannot install package with unicode module names on Windows

Julien Malard added the comment: Hello, Thanks for the insights and better fixes. Regarding (1), do you have any pointers on how or where to fix pip? I have an inprogress pull request there (https://github.com/pypa/pip/pull/5712) to fix a related unicode error during installation and could

[issue34421] Cannot install package with unicode module names on Windows

Serhiy Storchaka added the comment: PR 9126 makes distutils.log using "backslashreplace" instead of "unicode-escape" and simplifies the code (it is more efficient now, although the performance of logging is not critical). "unicode-escape" escapes all non-ASCII characters, even encodable. It

[issue34421] Cannot install package with unicode module names on Windows

Change by Serhiy Storchaka : -- pull_requests: +8579 stage: commit review -> patch review ___ Python tracker ___ ___

[issue34421] Cannot install package with unicode module names on Windows

Jeremy Kloth added the comment: The existing re-code solution is being triggered, as the `errors` in this case is 'surrogateescape' with an encoding of 'cp1252'. Here, pip is using subprocess.Popen() to have Python run setup.py. During execution, a filename,

[issue34421] Cannot install package with unicode module names on Windows

Serhiy Storchaka added the comment: I would prefer to use the backslashreplace error handler rather of the unicode-escape codec. Just as few lines above, but with ASCII encoding. msg = msg.encode('ascii', 'backslashreplace').decode('ascii') It is still not clear to me why the current

[issue34421] Cannot install package with unicode module names on Windows

miss-islington added the comment: New changeset 77b92b15a5e5c84b91d3fd9d02f63db432fa8903 by Miss Islington (bot) in branch '3.7': bpo-34421 avoid unicode error in distutils logging (GH-8799) https://github.com/python/cpython/commit/77b92b15a5e5c84b91d3fd9d02f63db432fa8903 --

[issue34421] Cannot install package with unicode module names on Windows

miss-islington added the comment: New changeset 3b36642924a51e6bceb7033916c3049764817166 by Miss Islington (bot) in branch '3.6': bpo-34421 avoid unicode error in distutils logging (GH-8799) https://github.com/python/cpython/commit/3b36642924a51e6bceb7033916c3049764817166 -- nosy:

[issue34421] Cannot install package with unicode module names on Windows

Change by Éric Araujo : -- assignee: -> eric.araujo resolution: -> fixed stage: patch review -> commit review status: open -> pending type: crash -> behavior versions: +Python 3.7, Python 3.8 ___ Python tracker

[issue34421] Cannot install package with unicode module names on Windows

Change by miss-islington : -- pull_requests: +8570 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34421] Cannot install package with unicode module names on Windows

Change by miss-islington : -- pull_requests: +8571 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34421] Cannot install package with unicode module names on Windows

Éric Araujo added the comment: New changeset 0afada163c7ef25c3a9d46ed445481fb69f2ecaf by Éric Araujo (Julien Malard) in branch 'master': bpo-34421 avoid unicode error in distutils logging (GH-8799) https://github.com/python/cpython/commit/0afada163c7ef25c3a9d46ed445481fb69f2ecaf --

[issue34421] Cannot install package with unicode module names on Windows

/project/julienmalard/Tinamit) for my TInamit project, which has Taqdir as a dependency. Thanks! -Julien Malard દ્વારા: Serhiy Storchaka મોકલ્યું: 18 ઑગસ્ટ 2018 06:32 પ્રતિ: Julien Malard વિષય: [issue34421] Cannot install package with unicode module names

[issue34421] Cannot install package with unicode module names on Windows

New submission from Serhiy Storchaka : Please provide more details. How to reproduce your issue? What you got, and what you expect to get? Seems the code just before lines modified by your PR are purposed to solve this issue. Why it doesn't work? -- nosy: +serhiy.storchaka

[issue34421] Cannot install package with unicode module names on Windows

Change by Julien Malard : -- keywords: +patch pull_requests: +8274 stage: -> patch review ___ Python tracker ___ ___

[issue34421] Cannot install package with unicode module names on Windows

Change by Julien Malard : -- components: Distutils nosy: dstufft, eric.araujo, julien.malard priority: normal severity: normal status: open title: Cannot install package with unicode module names on Windows type: crash versions: Python 3.6 ___