[issue3745] _sha256 et al. encode to UTF-8 by default

Marc-Andre Lemburg added the comment: Gregory P. Smith wrote: > > Gregory P. Smith added the comment: > > In order to get a -3 PyErr_WarnPy3k warning for unicode being passed to > hashlib objects (a nice idea) I suggest creating an additonal 's*' like thing > ('s3' perhaps?) in Python/getar

[issue3745] _sha256 et al. encode to UTF-8 by default

Marc-Andre Lemburg added the comment: Gregory P. Smith wrote: > > Gregory P. Smith added the comment: > > trunk r77252 switches python 2.7 to use 's*' for argument parsing. unicodes > can be hashed (encoded to the system default encoding by s*) again. > > This change has been blocked from

[issue3745] _sha256 et al. encode to UTF-8 by default

Gregory P. Smith added the comment: I believe everything in here has been addressed. Please open new issues with details for anything that doesn't quite right. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue3745] _sha256 et al. encode to UTF-8 by default

Gregory P. Smith added the comment: In order to get a -3 PyErr_WarnPy3k warning for unicode being passed to hashlib objects (a nice idea) I suggest creating an additonal 's*' like thing ('s3' perhaps?) in Python/getargs.c for that purpose rather than modifying all of the hashlib modules to ac

[issue3745] _sha256 et al. encode to UTF-8 by default

Gregory P. Smith added the comment: trunk r77252 switches python 2.7 to use 's*' for argument parsing. unicodes can be hashed (encoded to the system default encoding by s*) again. This change has been blocked from being merged into py3k unless someone decides we actually want this magic unic

[issue3745] _sha256 et al. encode to UTF-8 by default

Marc-Andre Lemburg added the comment: Gregory P. Smith wrote: > > Gregory P. Smith added the comment: > > lemburg - see which issue #? Sorry, the message got truncated for some reason. I was referring to http://bugs.python.org/issue3745 This was discussed on python-dev: http://mail.python

[issue3745] _sha256 et al. encode to UTF-8 by default

Roumen Petrov added the comment: gregory - refer to setup.py logic to build modules -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue3745] _sha256 et al. encode to UTF-8 by default

Karen Tracey added the comment: I think the missing issue reference is to this thread on python-dev: http://mail.python.org/pipermail/python-dev/2009-December/094574.html -- ___ Python tracker

[issue3745] _sha256 et al. encode to UTF-8 by default

Gregory P. Smith added the comment: rpetrov - I couldn't really understand your message so I'm not sure if I'm answering the right things: yes both the openssl and non-openssl modules need to behave identically. the reason openssl is used when possible is that its optimized hash functions a

[issue3745] _sha256 et al. encode to UTF-8 by default

Gregory P. Smith added the comment: lemburg - see which issue #? Anyways perhaps the right thing to do instead of trunk r65961 would have been to change the s# to an s*. Undoing it will be more painful now as several changes have gone in since that require undoing and possibly redoing differ

[issue3745] _sha256 et al. encode to UTF-8 by default

Roumen Petrov added the comment: What about inconsistent module build - as is reported some platform build sha256 module that support unicode but most it is not build if openssl is version 0.8+. Same for sha512 module. If unicode for hashlib is not acceptable for trunk than why is not build alw

[issue3745] _sha256 et al. encode to UTF-8 by default

Changes by Karen Tracey : -- nosy: +kmtracey ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue3745] _sha256 et al. encode to UTF-8 by default

Marc-Andre Lemburg added the comment: Gregory, this patch should not have been backported to Python 2.7. See issue Could you please revert the change on trunk ? Thanks. A much better solution would be to issue a -3 warning in case a Unicode object is passed to the hash functions. However, this

[issue3745] _sha256 et al. encode to UTF-8 by default

Gregory P. Smith added the comment: fixed in trunk r69561. -- components: +Extension Modules -Library (Lib) resolution: -> fixed status: open -> closed versions: +Python 3.0, Python 3.1 ___ Python tracker

[issue3745] _sha256 et al. encode to UTF-8 by default

Gregory P. Smith added the comment: fixed in release30-maint r69555. sounds like its out of the question for 2.6. i will backport it to trunk. -- keywords: +26backport versions: -Python 2.6, Python 3.0 ___ Python tracker

[issue3745] _sha256 et al. encode to UTF-8 by default

STINNER Victor added the comment: gpolo gave me the solution to restore a deleted message: http://bugs.python.org/issuexx...@action=edit&@a...@messages=msgnum ___ Python tracker ___ _

[issue3745] _sha256 et al. encode to UTF-8 by default

STINNER Victor added the comment: I agree with pitrou: leave python 2.6 unchanged, but please backport to 3.0.1 ;-) ___ Python tracker ___ ___

[issue3745] _sha256 et al. encode to UTF-8 by default

STINNER Victor added the comment: Wooops, my mouse clicked on Remove!? I removed Message73550, sorry gregory. Here was the content of the message: --- agreed. most platforms should be using the openssl version, i will update the non-openssl implementations to behave the same. I don't think th

[issue3745] _sha256 et al. encode to UTF-8 by default

Changes by STINNER Victor : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python

[issue3745] _sha256 et al. encode to UTF-8 by default

Antoine Pitrou added the comment: I don't think backporting to 2.6 is fine, people may be relying on the current behaviour. As for 3.0.1, you'd better be quick, it's scheduled for tomorrow. -- nosy: +pitrou ___ Python tracker

[issue3745] _sha256 et al. encode to UTF-8 by default

Gregory P. Smith added the comment: Fixed in py3k branch r69524. needs porting to release30-maint. possibly also release26-maint and trunk. -- priority: -> normal versions: +Python 2.6, Python 2.7 ___ Python tracker

[issue3745] _sha256 et al. encode to UTF-8 by default

Lukas Lueg added the comment: solved in #4818 and #4821 -- nosy: +ebfe ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue3745] _sha256 et al. encode to UTF-8 by default

Hagen Fürstenau added the comment: Seems that this problem is being taken care of in issue #4751. ___ Python tracker ___ ___ Python-bugs-list m

[issue3745] _sha256 et al. encode to UTF-8 by default

Gregory P. Smith <[EMAIL PROTECTED]> added the comment: agreed. most platforms should be using the openssl version, i will update the non-openssl implementations to behave the same. I don't think this is worth being a release blocker. I'll do it for 3.0.1. -- assignee: -> gregory.p.s

[issue3745] _sha256 et al. encode to UTF-8 by default

New submission from Hagen Fürstenau <[EMAIL PROTECTED]>: Whereas openssl-based _hashlib refuses to accept unencoded strings: >>> _hashlib.openssl_sha256("\xff") Traceback (most recent call last): File "", line 1, in TypeError: object supporting the buffer API required the _sha256 version enc