[issue40924] Recent importlib change breaks most recent certifi == 2020.4.5.2

Łukasz Langa added the comment: This can now be closed. Thank you for all hard work here. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue40924] Recent importlib change breaks most recent certifi == 2020.4.5.2

Łukasz Langa added the comment: New changeset 2fb5f038f2a2e91a7293d62dfd5601e6eb500c55 by Jason R. Coombs in branch 'master': bpo-40924: Ensure importlib.resources.path returns an extant path (GH-20857) https://github.com/python/cpython/commit/2fb5f038f2a2e91a7293d62dfd5601e6eb500c55 ---

[issue40924] Recent importlib change breaks most recent certifi == 2020.4.5.2

Łukasz Langa added the comment: New changeset 8a3469047c3c7b68f434ed244ef3ae4292dd8cbc by Jason R. Coombs in branch '3.9': [3.9] bpo-40924: Remove protocol for supplying Traversable objects from loaders (GH-20820) https://github.com/python/cpython/commit/8a3469047c3c7b68f434ed244ef3ae4292dd8c

[issue40924] Recent importlib change breaks most recent certifi == 2020.4.5.2

Change by Jason R. Coombs : -- pull_requests: +20049 pull_request: https://github.com/python/cpython/pull/20857 ___ Python tracker ___ _

[issue40924] Recent importlib change breaks most recent certifi == 2020.4.5.2

Change by Jason R. Coombs : -- pull_requests: +20017 pull_request: https://github.com/python/cpython/pull/20820 ___ Python tracker ___ _

[issue40924] Recent importlib change breaks most recent certifi == 2020.4.5.2

Jason R. Coombs added the comment: Thanks for the thorough and considerate response. I do think your original recommendation of reverting the broken feature is the best approach at this point. That is, keep resources.files with the fallback shim and eliminate support for loaders supplying tha

[issue40924] Recent importlib change breaks most recent certifi == 2020.4.5.2

Łukasz Langa added the comment: I thought about this all day. Given the scope of the change you made I think no option looks ideal. If we revert the entire feature, it's a big bummer for everybody involved and it might be an overreaction. If we keep the feature at the state of Beta 1, it migh

[issue40924] Recent importlib change breaks most recent certifi == 2020.4.5.2

Jason R. Coombs added the comment: I feel terrible and really regret that this was able to break things so badly. What options are available at this point? I'd at the very least like to remove the `loader.files()` behavior to avoid encouraging other loaders to implement it. Should we also re

[issue40924] Recent importlib change breaks most recent certifi == 2020.4.5.2

Łukasz Langa added the comment: > I do respect the beta feature freeze. The relevant feature was added prior to > b1. The reverted change is an incremental fix addressing underlying > implementation details such as how resources are resolved and removing > duplicate code paths. Using the rev

[issue40924] Recent importlib change breaks most recent certifi == 2020.4.5.2

Jason R. Coombs added the comment: This issue stems from improper reliance on implementation details of `importlib.resources.path`, which returns a context manager that is designed to clean up the file after the context closes. certifi would have encountered the same problem on older Pythons

[issue40924] Recent importlib change breaks most recent certifi == 2020.4.5.2

Łukasz Langa added the comment: New changeset ce5e6f098f8a270e50b989baa75765584573706b by Łukasz Langa in branch '3.9': [3.9] bpo-40924: Revert "bpo-39791 native hooks for importlib.resources.files (GH-20576)" (#20760) https://github.com/python/cpython/commit/ce5e6f098f8a270e50b989baa75765584

[issue40924] Recent importlib change breaks most recent certifi == 2020.4.5.2

Change by Łukasz Langa : -- keywords: +patch pull_requests: +19959 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/20760 ___ Python tracker _

[issue40924] Recent importlib change breaks most recent certifi == 2020.4.5.2

Łukasz Langa added the comment: In this case we need to revert the 3.9 backport to release a hotfix tonight. Please respect the beta feature freeze. -- ___ Python tracker ___

[issue40924] Recent importlib change breaks most recent certifi == 2020.4.5.2

Jason R. Coombs added the comment: I understand the issue here and can supply more details soon (no later than this weekend). -- ___ Python tracker ___ __

[issue40924] Recent importlib change breaks most recent certifi == 2020.4.5.2

Steve Dower added the comment: That was a *big* patch to importlib.resources... And newly defined and standardised protocols? That seems like a lot to bring in without having gone through a PEP anyway, despite the minor bug that has drawn attention to it. I don't think backports should be tr

[issue40924] Recent importlib change breaks most recent certifi == 2020.4.5.2

New submission from Ned Deily : The very recent latest commits for Issue39791, "New `files()` api from importlib_resources", have broken the popular certifi package, a package which provides a basic set of Root Certificates for TLS secure network connection verification. Among other users of i