[issue42140] asyncio.wait function creates futures set two times

Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 ___ Python tracker ___ ___

[issue42140] asyncio.wait function creates futures set two times

Yury Selivanov added the comment: Thanks for the change and for the discussion to everybody involved. The PR makes sense and I've already merged it. -- ___ Python tracker ___

[issue42140] asyncio.wait function creates futures set two times

miss-islington added the comment: New changeset 33922cb0aa0c81ebff91ab4e938a58dfec2acf19 by Miss Islington (bot) in branch '3.9': bpo-42140: Improve asyncio.wait function (GH-22938) https://github.com/python/cpython/commit/33922cb0aa0c81ebff91ab4e938a58dfec2acf19 -- ___

[issue42140] asyncio.wait function creates futures set two times

Change by miss-islington : -- keywords: +patch pull_requests: +22129 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23233 ___ Python tracker ___ _

[issue42140] asyncio.wait function creates futures set two times

miss-islington added the comment: New changeset 7e5ef0a5713f968f6e942566c78bf57ffbef01de by Diogo Dutra in branch 'master': bpo-42140: Improve asyncio.wait function (GH-22938) https://github.com/python/cpython/commit/7e5ef0a5713f968f6e942566c78bf57ffbef01de -- nosy: +miss-islington

[issue42140] asyncio.wait function creates futures set two times

Jakub Stasiak added the comment: I opened https://bugs.python.org/issue42230 to make the documentation reflect the reality in this matter. -- ___ Python tracker ___ _

[issue42140] asyncio.wait function creates futures set two times

Change by Jakub Stasiak : -- nosy: +jstasiak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue42140] asyncio.wait function creates futures set two times

Justin Arthur added the comment: > So the behaviour you describe will happen anyway. Unless we make your change against the 3.9 branch, in which case the fix will make it into the 3.9.x series of patch releases. -- ___ Python tracker

[issue42140] asyncio.wait function creates futures set two times

Diogo Dutra added the comment: > I wouldn't be surprised if there are other libraries or apps out there for which removing iterator support was an accidentally-breaking change and it may be strange if this is only is broken in 3.9.x, but working both before and after. Justin, when the deprecati

[issue42140] asyncio.wait function creates futures set two times

Justin Arthur added the comment: I believe the documentation may be referring to the English set and not a Python set, but I could be wrong. Yury changed the wording from sequence to set in 3.7, but we didn't document a breaking change as far as I know. The purpose of those set constructions

[issue42140] asyncio.wait function creates futures set two times

Chris Jerdonek added the comment: If it's just a code cleanup and not a bugfix though, it shouldn't be backported. But yes, as a cleanup it's fine. And even if it's expected to go away later, it's okay to do now. -- ___ Python tracker

[issue42140] asyncio.wait function creates futures set two times

Justin Arthur added the comment: Your change makes perfect sense to me. It would be a backport-only change as the 2nd set creation is actually getting removed for the development version (3.10) to finalize the deprecation of wait's coroutine scheduling. -- nosy: +JustinTArthur _

[issue42140] asyncio.wait function creates futures set two times

Diogo Dutra added the comment: > Are you suggesting this is a bug, or is it just a suggested code cleanup? It is a suggested code cleanup. My point is that the code creates two sets based on the Sequence `fs`. I think it is better if the code creates the set just one time, instead of two times

[issue42140] asyncio.wait function creates futures set two times

Denis S. Otkidach added the comment: The current error message is way too cryptic anyway. And restricting it to the set type only, as in docs, will certainly break a lot of code (passing a list is quite common). -- ___ Python tracker

[issue42140] asyncio.wait function creates futures set two times

Chris Jerdonek added the comment: Are you suggesting this is a bug, or is it just a suggested code cleanup? I ask because the docs suggest that a set should be passed: https://docs.python.org/3/library/asyncio-task.html#asyncio.wait And the docstring says it should be a sequence: https://gith

[issue42140] asyncio.wait function creates futures set two times

Change by Denis S. Otkidach : -- nosy: +ods ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue42140] asyncio.wait function creates futures set two times

New submission from Diogo Dutra : The python3.9 code creates the futures set two times. We can create this set before, avoiding the second creation. This python3.9 behaviour breaks the aiokafka library, because it gives an iterator to that function, so the second iteration become empty. -