[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Change by Mark Shannon : -- pull_requests: +23665 pull_request: https://github.com/python/cpython/pull/24902 ___ Python tracker ___

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Pablo Galindo Salgado added the comment: PEP 626 deprecates co_lnotab, co_lnotab: https://www.python.org/dev/peps/pep-0626/#id15 This doesn't seem to be mentioned in the What's new document and is quite important. Mark, do you mind creating a PR for this? I could do it and add you as a revi

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Change by Mark Shannon : -- pull_requests: +23654 pull_request: https://github.com/python/cpython/pull/24892 ___ Python tracker ___

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Mark Shannon added the comment: No. We should add it. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Ned Batchelder added the comment: Is there a reason PEP 626 isn't yet mentioned in https://docs.python.org/3.10/whatsnew/3.10.html ? -- ___ Python tracker ___ ___

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Change by Mark Shannon : -- pull_requests: +23620 pull_request: https://github.com/python/cpython/pull/24860 ___ Python tracker ___

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Neil Schemenauer added the comment: New changeset 87ec26b812e9c4095c017dc60f246eda37b83ab2 by Neil Schemenauer in branch 'master': bpo-43372: Use _freeze_importlib for regen-frozen. (GH-24759) https://github.com/python/cpython/commit/87ec26b812e9c4095c017dc60f246eda37b83ab2 --

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Change by Neil Schemenauer : -- pull_requests: +23532 pull_request: https://github.com/python/cpython/pull/24759 ___ Python tracker ___

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Change by Neil Schemenauer : -- pull_requests: +23492 pull_request: https://github.com/python/cpython/pull/24714 ___ Python tracker ___

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Change by Neil Schemenauer : -- nosy: +nascheme nosy_count: 7.0 -> 8.0 pull_requests: +23485 pull_request: https://github.com/python/cpython/pull/24708 ___ Python tracker ___ _

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Change by Mark Shannon : -- pull_requests: +22923 pull_request: https://github.com/python/cpython/pull/24094 ___ Python tracker ___

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Mark Shannon added the comment: New changeset 28b75c80dcc1e17ed3ac1c69362bf8dc164b760a by Mark Shannon in branch 'master': bpo-42246: Don't eliminate jumps to jumps, if it will break PEP 626. (GH-23896) https://github.com/python/cpython/commit/28b75c80dcc1e17ed3ac1c69362bf8dc164b760a --

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Change by Batuhan Taskaya : -- nosy: +BTaskaya ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Change by Mark Shannon : -- pull_requests: +22751 pull_request: https://github.com/python/cpython/pull/23896 ___ Python tracker ___

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Change by Inada Naoki : -- nosy: +methane ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Mark Shannon added the comment: New changeset bf353f3c2d937772a8cf30b15fd8eb7b82665ccb by Mark Shannon in branch 'master': bpo-42246: Make sure that `f_lasti`, and thus `f_lineno`, is set correctly after raising or reraising an exception (GH-23803) https://github.com/python/cpython/commit/bf

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Change by Mark Shannon : -- pull_requests: +22663 pull_request: https://github.com/python/cpython/pull/23803 ___ Python tracker ___

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Mark Shannon added the comment: https://github.com/python/cpython/pull/23780 fixes the finally handling. The if-break case was fixed by earlier changes. -- ___ Python tracker

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Mark Shannon added the comment: New changeset 8473cf89bdbf2cb292b39c972db540504669b9cd by Mark Shannon in branch 'master': bpo-42246: Remove DO_NOT_EMIT_BYTECODE macros, so that while loops and if statements conform to PEP 626. (GH-23743) https://github.com/python/cpython/commit/8473cf89bdbf

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Mark Shannon added the comment: Thanks Ned, that's really helpful. I'll go through those points: Code after break/continue is no longer compiled. Expected First line number of modules Expected Except clause when no exception https://bugs.python.org/issue42634 Double loops (this

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Ned Batchelder added the comment: Mark, I'm categorizing and characterizing the test failures. Here's the start of it: https://gist.github.com/nedbat/6c5dedde9df8d2de13de8a6a39a5f112 Let me know what other information would be useful. -- ___ Pyt

[issue42246] Implement PEP 626 -- Precise line numbers for debugging

Change by Raymond Hettinger : -- title: Implement PEP 626 -> Implement PEP 626 -- Precise line numbers for debugging ___ Python tracker ___ ___

[issue42246] Implement PEP 626

雅雯 added the comment: 幹你娘 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/

[issue42246] Implement PEP 626

雅雯 added the comment: 你全家死光 -- Added file: https://bugs.python.org/file49671/IMAG0629_1.jpg ___ Python tracker ___ ___ Python-bugs-l

[issue42246] Implement PEP 626

雅雯 added the comment: 幹你娘 我是渣男專打老婆騙吃拐幹 -- Added file: https://bugs.python.org/file49670/IMAG0629_1.jpg ___ Python tracker ___ ___ Py

[issue42246] Implement PEP 626

Change by 雅雯 : Removed file: https://bugs.python.org/file49668/IMAG0629_1.jpg ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue42246] Implement PEP 626

雅雯 added the comment: 全家死光 -- Added file: https://bugs.python.org/file49669/IMAG0629_1(1).jpg ___ Python tracker ___ ___ Python-bugs

[issue42246] Implement PEP 626

雅雯 added the comment: 幹你娘 -- nosy: +zhtw1234 Added file: https://bugs.python.org/file49668/IMAG0629_1.jpg ___ Python tracker ___ ___

[issue42246] Implement PEP 626

Mark Shannon added the comment: Ned, What are the failures? I'd like to take a look, to see if things are as expected, and if there are any tests we can add to CPython. -- ___ Python tracker __

[issue42246] Implement PEP 626

Ned Batchelder added the comment: Mark, BTW: I have run the coverage.py test suite on 3.10.0a3, and as expected there are failures. I haven't dug into it yet to see what looks expected and what does not. I also see there are still changes happening on master, so I'm not sure when to commit

[issue42246] Implement PEP 626

Change by Mark Shannon : -- pull_requests: +22601 pull_request: https://github.com/python/cpython/pull/23743 ___ Python tracker ___

[issue42246] Implement PEP 626

Mark Shannon added the comment: New changeset eaccc12aa986f92ea05f3f0a63cedbff78dd67f1 by Mark Shannon in branch 'master': bpo-42246: Don't forget the entry block when ensuring that all exits have a line number (GH-23636) https://github.com/python/cpython/commit/eaccc12aa986f92ea05f3f0a63ced

[issue42246] Implement PEP 626

Change by Mark Shannon : -- pull_requests: +22504 pull_request: https://github.com/python/cpython/pull/23636 ___ Python tracker ___

[issue42246] Implement PEP 626

Mark Shannon added the comment: New changeset 5977a7989d49c3e095c7659a58267d87a17b12b1 by Mark Shannon in branch 'master': bpo-42246: Make sure that line number is correct after a return, as required by PEP 626 (GH-23495) https://github.com/python/cpython/commit/5977a7989d49c3e095c7659a58267

[issue42246] Implement PEP 626

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue42246] Implement PEP 626

Change by Mark Shannon : -- pull_requests: +22384 pull_request: https://github.com/python/cpython/pull/23495 ___ Python tracker ___

[issue42246] Implement PEP 626

Mark Shannon added the comment: New changeset fd009e606a48e803e7187983bf9a5682e938fddb by Mark Shannon in branch 'master': bpo-42246: Fix memory leak in compiler (GH-23256) https://github.com/python/cpython/commit/fd009e606a48e803e7187983bf9a5682e938fddb --

[issue42246] Implement PEP 626

Change by Mark Shannon : -- pull_requests: +22153 pull_request: https://github.com/python/cpython/pull/23256 ___ Python tracker ___

[issue42246] Implement PEP 626

STINNER Victor added the comment: > New changeset 877df851c3ecdb55306840e247596e7b7805a60a by Mark Shannon in > branch 'master': > bpo-42246: Partial implementation of PEP 626. (GH-23113) This change introduced reference leaks: https://buildbot.python.org/all/#builders/384/builds/100 5 tests

[issue42246] Implement PEP 626

Mark Shannon added the comment: New changeset cc75ab791dd5ae2cb9f6e0c3c5f734a6ae1eb2a9 by Mark Shannon in branch 'master': bpo-42246: Eliminate jumps to exit blocks by copying those blocks. (#23251) https://github.com/python/cpython/commit/cc75ab791dd5ae2cb9f6e0c3c5f734a6ae1eb2a9 --

[issue42246] Implement PEP 626

Change by Mark Shannon : -- pull_requests: +22148 pull_request: https://github.com/python/cpython/pull/23251 ___ Python tracker ___

[issue42246] Implement PEP 626

Change by Mark Shannon : -- pull_requests: +22142 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23245 ___ Python tracker ___

[issue42246] Implement PEP 626

Mark Shannon added the comment: New changeset 877df851c3ecdb55306840e247596e7b7805a60a by Mark Shannon in branch 'master': bpo-42246: Partial implementation of PEP 626. (GH-23113) https://github.com/python/cpython/commit/877df851c3ecdb55306840e247596e7b7805a60a -- _

[issue42246] Implement PEP 626

Change by Mark Shannon : -- nosy: +nedbat ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue42246] Implement PEP 626

Pablo Galindo Salgado added the comment: > Dead code elimination will remove the `secret_debugging_code()`, but leave > the test. The peephole optimiser can then reduce it to a NOP, but won't > eliminate it as it is the only instruction for line 1. Gotcha. I am pretty sure that this will hav

[issue42246] Implement PEP 626

Mark Shannon added the comment: The following code is completely eliminated by the macros. 1. if 0: 2. secret_debugging_code() PEP 626 says that all executed lines of code must generate trace events, so we need to emit an instruction for line 1. Dead code elimination will remove the `sec

[issue42246] Implement PEP 626

Pablo Galindo Salgado added the comment: I'm happy that we are removing BEGIN_DO_NOT_EMIT_BYTECODE and END_DO_NOT_EMIT_BYTECODE but could you elaborate how this is related? These macros protect the compiler from emitting bytecode that corresponds to deaf code and by definition, unreachable.

[issue42246] Implement PEP 626

Change by Mark Shannon : -- keywords: +patch pull_requests: +22030 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23113 ___ Python tracker ___ ___

[issue42246] Implement PEP 626

New submission from Mark Shannon : Implementation of PEP 626 requires: 1. Implementation of the new line number table and associated APIs. 2. Removal of BEGIN_DO_NOT_EMIT_BYTECODE and END_DO_NOT_EMIT_BYTECODE from the compiler as they do not understand line numbers and may remove lines from th