[issue43253] asyncio open_connection fails when a socket is explicitly closed

Maximilian Hils added the comment: Thank you for the super quick turnaround. My heart goes out to you and everyone else in Ukraine. -- ___ Python tracker ___ _

[issue43253] asyncio open_connection fails when a socket is explicitly closed

Andrew Svetlov added the comment: Thanks! -- resolution: -> fixed status: -> closed ___ Python tracker ___ ___ Python-bugs-list m

[issue43253] asyncio open_connection fails when a socket is explicitly closed

miss-islington added the comment: New changeset 64a68c39cb508b016e5a4486ebb4052f6e65fca0 by Miss Islington (bot) in branch '3.9': bpo-43253: Don't call shutdown() for invalid socket handles (GH-31892) https://github.com/python/cpython/commit/64a68c39cb508b016e5a4486ebb4052f6e65fca0

[issue43253] asyncio open_connection fails when a socket is explicitly closed

miss-islington added the comment: New changeset 88c243fd8d5a43282ef06bd0872e3b88c68bb856 by Miss Islington (bot) in branch '3.10': bpo-43253: Don't call shutdown() for invalid socket handles (GH-31892) https://github.com/python/cpython/commit/88c243fd8d5a43282ef06bd0872e3b88c68bb856 ---

[issue43253] asyncio open_connection fails when a socket is explicitly closed

Change by miss-islington : -- pull_requests: +3 pull_request: https://github.com/python/cpython/pull/31906 ___ Python tracker ___ __

[issue43253] asyncio open_connection fails when a socket is explicitly closed

Change by miss-islington : -- nosy: +miss-islington nosy_count: 10.0 -> 11.0 pull_requests: +2 pull_request: https://github.com/python/cpython/pull/31905 ___ Python tracker ___

[issue43253] asyncio open_connection fails when a socket is explicitly closed

Andrew Svetlov added the comment: New changeset 70155412f1543f100d4aa309b8691cbcabd3e0e1 by Maximilian Hils in branch 'main': bpo-43253: Don't call shutdown() for invalid socket handles (GH-31892) https://github.com/python/cpython/commit/70155412f1543f100d4aa309b8691cbcabd3e0e1 --

[issue43253] asyncio open_connection fails when a socket is explicitly closed

Change by Andrew Svetlov : -- versions: +Python 3.11 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue43253] asyncio open_connection fails when a socket is explicitly closed

Change by Maximilian Hils : -- pull_requests: +29990 pull_request: https://github.com/python/cpython/pull/31892 ___ Python tracker ___ _

[issue43253] asyncio open_connection fails when a socket is explicitly closed

Andrew Svetlov added the comment: Maximilian, thanks for the investigation. A check for 'fileno != -1' seems correct to me. Would you prepare a pull request? -- ___ Python tracker __

[issue43253] asyncio open_connection fails when a socket is explicitly closed

Maximilian Hils added the comment: asvetlov: Sorry if I articulated myself badly, but I do think this is a valid bug. It's unfortunately hard to provide a better repro (I tried), but we are hitting this regularly when mitmproxy is accepting connections under heavy load. We're just calling `a

[issue43253] asyncio open_connection fails when a socket is explicitly closed

Change by Andrew Svetlov : -- resolution: not a bug -> status: closed -> ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue43253] asyncio open_connection fails when a socket is explicitly closed

Change by Maximilian Hils : -- versions: +Python 3.10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue43253] asyncio open_connection fails when a socket is explicitly closed

Maximilian Hils added the comment: We are hitting the same traceback with mitmproxy on Windows without ever passing a socket object to open_connection. In other words, this can be triggered without performing any action on 'sock' due to some race conditions in the Windows network stack. I un

[issue43253] asyncio open_connection fails when a socket is explicitly closed

Andrew Svetlov added the comment: Please consider passing 'sock' argument as the ownership transfer. You should not perform any action on 'sock' object directly anymore. This is true for all asyncio API. -- resolution: -> not a bug stage: -> resolved status: open -> closed

[issue43253] asyncio open_connection fails when a socket is explicitly closed

Change by Adhika Setya Pramudita : -- nosy: +adhika.setyap ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue43253] asyncio open_connection fails when a socket is explicitly closed

Change by Emmanuel Arias : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker ___ ___

[issue43253] asyncio open_connection fails when a socket is explicitly closed

Daniel Engel added the comment: It reproduced on a windows machine -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue43253] asyncio open_connection fails when a socket is explicitly closed

Emmanuel Arias added the comment: I cannot reproduce on a Debian machine. Seems to be a Windows component issue? -- nosy: +eamanu ___ Python tracker ___ __

[issue43253] asyncio open_connection fails when a socket is explicitly closed

New submission from Daniel Engel : Python 3.9.0 (tags/v3.9.0:9cf6752, Oct 5 2020, 15:34:40) [MSC v.1927 64 bit (AMD64)] Type 'copyright', 'credits' or 'license' for more information IPython 7.18.1 -- An enhanced Interactive Python. Type '?' for help. In [1]: import socket ...: s1, s2 = soc