Georg Brandl ge...@python.org added the comment:
OK, fixed the two typos in r80067, r80068. Please open a new issue for further
fixes, this one gets a bit confusing :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5341
Éric Araujo mer...@netwok.org added the comment:
Raymond didn’t want the quote characters changed, sorry if I failed to channel
him.
I’ll port the “builtin” typo fixes to the other branches and let this report
closed. Thanks for the guidance.
--
Éric Araujo mer...@netwok.org added the comment:
Hi
r79951 fixes “simplies” and add the typo “specifyication” Muphry’s Law wink.
Updated my patch to remove that and add this.
Regards
--
Added file: http://bugs.python.org/file16894/functools-typos-pep8.diff
Changes by Éric Araujo mer...@netwok.org:
Removed file: http://bugs.python.org/file16855/functools-typos-pep8.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5341
___
Changes by Éric Araujo mer...@netwok.org:
Removed file: http://bugs.python.org/file16894/functools-typos-pep8.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5341
___
Éric Araujo mer...@netwok.org added the comment:
I saw the author of functools on the chatroom and asked for feedback. Summary:
* Rewrapping, whitespace changes, quote changes and other minor PEP 8 stuff is
not worth the trouble it creates (eats time without improving Python’s quality,
and
Éric Araujo mer...@netwok.org added the comment:
Hello spelling and doc people
(I hope it’s okay to use this bug as umbrella instead of opening a myriad bugs
for typos.)
Attached patch fixes small things in functools module and docs:
- Typos: “simplies” does not exist, “fills-in” needs no
R. David Murray rdmur...@bitdance.com added the comment:
Georg can correct me if I'm wrong, but I believe we generally only rewrap lines
when we change the text for some other reason. My observation was that Georg
re-wraps doc text to 79 chars, so that's what I've been doing. PEP 8 really
Georg Brandl ge...@python.org added the comment:
David is correct, rewrapping while editing is intrusive enough.
The docs should be wrapped at 79/80 characters. The reason that most files
have longer lines is that the latex to rest converter tool had a flaw in the
wrapping code that I didn't
Éric Araujo mer...@netwok.org added the comment:
rewrap lines when we change the text for some other reason.
Doesn’t that make harder to review the real changes when they are mixed
with rewrapping?
PEP 8 really only applies to source files, the docs are (at least
currently) Georg's
Georg Brandl ge...@python.org added the comment:
rewrap lines when we change the text for some other reason.
Doesn’t that make harder to review the real changes when they are mixed
with rewrapping?
That's true. I wouldn't do it in patches I mean someone else to review. But
many times it's
R. David Murray rdmur...@bitdance.com added the comment:
No, I meant demense (I even looked up the spelling). The word is related to
domain, but has a somewhat more precise shading of meaning :)
A lord's chief manor place, with that part of the lands
belonging thereto which has not
Éric Araujo mer...@netwok.org added the comment:
Thanks for the new word. (I checked with my local dictd but not on the
Intertubes, should have).
Having designated active maintainers for modules and areas is indeed great.
Cheers
--
___
Python
Éric Araujo mer...@netwok.org added the comment:
Hello again
And now for something completely different: more builtin/built-in/built in
fixes. I hope it’s okay to edit Misc/HISTORY and old Misc/NEWS entries.
Note that I fixed two unrelated typos that I noticed near “builtin” uses.
Some day
Éric Araujo mer...@netwok.org added the comment:
Here is the path that rewraps lines longer than 80 characters.
Note that it is possible than some lines were unnecessarily rewrapped; I’m not
really sure whether my editor displays the characters count or the index of the
next character. Sorry
Éric Araujo mer...@netwok.org added the comment:
I grepped for “built-in” in Doc and found very few misuses. Patch attached.
Some lines needed rewrapping, I made another patch for this to ease reviewing.
Cheers
--
Added file: http://bugs.python.org/file16478/doc.diff
Éric Araujo mer...@netwok.org added the comment:
I should have seen this when changing one use of “builtin”. Applies only to
py3k, since the glossary for trunk does not mention the `next` function.
--
Added file: http://bugs.python.org/file16176/typo.diff
Georg Brandl ge...@python.org added the comment:
Thanks, committed as r78024, r78025, respectively.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5341
___
Éric Araujo mer...@netwok.org added the comment:
Additional note to help reviewing: I changed occurrences of the form “builtin
x” to “built-in function x” not because I think the noun “builtin” is
incorrect, as you may guess from my first message in this thread, but because
it seemed more
Éric Araujo mer...@netwok.org added the comment:
Hello
I fixed a few remaining misuses of “builtin” in the source. There is some diff
noise due to reformatting paragraphs where the addition of the hyphen caused
the line to get over 80 characters.
Note that I didn’t check the use of
Changes by Éric Araujo mer...@netwok.org:
Added file: http://bugs.python.org/file16130/fix-builtin_3.2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5341
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5341
___
___
Éric Araujo mer...@netwok.org added the comment:
Short summary from a discussion on #python-dev:
- verb form: “This function is built in.”
- adjective form: “``str`` is a built-in function”
- noun form (not mainstream English, but usual in programming contexts):
“``repr`` is a builtin”, “prefer
Mark Dickinson dicki...@gmail.com added the comment:
Thanks, Georg. And yes, I was indeed wondering why I found so few wayward
apostrophes!
Applied in r69846, r69847. I'm not sure whether it's worth backporting
these to 2.6 and 3.0.
Please do not change builtin to built-in. In a python
New submission from Mark Dickinson dicki...@gmail.com:
Here's a patch that represents the result of grepping through the source
for some of my favo(u)rite spelling errors.
Georg, I reali(z/s)e that most of these fixes are outside the Doc/
directory, but are you interested in taking a look at
Georg Brandl ge...@python.org added the comment:
I reviewed the patch and found nothing wrong. (BTW, if you noticed the
almost-total lack of its-it's errors, it's because I fixed all of them
some time ago :)
built-in is fine.
About AE/BE: I think we had a consensus somewhere that we have no
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
Please do not change builtin to built-in. In a python context, it reads
fine as one word.
--
nosy: +rhettinger
___
Python tracker rep...@bugs.python.org
27 matches
Mail list logo
