Jesús Cea Avión j...@jcea.es added the comment:
I have problem getting your changes working in python 3.x. Yes, pybsddb
supports py3k.
The problem is line sys.exc_traceback = sys.last_traceback = None, that
throws the following error under python 3.x:
File
Jesús Cea Avión j...@jcea.es added the comment:
Patch up-ported to pybsddb 4.8.4.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7808
___
___
Florent Xicluna florent.xicl...@gmail.com added the comment:
Jesús, your patch looks good. I prefer your approach.
My use of the weakrefs was an ugly workaround, I admit.
Maybe the close() method in the C module should be in charge of DECREFing the
handlers and freeing memory. I did not look
Jesús Cea Avión j...@jcea.es added the comment:
I confirm the leaks in the C code. How do you find them?
I see your point with the weakrefs in the unittest, but I don't see why they
are so important. We are creating a GC cycle, yes, but the GC will collect it
eventually, beside the reference
Florent Xicluna florent.xicl...@gmail.com added the comment:
The tool is called regrtest:
~ $ ./python -m test.regrtest -R 2:3: -uall test_bsddb3
Some devs and some buildbots hunt refleaks in the test suite.
Even if the test-related refleaks are not important, they may hide real
refleaks in
Ezio Melotti ezio.melo...@gmail.com added the comment:
You need a debug build of Python to use -R:
./configure --with-pydebug make
See also: http://www.python.org/dev/faq/#how-do-i-create-a-debug-build-of-python
--
___
Python tracker
Florent Xicluna florent.xicl...@gmail.com added the comment:
I confirm the leaks in the C code. How do you find them?
I've done it manually, disabling some tests, and running regrtest -R
repeatedly until I isolate the function which is responsible.
Then I studied the source code, looking for
Jesús Cea Avión j...@jcea.es added the comment:
I have spend a few hours trying to understand the issue deeply, and I have an
easier to understand version. It is bigger, but explain the issue good enough
to use in a production program.
Please, Florent, review. It pass the leak test.
I rather
Jesús Cea Avión j...@jcea.es added the comment:
Florent, Could you explain the changes to the unittest?. I don't understand
them.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7808
___
Florent Xicluna florent.xicl...@gmail.com added the comment:
Could you explain the changes to the unittest?
The reference to self in the hooks were preventing the GC of the test case,
as far as I understand, because it creates a cycle.
When using weak references, there's no more dead cycles.
Changes by Florent Xicluna la...@yahoo.fr:
Removed file: http://bugs.python.org/file16039/issue7808_bsddb3_refleak.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7808
___
Florent Xicluna la...@yahoo.fr added the comment:
Patch updated for latest trunk.
--
Added file: http://bugs.python.org/file16183/issue7808_bsddb3_refleak_v2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7808
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7808
___
___
Python-bugs-list
Changes by Florent Xicluna la...@yahoo.fr:
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7808
___
___
Python-bugs-list mailing
Changes by Florent Xicluna la...@yahoo.fr:
--
type: performance - resource usage
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7808
___
___
New submission from Florent Xicluna la...@yahoo.fr:
Patch proposed to fix the refleaks.
--
keywords: +patch
stage: - patch review
Added file: http://bugs.python.org/file16039/issue7808_bsddb3_refleak.diff
___
Python tracker rep...@bugs.python.org
Changes by Florent Xicluna la...@yahoo.fr:
--
components: Extension Modules
nosy: flox
priority: normal
severity: normal
status: open
title: test_bsddb3 leaks references
type: performance
versions: Python 2.6, Python 2.7
___
Python tracker
Changes by Florent Xicluna la...@yahoo.fr:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7808
___
___
Python-bugs-list mailing list
18 matches
Mail list logo