Senthil Kumaran orsent...@gmail.com added the comment:
Fix committed in revision 85202 (py3k), r85203 (release31-maint),
r85204(release27-maint). I had change the patch to use copy.deepcopy instead of
os.environ.copy() because for the purposes of test os.environ was masked with
R. David Murray rdmur...@bitdance.com added the comment:
Anatoly, last we heard you did not wish to sign the contributor agreement and
so were not submitting patches. We are respecting your wishes by not applying
this. Have you changed your mind?
--
anatoly techtonik techto...@gmail.com added the comment:
I still haven't received answers on the licensing questions in developer's
mailing list. After the amount of negative feedback received I decided not to
continue. But I am still interested in constructive discussion to get
satisfying
Georg Brandl ge...@python.org added the comment:
ISTM that the attached patch is trivial enough not to require any contributor
agreement or copyright assignment, at least if we change Ma Test CGI Server
v1.0 to something neutral.
--
___
Python
Changes by Éric Araujo mer...@netwok.org:
--
stage: unit test needed - patch review
versions: -Python 2.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9272
___
anatoly techtonik techto...@gmail.com added the comment:
So..
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9272
___
___
Python-bugs-list
anatoly techtonik techto...@gmail.com added the comment:
The test is hard to write. The server is launched in a separate thread. Any
ideas how to check os.environ there?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9272
anatoly techtonik techto...@gmail.com added the comment:
Ok. os.environ seems to be shared between threads. Here is updated patch.
--
Added file:
http://bugs.python.org/file18102/9272.CGIHTTPServer-poisons-os.environ.patch
___
Python tracker
Senthil Kumaran orsent...@gmail.com added the comment:
The patch and the tests look good. I could verify it too. I shall commit it.
--
assignee: - orsenthil
resolution: - accepted
___
Python tracker rep...@bugs.python.org
Georg Brandl ge...@python.org added the comment:
I don't think a deepcopy of the environment is necessary here. environ.copy()
is just fine. Other than that, I agree with Eric.
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
New submission from anatoly techtonik techto...@gmail.com:
When CGIHTTPServer prepares to start child CGI program it modifies global
os.environ. This implicitly changes parents application state if it also relies
on some of CGI environment variables.
--
messages: 110418
nosy:
Changes by anatoly techtonik techto...@gmail.com:
--
keywords: +patch
Added file:
http://bugs.python.org/file18024/9272.CGIHTTPServer-poisons-os.environ.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9272
Changes by R. David Murray rdmur...@bitdance.com:
--
components: +Library (Lib)
nosy: +orsenthil, r.david.murray
type: - behavior
versions: +Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9272
anatoly techtonik techto...@gmail.com added the comment:
Patch queue with other minor fixes you may consider useful
http://bitbucket.org/techtonik/http.server-patches/qseries
--
___
Python tracker rep...@bugs.python.org
Eric Smith e...@trueblade.com added the comment:
The change looks reasonable to me. It needs a test.
--
nosy: +eric.smith
stage: - unit test needed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9272
15 matches
Mail list logo
