[issue24617] os.makedirs()'s [mode] not correct

2016-06-04 Thread Martin Panter
Martin Panter added the comment: I think it would be good to move the sentence about FileExistsError away from your new paragraph about *mode*. Also, I would try to make the hyperlink a bit more explicit and descriptive, maybe The *mode* parameter is passed to :func:`mkdir`; see :ref:`the mkdi

[issue27213] Rework CALL_FUNCTION* opcodes

2016-06-04 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Currently there are 4 opcodes (CALL_FUNCTION, CALL_FUNCTION_VAR, CALL_FUNCTION_KW, CALL_FUNCTION_VAR_KW) for calling a function depending of presenting the var-positional and var-keyword arguments: func(arg1, ..., argN, name1=kwarg1, ..., nameM=kwargM)

[issue27213] Rework CALL_FUNCTION* opcodes

2016-06-04 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- dependencies: +Opcode for creating dict with constant keys ___ Python tracker ___ ___ Python-bugs-lis

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

2016-06-04 Thread Martin Panter
Martin Panter added the comment: It seems the test is broken on Windows: http://buildbot.python.org/all/builders/x86%20Windows7%203.5/builds/915/steps/test/logs/stdio == ERROR: test_mixed_case_module_names_are_lower_cased (test

[issue26373] asyncio: add support for async context manager on streams?

2016-06-04 Thread Martin Panter
Martin Panter added the comment: Above two commits were actuall for Issue 26372 -- nosy: +martin.panter ___ Python tracker ___ ___ Pyt

[issue27214] a potential future bug and an optimization that mostly undermines performance in long_invert

2016-06-04 Thread Oren Milman
New submission from Oren Milman: the current state long_invert first checks whether v is a single-digit int. If it is, it simply does 'return PyLong_FromLong(-(MEDIUM_VALUE(v) + 1));'. Otherwise, long_invert does (edited for brevity) 'x = long_add(v, PyLong_FromLong(1)

[issue26372] Popen.communicate not ignoring BrokenPipeError

2016-06-04 Thread Martin Panter
Martin Panter added the comment: Maybe use os.devnull instead of "/dev/null"? http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/7728/steps/test/logs/stdio == ERROR: test_communicate_BrokenPipeError_stdi

[issue27214] a potential future bug and an optimization that mostly undermines performance in long_invert

2016-06-04 Thread Oren Milman
Changes by Oren Milman : Added file: http://bugs.python.org/file43188/patchedCPythonTestOutput.txt ___ Python tracker ___ ___ Python-bugs-list

[issue27214] a potential future bug and an optimization that mostly undermines performance in long_invert

2016-06-04 Thread Oren Milman
Changes by Oren Milman : Added file: http://bugs.python.org/file43187/CPythonTestOutput.txt ___ Python tracker ___ ___ Python-bugs-list mailin

[issue27214] a potential future bug and an optimization that mostly undermines performance in long_invert

2016-06-04 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +mark.dickinson, serhiy.storchaka stage: -> patch review versions: +Python 3.6 ___ Python tracker ___

[issue27179] subprocess uses wrong encoding on Windows

2016-06-04 Thread STINNER Victor
STINNER Victor added the comment: "To clarify - ANSI is the natural default *for programs that don't support Unicode*." Exactly. For this reason, I am stronly opposed to chnage the default encoding. I'm ok to add helper functions or new flags. It looks like it took more than five years to supp

[issue26915] Test identity first in membership operation of ItemsView, ValuesView and Sequence in collections.abc

2016-06-04 Thread Xiang Zhang
Xiang Zhang added the comment: Thanks for review Serhiy and nice thoughts. I make the class inherited directly from Sequence. So if the methods in Sequence are OK, the test class is OK. -- Added file: http://bugs.python.org/file43189/issue26915_v3.patch

[issue26915] Test identity first in membership operation of ItemsView, ValuesView and Sequence in collections.abc

2016-06-04 Thread Xiang Zhang
Xiang Zhang added the comment: Oh, sorry. Make the __len__ signature wrong. Change it. -- Added file: http://bugs.python.org/file43190/issue26915_v4.patch ___ Python tracker ___

[issue26939] android: test_functools hangs on armv7

2016-06-04 Thread Xavier de Gaye
Changes by Xavier de Gaye : Added file: http://bugs.python.org/file43191/test_lru_cache_threaded-x86-printf.txt ___ Python tracker ___ ___ Py

[issue26939] android: test_functools hangs on armv7

2016-06-04 Thread Xavier de Gaye
Changes by Xavier de Gaye : Added file: http://bugs.python.org/file43192/test_lru_cache_threaded-armv7-printf.txt ___ Python tracker ___ ___

[issue26939] android: test_functools hangs on armv7

2016-06-04 Thread Xavier de Gaye
Xavier de Gaye added the comment: pycond_timedwait_2.patch prints the delta time in microseconds when deadline is in the past. Running the patch with the following command: python -m test -m test_lru_cache_threaded -v test_functools gives these results: a) natively: deadline is never in th

[issue27215] Docstrings of Sequence and MutableSequence seems not right

2016-06-04 Thread Xiang Zhang
New submission from Xiang Zhang: Docstrings of Sequence and MutableSequence in collections.abc says "Concrete subclasses must provide __new__ and __init__". This seems not the truth. Not providing __new__ and __init__ is also OK. -- messages: 267249 nosy: rhettinger, xiang.zhang priori

[issue27216] Fix capitalisation of "Python runtime" in os.path.islink description

2016-06-04 Thread Alex Chan
New submission from Alex Chan: Since Python is a proper noun, it should be capitalised. Fix a case where the docs used lowercase "python". The phrase "by the python runtime" was added in the 2.7 docs; the 2.6 docs just say "if symbolic links are not supported". -- assignee: docs@pyth

[issue5124] IDLE - pasting text doesn't delete selection

2016-06-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a patch that makes pasting text in all Text, Entry and Spinbox widgets to delete selection. -- stage: test needed -> patch review Added file: http://bugs.python.org/file43195/idle_paste_replace.patch ___ Py

[issue27215] Docstrings of Sequence and MutableSequence seems not right

2016-06-04 Thread ppperry
Changes by ppperry : -- assignee: -> docs@python components: +Documentation nosy: +docs@python ___ Python tracker ___ ___ Python-bugs

[issue27215] Docstrings of Sequence and MutableSequence seems not right

2016-06-04 Thread ppperry
Changes by ppperry : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue27181] Add geometric mean to `statistics` module

2016-06-04 Thread Ram Rachum
Ram Rachum added the comment: And of course, if the goal of the `statistics` module is to be comprehensive, one should ask himself what should be the difference between this new module and a mature statistics module like `scipy.stats`, and whether we should try to copy the features of off `sci

[issue26439] ctypes.util.find_library fails when ldconfig/glibc not available (e.g., AIX)

2016-06-04 Thread Martin Panter
Martin Panter added the comment: Okay here are some more thoughts about your latest patch: ## Automatic RTLD_MEMBER ## I was still uneasy about the automatic setting of RTLD_MEMBER. But I looked for how others handle this, and I found Libtool’s LTDL library, and Apache Portable Runtime (APR).

[issue27217] IDLE 3.5.1 not using Tk 8.6

2016-06-04 Thread Glenn Travis
New submission from Glenn Travis: I do not know if this is truly an issue, but it is a concern to me. I installed Tk 8.6 after reading all the Macintosh OS warnings online and in the IDLE window. However, according to the About IDLE box, IDLE is still "using" 8.5; and the warning still appear

[issue27217] IDLE 3.5.1 not using Tk 8.6

2016-06-04 Thread Emanuel Barry
Changes by Emanuel Barry : -- components: +IDLE, Macintosh nosy: +kbk, ned.deily, roger.serwy, ronaldoussoren, terry.reedy stage: -> test needed type: resource usage -> behavior versions: +Python 3.5 ___ Python tracker

[issue23401] Add pickle support of Mapping views

2016-06-04 Thread Raymond Hettinger
Raymond Hettinger added the comment: Guido, is it your intention that the ABCs grow pickle support? I presume if this were implemented that it would become a requirement for all classes (and their subclasses) that purport to be mappings. I thought that you had designed to the ABCs to stay f

[issue27203] Failing doctests in Doc/faq/programming.rst

2016-06-04 Thread Jelle Zijlstra
Changes by Jelle Zijlstra : Removed file: http://bugs.python.org/file43173/faqdoctests.patch ___ Python tracker ___ ___ Python-bugs-list maili

[issue27203] Failing doctests in Doc/faq/programming.rst

2016-06-04 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: Thanks for teaching me about `make suspicious`. The attached patch fixes the issue. This doesn't fix all failures in the file but it gets us closer. -- assignee: -> docs@python components: +Documentation nosy: +docs@python versions: +Python 3.6 Added

[issue27179] subprocess uses wrong encoding on Windows

2016-06-04 Thread Dāvis
Dāvis added the comment: it makes no sense to not use better encoding default in some cases like my patch does. Most programs use console's encoding not ANSI codepage and thus by limiting default only to ANSI codepage we force basically everyone to always specify encoding. This is current beha

[issue13771] HTTPSConnection __init__ super implementation causes recursion error

2016-06-04 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: Could you provide a minimal code sample that demonstrates the problem? I'm having a hard time seeing why the http.client code is buggy. -- nosy: +Jelle Zijlstra ___ Python tracker

[issue27179] subprocess uses wrong encoding on Windows

2016-06-04 Thread Eryk Sun
Eryk Sun added the comment: >> so ANSI is the natural default for a detached process > > To clarify - ANSI is the natural default *for programs that > don't support Unicode*. By natural, I meant in the context of using GetConsoleOutputCP(), since WideCharToMultiByte(0, ...) encodes text as ANS

[issue27217] IDLE 3.5.1 not using Tk 8.6

2016-06-04 Thread Ned Deily
Ned Deily added the comment: Assuming you are using the Python 3.5.1 from the python.org OS X binary installer, you need to install a version of Tcl/Tk 8.5 (such as ActiveTcl 8.5.18), not 8.6, as is described here: https://www.python.org/download/mac/tcltk/. -- resolution: -> not a b

[issue27218] improve tracing performance with f_trace set to Py_None

2016-06-04 Thread Xavier de Gaye
New submission from Xavier de Gaye: When a trace function set by sys.settrace() returns None, tracing of the current scope should stop, but this feature is not implemented (issue 11992). Currently f_trace is never set to Py_None. Setting f_trace to Py_None in trace_trampoline() when the trace

[issue27219] turtle.fillcolor doesn't accept a tuple of floats

2016-06-04 Thread Jelle Zijlstra
New submission from Jelle Zijlstra: But `turtle.pencolor()` returns a tuple of floats, so calling `turtle.fillcolor(turtle.pencolor())`. This issue shows up in the doctest at library/turtle.rst line 936. I can submit a patch with tests once the tests in issue21916 are in. -- assignee:

[issue27217] IDLE 3.5.1 not using Tk 8.6

2016-06-04 Thread Glenn Travis
Glenn Travis added the comment: Ok, Thank you. I wonder why they have OS X version 8.6, which seems to be the default dl link page? > On Jun 4, 2016, at 11:25 AM, Ned Deily wrote: > > > Ned Deily added the comment: > > Assuming you are using the Python 3.5.1 from the python.org OS X binary

[issue20041] TypeError when f_trace is None and tracing.

2016-06-04 Thread Xavier de Gaye
Xavier de Gaye added the comment: This patch fixes the TypeError. New issue 27218: improve tracing performance with f_trace set to Py_None. -- Added file: http://bugs.python.org/file43198/none_f_trace.patch ___ Python tracker

[issue27217] IDLE 3.5.1 not using Tk 8.6

2016-06-04 Thread Ned Deily
Ned Deily added the comment: Well, 8.6 is the latest version of Tcl/Tk but, because Apple does not yet ship 8.6 in OS X, we have continued to use 8.5. That will change in Python 3.6. -- ___ Python tracker ___

[issue27217] IDLE 3.5.1 not using Tk 8.6

2016-06-04 Thread Glenn Travis
Glenn Travis added the comment: Thank you again, Does that mean that I will need to reinstall 8.6 when python 3.6 comes out? > On Jun 4, 2016, at 11:34 AM, Ned Deily wrote: > > > Ned Deily added the comment: > > Well, 8.6 is the latest version of Tcl/Tk but, because Apple does not yet > ship

[issue27216] Fix capitalisation of "Python runtime" in os.path.islink description

2016-06-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7c20ea2bdb3f by Ned Deily in branch '2.7': Issue 27216: Fix typo (noticed by Alex Chan). https://hg.python.org/cpython/rev/7c20ea2bdb3f New changeset 5160d59a8f1c by Ned Deily in branch '3.5': Issue 27216: Fix typo (noticed by Alex Chan). https://hg

[issue27216] Fix capitalisation of "Python runtime" in os.path.islink description

2016-06-04 Thread Ned Deily
Ned Deily added the comment: Thanks for noticing! -- nosy: +ned.deily resolution: -> fixed stage: -> resolved status: open -> closed type: enhancement -> versions: +Python 3.5, Python 3.6 ___ Python tracker

[issue27179] subprocess uses wrong encoding on Windows

2016-06-04 Thread Eryk Sun
Eryk Sun added the comment: Another set of counterexamples are the utilities in the GnuWin32 collection, which use ANSI in a pipe: >>> call('chcp.com') Active code page: 437 0 >>> '¡'.encode('1252') b'\xa1' >>> '\xa1'.encode('437') b'\xad' >>> os.listdir('.')

[issue21916] Create unit tests for turtle textonly

2016-06-04 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: This patch removes the unrelated XML changes and addresses most of the code review comments. -- nosy: +Jelle Zijlstra Added file: http://bugs.python.org/file43199/issue21916-cr.patch ___ Python tracker

[issue27217] IDLE 3.5.1 not using Tk 8.6

2016-06-04 Thread Ned Deily
Ned Deily added the comment: Multiple versions of Tcl/Tk can co-exist. Installing ActiveTcl 8.5.x does not remove the 8.6.x version you installed earlier. -- ___ Python tracker ___

[issue25804] Make Profile.print_stats support sorting by mutiple values

2016-06-04 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: Patch looks good to me -- nosy: +Jelle Zijlstra ___ Python tracker ___ ___ Python-bugs-list mailing

[issue27217] IDLE 3.5.1 not using Tk 8.6

2016-06-04 Thread Terry J. Reedy
Terry J. Reedy added the comment: Glenn, in the future when you reply by email, please trim off the quoted message you are responding to, as your reply appears beneath it on the web site. -- ___ Python tracker ___

[issue27200] make doctest in CPython has failures

2016-06-04 Thread Berker Peksag
Berker Peksag added the comment: Thanks for all of these patches, but I'm -1 on committing them. We already have an extensive test suite and I'm pretty sure that all of these examples are already tested in Lib/test [*]. Learning reST is already hard for contributors and we shouldn't make it ha

[issue27220] Add a pure Python version of 'collections.defaultdict'

2016-06-04 Thread Emanuel Barry
New submission from Emanuel Barry: Attached patch adds a pure Python version of `collections.defaultdict`. This is yet another step in providing better support for alternate implementations, which may or may not have `_collections`. I also went ahead and fixed __all__ so that `from collections

[issue21159] configparser.InterpolationMissingOptionError is not very intuitive

2016-06-04 Thread Łukasz Langa
Łukasz Langa added the comment: Closing since there's apparently nothing actionable at this point. -- keywords: -3.5regression resolution: -> fixed status: open -> closed ___ Python tracker __

[issue27200] make doctest in CPython has failures

2016-06-04 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: I would consider this a test of the quality of the documentation, not of the implementation. It's important that the examples in the documentation are actually correct. For example, a doctest in Doc/library/datetime.rst passes an "hours=" keyword argument to d

[issue23401] Add pickle support of Mapping views

2016-06-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The option 3 is now available with pickle protocols >= 2 (but less efficient with protocols < 4). Adding pickle support of Mapping views doesn't add a requirement for all classes that purport to be mappings. But if you implement pickle support of your mapp

[issue27182] PEP 519 support in the stdlib

2016-06-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset 00991aa5fdb5 by Ethan Furman in branch 'default': issue27182: update fsencode and fsdecode for os.path(); patch by Dusty Phillips https://hg.python.org/cpython/rev/00991aa5fdb5 -- nosy: +python-dev ___ Py

[issue20041] TypeError when f_trace is None and tracing.

2016-06-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. -- assignee: -> serhiy.storchaka stage: patch review -> commit review versions: +Python 3.5, Python 3.6 -Python 3.3, Python 3.4 ___ Python tracker

[issue27182] PEP 519 support in the stdlib

2016-06-04 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: In the patch that was just committed, the path_type variables are undefined (os.py lines 892 and 908). There is also no test for these error cases—we should test the cases where the path has no __fspath__ or does not return a bytes or str. -- ___

[issue27200] make doctest in CPython has failures

2016-06-04 Thread R. David Murray
R. David Murray added the comment: Yes, the point here is to test the docs, not the code, and is definitely worthwhile. If we can get make doctest to pass, then the docs buildbot can start running it. -- nosy: +r.david.murray ___ Python tracker

[issue19234] socket.fileno() documentation

2016-06-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset d83007ab69e2 by Kushal Das in branch '3.5': Issue #19234: Documents socket.fileno() returns -1 on failure https://hg.python.org/cpython/rev/d83007ab69e2 New changeset 3c745b656dca by Kushal Das in branch 'default': Issue #19234: Merge from 3.5 https

[issue27186] add os.fspath()

2016-06-04 Thread Ethan Furman
Ethan Furman added the comment: Dusty: The pathlib tests looks like it's only testing the PurePath implementation; while this /should/ be sufficient, please add tests for the other classes as well. -- ___ Python tracker

[issue25548] Show the address in the repr for class objects

2016-06-04 Thread Raymond Hettinger
Raymond Hettinger added the comment: Nofar said not to wait for her on this one. -- assignee: rhettinger -> kushal.das ___ Python tracker ___

[issue20041] TypeError when f_trace is None and tracing.

2016-06-04 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue27218] improve tracing performance with f_trace set to Py_None

2016-06-04 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue27218] improve tracing performance with f_trace set to Py_None

2016-06-04 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue27182] PEP 519 support in the stdlib

2016-06-04 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: Attached patch fixes the undefined variable and adds additional tests. -- Added file: http://bugs.python.org/file43201/issue27182-path_type.patch ___ Python tracker ___

[issue27219] turtle.fillcolor doesn't accept a tuple of floats

2016-06-04 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- dependencies: +Create unit tests for turtle textonly type: -> enhancement ___ Python tracker ___ ___

[issue20041] TypeError when f_trace is None and tracing.

2016-06-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4d916be61d46 by Serhiy Storchaka in branch '2.7': Issue #20041: Fixed TypeError when frame.f_trace is set to None. https://hg.python.org/cpython/rev/4d916be61d46 New changeset 74ad78d2dd8d by Serhiy Storchaka in branch '3.5': Issue #20041: Fixed Typ

[issue27129] Wordcode, part 2

2016-06-04 Thread Eric Fahlgren
Changes by Eric Fahlgren : -- nosy: +eric.fahlgren ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue21916] Create unit tests for turtle textonly

2016-06-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Added few minor comments on Rietveld. Please use more complex example for invalid config. Add valid lines before and after an invalid line. -- versions: +Python 3.6 -Python 3.4 ___ Python tracker

[issue21916] Create unit tests for turtle textonly

2016-06-04 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: Thanks for your comments. Added a patch addressing your comments. -- Added file: http://bugs.python.org/file43202/issue21916-cr2.patch ___ Python tracker __

[issue26809] Add __all__ list to the string module

2016-06-04 Thread Emanuel Barry
Changes by Emanuel Barry : -- title: `string` exposes ChainMap from `collections` -> Add __all__ list to the string module ___ Python tracker ___ ___

[issue25738] http.server doesn't handle RESET CONTENT status correctly

2016-06-04 Thread Susumu Koshiba
Susumu Koshiba added the comment: Thanks a lot for a quick review. I've created a new patch with below changes. 1. No content-length and the body to be sent for: a. 204(No Content) b. 205(Reset Content) c. 304(Not Modified) d. response to HEAD request method e. 1xx 2. D

[issue27186] add os.fspath()

2016-06-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset 780cbe18082e by Ethan Furman in branch 'default': issue27186: add C version of os.fspath(); patch by Jelle Zijlstra https://hg.python.org/cpython/rev/780cbe18082e -- ___ Python tracker

[issue26372] Popen.communicate not ignoring BrokenPipeError

2016-06-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3a560525ca50 by Gregory P. Smith in branch '3.5': issue26372 - use os.devnull instead of /dev/null https://hg.python.org/cpython/rev/3a560525ca50 New changeset 52e331b86f2b by Gregory P. Smith in branch 'default': issue26372 - use os.devnull instead

[issue27182] PEP 519 support in the stdlib

2016-06-04 Thread Ethan Furman
Changes by Ethan Furman : -- Removed message: http://bugs.python.org/msg267280 ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue23401] Add pickle support of Mapping views

2016-06-04 Thread Guido van Rossum
Guido van Rossum added the comment: Raymond, what is your opinion? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue27186] add os.fspath()

2016-06-04 Thread Ethan Furman
Ethan Furman added the comment: New changeset 00991aa5fdb5 by Ethan Furman in branch 'default': issue27182: update fsencode and fsdecode for os.path(); patch by Dusty Phillips https://hg.python.org/cpython/rev/00991aa5fdb5 (had wrong issue # in commit) -- __

[issue23401] Add pickle support of Mapping views

2016-06-04 Thread Guido van Rossum
Guido van Rossum added the comment: Serhiy, why would you want to separately pickle such a view? It's a trivial wrapper around a dict/mapping. What's the use case? -- ___ Python tracker __

[issue23264] Add pickle support of dict views

2016-06-04 Thread Guido van Rossum
Guido van Rossum added the comment: Why no docs? -- nosy: +gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue25738] http.server doesn't handle RESET CONTENT status correctly

2016-06-04 Thread Susumu Koshiba
Susumu Koshiba added the comment: Sorry, re-created a patch to do the right word wrapping and made my comments less verbose. -- Added file: http://bugs.python.org/file43204/issue25738_http_reset_content_04.patch ___ Python tracker

[issue27186] add os.fspath()

2016-06-04 Thread Ethan Furman
Ethan Furman added the comment: Jelle: the DirEntry patch looks good so far, but it needs a test for a bytes path. -- ___ Python tracker ___ ___

[issue21130] equivalent functools.partial instances should compare equal

2016-06-04 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: I think the patch needs more tests, including: - Comparing a partial against some other objects - Comparing two partials with a different function - Comparing two partials with different args You also need to check each call to PyObject_RichCompareBool for error

[issue27186] add os.fspath()

2016-06-04 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: Thanks for reviewing. This patch adds tests with a bytes DirEntry. -- Added file: http://bugs.python.org/file43205/issue27186-DirEntry-fspath.patch ___ Python tracker _

[issue26809] Add __all__ list to the string module

2016-06-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8136f9623d7f by Zachary Ware in branch '3.5': Issue #26809: Add __all__ to string module. Patch by Emanuel Barry https://hg.python.org/cpython/rev/8136f9623d7f New changeset 21ae58b77924 by Zachary Ware in branch 'default': Closes #26809: Merge wit

[issue27221] [multiprocessing] Doc is outdated regarding method picklability

2016-06-04 Thread Memeplex
New submission from Memeplex: The module documentation recommends... More picklability Ensure that all arguments to Process.__init__() are picklable. This means, in particular, that bound or unbound methods cannot be used directly as the target (unless you use the fork start method) — just de

[issue16851] Hint about correct ismethod and isfunction usage

2016-06-04 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: Sounds like this can be closed? -- nosy: +Jelle Zijlstra ___ Python tracker ___ ___ Python-bugs-list

[issue26632] @public - an __all__ decorator

2016-06-04 Thread Zachary Ware
Zachary Ware added the comment: I had seen this go by on new-bugs-announce, but hadn't formed an opinion about it. I had also noticed several issues about __all__, but hadn't realized how widespread those issues were. Now I've just been introduced to #23883 via #26809, and was sad to find th

[issue27186] add os.fspath()

2016-06-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset e672cf63d08a by Ethan Furman in branch 'default': issue27186: add PathLike ABC https://hg.python.org/cpython/rev/e672cf63d08a -- ___ Python tracker ___

[issue21130] equivalent functools.partial instances should compare equal

2016-06-04 Thread Emanuel Barry
Emanuel Barry added the comment: Git diffs work, but this one doesn't apply cleanly. I manually fixed it and re-generated the patch. Rietveld should pick it up now. Otherwise, what Jelle said. I'm not sure if the macro has the best name though - I'd probably name it `PyPartial_CheckExact` and

[issue27222] redundant checks and a weird use of goto statements in long_rshift

2016-06-04 Thread Oren Milman
New submission from Oren Milman: current state 1. long_rshift first checks whether a is a negative int. If it is, it does (edited for brevity) 'z = long_invert(long_rshift(long_invert(a), b));'. Otherwise, it calculates the result of the shift and stores it in z. In thi

[issue27222] redundant checks and a weird use of goto statements in long_rshift

2016-06-04 Thread Oren Milman
Changes by Oren Milman : Added file: http://bugs.python.org/file43209/patchedCPythonTestOutput.txt ___ Python tracker ___ ___ Python-bugs-list

[issue27222] redundant checks and a weird use of goto statements in long_rshift

2016-06-04 Thread Oren Milman
Changes by Oren Milman : Added file: http://bugs.python.org/file43208/CPythonTestOutput.txt ___ Python tracker ___ ___ Python-bugs-list mailin

[issue25151] venv does not work with debian releases, if you want to install pip

2016-06-04 Thread Matthias Klose
Changes by Matthias Klose : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue25151] venv does not work with debian releases, if you want to install pip

2016-06-04 Thread Matthias Klose
Matthias Klose added the comment: The current Debian packages show this error message: $ python3 -m venv /tmp/foobar The virtual environment was not created successfully because ensurepip is not available. On Debian/Ubuntu systems, you need to install the python3-venv package using the followin

[issue27179] subprocess uses wrong encoding on Windows

2016-06-04 Thread Dāvis
Dāvis added the comment: Of course I agree that proper solution is to use Unicode/Wide API but that's much more work to implement and I rather have now this half-fix which works for most of cases than nothing till whenever Unicode support is implemented which might be nowhere soon. > IMO, it

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

2016-06-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset e6560f018845 by Terry Jan Reedy in branch '2.7': Issue #24759: Add 'private' notice for idlelib.idle_test. https://hg.python.org/cpython/rev/e6560f018845 New changeset d75a25b3abe1 by Terry Jan Reedy in branch '3.5': Issue #24759: Add 'private' noti

[issue21916] Create unit tests for turtle textonly

2016-06-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Nice. LGTM. -- stage: patch review -> commit review versions: +Python 2.7 ___ Python tracker ___ _

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

2016-06-04 Thread Terry J. Reedy
Terry J. Reedy added the comment: I believe require85-v2.diff adds everything specified in my last post. -- Added file: http://bugs.python.org/file43210/require85-v2.diff ___ Python tracker

[issue21916] Create unit tests for turtle textonly

2016-06-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset f0b94cfcea45 by Serhiy Storchaka in branch '2.7': Issue #21916: Added tests for the turtle module. https://hg.python.org/cpython/rev/f0b94cfcea45 New changeset 3b9e96440a70 by Serhiy Storchaka in branch '3.5': Issue #21916: Added tests for the turtl

[issue21916] Create unit tests for turtle textonly

2016-06-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Jelle, do you want to add tests the constructor, repr and pickling of Vec2D? -- stage: commit review -> needs patch ___ Python tracker ___ ___

[issue27222] redundant checks and a weird use of goto statements in long_rshift

2016-06-04 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +mark.dickinson, serhiy.storchaka stage: -> patch review versions: +Python 3.6 ___ Python tracker ___

[issue27186] add os.fspath()

2016-06-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset 76b2ddaee6bd by Ethan Furman in branch 'default': issue27186: fix fsencode/fsdecode and update tests; patch by Jelle Zijlstra https://hg.python.org/cpython/rev/76b2ddaee6bd -- ___ Python tracker

[issue23401] Add pickle support of Mapping views

2016-06-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Because I can! I just want to ensure that all basic types (for which it makes sense) are correctly and portable pickleable, especially collections and related classes. Note that currently Mapping views are pickleable (as most pure Python classes), but pickle

[issue23401] Add pickle support of Mapping views

2016-06-04 Thread Guido van Rossum
Guido van Rossum added the comment: I think it's fine to do this for concrete classes, I just don't think it should be added to ABCs. --Guido (mobile) -- ___ Python tracker ___

  1   2   >