Giampaolo Rodola' added the comment:
> I'd really love to understand what the state of the TCP connection
> is here. I'm presuming that it's still open, because otherwise you'd
> get a different error from OpenSSL. So what's the error that's
&g
Changes by Giampaolo Rodola' :
--
nosy: +giampaolo.rodola, josiah.carlson
___
Python tracker
<http://bugs.python.org/issue8003>
___
___
Python-bugs-list m
Changes by Giampaolo Rodola' :
--
nosy: +giampaolo.rodola
___
Python tracker
<http://bugs.python.org/issue6768>
___
___
Python-bugs-list mailing list
Unsubsc
Changes by Giampaolo Rodola' :
--
nosy: +giampaolo.rodola
___
Python tracker
<http://bugs.python.org/issue6589>
___
___
Python-bugs-list mailing list
Unsubsc
Giampaolo Rodola' added the comment:
> The intuitive explanation seems to be:
> - there are some bytes available for reading on the *TCP socket*,
> therefore asyncore calls the read handler
> - however, there are not enough bytes for OpenSSL to actually decrypt
> any data,
Giampaolo Rodola' added the comment:
> The patch isn't exactly correct: it should ideally retry the unwrap()
> call later, rather than simply ignore the error. But since it's just
> used for testing, it looks sufficient.
Actually unwrap() should already be called
Giampaolo Rodola' added the comment:
By reading the doc it is not clear if we should activate this option only when
dealing with blocking sockets.
What's the behavior with non blocking ones?
Does it result in a no-op or does it hang the
Giampaolo Rodola' added the comment:
Mmm you're right. Sorry.
I'm clearly too tired. =)
--
___
Python tracker
<http://bugs.python.org/issue8222>
___
__
Giampaolo Rodola' added the comment:
@Antoine Pitrou: ok, I think I'll have to be able to replicate the error in
order to try to fix this. I'm gonna try on FreeBSD and another Linux box later
today.
--
___
Python tracker
<http
Giampaolo Rodola' added the comment:
Florent can you give me a clue on how to make python use OpenSSL 0.9.8k on
Ubuntu?
Despite I compiled and installed 0.9.8k from sources the system version keeps
being 0.9.8g and I guess that Python is using that one.
Do I have to recompile Python by
Giampaolo Rodola' added the comment:
Ok, I've finally been able to reproduce the issue by installing OpenSSL 0.9.8m
on my Ubuntu box.
By doing some debugging I'm starting to think that maybe there's something
wrong with the shutdown() method implementation itself be
Giampaolo Rodola' added the comment:
Yes, it's the _sslobj.shutdow() call:
File "test_ftplib.py", line 332, in handle_close
self.socket = self.socket.unwrap()
File "/usr/local/lib/python2.7/ssl.py", line 258, in unwrap
s = self._sslobj.shutdown()
erro
Giampaolo Rodola' added the comment:
No I haven't, but I tried just now and I get the same error.
--
___
Python tracker
<http://bugs.python.
Giampaolo Rodola' added the comment:
As suggested in this thread:
http://mirt.net/pipermail/stunnel-users/2005-July/000661.html
...I made the following change to the Makefile:
- LIBS= -lpthread -ldl -lutil
+ LIBS= -lpthread -ldl -lutil -lz
That made the error change as fo
Giampaolo Rodola' added the comment:
I was about to open a request for this.
Thanks.
--
___
Python tracker
<http://bugs.python.org/issue8321>
___
___
Pytho
Giampaolo Rodola' added the comment:
>>> import ssl
Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python2.7/ssl.py", line 62, in
from _ssl import OPENSSL_VERSION_NUMBER, OPENSSL_VERSION_INFO,
OPENSSL_VERSI
Giampaolo Rodola' added the comment:
The ./configure -> make -> make install process went fine, or at least, I think
so, as it completed without reporting errors or exiting.
...But maybe I'm doing something wrong as just a little while ago I was
modifying _ssl.c but wasn
Giampaolo Rodola' added the comment:
You were right: make output had an error involving ssl I didn't notice. My bad.
--
___
Python tracker
<http://bugs.python.
Changes by Giampaolo Rodola' :
--
nosy: +giampaolo.rodola
___
Python tracker
<http://bugs.python.org/issue8324>
___
___
Python-bugs-list mailing list
Unsubsc
Giampaolo Rodola' added the comment:
def handle_error(self):
-raise
+# Ignore errors while closing, because the remote end could have
+# abruptly shut down the TCP connection while we are still
+# waiting for SSL shutdown to f
Giampaolo Rodola' added the comment:
> By the way, this "broken pipe" error could be due to the fact that the
> FTP_TLS client never tries to call unwrap() on its SSL socket. Perhaps
> the close() method should be overriden?
ftplib.FTP_TLS class already calls unwrap()
Giampaolo Rodola' added the comment:
> I don't understand your reasoning. These are separate connections,
> closing one shouldn't affect the other.
I meant another thing. I was talking about the fact that the test server
attempts to shutdown() both control and data
Giampaolo Rodola' added the comment:
Thinking back about this, I wonder whether "FTPS" could be a better name to use
instead of "FTP_TLS".
It's shorter, easier to remember, and also makes more sense since also
Giampaolo Rodola' added the comment:
I'm the one who recently added FTPS support to ftplib.py and wrote tests for
both FTP and FTPS. I'm not the "maintaner" of the module but I'd like to be
notified in case of issues about it, so would it make sense
Giampaolo Rodola' added the comment:
Any update about this issue?
This should be marked as high priority, imho.
--
___
Python tracker
<http://bugs.python.org/i
Changes by Giampaolo Rodola' :
--
nosy: +giampaolo.rodola
___
Python tracker
<http://bugs.python.org/issue6916>
___
___
Python-bugs-list mailing list
Unsubsc
Giampaolo Rodola' added the comment:
If everyone agrees on "error: [Errno 0] Error" being a legitimate alias for a
"connection closed event" condition then I'd say the test server looks good,
even if I think that expecting a ssl.SSLError derived exception woul
Changes by Giampaolo Rodola' :
--
assignee: -> giampaolo.rodola
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue4814>
___
___
Py
Giampaolo Rodola' added the comment:
Closed as a duplicate of 6822 which provides a patch.
--
nosy: +giampaolo.rodola
resolution: -> duplicate
status: open -> closed
___
Python tracker
<http://bugs.python
Giampaolo Rodola' added the comment:
Fixed as r80172 (python 2.7) and r80176 (python 3.2).
--
assignee: -> giampaolo.rodola
priority: -> normal
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type: -> behavior
versions: +Python 2.6,
Changes by Giampaolo Rodola' :
--
resolution: -> out of date
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue1726451>
___
___
Giampaolo Rodola' added the comment:
Closing this out as invalid as an exception being raised after an invalid PASV
response makes perfect sense.
--
resolution: -> rejected
stage: -> committed/rejected
status: open -> closed
type
Changes by Giampaolo Rodola' :
--
nosy: +giampaolo.rodola
___
Python tracker
<http://bugs.python.org/issue6095>
___
___
Python-bugs-list mailing list
Unsubsc
Giampaolo Rodola' added the comment:
The patch in attachment implements support for epoll() and kqueue() by adding a
new "poller" argument to asyncore.loop().
However, I had a chat with Jean Paul Calderone today which pointed out how
useless this is. =)
The problem i
Changes by Giampaolo Rodola' :
--
nosy: +exarkun
___
Python tracker
<http://bugs.python.org/issue6692>
___
___
Python-bugs-list mailing list
Unsubsc
Giampaolo Rodola' added the comment:
Forgot to add the patch.
--
keywords: +patch
Added file: http://bugs.python.org/file16994/asyncore.patch
___
Python tracker
<http://bugs.python.org/i
Giampaolo Rodola' added the comment:
Fixed as r80226 (2.7) and r80228 (3.2).
--
components: +Library (Lib)
priority: -> normal
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type: -> behavior
___
P
Changes by Giampaolo Rodola' :
--
nosy: +giampaolo.rodola
___
Python tracker
<http://bugs.python.org/issue4142>
___
___
Python-bugs-list mailing list
Unsubsc
Changes by Giampaolo Rodola' :
--
nosy: +giampaolo.rodola
status: pending -> open
___
Python tracker
<http://bugs.python.org/issue3596>
___
___
Python-bug
Changes by Giampaolo Rodola' :
--
status: open -> pending
___
Python tracker
<http://bugs.python.org/issue3596>
___
___
Python-bugs-list mailing list
Unsu
Changes by Giampaolo Rodola' :
--
nosy: +giampaolo.rodola
___
Python tracker
<http://bugs.python.org/issue8483>
___
___
Python-bugs-list mailing list
Unsubsc
Giampaolo Rodola' added the comment:
I think the problem relies in here:
# cheap inheritance, used to pass all other attribute
# references to the underlying socket object.
def __getattr__(self, attr):
return getattr(self.socket, attr)
I wonder why this has been add
Giampaolo Rodola' added the comment:
> Unfortunately, even if forwarding everything to the socket is
> questionable, it would probably be a really bad idea to change it,
> since there is likely code in the field depending on this behavior.
I agree, even if it would break a
Giampaolo Rodola' added the comment:
You're absolutely right.
Patch in attachment.
--
keywords: +patch
Added file: http://bugs.python.org/file17026/asyncore.patch
___
Python tracker
<http://bugs.python.
New submission from Giampaolo Rodola' :
The patch in attachment provides actual tests for asyncore.dispatcher class
API, including all handle_* callback methods.
--
assignee: josiahcarlson
files: asyncore.patch
keywords: patch, patch
messages: 103896
nosy: giampaolo.r
Giampaolo Rodola' added the comment:
> should be 'listens'
[...]
> should be 'bound'
done
> I'd prefer to see a 'BaseTestAPI' that has no base class, and two
> TestCase subclasses that use BaseTestAPI as a mixin, one for
> use_poll=Tr
Giampaolo Rodola' added the comment:
Idea: wouldn't it be better to provide a more powerful "accept_mail" method
instead of "accept_domain?
--
nosy: +giampaolo.rodola
___
Python tracker
<http
Giampaolo Rodola' added the comment:
I'm not sure how to reproduce this issue but I doubt calling close() from
__del__ would solve the problem, neither would be a good idea as close() might
end up being called more than once, which is not desirable.
Try to paste the code you
Giampaolo Rodola' added the comment:
Closing this out as rejected.
--
resolution: -> rejected
status: open -> closed
type: -> behavior
___
Python tracker
<http://bugs.pytho
Giampaolo Rodola' added the comment:
Builbots are all ok except Solaris which makes me think that maybe asyncore is
broken on such platform:
http://python.org/dev/buildbot/builders/sparc%20solaris10%20gcc%20trunk/builds/728/steps/test/logs/stdio
I've tried to adjust the tests a lit
Giampaolo Rodola' added the comment:
Do you intend to provide a patch?
--
nosy: +giampaolo.rodola
___
Python tracker
<http://bugs.python.org/issue8536>
___
___
Giampaolo Rodola' added the comment:
I seem to remember that those classes were initially removed and then re-added
by Josiah for backward compatibility (see discussions in issue 1641 and issue
1736190).
Despite practically useless after the changes applied to asynchat in Python
2.6,
New submission from Giampaolo Rodola' :
I recently took a look at asynchat doc and found out it has some issues which
should be addressed.
In my opinion the following methods and functions should NOT be mentioned:
- async_chat.refill_buffer()
this has been removed in Python 2.6 and no l
Changes by Giampaolo Rodola' :
--
nosy: +giampaolo.rodola
___
Python tracker
<http://bugs.python.org/issue5565>
___
___
Python-bugs-list mailing list
Unsubsc
Changes by Giampaolo Rodola' :
--
nosy: +giampaolo.rodola
___
Python tracker
<http://bugs.python.org/issue8106>
___
___
Python-bugs-list mailing list
Unsubsc
Changes by Giampaolo Rodola' :
--
nosy: +giampaolo.rodola
___
Python tracker
<http://bugs.python.org/issue6560>
___
___
Python-bugs-list mailing list
Unsubsc
Changes by Giampaolo Rodola' :
--
nosy: +giampaolo.rodola
___
Python tracker
<http://bugs.python.org/issue7865>
___
___
Python-bugs-list mailing list
Unsubsc
Changes by Giampaolo Rodola' :
--
nosy: +giampaolo.rodola
___
Python tracker
<http://bugs.python.org/issue5178>
___
___
Python-bugs-list mailing list
Unsubsc
Changes by Giampaolo Rodola' :
--
nosy: +giampaolo.rodola
___
Python tracker
<http://bugs.python.org/issue8570>
___
___
Python-bugs-list mailing list
Unsubsc
Changes by Giampaolo Rodola' :
--
nosy: +giampaolo.rodola
___
Python tracker
<http://bugs.python.org/issue8569>
___
___
Python-bugs-list mailing list
Unsubsc
Giampaolo Rodola' added the comment:
As per discussion with Josiah I'm leaving fifo class alone as it can still be
used also with the newer producer_fifo implementation (changed in Python 2.6).
The other changes described in my comments above still hold.
Committed in r80631 (2.7), r
Giampaolo Rodola' added the comment:
Good catch. I modified your patch a little bit including a catch for
OverflowError exception and a last attempt to look up into errno.errorcode:
def _strerror(err):
try:
return strerror(err)
except (ValueError, OverflowError):
Giampaolo Rodola' added the comment:
Assuming this is still desirable I'd really like to move forward with this
issue.
The current situation is that we have two patches.
My patch
pros:
* affects asyncore.py only
* (imho) cleaner, as it just adds one class
* stable,
Giampaolo Rodola' added the comment:
Attached is a patch which fixes FTP_TLS class as well and changes the test
server a little bit.
Shouldn't retrlines() suffer the same issue?
--
assignee: -> giampaolo.rodola
nosy: +giampaolo.rodola
versions: +Python 3.1, Python 3.
New submission from Giampaolo Rodola' :
Similarly to issue 3972 the patch in attachment adds a new "source_address"
option to FTP class to bind to a specific address when connecting to a remote
FTP server.
It must be noted that this gets done for both control and passive da
Giampaolo Rodola' added the comment:
Issue 8594 is related with this one.
--
superseder: -> Add a "source_address" option to ftplib
___
Python tracker
<http://bugs.py
Changes by Giampaolo Rodola' :
--
nosy: +giampaolo.rodola
___
Python tracker
<http://bugs.python.org/issue8598>
___
___
Python-bugs-list mailing list
Unsubsc
Giampaolo Rodola' added the comment:
> You should not use find_unused_port()
I agree find_unused_port() is the wrong approach in general, but in this case I
think there's nothing we can do about it.
> you never set self.source_address.
You're right, I should set it in
Giampaolo Rodola' added the comment:
> find_unused_port is the wrong approach altogether. Uses of it should
> be replaced by bind_port and then find_unused_port should be removed
I agree find_unused_port() is the wrong approach in general, but there are
certain cases where thi
Giampaolo Rodola' added the comment:
> Any time you have any API that you want to test that requires a
> pre-allocated port number, you're going to have intermittent failures.
> Such APIs are broken and should be fixed where possible and avoided
> oth
Changes by Giampaolo Rodola' :
--
___
Python tracker
<http://bugs.python.org/issue8576>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail
Giampaolo Rodola' added the comment:
> Any time you have any API that you want to test that requires a
> pre-allocated port number, you're going to have intermittent failures.
> Such APIs are broken and should be fixed where possible and avoided
> oth
Changes by Giampaolo Rodola' :
--
nosy: +giampaolo.rodola
___
Python tracker
<http://bugs.python.org/issue8604>
___
___
Python-bugs-list mailing list
Unsubsc
Giampaolo Rodola' added the comment:
Adding this:
def handle_error(self):
raise
...to SimSMTPChannel class would help to provide a clearer error message to
understand where exactly EBADF comes from, altough I think this was an old
asyncore bug which have already been fixe
Giampaolo Rodola' added the comment:
As per discussion on #python-dev we think it's better to proceed as follows:
for python 2.7 and 3.2:
- fix __getattr__ error message
- raise a DeprecationWarning if cheap inheritance is used and definitively
remove its support in the next maj
Giampaolo Rodola' added the comment:
Yes, I think it's better to remain consistent with the rest of the module which
uses %s all around the place, also for backward compatibility in case someone
wants to copy asyncore.py shipped with recent python versions and use it in
their
Giampaolo Rodola' added the comment:
Fixed in r80875 (2.7), r80876 (3.2), r80878 (2.6) and r80879 (3.1) which also
includes changes to fix issue 8573.
--
resolution: -> fixed
stage: commit review -> committed/rejected
status: ope
Giampaolo Rodola' added the comment:
Done in r80882 for ftplib and smtplib modules.
--
___
Python tracker
<http://bugs.python.org/issue3620>
___
___
Pytho
Changes by Giampaolo Rodola' :
--
nosy: +giampaolo.rodola
___
Python tracker
<http://bugs.python.org/issue7735>
___
___
Python-bugs-list mailing list
Unsubsc
Giampaolo Rodola' added the comment:
I have adjusted the failing tests in r80895 and r80930 which now pass on
Solaris.
It seems Solaris has two problems:
- OOB data (aka handle_expt) doesn't work, but I'm not too worried about this
as it's very rarely used. In
Giampaolo Rodola' added the comment:
Is this is still desirable?
If so I can work on a patch for ftplib which provides a finer error handling in
case of disconnection while sending QUIT and updates tests which should be
modified to fit in the newer test
Changes by Giampaolo Rodola' :
--
___
Python tracker
<http://bugs.python.org/issue4972>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail
Giampaolo Rodola' added the comment:
Is this still desirable?
If so I can work on a patch for ftplib which provides a finer error handling in
case of disconnection while sending QUIT and updates tests which should be
modified to fit in the newer test
Giampaolo Rodola' added the comment:
A patch including tests and doc changes is in attachment.
--
versions: +Python 3.2 -Python 2.7, Python 3.1
Added file: http://bugs.python.org/file17276/ftplib.patch
___
Python tracker
<http://bugs.py
Giampaolo Rodola' added the comment:
> Magic methods usually don’t have docstrings, since they implement one
> operation that is described in one place (think __len__ vs. len).
Agreed, I only left it since it was there in the first place.
> What did you add a cmd_noop method
Giampaolo Rodola' added the comment:
> Is the string returned by a real FTP server “331 username ok”? (My
> point is that I think it would be better to have different strings for
> cmd_noop and cmd_user.)
Whoops! No that should have been "200 noop ok".
I copied cmd
Changes by Giampaolo Rodola' :
Removed file: http://bugs.python.org/file17276/ftplib.patch
___
Python tracker
<http://bugs.python.org/issue4972>
___
___
Python-bugs-l
Giampaolo Rodola' added the comment:
This is now committed as r81041.
I've also removed the long description from what's new file, as you were
suggesting.
The other two patches should be adapted for 3.2.
--
___
Python
Giampaolo Rodola' added the comment:
Committed in r81043 (trunk) and r81044 (3.2).
Thanks for your comments.
--
assignee: josiahcarlson -> giampaolo.rodola
components: +Tests
resolution: -> fixed
stage: -> committed/rejected
versions: +Python 2
Changes by Giampaolo Rodola' :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue8490>
___
___
Python-bugs-list mailing list
Unsu
Giampaolo Rodola' added the comment:
Closed as duplicate of issue7037.
--
nosy: +giampaolo.rodola
resolution: -> duplicate
status: open -> closed
___
Python tracker
<http://bugs.python
Giampaolo Rodola' added the comment:
I'm not a xml* modules user but I've tried to apply the patch against the trunk
and it seems it still works.
--
nosy: +effbot, giampaolo.rodola, loewis
versions: +Python 2.7, Python 3.1, Python
Giampaolo Rodola' added the comment:
What are the enhancements introduced by this patch?
A faster cancel() implementation?
If so some simple benchmarks showing the speed improvement of cancel() and
eventually also other methods like enterabs() and run() would be nice to have.
I'
New submission from Giampaolo Rodola' :
sched.py module is currently lacking a test suite.
Possibly this should be resolved before fixing issue 8684.
--
components: Tests
messages: 105503
nosy: giampaolo.rodola, josiah.carlson, josiahcarlson, pitrou
priority: normal
severity: n
Giampaolo Rodola' added the comment:
Created issue 8687 to address the test suite problem.
--
superseder: -> sched.py module doesn't have a test suite
___
Python tracker
<http://bugs.pyth
Giampaolo Rodola' added the comment:
Patch in attachment.
--
keywords: +patch
Added file: http://bugs.python.org/file17296/test_sched.patch
___
Python tracker
<http://bugs.python.org/i
Giampaolo Rodola' added the comment:
> Let the user leverage the existing scheduler API. Cut out
> scheduled_task and call_later, which just wraps the scheduler API.
> The user can simply call scheduled_tasks.enter() or
> scheduled_tasks.cancel(). It's one less API
Changes by Giampaolo Rodola' :
--
nosy: +ezio.melotti
___
Python tracker
<http://bugs.python.org/issue8694>
___
___
Python-bugs-list mailing list
Unsubsc
Giampaolo Rodola' added the comment:
I agree. Are you recommending to take advantage of this and change the tests in
some way?
--
___
Python tracker
<http://bugs.python.org/i
Giampaolo Rodola' added the comment:
Some comments:
-# This file implements the minimal SMTP protocol as defined in RFC 821. It
+# This file implements the minimal SMTP protocol as defined in RFC 5321. It
Is RFC 5321 completely implemented? Otherwise I would turn this in "as defin
101 - 200 of 1167 matches
Mail list logo
