Tim Golden added the comment:
Added, including a slightly surprising change needed to test_zipimport_support
(which arguably should have been there from the start for robustness).
--
assignee: - tim.golden
Added file: http://bugs.python.org/file32338/issue14255.2.diff
Tim Golden added the comment:
Fine. I'll commit it later. (Probably tomorrow at this point)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19273
Tim Golden added the comment:
Had a to-and-fro on IRC with RDM who highlighted that an inconsistency between
os.listdir and os.path.exists (the case here) is, at least, undesirable. As it
stands, our os.exists on os.stat mechanism will fail because any attempt to get
any kind of handle via
Tim Golden added the comment:
Done. Thanks for the patch.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19273
Tim Golden added the comment:
Fixed on tip. Thanks for the issue and the original patch.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4905
Tim Golden added the comment:
This is, in principle, a backwards-incompatible change as any code will stop
working which relies on exec* running useful tools in c:\bin. (I have a
c:\tools which is basically the same thing).
Frankly, I'm -0 on changing it; it does no real harm that I can see
Changes by Tim Golden m...@timgolden.me.uk:
Removed file: http://bugs.python.org/file32338/issue14255.2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14255
Tim Golden added the comment:
New patch, tested on Windows Linux
--
Added file: http://bugs.python.org/file32362/issue14255.3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14255
Tim Golden added the comment:
Applied. Thanks for the patch.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13234
Tim Golden added the comment:
If you can put together a self-contained test case which fails on
3.3/3.4 I'm quite happy to re-open this. Given the nature of the issue,
you'll have to be quite precise as to Windows version, whether 32/64,
whether running as Administrator, and exact Python
Changes by Tim Golden m...@timgolden.me.uk:
--
stage: patch review - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19273
New submission from Tim Golden:
Modules/audioop.c is giving compile warnings on Windows against lines 18 437.
..\Modules\audioop.c(18): warning C4146: unary minus operator applied to
unsigned type, result still unsigned
..\Modules\audioop.c(437): warning C4146: unary minus operator applied
Tim Golden added the comment:
The attached patch appears to fix the problem.
--
keywords: +patch
Added file: http://bugs.python.org/file32390/audioop.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19418
Tim Golden added the comment:
I don't think it will, given MS description of the compiler warning:
http://msdn.microsoft.com/en-us/library/4kh09110%28v=vs.100%29.aspx
but I'll certainly give it a go.
--
___
Python tracker rep...@bugs.python.org
Tim Golden added the comment:
Good idea. I'll test against Win32/64 Linux 32
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19418
Tim Golden added the comment:
Fixed. Thanks for the report.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14255
Tim Golden added the comment:
Applied. Thanks for the patch.
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15792
Changes by Tim Golden m...@timgolden.me.uk:
Removed file: http://bugs.python.org/file32390/audioop.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19418
Tim Golden added the comment:
The attached patch (using Tim Peters' -1 trick) builds tests ok on Win32/64
Linux 32.
--
Added file: http://bugs.python.org/file32400/issue19418.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Tim Golden added the comment:
Good point. Updated patch.
--
Added file: http://bugs.python.org/file32401/issue19418.2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19418
Changes by Tim Golden m...@timgolden.me.uk:
Removed file: http://bugs.python.org/file32400/issue19418.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19418
Tim Golden added the comment:
Fine by me
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19433
___
___
Python-bugs-list mailing list
Unsubscribe
Tim Golden added the comment:
Fixed in 3.3 / 3.4
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
versions: -Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19418
Changes by Tim Golden m...@timgolden.me.uk:
--
assignee: - tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19464
___
___
Python-bugs
Changes by Tim Golden m...@timgolden.me.uk:
--
assignee: - tim.golden
versions: +Python 3.4 -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10197
Tim Golden added the comment:
That's because IDLE uses a completely different input loop from the
console interpreter.
I'll try to get to this but I'm chock-a-block with other work at the
moment. If anyone else wants to dig, please do so. if the worst came to
the worst we could back out my
Tim Golden added the comment:
+1
Richard - are you in a position to commit / push?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17619
Tim Golden added the comment:
Attached is a qd script to produce the list of extension - mimetype maps for
a version of the mimetypes module.
--
Added file: http://bugs.python.org/file29900/mt.py
___
Python tracker rep...@bugs.python.org
http
Tim Golden added the comment:
Three outputs produced by mt.py: tip as-is; tip without registry; tip
with new approach to registry. The results for 2.7 are near-enough
identical. Likewise the results for an elevated prompt.
--
Added file: http://bugs.python.org/file29901/mt-tip.txt
Added
Tim Golden added the comment:
There seems to be a consensus that the current behaviour is undesirable,
indeed broken for any meaningful use.
The critical argument against the current Registry approach is that it
returns unexpected (or outright incorrect) mimetypes for very standard
extensions
Tim Golden added the comment:
Essentially: no. The permissions system in Windows is very different
from that of Unix. The CRT attempts to mimic it, but for things like
read-onlyness, it does so by setting the (old-style DOS) attributes.
These are only just meaningful for files
Tim Golden added the comment:
My initial reaction is that, whether the 2.7 behaviour is faulty or not, I
can't reproduce the correct behaviour on any version of Windows going back to
2.4. Take the attached Python file issue18040.py and run
c:\pythonxx\python.exe -i issue18040.py for any
Tim Golden added the comment:
Correction: I see the desired behaviour in 3.3/3.4 which is where the
overhaul to Ctrl-C handling on Windows was applied. I still can't see it
in 2.6 or in 3.1/3.2 on Windows.
The problem lies in the fact that PyOS_InterruptOccurred and
PyErr_CheckSignals from
Tim Golden added the comment:
Personally, I'm +0 at best on this change. It would achieve consistency with
Linux but I'm not sure what you'd do with such functionality.
Adding Richard Oudkerk who did the rework of the interrupt signal for 3.3.
Richard, any opinion on this?
--
nosy
Tim Golden added the comment:
Thanks for the feedback, David. Closing as won't fix.
--
resolution: - wont fix
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18040
Tim Golden added the comment:
Glancing back, it isn't perhaps clear to the casual reader what's being
proposed here, and why. The idea is that a pip-style installer become part of
core Python. For Windows users, any standalone scripts from an installed
package would be placed in scripts
Tim Golden added the comment:
Paul, are you using the hg tip of pywin32? pywin32_postintall.py was
patched a couple of months ago to use imp.load_dynamic (essentially to
work around this issue).
--
nosy: +tim.golden
___
Python tracker rep
Tim Golden added the comment:
Unfortunately this missed the boat for 3.3; I'll target 3.4 when we've got a
branch to commit to.
--
versions: +Python 3.4 -Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Changes by Tim Golden m...@timgolden.me.uk:
--
assignee: tim.golden -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6839
___
___
Python-bugs-list
Changes by Tim Golden m...@timgolden.me.uk:
--
assignee: - tim.golden
nosy: +tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16097
Tim Golden added the comment:
Committed in bb77400af434.
Thanks
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16097
Tim Golden added the comment:
The natural way to do this in windows is using the Job API:
http://msdn.microsoft.com/en-us/library/windows/desktop/ms684161%28v=vs.85%29.aspx
However I'm not sure where to apply this within the multiprocessing
architecture (or if it's even a good idea
Tim Golden added the comment:
Confirming that this doesn't happen on 2.7
py -2 £.py succeeds
py -3 £.py gives:
python: failed to set __main__.__loader__
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16218
Changes by Tim Golden m...@timgolden.me.uk:
--
nosy: +christian.heimes
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16328
___
___
Python-bugs
Tim Golden added the comment:
[this response appears to have got lost in an email black hole somewhere]
I assume that $PYTHONPATH is actually referring to sys.exec_prefix
(and not the PYTHONPATH env var which has nothing to do with this).
In any case c:\python27\scripts is still the place
I assume that $PYTHONPATH is actually referring to sys.exec_prefix
(and not the PYTHONPATH env var which has nothing to do with this).
In any case c:\python27\scripts is still the place for scripts. There is
a c:\python27\tools\scripts (which you're welcome to add to your %PATH%
if you find the
Tim Golden added the comment:
On 02/11/2012 21:00, Andrew Svetlov wrote:
I guess to return sh if supported, cmd.exe for Windows.
FWIW the canonical approach on Windows is to return whatever %COMSPEC%
points to.
--
nosy: +tim.golden
___
Python
Tim Golden added the comment:
I've got a patch for this which applies cleanly to the 3.4 tip. I still need to
sort out the Windows issues (which I don't think will be difficult; it looks
like a test issue, not a code issue)
--
assignee: - tim.golden
Tim Golden added the comment:
I'm planning to refactor the tests and the code very slightly. When I've
got a reworked patch I'll ping it back to you to ensure it matches your
intent. IIUC you're implementing comma-separated lists {abc,def} and
nested braces {a{b,c}d,efg} but not ranges {a..z
Tim Golden added the comment:
Attached is a refactored version of Mathieu's patch which, when applied to tip,
passes all tests.
--
Added file: http://bugs.python.org/file27894/0003-reworked-issue9584.patch
___
Python tracker rep...@bugs.python.org
Tim Golden added the comment:
Something went wrong with that patch; it doesn't include all the changes to
test_glob. I'll upload a newer patch later.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9584
Tim Golden added the comment:
Scratch that last comment: the patch does apply. I've tested it against Windows
Ubuntu. If no one comes in with any objections I'll commit it within the next
day.
--
___
Python tracker rep...@bugs.python.org
http
Tim Golden added the comment:
Must have been something I did. I'll revert the commit and re-test.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9584
Tim Golden added the comment:
Well even in the original [working] version, the scope of this change
was limited to glob.glob. os.listdir doesn't currently support any form
of expansion (at least not on Windows) and nor does os.makedirs. I don't
see any problem in restricting this change
Tim Golden added the comment:
Sorry, I misunderstood the point you were making with the
os.listdir/makedirs examples. Fair point about backwards compatibility.
This may make this change untenable as no-one will want a series of
use_feature_xxx flags, one for each change we introduce to glob.glob
Changes by Tim Golden m...@timgolden.me.uk:
Removed file: http://bugs.python.org/file27894/0003-reworked-issue9584.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9584
Tim Golden added the comment:
Given that this isn't going to go ahead in its current form, and will need
wider discussion on python-dev, I'm unassigning myself and I've removed the
flawed version of the patch which I'd posted.
--
assignee: tim.golden
Tim Golden added the comment:
I'm sorry, but I genuinely can't see what you're trying to say here. If you
believe that there's a bug in Python's standard library, can you show a
reproducible *Python* testcase for it, please (using the pywin32 modules if
that helps) and state clearly what you
Changes by Tim Golden m...@timgolden.me.uk:
--
nosy: +gregory.p.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16458
___
___
Python-bugs-list
Tim Golden added the comment:
On 13/11/2012 20:57, Karthk Rajagopalan wrote:
I added test case using perl and python since it was easy to
reproduce using perl socket module and show the issue happening with
python's subprocess.py. There is definitely an action required in
subprocess.py
Tim Golden added the comment:
Start here: http://docs.python.org/devguide/
In particular: http://docs.python.org/devguide/patch.html
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16458
Tim Golden added the comment:
Karthk, if you can run up an up-to-date patch and a test I'm willing to review
and commit it, otherwise this one will lie quiet.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16458
Tim Golden added the comment:
Not Python, but Windows. See here:
http://msdn.microsoft.com/en-gb/library/windows/desktop/aa384187%28v=vs.85%29.aspx
--
nosy: +tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16524
Tim Golden m...@timgolden.me.uk added the comment:
Problem seems to be in Modules/_multiprocessing/semaphore.c
line 549 where __enter__ is defined as an alias for
semlock_acquire, as is acquire a few lines above. However,
while acquire specifies METH_VARARGS | METH_KEYWORDS,
__enter__ has only
Changes by Tim Golden m...@timgolden.me.uk:
--
type: - crash
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5261
___
___
Python-bugs-list mailing
Tim Golden m...@timgolden.me.uk added the comment:
OK, I can see why this is happening and in fact there are two levels of
problem. The trouble is that, in my ignorance, I can't work out exactly
why the existing code is doing what it's doing.
(References to mmapmodule.c at r69666)
Problem 1
Tim Golden m...@timgolden.me.uk added the comment:
Patch attached to mmapmodule.c and test_mmap.py
--
keywords: +patch
Added file: http://bugs.python.org/file13107/mmapmodule.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Tim Golden m...@timgolden.me.uk added the comment:
Can't reproduce under Python 2.6 or Python 2.5.2. Likelihood is a virus
checker / indexer process.
--
nosy: +tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1285
Tim Golden m...@timgolden.me.uk added the comment:
Have a look at issue 2733
http://bugs.python.org/issue2733
where I've just proposed a patch in this area. I'm also
not sure exactly what's going on, but I have patched what
I believe is a linked pair of bugs in that code.
--
nosy
Tim Golden m...@timgolden.me.uk added the comment:
From me, yes of course, but I assume you want another
core dev for a 2nd opinion.
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2733
Tim Golden m...@timgolden.me.uk added the comment:
Hirokazu Yamamoto wrote:
Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment:
I reconsidered this issue. When mmap is anonymous,
self-file_handle == INVALID_HANDLE_VALUE (-1), so we should not call
SetFilePointer
Tim Golden m...@timgolden.me.uk added the comment:
Effectively a duplicate of http://bugs.python.org/issue2421
(which has been sitting around unapplied for a few months)
I certainly don't mind which one goes in, but I think
one should be closed in favour of the other. (And that
one should
New submission from Tim Golden m...@timgolden.me.uk:
tools\msi\merge.py attempts to import config and fails with an
ImportError if it doesn't exist (which it doesn't by default). msi.py
catches this exception and ignores it.
The attached patch carries the same behaviour over to merge.py
New submission from Tim Golden m...@timgolden.me.uk:
The msi.py determines which files to carry over into the installer for
the lib\test directory. zipdir.zip was added recently for test_zipfile
and this isn't picked up. The attached patch adds it in.
--
components: Installation
files
New submission from Tim Golden m...@timgolden.me.uk:
lib\distutils\tests\test_util.py, run as part of the full testsuite,
creates a stub os.uname on an OS which doesn't support it natively.
However, it fails to restore it correctly -- ie fails to delete the
attribute. As a result, test_platform
Tim Golden m...@timgolden.me.uk added the comment:
Adding Tarek to nosy list as he added the code earlier this month
--
nosy: +tarek
title: distutils.test_util fails to restore os.uname - distutils.test_util
fails to restore os.uname; causes test_platform to fail
Tim Golden m...@timgolden.me.uk added the comment:
Erik Sandberg wrote:
Erik Sandberg sandb...@virtutech.com added the comment:
I experimented further, the only way to run a .bat file whose name
contains funny characters, seems to be:
subprocess.call('f(o.bat', shell=True)
Well there's
Tim Golden m...@timgolden.me.uk added the comment:
Erik Sandberg wrote:
Erik Sandberg sandb...@virtutech.com added the comment:
Did you test your code?
Several times, cutting and pasting into the Python interpreter.
But I missed the fact that you were running Python 2.5
Python 2.6.1 (r261
Tim Golden m...@timgolden.me.uk added the comment:
Can I nudge this one a bit? It causes an interpreter crash and the patch
seems good (subject to someone else's review).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5261
Tim Golden m...@timgolden.me.uk added the comment:
Is there mileage for glob.glob to grow a dialect
param, with a default value to keep it backwards
compatible? Otherwise, presumably, proponents of
some other xsh variant will come forward with
their scheme of matching, and regex-followers
Tim Golden m...@timgolden.me.uk added the comment:
Well it may be uncommon, but it's perfectly easily reproducible:
Just try to reinstall / repair from a file not called
python-2.5.2.msi. Maybe uninstall: haven't tried.
If Martin doesn't get there, I'll try to look at the log and
see
New submission from Tim Golden m...@timgolden.me.uk:
tools/msi/msi.py is still trying to copy the README file from the
lib/test directory. This file was removed in r70872. Patch attached
against r71393 of msi.py.
--
components: Build, Demos and Tools, Windows
files: msi.r71393.patch
Tim Golden m...@timgolden.me.uk added the comment:
Edmund Eyles wrote:
New submission from Edmund Eyles ho...@heddonsgate.co.uk:
The documentation for the webbrowser module at
http://www.python.org/doc/2.5/lib/module-webbrowser.html refers to the
use of the BROWSER environment variable
Index: bdist_msi.py
===
--- bdist_msi.py(revision 72507)
+++ bdist_msi.py(working copy)
@@ -141,6 +141,8 @@
bdist_base = self.get_finalized_command('bdist').bdist_base
self.bdist_dir =
Changes by Tim Golden m...@timgolden.me.uk:
--
assignee: - tarek
components: +Distutils
nosy: +tarek
type: - behavior
versions: +Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6065
Tim Golden m...@timgolden.me.uk added the comment:
I doubt there's any real likelihood of the official Python 2.5.4 being
generated with a different compiler: it would mean, in principle, that all
binary extensions would have be recompiled to ensure there were no issues. I
suggest you ask
Tim Golden added the comment:
Patched according to Nick Coghlan's suggestion in
http://bugs.python.org/issue9922#msg150093. Ad hoc tests look ok on Windows.
I'll add tests look at *nix later.
--
Added file: http://bugs.python.org/file32450/issue10197.diff
Tim Golden added the comment:
Applied to 3.3 3.4. Thanks for the patch.
--
resolution: - fixed
stage: - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19464
Changes by Tim Golden m...@timgolden.me.uk:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19464
___
___
Python-bugs-list
Tim Golden added the comment:
Code tests now work on Windows. Applied to 3.3 3.4.
--
resolution: - fixed
stage: test needed - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10197
Tim Golden added the comment:
This has nearly been fixed by the rewrite of the get[status]output code under
issue10197. There is an issue, though, with the use there of universal_newlines
mode, which forces check_output to return a string rather than bytes.
--
nosy: +tim.golden
Tim Golden added the comment:
The code I've just committed to issue10197 means that the get[status]output
functions now pass their (few) tests on all platforms. More by chance than
judgement, that change employed universal_newlines which has the effect of
forcing the output of check_output
Changes by Tim Golden m...@timgolden.me.uk:
--
assignee: - tim.golden
versions: +Python 3.3, Python 3.4 -Python 3.1, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9922
Changes by Tim Golden m...@timgolden.me.uk:
Added file: http://bugs.python.org/file32483/issue9922.34.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9922
Tim Golden added the comment:
Good point. I've added the versionchanged tag.
The issue with bytes-string encoding goes all the way back to
Popen.communicate if universal newlines mode is used so I've simply put
in a reference to the existing notes on the subject higher up in the docs
Changes by Tim Golden m...@timgolden.me.uk:
--
assignee: - tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13674
___
___
Python-bugs
Changes by Tim Golden m...@timgolden.me.uk:
--
components: +Windows
versions: +Python 3.4 -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13674
Tim Golden added the comment:
Attached is a patch with tests
--
keywords: +patch
Added file: http://bugs.python.org/file32516/issue13674.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13674
Tim Golden added the comment:
On 06/11/2013 15:23, STINNER Victor wrote:
+if (strchr(y, outbuf[1]) buf.tm_year 0)
hum... why not simply outbuf[1] == 'y' ? It would be more explicit
and less surprising.
Ummm. I have no idea what I was thinking about there. I think it was
somehow
Tim Golden added the comment:
Thanks: final outdated comments removed
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10197
301 - 400 of 601 matches
Mail list logo
