Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-24 Thread Larry Hastings
On 07/18/2017 02:36 AM, Antoine Pitrou wrote: Can I take the opportunity to say thank you again (both you and Larry) for the "blurb" tool? It really makes an important difference when contributing. On 07/18/2017 03:24 AM, Victor Stinner wrote: Thank you Larry Hastings, Brett Cannon and othe

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-19 Thread Barry Warsaw
Ah, how deservedly superficial my title is: % python3 flufl.py File "flufl.py", line 3 1 <> 2 ^ SyntaxError: invalid syntax % cat flufl.py from __future__ import barry_as_FLUFL 1 <> 2 -Barry > On Jul 19, 2017, at 11:31, Victor Stinner wrote: > > 2017-07-19 17:23 GMT+02:00 Barry W

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-19 Thread Victor Stinner
2017-07-19 17:23 GMT+02:00 Barry Warsaw : > That, and bringing back the diamond operator for realz. For people who don't know the "diamond operator" like me ;-) haypo@selma$ python3 Python 3.5.3 (default, May 10 2017, 15:05:55) >>> from __future__ import barry_as_FLUFL >>> 1 != 2 SyntaxError: inv

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-19 Thread Barry Warsaw
On Jul 18, 2017, at 11:01 PM, Brett Cannon wrote: >It's very obvious, Barry, that you're playing the long game of trying to >line up GitLab as the next platform once we grow tired of GitHub and need >to switch in a few years. I'm on to you. ;) That, and bringing back the diamond operator for real

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Mariatta Wijaya
> > 2. Bot to backport PRs (which could also be automatically merged) > So, to me, this is the priority item on the list. I'm planning to work on the cherry-pick bot this during the core sprint in September. Unless someone beat me to it. Automatically close stale PRs (e.g. not signing CLA, cha

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Brett Cannon
On Tue, 18 Jul 2017 at 16:06 Terry Reedy wrote: > On 7/18/2017 2:31 PM, Brett Cannon wrote: > > > Once again, glad the goals are panning out. :) Key thing has always been > > to increase our bandwidth and part of that was always to push more on to > > contributors so they can be more self-servici

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Brett Cannon
On Tue, 18 Jul 2017 at 12:54 Barry Warsaw wrote: > On Jul 18, 2017, at 15:21, R. David Murray wrote: > > > > I much prefer rietveld over github reviews, but I also much prefer the > > integration between the bug tracker and github over the minimal > > integration we had for rietveld. Thanks to

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Terry Reedy
On 7/18/2017 2:31 PM, Brett Cannon wrote: Once again, glad the goals are panning out. :) Key thing has always been to increase our bandwidth and part of that was always to push more on to contributors so they can be more self-servicing. * most contributors create backports (using cherry-

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Barry Warsaw
On Jul 18, 2017, at 15:21, R. David Murray wrote: > > I much prefer rietveld over github reviews, but I also much prefer the > integration between the bug tracker and github over the minimal > integration we had for rietveld. Thanks to all the people who made > that happen, and especially Brett

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread R. David Murray
On Tue, 18 Jul 2017 12:24:13 +0200, Victor Stinner wrote: > I'm just not unconfortable with the fact that an approval is kept even > if the PR is modified after the review :-/ I would expect a list a > notice "changed modified after the review" or something like that. At > least, for my own revie

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Brett Cannon
On Tue, 18 Jul 2017 at 03:24 Victor Stinner wrote: > Hi, > > 2017-07-18 11:36 GMT+02:00 Antoine Pitrou : > > Can I take the opportunity to say thank you again (both you and Larry) > > for the "blurb" tool? It really makes an important difference when > > contributing. > Glad it's working out! A

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Serhiy Storchaka
18.07.17 14:40, Antoine Pitrou пише: Assuming you meant Martin von Löwis, I think Martin stopped contributing long before we migrated to git (unfortunately, I might add). I hope he's doing ok. I meant Martin Panter. His was the third of most active committers recent two years, but didn't comm

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Nick Coghlan
On 18 July 2017 at 21:36, Serhiy Storchaka wrote: > I rather like the new workflow (except few lost features), but I afraid than > many core developers are feeling uncomfortable with it. Aye, I think for folks already familiar with git and PR-style workflows through other projects, it's been almo

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Antoine Pitrou
Le 18/07/2017 à 13:36, Serhiy Storchaka a écrit : > > I have a different impression. Some core developers (like Raymond or > Martin) stopped committing even if they are active on the bug tracker or > mailing lists. Others make much less commits than they did before the > migration. Assuming y

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Serhiy Storchaka
18.07.17 13:24, Victor Stinner пише: == More contributors, more contributions, faster reviewed/merged == In term of contributions, I looked at statistics yesterday and it became clear the number of different authors is significantely much higher, around 25 contributors / month before, now closer

[python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Victor Stinner
Hi, 2017-07-18 11:36 GMT+02:00 Antoine Pitrou : > Can I take the opportunity to say thank you again (both you and Larry) > for the "blurb" tool? It really makes an important difference when > contributing. > > Regards > > Antoine. I concur with Antoine, I'm now *very* happy with the new workflow