Re: [python-committers] Wrongly stopping merges discourages merging.

2018-06-04 Thread Guido van Rossum
+1. For example for mypy I use the "triangular" git setup even though as a mypy core dev I could simply push my branch to the main repo. On Mon, Jun 4, 2018 at 11:49 AM, Donald Stufft wrote: > I’d also add that it is generally a good thing that people with power and > a voice (e.g. the core

Re: [python-committers] Wrongly stopping merges discourages merging.

2018-06-04 Thread Donald Stufft
I’d also add that it is generally a good thing that people with power and a voice (e.g. the core devs) are having a similar experience that an external contributor would. This is our best line of defense against the external contributor experience degrading to a bad place. By having core devs

Re: [python-committers] Wrongly stopping merges discourages merging.

2018-06-04 Thread Brett Cannon
On Sun, 3 Jun 2018 at 13:23 Terry Reedy wrote: > When we used hg, core dev committers could actually commit to the > repository when they judged it appropriate. When we moved to github, > Brett, with whoever's approval, Since this seems very much directed at me, I should mention any authority

Re: [python-committers] Wrongly stopping merges discourages merging.

2018-06-04 Thread Brett Cannon
On Sun, 3 Jun 2018 at 20:30 Ned Deily wrote: > On Jun 3, 2018, at 22:30, Steve Dower wrote: > > We probably have enough data on the VSTS builds by now to see whether > they are comparable/faster than AppVeyor. Obviously the idea of doing that > work was to be able to migrate builds if it made

Re: [python-committers] Wrongly stopping merges discourages merging.

2018-06-03 Thread Steve Dower
definition of interest. Top-posted from my Windows 10 phone From: Victor Stinner Sent: Sunday, June 3, 2018 14:47 To: Terry Reedy Cc: python-committers Subject: Re: [python-committers] Wrongly stopping merges discourages merging. 2018-06-03 22:23 GMT+02:00 Terry Reedy : > Exhibit 1. For at le

Re: [python-committers] Wrongly stopping merges discourages merging.

2018-06-03 Thread Victor Stinner
I reported two issues: "AppVeyor builds interrupted before tests complete" https://bugs.python.org/issue33764 "AppVeyor didn't start on my PR 7365" https://bugs.python.org/issue33765 Victor ___ python-committers mailing list

Re: [python-committers] Wrongly stopping merges discourages merging.

2018-06-03 Thread Victor Stinner
2018-06-03 22:23 GMT+02:00 Terry Reedy : > Exhibit 1. For at least a couple of weeksin may, faults in the asyncio test > (and another) caused the asyncio test to randomly fail about half the time. > With one retest, each CI bot failed about 1/4 the time. At least one bot of > the two bots failed

Re: [python-committers] Wrongly stopping merges discourages merging.

2018-06-03 Thread Zachary Ware
Hi Terry, I have an email going out to AppVeyor with you CCed, we'll see what kind of response we get (probably tomorrow). In the meantime, I'll look into disabling largefile tests, or test_mmap specifically on AppVeyor to see whether that helps the situation. On Sun, Jun 3, 2018 at 3:23 PM,

[python-committers] Wrongly stopping merges discourages merging.

2018-06-03 Thread Terry Reedy
When we used hg, core dev committers could actually commit to the repository when they judged it appropriate. When we moved to github, Brett, with whoever's approval, decided that we should no longer be trusted to make commits without approval of a couple of mindless robots. However, the