[python-committers] Codecov and PR

2017-04-21 Thread Victor Stinner
Hi, I tried to merge a pull request on my phone, but I got the error: "Pull requests that have a failing status can’t be merged on a phone." The GitHub PEP announced that it will be possible to merge a change from the beach. Well, it's doable but only if you bring a laptop, not a phone :-) All

Re: [python-committers] Codecov and PR

2017-04-21 Thread Victor Stinner
Ah, I found a workaround: Firefox on Android has a "[x] See the computer version" option which allows the merge!? Victor Le 22 avr. 2017 12:29 AM, "Victor Stinner" a écrit : > Hi, > > I tried to merge a pull request on my phone, but I got the error: > >

Re: [python-committers] Codecov and PR

2017-04-22 Thread Victor Stinner
Oh, I forgot something about Codecov: it took me 2 minutes to understand why a PR gets the red icon whereas all tests pass and the merge button was waiting for my click. In fact, Codecov failed but the test isn't blocking. I would expect the green icon on the overall list of PR. Well, it's not blo

Re: [python-committers] Codecov and PR

2017-04-22 Thread Victor Stinner
Thank you, I will take a look and see if I can help. Victor Le 22 avr. 2017 6:43 PM, "Brett Cannon" a écrit : > > > On Fri, 21 Apr 2017 at 15:33 Victor Stinner > wrote: > >> Ah, I found a workaround: Firefox on Android has a "[x] See the computer >&

Re: [python-committers] Codecov and PR

2017-04-25 Thread Victor Stinner
`self.initfp()` is very unlikely raise exceptions. But MemoryError, KeyboardInterrupt or other rare exceptions may be happen. unittest.mock helps a lot to test such corner case: mock initfp() with a MemoryError side effect, maybe also close () to check that the method was called... The new probl

Re: [python-committers] No Travis-CI on OS X?

2017-05-02 Thread Victor Stinner
2017-05-02 23:37 GMT+02:00 Donald Stufft : > I think the only reason we don’t have them on is because the macOS builds on > Travis are _Super_ slow and regularly get a large backlog. Fast Finish and > Allowed Failures would help with that though. Maybe we can start with a small subset of tests and

Re: [python-committers] Coverage build broken?

2017-05-04 Thread Victor Stinner
It seems like a real bug and a regression, I opened an issue to track it: http://bugs.python.org/issue30273 Victor 2017-05-04 16:44 GMT+02:00 Antoine Pitrou : > > Hello, > > I'm getting the following error on the Travis-CI coverage job: > (from https://travis-ci.org/python/cpython/jobs/228758363#

Re: [python-committers] Coverage build broken?

2017-05-04 Thread Victor Stinner
2017-05-04 22:51 GMT+02:00 Victor Stinner : > It seems like a real bug and a regression, I opened an issue to track it: > http://bugs.python.org/issue30273 Ok, it should be fixed by my commit: https://github.com/python/cpython/commit/b109a1d3360fc4bb87b9887264e3634632d392ca

Re: [python-committers] Coverage build broken?

2017-05-04 Thread Victor Stinner
2017-05-04 23:56 GMT+02:00 Brett Cannon : > Thanks, Victor! Well, I was also responsible of the breakage :-) But maybe it wasn't a good idea in the first place to use AST_H_DIR in distutils/sysconfig.py to get the "Include" string? ;-) Or maybe I missed a feature: is it possible to change the Inc

[python-committers] Feedback on the new CPython workflow

2017-05-17 Thread Victor Stinner
Hi, I wanted to wait a little bit before giving back my feedback on the new workflow. I just attend Brett Canon's talk at the Language Summit. So here are my misc notes on the new workflow. * Is there anyone already working on the workflow who would like to get a grant (money!) from the PSF? * I

Re: [python-committers] Feedback on the new CPython workflow

2017-05-18 Thread Victor Stinner
2017-05-18 9:01 GMT-07:00 Mariatta Wijaya : > The question is: since backport branch is temporary and gets deleted once PR > is created, is this even important? I stopped using cherry-picker.py to use a simple shell script for the last step, create a PR from a local branch, because I had too many

Re: [python-committers] Proposing Carol Willing to become a core developer

2017-05-23 Thread Victor Stinner
tl;dr +1 for me as well 2017-05-23 13:15 GMT-05:00 Brett Cannon : > For those of you who don't know Carol, (...) To be honest, I just met Carol at the Pycon US (yeah! that's the purpose of such event, no?). I wasn't aware of her amazing work on CPython. The thing is that I'm a "code" nerd: I basi

Re: [python-committers] Proposing Carol Willing to become a core developer

2017-05-23 Thread Victor Stinner
2017-05-23 16:42 GMT-05:00 Senthil Kumaran : > Also, liked reading Victor's email. :) Thank you. It's my feedback of constructive discussions about the Python community at Pycon. Victor ___ python-committers mailing list [email protected] htt

Re: [python-committers] Proposing Carol Willing to become a core developer

2017-05-24 Thread Victor Stinner
Le 24 mai 2017 17:17, "Guido van Rossum" a écrit : OK, I think we have enough +1 votes... Brett, will you make it happen? Well, that vote is just a world record in term of +1 in a short period of time! (I also count +1 for Guido if I understood correctly ;-)) Victor ___

Re: [python-committers] Proposing Carol Willing to become a core developer

2017-05-25 Thread Victor Stinner
Welcome Carol! Victor Le 24 mai 2017 7:41 PM, "Brett Cannon" a écrit : > Done! > > Carol, just accept the invitation to join the Python core team on GitHub > at https://github.com/python and that's it! (I already subscribed you to > python-committers under your Gmail account and Mariatta is tak

[python-committers] Please stop fixing easy issues right now! Leave them as exercices to newcomes

2017-06-02 Thread Victor Stinner
Hi, I discussed with Mariatta and Carol at Pycon US about new contributors and the difficulty to find "easy issues" to start contributing to CPython. The thing is that easy issues usually are fixed in less than 24 hours which doesn't give the opportunity to newcomers to fix them. *Many* people as

Re: [python-committers] Please stop fixing easy issues right now! Leave them as exercices to newcomes

2017-06-02 Thread Victor Stinner
2017-06-02 11:28 GMT+02:00 Antoine Pitrou : > In that case, it's probably reasonable to remove the "easy" tag ;-) Right, we need to cleanup this old list to "easy" issues. > That's a good policy. I remember doing so some years ago. Of course, > if some "easy" issue you care about hasn't been f

Re: [python-committers] IMPORTANT: Python 3.6.2 Maintenance Release Release Candidate in 3+ days (Monday 2017-06-12 12:00 UTC)

2017-06-09 Thread Victor Stinner
Oh, about very annoying 3.6 bug, there was a regression caused by FASTCALL optimizations. It's now fixed in the 3.6 branch: https://github.com/python/cpython/commit/f0ff849adc6b4a01f9d1f08d9ad0f1511ff84541 Victor 2017-06-09 5:34 GMT+02:00 Ned Deily : > We are approaching the end of the second c

Re: [python-committers] Sporadic failures in test_multiprocessing_main_handling?

2017-06-12 Thread Victor Stinner
Hi Antoine, Buildbots got a new coloor last month: orange. It means that we detected "warnings", one of these warnings are tests which failed once but then passed when run a second time. I started to open an issue for each CI failure and for each unstable test (fail then pass). For multiprocessin

Re: [python-committers] Sporadic failures in test_multiprocessing_main_handling?

2017-06-12 Thread Victor Stinner
typo: 2017-06-13 8:42 GMT+02:00 Victor Stinner : > See also *my* "buildbot report" emails to python-dev. Oh, it seems like you bug you saw is not in the bug tracker. I opened this issue: http://bugs.python.org/issue30643 You can use it to track your progress on that one, since it

[python-committers] Promote Julien Palards as Committers on docsbuild-scripts

2017-06-13 Thread Victor Stinner
Hi, Would it be possible to give the commit bit to Julien Palards on the following project (only on this project)? https://github.com/python/docsbuild-scripts/pulls His GitHub account is "JulienPalard": https://github.com/JulienPalard Thanks to the migration to GitHub, we are now able to g

Re: [python-committers] Promote Julien Palards as Committers on docsbuild-scripts

2017-06-13 Thread Victor Stinner
Le 14 juin 2017 00:29, "Brett Cannon" a écrit : It is, but the infrastructure team owns that repo, not Python core. -Brett Oh, I didn't know. Is it possible to see who owns a GitHub Python project at https://github.com/python/? If not, do you think that it would be worth it to document it som

[python-committers] Revert changes which break too many buildbots

2017-06-14 Thread Victor Stinner
Hi, The CPython workflow was enhanced to get pre-commit CI checks. That's a huge win, thank you for that... But, sometimes, a change can still break many buildbots, bugs which weren't catched by pre-commit checks (Travis CI/Linux and AppVeyor/Windows). Buildbots cover much more different architect

Re: [python-committers] Revert changes which break too many buildbots

2017-06-14 Thread Victor Stinner
2017-06-14 18:38 GMT+02:00 Serhiy Storchaka : >> What do you think? Would you be ok with such rule? > > I think we first should make buildbots notifying the author of a > commit that broke tests or building, so his can either quickly fix the > failure or revert his commit. One or two months ago, I

Re: [python-committers] Promote Julien Palards as Committers on docsbuild-scripts

2017-06-14 Thread Victor Stinner
2017-06-14 22:40 GMT+02:00 Brett Cannon : >> Oh, I didn't know. Is it possible to see who owns a GitHub Python project >> at https://github.com/python/? > > If you can see https://github.com/orgs/python/teams/python-core/repositories > then yes. :) About this list, there was a question on the buil

Re: [python-committers] Revert changes which break too many buildbots

2017-06-14 Thread Victor Stinner
2017-06-14 18:38 GMT+02:00 Serhiy Storchaka : > I think we first should make buildbots notifying the author of a > commit that broke tests or building, so his can either quickly fix the > failure or revert his commit. Hum, I think that I should elaborate my previous email. It's usually easy to id

Re: [python-committers] Revert changes which break too many buildbots

2017-06-15 Thread Victor Stinner
2017-06-15 5:31 GMT+02:00 Nick Coghlan : > I'm not necessarily opposed to such a policy change, but if folks > really want guaranteed green post-merge buildbots for all platforms > (rather than just guaranteed green for Linux & Windows, sometimes red > for everything else), then I think a better pl

Re: [python-committers] Promote Julien Palards as Committers on docsbuild-scripts

2017-06-15 Thread Victor Stinner
Oh nice, thanks to your change, it's now listed in the list! https://github.com/orgs/python/teams/python-core/repositories Victor 2017-06-15 22:40 GMT+02:00 Brett Cannon : > I've made Python core able to read the buildmaster-config repo. > > On Wed, 14 Jun 2017 at 13:53 Vict

Re: [python-committers] Revert changes which break too many buildbots

2017-06-16 Thread Victor Stinner
2017-06-16 10:37 GMT+02:00 Nick Coghlan : > Hopefully reversions will continue to be rare (since relatively few > changes are likely to be as platform dependent as PEP 538, and > Windows/*nix differences are already covered in pre-merge CI), but > when they do come up, the reminder of how to manual

Re: [python-committers] Bedevere now automatically removes "needs backport to *" labels

2017-06-20 Thread Victor Stinner
Does it allow catch for 3.3 and 3.4 branches? I got notifications for 3.6, 3.5 and 2.7 backports of https://github.com/python/cpython/pull/1849 but not for the 3.3 and 3.4 backports: https://github.com/python/cpython/pull/2291 https://github.com/python/cpython/pull/2292 These two backports have th

Re: [python-committers] Bedevere now automatically removes "needs backport to *" labels

2017-06-20 Thread Victor Stinner
2017-06-20 16:56 GMT+02:00 Mariatta Wijaya : > I think it's because there was no 'needs backport to 3.4' label from PR > 1849, so it doesn't make the comment about 3.4 backport PR. Oh, I see. These labels don't exist :-) Maybe we should add them, but only security changes should be backported to 3

[python-committers] Fun fact, The Knights Who Say "Ni" (bot) complained about CLA on Modules/expat/

2017-06-21 Thread Victor Stinner
Hi, Fun fact: I cherry-picked a change from libexpat into Modules/expat (VS2008 fix for stdint.h), and I kept the author. Then The Knights Who Say "Ni" (bot) complained that Sebastian Pipping didn't sign the CLA :-) https://github.com/python/cpython/pull/2312#issuecomment-310091014 I fixed the i

Re: [python-committers] Proposed release schedule for Python 3.5.4

2017-06-22 Thread Victor Stinner
For 3.4, please review my pending security fixes :-) There are more of them. About the cipher list in ssl, the change itself is simple but it's to blacklist DES and 3DES since it has been proved that these ciphers are really too weak nowadays: http://python-security.readthedocs.io/vuln/cve-2016-21

Re: [python-committers] [Python-Dev] Proposed release schedule for Python 3.5.4

2017-06-23 Thread Victor Stinner
2017-06-22 17:56 GMT+02:00 Brett Cannon : > On Thu, 22 Jun 2017 at 02:32 Larry Hastings wrote: >> Seriously, though, I was mostly hoping other people would handle the >> security stuff and just keep me informed. If I'm the only one permitted to >> accept PRs into 3.4 (and soon 3.5), okay, I can w

Re: [python-committers] [Python-Dev] Proposed release schedule for Python 3.5.4

2017-06-23 Thread Victor Stinner
2017-06-23 15:19 GMT+02:00 Larry Hastings : > Do you need write access to the branch in order to get Travis CI working? As soon as someone reviews my proposed 3.4 patches, no :-) I will work on a PR. Victor ___ python-committers mailing list python-comm

[python-committers] macOS Travis CI job became mandatory?

2017-06-26 Thread Victor Stinner
Hi, I was waiting for the result of Travis CI: 3 jobs already completed, but the macOS job was still running. The macOS job is marked as "allowed failure". I cancelled the job, but then the Travis CI was marked as failed in the PR :-/ So I restarted the job. Is it normal to have to wait for the s

Re: [python-committers] macOS Travis CI job became mandatory?

2017-06-26 Thread Victor Stinner
48 minutes later: the macOS is running for 33 minutes, but Travis CI fails to retrieve the logs :-/ https://travis-ci.org/python/cpython/jobs/247090627 Victor 2017-06-26 15:57 GMT+02:00 Victor Stinner : > Hi, > > I was waiting for the result of Travis CI: 3 jobs already completed,

Re: [python-committers] macOS Travis CI job became mandatory?

2017-06-26 Thread Victor Stinner
2017-06-26 16:47 GMT+02:00 Antoine Pitrou : > Just kill the job :-) See my first email: first, I killed the macOS job, and then Travis CI was marked as failed on PR, and so my PR couldn't be merged... Victor ___ python-committers mailing list python-com

Re: [python-committers] macOS Travis CI job became mandatory?

2017-06-26 Thread Victor Stinner
ost-commit jobs on buildbots, no? Victor 2017-06-26 16:46 GMT+02:00 Victor Stinner : > 48 minutes later: the macOS is running for 33 minutes, but Travis CI > fails to retrieve the logs :-/ > https://travis-ci.org/python/cpython/jobs/247090627 > > Victor > > 2017-06-26 15:57 G

Re: [python-committers] macOS Travis CI job became mandatory?

2017-06-26 Thread Victor Stinner
2017-06-26 17:25 GMT+02:00 Antoine Pitrou : > Given that it doesn't hurt to keep it, I would rather keep it. It > allows to quickly test for OS X-specific issues. According to my bad experience of today, it took longer than 1h30 to get the [Merge] button... Before, it took around 20 min. Well, i

Re: [python-committers] macOS Travis CI job became mandatory?

2017-06-27 Thread Victor Stinner
2017-06-27 18:33 GMT+02:00 Antoine Pitrou : > I see this sporadically on another project. There was no configuration > change, it just seems Travis-CI is misbehaving. Oh ok. It's fine in that case. Today, I didn't see this issue anymore :-) I was usually able to merge in less than 30 min, someti

Re: [python-committers] Travis now checks for whitespace issues in PRs

2017-06-28 Thread Victor Stinner
FYI PC/pyconfig.h couldn't be modified in the master branch, because it contains tabs. See https://github.com/python/cpython/pull/2476 failure. I created https://github.com/python/cpython/pull/2477 which contains a "make patchcheck" run to reformat PC/pyconfig.h. Maybe we should fix spaces of all

Re: [python-committers] Revert changes which break too many buildbots

2017-07-05 Thread Victor Stinner
o run! The slowest time on some buildbots. I don't know much more at this point. Please join http://bugs.python.org/issue30822 if you want to help fixing this issue ;-) Victor 2017-06-14 16:40 GMT+02:00 Victor Stinner : > Hi, > > The CPython workflow was enhanced to get pre-commit CI

Re: [python-committers] Revert changes which break too many buildbots

2017-07-05 Thread Victor Stinner
2017-07-05 15:51 GMT+02:00 Victor Stinner : > Ok, since I spent weeks on fixing buildbots, I'm now more confident > that our buildbots are super stable. Since a test_datetime change > introduced a *regression* (ARMv7 started to fail), I reverted the > first commit: > https

Re: [python-committers] [Python-Dev] 3.6.2 update: 3.6.2rc2 coming

2017-07-06 Thread Victor Stinner
2017-07-03 6:43 GMT+02:00 Ned Deily : > Expect to see 3.6.2rc2 available within the next couple of days (2017-07-04 > expected) and, assuming no new issues, 3.6.2 final about a week later (around > 2017-07-11). Any update on 3.6.2rc2? I would like to check if https://docs.python.org/3.6/whatsn

Re: [python-committers] Please edit the commit message when merge a PR

2017-07-10 Thread Victor Stinner
I would prefer to ask the author to squash and/or rebase his/her commits rather than having to edit the commit message myself. I prefer that the commit message is part of the review, and not only done by the one who clicks on the Merge button. It would prefer mistakes in the commit message. GitHu

Re: [python-committers] Please edit the commit message when merge a PR

2017-07-11 Thread Victor Stinner
2017-07-10 17:35 GMT+02:00 Guido van Rossum : > Often the committer has more context to write a proper commit message, and > asking the contributor to do the squash is just wasting time (plus in > general we *don't* want contributors to squash, since that loses the context > for the review). So I'm

Re: [python-committers] Should I make a 3.4.7rc1 next weekend?

2017-07-12 Thread Victor Stinner
I would love to have a new 3.4 release including all security fixes, sure! It would reduce the number of known vulnerability in Python 3.4: http://python-security.readthedocs.io/vulnerabilities.html 2017-07-12 15:09 GMT+02:00 Larry Hastings : > After a flurry of accepted PRs, I have now accrue

Re: [python-committers] "trivial" label replaced with "skip issue"

2017-07-16 Thread Victor Stinner
2017-07-14 20:33 GMT+02:00 Brett Cannon : > In preparation of fully moving over to blurb and per-file news entries (I > don't have an ETA from Larry on when he plans to do explode Misc/NEWS into > individual files), ... Oh, I wasn't aware of this plan. What is the benefit of converting old Misc/NE

Re: [python-committers] "trivial" label replaced with "skip issue"

2017-07-16 Thread Victor Stinner
2017-07-16 16:10 GMT+02:00 Victor Stinner : > What is the benefit of converting old Misc/NEWS entries? I guess that the benefit is to use a single format for all NEWS entries. I understand that it will ease the build of the changelog. > Do you have an idea of many files we will get? > D

Re: [python-committers] CLA bot bug for a particular contributor

2017-07-18 Thread Victor Stinner
I removed the "CLA not signed" and automatically, the label "CLA signed" appears in 2 seconds ;-) Have a nice day. Victor 2017-07-18 11:34 GMT+02:00 Antoine Pitrou : > > Hi, > > How can I get the CLA bot to fix its knowledge for a particular contributor? > > bugs.python.org user Gareth Rees (http

[python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Victor Stinner
Hi, 2017-07-18 11:36 GMT+02:00 Antoine Pitrou : > Can I take the opportunity to say thank you again (both you and Larry) > for the "blurb" tool? It really makes an important difference when > contributing. > > Regards > > Antoine. I concur with Antoine, I'm now *very* happy with the new workflow

Re: [python-committers] Unreliable contributor stats

2017-07-18 Thread Victor Stinner
2017-07-18 13:57 GMT+02:00 Antoine Pitrou : > Beware of how those numbers are calculated. > > When we were using hg, patches were typically committed by core > developers, so only core developers appeared as "contributors" in the hg > log. Right, that's why I wrote: "Well, Git allows to store the

[python-committers] Dismiss review if a PR is modified

2017-07-18 Thread Victor Stinner
2017-07-18 21:21 GMT+02:00 R. David Murray : > On Tue, 18 Jul 2017 12:24:13 +0200, Victor Stinner > wrote: >> I'm just not unconfortable with the fact that an approval is kept even >> if the PR is modified after the review :-/ I would expect a list a >> notice "

Re: [python-committers] Dismiss review if a PR is modified

2017-07-18 Thread Victor Stinner
13 AM, "Brett Cannon" a écrit : On Tue, 18 Jul 2017 at 13:10 Victor Stinner wrote: > 2017-07-18 21:21 GMT+02:00 R. David Murray : > > On Tue, 18 Jul 2017 12:24:13 +0200, Victor Stinner < > [email protected]> wrote: > >> I'm just not unconfortable

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-19 Thread Victor Stinner
2017-07-19 17:23 GMT+02:00 Barry Warsaw : > That, and bringing back the diamond operator for realz. For people who don't know the "diamond operator" like me ;-) haypo@selma$ python3 Python 3.5.3 (default, May 10 2017, 15:05:55) >>> from __future__ import barry_as_FLUFL >>> 1 != 2 SyntaxError: inv

Re: [python-committers] Un-available till End of August -2017

2017-07-22 Thread Victor Stinner
Welcome back ;-) Victor Le 22 juil. 2017 4:09 AM, "Senthil Kumaran" a écrit : > Hello Python Committers, > > I have been inactive (unsubscribed from all python.org) mailing list > since May 2017. > > I had some study / other commitments that took too much time and I decided > to rest a little f

Re: [python-committers] Travis-CI compiles twice

2017-07-24 Thread Victor Stinner
IMHO everything is fine and we don't have to do anything ;-) Antoine: >I've noticed that Travis-CI (sometimes?) compiles CPython twice. "make regen-all" doesn't compiles Python: * it compiles Parser/pgen * it compiles Programs/_freeze_importlib * it runs many commands to regenerate generated fil

Re: [python-committers] Travis-CI compiles twice

2017-07-24 Thread Victor Stinner
avis CI. If we move the test in a GCC job, it would allow to check regen and GCC warnings in the same job. Victor 2017-07-24 12:16 GMT+02:00 Antoine Pitrou : > > Le 24/07/2017 à 10:55, Victor Stinner a écrit : >> IMHO everything is fine and we don't have to do anything ;-) &g

Re: [python-committers] Travis-CI compiles twice

2017-07-24 Thread Victor Stinner
Technically, "make regen-all" doesn't use the freshly built Python. It uses PYTHON_FOR_REGEN which is usually "python3". Victor 2017-07-24 15:48 GMT+02:00 Nick Coghlan : > On 24 July 2017 at 18:55, Victor Stinner wrote: >> 2017-07-24 9:37 GMT+02:00 Serh

Re: [python-committers] RELEASED] Python 3.4.7rc1 and Python 3.5.4rc1 are now available

2017-07-25 Thread Victor Stinner
2017-07-25 12:23 GMT+02:00 Matthias Klose : > the build of the documentation fails with at least the 3.5.4rc1. It adds a > new > build dependency (blurb), which is inconvenient to build on stable > environments, > or when pip is not available. Please could you consider including the blurb > modu

[python-committers] AppVeyor was unable to build non-mergeable pull request

2017-07-25 Thread Victor Stinner
ue, but it spams Travis CI which has to abort running jobs, and then restarts new jobs from scratch. $ git log commit dc72f12b877cacdc3746e152a9379f4c3083fa22 <= my change Author: Victor Stinner Date: Wed Jul 26 02:20:55 2017 +0200 bpo-30778: Skip test_bs

Re: [python-committers] AppVeyor was unable to build non-mergeable pull request

2017-07-25 Thread Victor Stinner
2017-07-26 4:22 GMT+02:00 Brett Cannon : > So are you requesting we stop building on AppVeyor? No. I would like to know how to fix the AppVeyor issue :-) Is it a bug under our control? Victor ___ python-committers mailing list [email protected]

[python-committers] GitHub: remove the "needs backport to 3.5" label?

2017-08-09 Thread Victor Stinner
Hi, Python 3.5 entered security fix only mode. Should we now remove the "needs backport to 3.5" label? Other security only branches don't have this label neither (3.3 and 3.4). Victor ___ python-committers mailing list [email protected] https

Re: [python-committers] UPDATE 1: Core sprint 2017 - Sep 4 - Sep 9, Menlo Park, California

2017-08-11 Thread Victor Stinner
I created https://public.etherpad-mozilla.org/p/cpython-dev-sprint-2017 etherpad to organize the sprint. Feel free to write whatever you want about the sprint there ;-) I started to list project ideas. Victor 2017-07-12 13:55 GMT+02:00 Łukasz Langa : > Update: the sprint is on! > > *Good news*:

Re: [python-committers] GitHub: remove the "needs backport to 3.5" label?

2017-08-11 Thread Victor Stinner
> No one has said anything, so I will delete the label sometime today. >>> >>> On Wed, 9 Aug 2017 at 12:20 Brett Cannon wrote: >>> >>>> On Wed, 9 Aug 2017 at 01:55 Victor Stinner >>>> wrote: >>>> >>>>> Hi, >>&g

Re: [python-committers] Travis CI build on python/cpython passes in error

2017-08-21 Thread Victor Stinner
The Travis CI config runs the command: git diff --name-only 49f6449ef4b81537c19b82329caaf60596c516c2...d0c822cded495409b68432fa10f9573417ca1fb7 Git fails with "fatal: Invalid symmetric difference expression (...)" if it doesn't know one or both sha1. The first problem is that 49f6449ef4b81537c19

[python-committers] Travis CI: macOS is now blocking -- remove macOS from Travis CI?

2017-09-01 Thread Victor Stinner
Hi, Since today, it seems like the macOS task of a Travis CI job to validate a pull request hangs the whole job. Don't try to cancel the macOS job, or the whole job will be marked as failed! ... even if macOS is in the "Allowed Failure" section. I don't know the best way to "repair" such job. I u

Re: [python-committers] Travis CI: macOS is now blocking -- remove macOS from Travis CI?

2017-09-01 Thread Victor Stinner
Le 1 sept. 2017 7:24 PM, "Antoine Pitrou" a écrit : Le 01/09/2017 à 19:15, Victor Stinner a écrit : > > Yesterday, it was possible to merge a PR even if the macOS job was > still queued (no started). It's still possible today. Ah? The merge button was disabled wh

Re: [python-committers] Travis CI: macOS is now blocking -- remove macOS from Travis CI?

2017-09-05 Thread Victor Stinner
drop the macOS job: https://bugs.python.org/issue31355 Please read the issue for the full rationale. Victor 2017-09-01 19:15 GMT+02:00 Victor Stinner : > Hi, > > Since today, it seems like the macOS task of a Travis CI job to > validate a pull request hangs the whole job. > >

Re: [python-committers] Py_UNREACHABLE

2017-09-15 Thread Victor Stinner
The good news is that other C macros are now documented as well! https://docs.python.org/dev/c-api/intro.html#useful-macros If you look at Include/pymacro.h there are even more crazy macros which are not documented yet, like Py_BUILD_ASSERT(). I like Py_ARRAY_LENGTH() which gives the length of a

Re: [python-committers] Travis CI: macOS is now blocking -- remove macOS from Travis CI?

2017-09-19 Thread Victor Stinner
them last months.) Victor 2017-09-06 1:30 GMT+02:00 Victor Stinner : > Hi, > > I was bitten again by the issue on https://github.com/python/cpython/pull/3350 > > After restarting the Travis CI build twice (first by me, then by > Zach), I was able to merge it. But it's painful t

Re: [python-committers] Travis CI: macOS is now blocking -- remove macOS from Travis CI?

2017-09-19 Thread Victor Stinner
Le 20 sept. 2017 00:03, "Barry Warsaw" a écrit : I forget though, was it a problem with macOS CI stability or general throughput? I thought they just couldn’t keep up with the workload, in which case it seems like we should be able to throw more resources at it, right? There were multiple issu

[python-committers] Should I merge a PR that I approved if it was written by a different core developer?

2017-09-20 Thread Victor Stinner
w Git era, the author and committer *can* be two different people. Examples with "git log --pretty=full": commit 9abee722d448c1c00c7d4e11ce242ec7b13e5c49 Author: Victor Stinner Commit: GitHub commit 8f51bb436f8adfd139cad046b91cd462c7f27f6c (tag: v3.7.0a1) Author: Ne

Re: [python-committers] Should I merge a PR that I approved if it was written by a different core developer?

2017-09-20 Thread Victor Stinner
> I think it's a good idea in many cases, but not required. I'm not sure that I understood correctly, what is a good idea? To merge the PR if I consider that it's now good enough to be merged? > E.g. you may be OK > with the diff but still ask the author to clean up some small nits, and then > th

Re: [python-committers] Should I merge a PR that I approved if it was written by a different core developer?

2017-09-21 Thread Victor Stinner
Ok, no problem, let's say that a core dev should not merge a PR written by another core dev. In fact, I was already following this rule. I hesitated many times to click on Merge, but I wanted first to open a discussion. Here we are :-) Obvious, the good practice is to put as many approval as pos

[python-committers] What is a CPython core developer?

2017-09-22 Thread Victor Stinner
Hi, Recently, I asked their opinion to a few core developers about promoting some active contributors to core developers. It seems like we have no clear rules to decide if a contributor can be promoted or not. The problem is that sometimes, I am explicitly asked: What are the steps to become a co

Re: [python-committers] Travis CI: macOS is now blocking -- remove macOS from Travis CI?

2017-09-23 Thread Victor Stinner
Ok. I closed https://bugs.python.org/issue31355 Victor 2017-09-23 22:58 GMT+02:00 Antoine Pitrou : > > For the record: > https://blog.travis-ci.com/2017-09-22-macos-update > > Regards > > Antoine. > > > Le 01/09/2017 à 19:15, Victor Stinner a écrit : >> Hi,

Re: [python-committers] Hacktoberfest

2017-09-28 Thread Victor Stinner
Hi, 2017-09-28 18:21 GMT+02:00 Mariatta Wijaya : > October is hacktoberfest (https://hacktoberfest.digitalocean.com/) > In the month of October, people can sign up and contribute to open source > projects on GitHub. If they make 4 PRs during Hacktoberfest, they'll earn a > limited edition T-Shirt.

Re: [python-committers] What is a CPython core developer?

2017-10-04 Thread Victor Stinner
2017-09-22 18:48 GMT+02:00 Antoine Pitrou : >> * Long term commitement. (...) > > Unfortunately we can't evaluate that in advance. Even the person being > promoted often does not known whether they'll still be there in 5 or 10 > years. Hopefully that's on their horizon, but many factors can inter

Re: [python-committers] What is a CPython core developer?

2017-10-04 Thread Victor Stinner
2017-09-24 13:05 GMT+02:00 Nick Coghlan : > I think what we put there really does cover the essence of the role, > so the main questions I personally ask about a potential new core > developer are: > > 1. Would gaining core developer privileges improve their ability to > contribute effectively (in

Re: [python-committers] [Python-Dev] Reminder: 12 weeks to 3.7 feature code cutoff

2017-11-03 Thread Victor Stinner
2017-11-04 0:44 GMT+01:00 Joao S. O. Bueno : > This just popped up in Brython's issue tracker discussion: > > """ > Pierre Quentel > > 04:57 (16 hours ago) > to brython-dev/br., Subscribed > > I think it's better to rename all occurences of async now, although > it's strange that : > > there is cu

Re: [python-committers] IPv6 issues on *.python.org

2017-11-16 Thread Victor Stinner
Hi, > * gnutls_handshake() failed: Error in the pull function. It looks more like a TLS issue rather than an IPv6 issue. It reminds me a similar TLS issue on blog.python.org: "blog.python.org in HTTPS doesn't provide a server certificate?" https://github.com/python/psf-infra-meta/issues/3 You m

Re: [python-committers] IPv6 issues on *.python.org

2017-11-16 Thread Victor Stinner
49 ms * 2001:4860:0:1::1aad (2001:4860:0:1::1aad) 41.809 ms 11 fra15s11-in-x13.1e100.net (2a00:1450:4001:814::2013) 41.802 ms 44.339 ms 29.161 ms Victor 2017-11-16 15:26 GMT+01:00 Victor Stinner : > Hi, > >> * gnutls_handshake() failed: Error in the pull function. > > It looks

[python-committers] Nickname changed from haypo to vstinner

2017-11-17 Thread Victor Stinner
Hub, please use @vstinner. That's all, sorry for the noise, Victor Stinner aka vstinner ;-) ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/

[python-committers] Requirements to get the "bug triage" permission?

2017-11-20 Thread Victor Stinner
Hi, I identified some active contributors and I would like to offer them to get the "bug triage" permission. What's the requirements to give such permissions to someone? On my "Different stages of core developers" "lader", it's the 3rd stage ("step"?): http://cpython-core-tutorial.readthedocs.io

Re: [python-committers] CLA indication on Github out of date?

2017-11-24 Thread Victor Stinner
His bugs.python.org account still says "Contributor Form Received: No". Maybe the people responsible to handle CLA are busy with Thanksgiving? Victor 2017-11-24 12:02 GMT+01:00 Antoine Pitrou : > > Hello, > > I forget... Who handles updating the Python CLA database? > One of our contributors app

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

2017-12-05 Thread Victor Stinner
Hi Guido, Since the typing module is out of my interest area, I didn't notice Ivan contributions, so it's hard for me to give an opinion. Should I understand that he will mostly contribute to the typing module? If (in the beginning?) we restrict him to the typing module, I will simply rely on you

Re: [python-committers] Requirements to get the "bug triage" permission?

2017-12-06 Thread Victor Stinner
Hi, Ok, thanks Ezio and David. I completed my list: https://github.com/vstinner/cpython_core_tutorial/blob/master/core_developer.rst#bug-tracker My initial question is to know if bug triage permission can be seen as a first "award" / "badge" to recognize that contributions of someone are useful.

[python-committers] Cheryl Sabella was promoted to get bug triage permission

2017-12-06 Thread Victor Stinner
Hi, To recognize the good contributions of Cheryl Sabella, I gave her the bug triage permission on bugs.python.org. (In practice, Ezio gave her the permission.) In the past, such "promotion" wasn't always advertized on python-committers, but my intent is to make our process more transparent and a

[python-committers] Sanyam Khurana has been promoted to get bug triage permission

2017-12-06 Thread Victor Stinner
Hi, To recognize the good contributions of Sanyam Khurana, I gave him the bug triage permission on bugs.python.org. (In practice, Ezio gave him the permission.) He already commited 9 changes into the master branch since April, 2017. Congrats Sanyam! Victor __

Re: [python-committers] Requirements to get the "bug triage" permission?

2017-12-06 Thread Victor Stinner
2017-12-06 18:41 GMT+01:00 R. David Murray : > s/loose/lose/ Oops, fixed, thanks. >> So do you think that it's bad idea to use triage as an award? Or is it >> just a matter of adjusting requirements? > > Yes I think it is a bad idea to "use it" as an award. It is not an > award, it is a function

Re: [python-committers] Requirements to get the "bug triage" permission?

2017-12-06 Thread Victor Stinner
2017-12-06 18:45 GMT+01:00 Ezio Melotti : > Depends on what you exactly mean with "award". See my reply to David. > If the contributor knows what they are doing and they > are helpful, we can "award" them with the triager bit, but this award > shouldn't be given for unrelated accomplishments. M

Re: [python-committers] Cheryl Sabella was promoted to get bug triage permission

2017-12-06 Thread Victor Stinner
2017-12-06 23:07 GMT+01:00 Cheryl Sabella : > Wow, this is a shock! I'm sorry, maybe I had to warn you before? ;-) > Thank you, Victor, Ezio, and everyone else. This is > such an amazing and welcoming community, so thank you for letting me be a > part of it. You're welcome. Victor

Re: [python-committers] Requirements to get the "bug triage" permission?

2017-12-06 Thread Victor Stinner
2017-12-06 23:35 GMT+01:00 Antoine Pitrou : > The real issue is not that the step is hard to climb, but that it is > hard to get people interested in climbing that step (and continue being > active afterwards, even though the step has been climbed). It is to get > people interested in the tasks an

[python-committers] Statistics: growth of core dev number vs growth of the code size/complexity

2017-12-06 Thread Victor Stinner
Hi, I wrote a quick & dirty parser to compute statistics on *new* CPython core developer per year using the following page as data: https://devguide.python.org/developers/ 2007: 15 2008: 19 2009: 11 2010: 20 2011: 12 2012: 9 2013: 4 2014: 10 2015: 2 2016: 5 2017: 2 Compare these numbers to Stéph

[python-committers] Promote Julien Palard as core developer

2017-12-06 Thread Victor Stinner
Hi, I propose to promote Julien Palard as a core developer. Julien Palard is leading the french translation of the Python documentation since 2 or 3 years. He spent a lot of time to try to get this translation online. Since he was unlucky on the python-ideas mailing list, I convinced him to write

[python-committers] RFC: Process to become a core developer

2017-12-07 Thread Victor Stinner
Hi, I'm working on a process to describe how a contributor becomes a core developer. The purpose is to be transparent, list "requirements" and responsabilities to the contributor, and have written rules to help to take a fair decision. This document is a draft. I chose to post it on python-commit

Re: [python-committers] Cheryl Sabella was promoted to get bug triage permission

2017-12-07 Thread Victor Stinner
2017-12-06 18:43 GMT+01:00 Victor Stinner : > FYI She pushed not less than 14 commits into the master branch since > August, 2017. Oops, I used the wrong command to count her number of commits. vstinner@apu$ git log --author='Cheryl Sabella'|grep ^commit|wc -l 14 In fact, she

Re: [python-committers] Requirements to get the "bug triage" permission?

2017-12-07 Thread Victor Stinner
(I tried to answer to all replies. Since I chose to reply in a single email, so I chose to reply to own initial email.) Hi, It seems like I didn't express my ideas with the right words and so misguided the discussion. I'm sorry about that. I wrote a full "promotion process" document where I tried

  1   2   3   4   5   6   >