Re: apache 2.2 support

2006-02-10 Thread Justin Erenkrantz
TUS_IS_SUCCESS(s) ((s) == APR_SUCCESS \ > || (s) == APR_OS_START_SYSERR + ERROR_SUCCESS) > > Anyway, this prompted be to look at cases where APR_STATUS_IS_SUCCESS() > is used. They are in connobject.c and filterobject.c. I noticed something that > may need to be looked at

Re: apache 2.2 support

2006-02-09 Thread Graham Dumpleton
Jim Gallacher wrote .. > Graham Dumpleton wrote: > > The next section of code has: > > > > b = APR_BRIGADE_FIRST(self->bb_in); > > > > if (b == APR_BRIGADE_SENTINEL(self->bb_in)) > > return PyString_FromString(""); > > > > Now I am assuming here that the check with APR_BRIGADE_SE

Re: apache 2.2 support

2006-02-09 Thread Jim Gallacher
See http://issues.apache.org/jira/browse/MODPYTHON-78. Anyway, this prompted be to look at cases where APR_STATUS_IS_SUCCESS() is used. They are in connobject.c and filterobject.c. I noticed something that may need to be looked at, not strictly related to Apache 2.2 support. This is that we just m

Re: apache 2.2 support

2006-02-09 Thread Graham Dumpleton
d something that may need to be looked at, not strictly related to Apache 2.2 support. This is that we just made change in connobject.c to check for initial empty bucket brigade and to loop when that occurred. This could have come about because of EGAIN on socket read. The EGAIN wasn't