Re: [Python-Dev] PEP 448 (almost finished!) — Question regarding test_ast

2015-01-23 Thread Walter Dörwald
On 22 Jan 2015, at 23:03, Neil Girdhar wrote: Thanks for taking a look. I looked at inspect and I can't see anything that needs to change since it's the caller rather than the receiver who has more options after this PEP. You are probably right. And for calling via Signature.bind() your pat

Re: [Python-Dev] PEP 448 (almost finished!) — Question regarding test_ast

2015-01-22 Thread Neil Girdhar
Thanks for taking a look. I looked at inspect and I can't see anything that needs to change since it's the caller rather than the receiver who has more options after this PEP. Did you see anything in particular? Best, Neil On Thu, Jan 22, 2015 at 12:23 PM, Walter Dörwald wrote: > On 20 Jan 2

Re: [Python-Dev] PEP 448 (almost finished!) — Question regarding test_ast

2015-01-22 Thread Walter Dörwald
On 20 Jan 2015, at 17:34, Neil Girdhar wrote: > My question first: > test_ast is mostly generated code, but I can't find where it is being > generated. I am pretty sure I know how to fix most of the introduced > problems. Who is generating test_ast?? > > Update: > > So far, I've done the followi

Re: [Python-Dev] PEP 448 (almost finished!) — Question regarding test_ast

2015-01-20 Thread Neil Girdhar
Okay, I think it's ready for a code review. Would anyone be kind enough to offer comments? On Tue, Jan 20, 2015 at 12:10 PM, Neil Girdhar wrote: > Thanks! > > On Tue, Jan 20, 2015 at 12:09 PM, Benjamin Peterson > wrote: > >> $ ./python Lib/test/test_ast.py -g >> exec_results = [ >> ('Module',

Re: [Python-Dev] PEP 448 (almost finished!) — Question regarding test_ast

2015-01-20 Thread Benjamin Peterson
$ ./python Lib/test/test_ast.py -g exec_results = [ ('Module', [('Expr', (1, 0), ('NameConstant', (1, 0), None))]), ('Module', [('FunctionDef', (1, 0), 'f', ('arguments', [], None, [], [], None, []), [('Pass', (1, 9))], [], None)]), ('Module', [('FunctionDef', (1, 0), 'f', ('arguments', [('arg', (1

Re: [Python-Dev] PEP 448 (almost finished!) — Question regarding test_ast

2015-01-20 Thread Neil Girdhar
Thanks! On Tue, Jan 20, 2015 at 12:09 PM, Benjamin Peterson wrote: > $ ./python Lib/test/test_ast.py -g > exec_results = [ > ('Module', [('Expr', (1, 0), ('NameConstant', (1, 0), None))]), > ('Module', [('FunctionDef', (1, 0), 'f', ('arguments', [], None, [], [], > None, []), [('Pass', (1, 9))],

Re: [Python-Dev] PEP 448 (almost finished!) — Question regarding test_ast

2015-01-20 Thread Neil Girdhar
Hi Benjamin, I'm having trouble finding where it is generating the lines below EVERYTHING BELOW IS GENERATED # Neither a call to test_ast nor a make (in case it's generated somewhere else) regenerate those lines if they have been removed. How were those lines generated? Best, Neil O

Re: [Python-Dev] PEP 448 (almost finished!) — Question regarding test_ast

2015-01-20 Thread Benjamin Peterson
On Tue, Jan 20, 2015, at 11:34, Neil Girdhar wrote: > My question first: > test_ast is mostly generated code, but I can't find where it is being > generated. I am pretty sure I know how to fix most of the introduced > problems. Who is generating test_ast?? It generates itself.

[Python-Dev] PEP 448 (almost finished!) — Question regarding test_ast

2015-01-20 Thread Neil Girdhar
My question first: test_ast is mostly generated code, but I can't find where it is being generated. I am pretty sure I know how to fix most of the introduced problems. Who is generating test_ast?? Update: So far, I've done the following: Updated the patch to 3.5 Fixed the grammar to accept fin