Hello
I've looked at one bug and a bunch of patches and
added a comment to them:
(bug) [ 1102649 ] pickle files should be opened in binary mode
Added a comment about a possible different solution
[ 946207 ] Non-blocking Socket Server
Useless, what are the mixins for? Recommend close
[ 756021 ] Allo
Below are a set of five patch reviews. I don't have any patch to push for at
this point, so these patch reviews are just for you to read and enjoy. Thanks
everybody for developing and maintaining Python. I wouldn't know what to do
without it.
--Michiel.
Patch [ 853890 ] Optional keyword unicode
If someone could take a look at:
[ 1069624 ] incomplete support for AF_PACKET in socketmodule.c
I have to ship my own patched copy of the socket module because of
this... :|
On Sun, 2005-01-16 at 17:08 +0100, Irmen de Jong wrote:
> Hello
> I've looked at one bug and a bunch of patches and
>
Gustavo J. A. M. Carneiro wrote:
If someone could take a look at:
[ 1069624 ] incomplete support for AF_PACKET in socketmodule.c
The rule applies: five reviews, with results posted to python-dev,
and I will review your patch.
Regards,
Martin
___
Python
On Mon, 2005-01-17 at 23:12 +0100, "Martin v. Löwis" wrote:
> Gustavo J. A. M. Carneiro wrote:
> > If someone could take a look at:
> >
> > [ 1069624 ] incomplete support for AF_PACKET in socketmodule.c
>
>
> The rule applies: five reviews, with results posted to python-dev,
> and I will revie
Gustavo J. A. M. Carneiro wrote:
Oh... sorry, I didn't know about any rules.
My apologies - I had announced this (personal) rule
a few times, so I thought everybody on python-dev knew.
If you really want to push a patch, you
can do so by doing your own share of work, namely by
reviewing other's p
Irmen de Jong wrote:
Hello
I've looked at one bug and a bunch of patches and
added a comment to them:
[...]
[ 579435 ] Shadow Password Support Module
Would be nice to have, I recently just couldn't do the user
authentication that I wanted: based on the users' unix passwords
I'm almost done with com
Irmen de Jong wrote:
1- I can't add new files to this tracker item.
Should I open a new patch and refer to it?
Depends on whether you want tracker admin access (i.e.
become a SF python project member). If you do,
you could attach patches to bug reports not
written by you.
2- As shadow passwords
Irmen de Jong wrote:
> 3- Should the order of the chapters in the documentation
>be preserved? I'd rather add spwd below pwd, but
>this pushes the other unix modules "1 down"...
On Tuesday 18 January 2005 17:17, Martin v. Löwis wrote:
> You could make it a subsection (e.g. "spwd -- sha
Martin,
Irmen de Jong wrote:
1- I can't add new files to this tracker item.
Should I open a new patch and refer to it?
Depends on whether you want tracker admin access (i.e.
become a SF python project member). If you do,
you could attach patches to bug reports not
written by you.
That sounds ve
[Martin asks whether Irmen wants to be a tracker admin on SF]
[Irmen de Jong]
> That sounds very convenient, thanks.
> Does the status of 'python project member' come with
> certain expectations that must be complied with ? ;-)
If you're using Python, you're already required to comply with all of
Martin v. Löwis wrote:
I think Brett Cannon now also follows this rule; it
really falls short enough in practice because (almost)
nobody really wants to push his patch bad enough to
put some work into it to review other patches.
Yes, I am trying to support the rule, but my schedule is nutty right n
Irmen de Jong wrote:
That sounds very convenient, thanks.
Ok, welcome to the project! Please let me know whether
it "works".
Does the status of 'python project member' come with
certain expectations that must be complied with ? ;-)
There are a few conventions that are followed more
or less stringen
[Martin v. Löwis]
...
> - Add an entry to Misc/NEWS, if there is a new feature,
> or if it is a bug fix for a maintenance branch
> (I personally don't list bug fixed in the HEAD revision,
> but others apparently do)
You should. In part this is to comply with license requirements:
we're a d
Tim Peters wrote:
It's also extremely useful in practice to have a list of repaired bugs
in NEWS!
I'm not convinced about that - it makes the NEWS file almost unreadable,
as the noise is now so high if every tiny change is listed; it is very
hard to see what the important changes are.
Regards,
Mart
[Tim Peters]
>> It's also extremely useful in practice to have a list of repaired
>> bugs in NEWS!
[Martin v. Löwis]
> I'm not convinced about that - it makes the NEWS file almost
> unreadable, as the noise is now so high if every tiny change is
> listed; it is very hard to see what the important
Tim Peters wrote:
My experience disagrees, and I gave a specific example from just the
last day. High-level coverage of the important bits is served (and
served well) by Andrew's "What's New in Python" doc. (Although I'll
note that when I did releases, I tried to sort section contents in
NEWS, to
Irmen de Jong wrote:
I've looked at one bug and a bunch of patches and
added a comment to them:
Thanks! I have now processed the ones for which I found guidance.
As for the remaining ones:
[ 756021 ] Allow socket.inet_aton('255.255.255.255') on Windows
Looks good but added suggestion about when to
Martin v. Löwis wrote:
> Irmen de Jong wrote:
>
>> I've looked at one bug and a bunch of patches and
>> added a comment to them:
>
>
> Thanks! I have now processed the ones for which I found guidance.
Thank you
> As for the remaining ones:
>
>> [ 756021 ] Allow socket.inet_aton('255.255.255.2
19 matches
Mail list logo
