Re: [Python-Dev] bpo-5001: More-informative multiprocessing error messages (#3079)

2017-08-29 Thread Serhiy Storchaka
30.08.17 01:52, Antoine Pitrou пише: https://github.com/python/cpython/commit/bd73e72b4a9f019be514954b1d40e64dc3a5e81c commit: bd73e72b4a9f019be514954b1d40e64dc3a5e81c branch: master author: Allen W. Smith, Ph.D committer: Antoine Pitrou date: 2017-08-30T00:52:18+02:00 summary: bpo-5001: More-

Re: [Python-Dev] bpo-5001: More-informative multiprocessing error messages (#3079)

2017-08-30 Thread Antoine Pitrou
On Wed, 30 Aug 2017 08:48:56 +0300 Serhiy Storchaka wrote: > 30.08.17 01:52, Antoine Pitrou пише: > > https://github.com/python/cpython/commit/bd73e72b4a9f019be514954b1d40e64dc3a5e81c > > commit: bd73e72b4a9f019be514954b1d40e64dc3a5e81c > > branch: master > > author: Allen W. Smith, Ph.D > > com

Re: [Python-Dev] bpo-5001: More-informative multiprocessing error messages (#3079)

2017-08-30 Thread Nick Coghlan
On 30 August 2017 at 19:39, Antoine Pitrou wrote: > On Wed, 30 Aug 2017 08:48:56 +0300 > Serhiy Storchaka wrote: >> Please, please don't forget to edit commit messages before merging. An >> excessively verbose commit message will be kept in the repository >> forever and will harm future developer

Re: [Python-Dev] bpo-5001: More-informative multiprocessing error messages (#3079)

2017-08-30 Thread Paul Moore
On 30 August 2017 at 10:48, Nick Coghlan wrote: > On 30 August 2017 at 19:39, Antoine Pitrou wrote: >> On Wed, 30 Aug 2017 08:48:56 +0300 >> Serhiy Storchaka wrote: >>> Please, please don't forget to edit commit messages before merging. An >>> excessively verbose commit message will be kept in t

Re: [Python-Dev] bpo-5001: More-informative multiprocessing error messages (#3079)

2017-08-31 Thread Brett Cannon
On Wed, 30 Aug 2017 at 02:56 Paul Moore wrote: > On 30 August 2017 at 10:48, Nick Coghlan wrote: > > On 30 August 2017 at 19:39, Antoine Pitrou wrote: > >> On Wed, 30 Aug 2017 08:48:56 +0300 > >> Serhiy Storchaka wrote: > >>> Please, please don't forget to edit commit messages before merging.

Re: [Python-Dev] bpo-5001: More-informative multiprocessing error messages (#3079)

2017-08-31 Thread Paul Moore
On 31 August 2017 at 20:27, Brett Cannon wrote: > So you would want a comment when the PR reaches "awaiting merge" with > instructions requesting the author do their own squash commit to simplify > the message for us? That would work. It could say that the PR consists of multiple commits and the

Re: [Python-Dev] bpo-5001: More-informative multiprocessing error messages (#3079)

2017-08-31 Thread Terry Reedy
On 8/31/2017 3:27 PM, Brett Cannon wrote: On Wed, 30 Aug 2017 at 02:56 Paul Moore do so to squash their PRs themselves. Personally, I'd prefer that as, apart from admin activities like making sure the PR and issue number references are present and correct, I think the original su