Re: [Python-Dev] buildno (Was: [Python-checkins] commit of r41907- python/trunk/Makefile.pre.in)

2006-01-05 Thread Barry Warsaw
On Thu, 2006-01-05 at 00:36 +0100, Martin v. Löwis wrote: The portable way would be to check for svnversion in configure, and then only use it if it was found. You could also check for .svn in configure, and generate the entire buildno generation. OTOH, I also think we should get rid of

Re: [Python-Dev] buildno (Was: [Python-checkins] commit of r41907- python/trunk/Makefile.pre.in)

2006-01-05 Thread Armin Rigo
Hi Martin, On Thu, Jan 05, 2006 at 12:36:40AM +0100, Martin v. L?wis wrote: OTOH, I also think we should get rid of buildno entirely. Instead, svnversion should be compiled into the object file, or, if it is absent, $Revision$ should be used; the release process should be updated to force a

Re: [Python-Dev] buildno (Was: [Python-checkins] commit of r41907- python/trunk/Makefile.pre.in)

2006-01-05 Thread Martin v. Löwis
Barry Warsaw wrote: I was working on a patch to add a PY_BUILDNO macro to Include/patchlevel.h, which would have $Revision$ as its value. As you can see, this is done now. The value appears at the Python level only for tags, though, because it will be unreliable for the trunk and for branches.

Re: [Python-Dev] buildno (Was: [Python-checkins] commit of r41907- python/trunk/Makefile.pre.in)

2006-01-05 Thread Barry Warsaw
On Fri, 2006-01-06 at 01:33 +0100, Martin v. Löwis wrote: As you can see, this is done now. The value appears at the Python level only for tags, though, because it will be unreliable for the trunk and for branches. Cool, thanks. I can chuck my local diffs now. :) patchlevel.h seems like

Re: [Python-Dev] buildno (Was: [Python-checkins] commit of r41907- python/trunk/Makefile.pre.in)

2006-01-05 Thread Martin v. Löwis
Barry Warsaw wrote: It would still be one level behind: patchlevel.h gets N, then 'svn cp' creates the tag, producing N+1. OTOH, for a tag, the revision number is nearly irrelevant. Unless we tagged and then modified the file in that tag as the very last thing we do before we create the

[Python-Dev] buildno (Was: [Python-checkins] commit of r41907- python/trunk/Makefile.pre.in)

2006-01-04 Thread Martin v. Löwis
Barry Warsaw wrote: Unfortunately, /usr/bin/type doesn't seem to accept the -t flag for me on Solaris 9. Okay, so what's the best (read: portable) way to do this? The portable way would be to check for svnversion in configure, and then only use it if it was found. You could also check for .svn