Re: [Python-Dev] cpython: PyUnicode_FromKindAndData() raises a ValueError if the kind is unknown

2011-10-06 Thread Stephen J. Turnbull
Éric Araujo writes: > Le 04/10/2011 04:59, Stephen J. Turnbull a écrit : > > I'm not familiar with the hg dev process (I use hg a lot, but so far > > it Just Works for me :), but I would imagine they will move in that > > direction as well. "That direction" being "ability to attach notes to e

Re: [Python-Dev] cpython: PyUnicode_FromKindAndData() raises a ValueError if the kind is unknown

2011-10-06 Thread Éric Araujo
Hi, Le 04/10/2011 04:59, Stephen J. Turnbull a écrit : > Currently, in hg. git has a mechanism for adding notes which are > automatically displayed along with the original commit message, and > bzr is considering introducing such a mechanism. Mercurial commits can contain an “extra” dictionary, b

Re: [Python-Dev] cpython: PyUnicode_FromKindAndData() raises a ValueError if the kind is unknown

2011-10-06 Thread Éric Araujo
Hi, Le 03/10/2011 23:38, Terry Reedy a écrit : > Is it both technically possible (with hg) and socially permissible (with > us) to edit another's commit message? Not easily. A changeset identifier is a hash of date, user, parent changesets hashes, commit message and diff content; editing the co

Re: [Python-Dev] cpython: PyUnicode_FromKindAndData() raises a ValueError if the kind is unknown

2011-10-03 Thread Stephen J. Turnbull
"Martin v. Löwis" writes: [Terry Reedy wrote:] > > Is it both technically possible (with hg) and socially permissible (with > > us) to edit another's commit message? > > It's not technically possible, Currently, in hg. git has a mechanism for adding notes which are automatically displayed

Re: [Python-Dev] cpython: PyUnicode_FromKindAndData() raises a ValueError if the kind is unknown

2011-10-03 Thread Victor Stinner
> > -assert(0); > > +PyErr_SetString(PyExc_ValueError, "invalid kind"); > > > > return NULL; > > > > } > > Is that really a ValueError? It should only be a ValueError if the user > could trigger that error. Otherwise it should be a SystemError. You are right, ValueError is not be

Re: [Python-Dev] cpython: PyUnicode_FromKindAndData() raises a ValueError if the kind is unknown

2011-10-03 Thread Martin v. Löwis
> Is it both technically possible (with hg) and socially permissible (with > us) to edit another's commit message? It's not technically possible, but it would be socially permissible to fix spelling mistakes. With hg, editing commit messages would require some sort of patch queue system, where th

Re: [Python-Dev] cpython: PyUnicode_FromKindAndData() raises a ValueError if the kind is unknown

2011-10-03 Thread Terry Reedy
On 10/3/2011 12:23 PM, "Martin v. Löwis" wrote: Am 02.10.2011 17:46, schrieb Benjamin Peterson: On 10/02/11 01:14, victor.stinner wrote: PyUnicode_FromKindAndData() raises a ValueError if the kind is unknown Also, could I remind you that a better commit message is probably "make PyUnicod

Re: [Python-Dev] cpython: PyUnicode_FromKindAndData() raises a ValueError if the kind is unknown

2011-10-03 Thread Stephen J. Turnbull
"Martin v. Löwis" writes: > > Also, could I remind you that a better commit message is probably > > "make PyUnicode_FromKindAndData raise a ValueError if the kind is > > unknown". > > I think this is asking too much. This distinction is important enough that it's worth asking non-native spe

Re: [Python-Dev] cpython: PyUnicode_FromKindAndData() raises a ValueError if the kind is unknown

2011-10-03 Thread Martin v. Löwis
Am 02.10.2011 17:46, schrieb Benjamin Peterson: > 2011/10/2 Georg Brandl : >> On 10/02/11 01:14, victor.stinner wrote: >>> http://hg.python.org/cpython/rev/9124a00df142 >>> changeset: 72573:9124a00df142 >>> parent: 72571:fa0b1e50270f >>> user:Victor Stinner >>> date:Sat Oct

Re: [Python-Dev] cpython: PyUnicode_FromKindAndData() raises a ValueError if the kind is unknown

2011-10-02 Thread Benjamin Peterson
2011/10/2 Georg Brandl : > On 10/02/11 01:14, victor.stinner wrote: >> http://hg.python.org/cpython/rev/9124a00df142 >> changeset:   72573:9124a00df142 >> parent:      72571:fa0b1e50270f >> user:        Victor Stinner >> date:        Sat Oct 01 23:48:37 2011 +0200 >> summary: >>   PyUnicode_FromKi

Re: [Python-Dev] cpython: PyUnicode_FromKindAndData() raises a ValueError if the kind is unknown

2011-10-02 Thread Georg Brandl
On 10/02/11 16:21, Georg Brandl wrote: > On 10/02/11 01:14, victor.stinner wrote: >> http://hg.python.org/cpython/rev/9124a00df142 >> changeset: 72573:9124a00df142 >> parent: 72571:fa0b1e50270f >> user:Victor Stinner >> date:Sat Oct 01 23:48:37 2011 +0200 >> summary: >> Py

Re: [Python-Dev] cpython: PyUnicode_FromKindAndData() raises a ValueError if the kind is unknown

2011-10-02 Thread Georg Brandl
On 10/02/11 01:14, victor.stinner wrote: > http://hg.python.org/cpython/rev/9124a00df142 > changeset: 72573:9124a00df142 > parent: 72571:fa0b1e50270f > user:Victor Stinner > date:Sat Oct 01 23:48:37 2011 +0200 > summary: > PyUnicode_FromKindAndData() raises a ValueError if