Re: ldap.open() SSL patch

2010-04-19 Thread Adam Tauno Williams
On Mon, 2010-04-19 at 12:12 -0300, ygormu...@dcc.ufba.br wrote: > Michael Ströder : > > Just raising DeprecationWarning exception breaks existing code. I have to > > reject your patch. ;-) > I understand. > > I've checked in a solution which only outputs a warning (just like > > md5.py does > > i

Re: ldap.open() SSL patch

2010-04-19 Thread ygormutti
Michael Ströder : > Just raising DeprecationWarning exception breaks existing code. I have to > reject your patch. ;-) I understand. > I've checked in a solution which only outputs a warning (just like > md5.py does > in recent Python releases). So old code should still work. I agree that thi

Re: ldap.open() SSL patch

2010-04-18 Thread Michael Ströder
ygormu...@dcc.ufba.br wrote: > Michael Ströder : > >> Yes, you're right. I would accept such a patch. ;-) >> >> At least it's documented: >> >> http://www.python-ldap.org/doc/html/ldap.html#ldap.open > > I was using ldap.open because there are many code samples where it's > still used, in the tub

Re: ldap.open() SSL patch

2010-04-17 Thread ygormutti
Michael Ströder : Yes, you're right. I would accept such a patch. ;-) At least it's documented: http://www.python-ldap.org/doc/html/ldap.html#ldap.open I was using ldap.open because there are many code samples where it's still used, in the tubes. The new patch is attached. I hope to cont

Re: ldap.open() SSL patch

2010-04-17 Thread Michael Ströder
ygormu...@dcc.ufba.br wrote: > Michael Ströder : > >> Using ldap.open() is deprecated for quite a while now. python-ldap >> applications still using this function should be fixed. > > In this case, I think ldap.open() must raise a DeprecationWarning. Don't > you? Yes, you're right. I would accep

Re: ldap.open() SSL patch

2010-04-17 Thread ygormutti
Michael Ströder : > Using ldap.open() is deprecated for quite a while now. python-ldap > applications still using this function should be fixed. In this case, I think ldap.open() must raise a DeprecationWarning. Don't you? -- Ygor Mutti (http://icaju.com - @Mamutti) --

Re: ldap.open() SSL patch

2010-04-17 Thread Michael Ströder
ygormu...@dcc.ufba.br wrote: > I'm a member of GrudeSL (Free Software Development Group) at UFBA > (Federal University of Bahia). We were trying to integrate our new > Django site authentication with the existing LDAP server, so we ran > for python-ldap and I can say it does its job very well

ldap.open() SSL patch

2010-04-17 Thread ygormutti
Hi, I'm a member of GrudeSL (Free Software Development Group) at UFBA (Federal University of Bahia). We were trying to integrate our new Django site authentication with the existing LDAP server, so we ran for python-ldap and I can say it does its job very well (thank you very much! :D). B