[issue17075] logging documentation for library cleanup

2013-01-29 Thread Aaron Sherman
New submission from Aaron Sherman: This documentation states that libraries can turn off logging by adding a NullHandler: http://docs.python.org/2/howto/logging.html#configuring-logging-for-a-library This is not entirely true. It only holds true if the application which calls the library has

[issue17076] shutil.copytree failing on xattr-less filesystems (like NFS)

2013-01-29 Thread Thomas Wouters
New submission from Thomas Wouters: The new xattr support in shutil causes shutil.copytree and shutil.copy2 to fail inelegantly on (source) filesystems that do not support xattrs (like NFS): # /home/twouters does not support xattrs os.listxattr(/home/twouters/foo) Traceback (most recent call

[issue12004] PyZipFile.writepy gives internal error on syntax errors

2013-01-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3a1ac42435f9 by Serhiy Storchaka in branch '3.2': Issue #12004: Fix an internal error in PyZipFile when writing an invalid http://hg.python.org/cpython/rev/3a1ac42435f9 New changeset 678320c7f63d by Serhiy Storchaka in branch '3.3': Issue #12004:

[issue12004] PyZipFile.writepy gives internal error on syntax errors

2013-01-29 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for the patch. -- resolution: - fixed stage: commit review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12004

[issue17074] (docs) Consistent formatting of constants

2013-01-29 Thread Chris Jerdonek
Chris Jerdonek added the comment: This has already been proposed in issue 15580. By the way, you don't always want to replace true with ``True``. The former has a different connotation/meaning which is boolean true rather than the object True. -- nosy: +chris.jerdonek resolution: -

[issue17074] (docs) Consistent formatting of constants

2013-01-29 Thread Zearin
Zearin added the comment: Ah; I did look for dupes, but didn’t find it. (So many issues…!) Thanks for pointing me in the right direction. By the way, you don't always want to replace true with ``True``. The former has a different connotation/meaning which is boolean true = rather than the

[issue17077] Fix test_tools hangs

2013-01-29 Thread Jeremy Kloth
New submission from Jeremy Kloth: Attached is a patch to test_tools that gets it back to a run-able state. -- components: Tests files: test_tools.diff keywords: patch messages: 180925 nosy: jkloth, serhiy.storchaka priority: normal severity: normal status: open title: Fix test_tools

[issue17071] Signature.bind() fails with a keyword argument named self

2013-01-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: Here is a patch. -- keywords: +patch Added file: http://bugs.python.org/file28900/sig_bind_self.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17071

[issue17075] logging documentation for library cleanup

2013-01-29 Thread Chris Jerdonek
Chris Jerdonek added the comment: This documentation states that libraries can turn off logging by adding a NullHandler: I don't think that's what the documentation says. It says, If for some reason you don’t want these messages printed *in the absence of any logging configuration* [my

[issue15580] fix True/False/None reST markup

2013-01-29 Thread Zearin
Zearin added the comment: I recently attempted to enhance the documentation in #17074. While I wasn’t linking all occurrences of True/False/None, I did mark them up as ``True``/``False``/``None``. Additionally, I made sure that these were (when appropriate) capitalized. I really disagree

[issue17074] (docs) Consistent formatting of constants

2013-01-29 Thread Chris Jerdonek
Chris Jerdonek added the comment: Yes, I know. I went through all the occurrences one by one, and I tried to take that into account. See issue 4945 for a discussion like this. Might be relevant to what you have in mind. -- ___ Python tracker

[issue17076] shutil.copytree failing on xattr-less filesystems (like NFS)

2013-01-29 Thread Antoine Pitrou
Changes by Antoine Pitrou pit...@free.fr: -- nosy: +hynek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17076 ___ ___ Python-bugs-list mailing

[issue4945] json checks True/False by identity, not boolean value

2013-01-29 Thread Zearin
Zearin added the comment: Note: Javascript has something analogous to Python’s ``==`` and ``is``. In JS: 0 == false true 0 === false false 1 == true true 1 === true false Perhaps this discrepancy could be fixed in the JSON processing? -- nosy: +zearin

[issue17074] (docs) Consistent formatting of constants

2013-01-29 Thread Chris Jerdonek
Chris Jerdonek added the comment: This has already been proposed in issue 15580. By the way, I should have said something along the same lines. Issue 15580 is about eliminating uses of :const:`None`, etc, whereas this targets a different case. But it is similar in scope so the same

[issue17074] (docs) Consistent formatting of constants

2013-01-29 Thread Zearin
Zearin added the comment: By the way, I should have said something along the same lines. Issue 15580 is about eliminating uses of :const:`None`, etc, whereas this targets a different case. But it is similar in scope so the same discussion/reasons apply. Yep! I read, and understood the

[issue15580] fix True/False/None reST markup

2013-01-29 Thread R. David Murray
R. David Murray added the comment: I prefer to have some of them be links and some of them be code markup. That is, I think there is value in having some of them be links. As Georg said, the devguide rule is more about it not being *necessary* to waste time marking them *all* up as

[issue17055] ftplib.ftpcp test

2013-01-29 Thread Łukasz Langa
Łukasz Langa added the comment: Thanks for your patch. A couple of remarks: - try to adhere to PEP 8 in your patches (most notably here: 80 characters per line, please). The rest of test_ftplib.py is also somewhat guilty in that regard but that shouldn't discourage you to do the right thing.

[issue15580] fix True/False/None reST markup

2013-01-29 Thread R. David Murray
R. David Murray added the comment: Note, by the way, that I apply the same rule to most link markup. If I refer to, say, a module name in a paragraph or set of related paragraphs multiple times, I will typically only mark up the first occurrence as a :mod: link. It's not a hard and fast

[issue4945] json checks True/False by identity, not boolean value

2013-01-29 Thread R. David Murray
R. David Murray added the comment: I would be very careful trying to reason by analogy there. ==, is, and javascripts === are rather different in detail, from what I understand. Nor do I see what javascript has to do with this issue :) As far as the remaining documentation issue here, IMO

[issue17071] Signature.bind() fails with a keyword argument named self

2013-01-29 Thread Yury Selivanov
Yury Selivanov added the comment: Thanks Antoine, the patch looks good to me. The only thing I would have done differently myself is to name self as __bind_self__ (with two underscores at the end). Could you please apply the patch? -- ___ Python

[issue17055] ftplib.ftpcp test

2013-01-29 Thread Michał Jastrzębski
Michał Jastrzębski added the comment: Hello, Thanks for tips. How about now? -- Added file: http://bugs.python.org/file28901/ftpcp_test.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17055

[issue15580] fix True/False/None reST markup

2013-01-29 Thread Chris Jerdonek
Chris Jerdonek added the comment: It might be worth clarifying in the devguide then if True/False/etc shouldn't be treated differently from other things. The current wording suggests that links shouldn't be used at all in those cases (e.g. given that they’re fundamental to the language and

[issue17075] logging documentation for library cleanup

2013-01-29 Thread R. David Murray
R. David Murray added the comment: Indeed. The whole point of that section is to explain how the library can refrain from spewing unwanted logging *if the application doesn't care about logging*. If the application does care (has configured logging), it would be wrong to block the logging.

[issue17055] ftplib.ftpcp test

2013-01-29 Thread Michał Jastrzębski
Michał Jastrzębski added the comment: My mistake, this one is better. -- Added file: http://bugs.python.org/file28902/ftpcp_test.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17055 ___

[issue17074] (docs) Consistent formatting of constants

2013-01-29 Thread Ezio Melotti
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17074 ___ ___

[issue15580] fix True/False/None reST markup

2013-01-29 Thread R. David Murray
R. David Murray added the comment: True. I disagree with the existing language, as I've indicated, but I'll leave it up to Georg as doc master. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15580

[issue15580] fix True/False/None reST markup

2013-01-29 Thread Ezio Melotti
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15580 ___ ___

[issue17071] Signature.bind() fails with a keyword argument named self

2013-01-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 49fd1c8aeca5 by Antoine Pitrou in branch '3.3': Issue #17071: Signature.bind() now works when one of the keyword arguments is named ``self``. http://hg.python.org/cpython/rev/49fd1c8aeca5 New changeset 4ff1dc8c0a3c by Antoine Pitrou in branch

[issue17071] Signature.bind() fails with a keyword argument named self

2013-01-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: Committed to 3.3 and default! -- resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17071

[issue17015] mock could be smarter and inspect the spec's signature

2013-01-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: Here is a new patch, making all assert_*_call methods work as well as autospeccing, and adding tests. Not sure I'm forgetting something else. -- Added file: http://bugs.python.org/file28903/issue17015-3.patch ___

[issue15505] unittest.installHandler incorrectly assumes SIGINT handler is set.

2013-01-29 Thread Thomas Wouters
Thomas Wouters added the comment: ping (you know why :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15505 ___ ___ Python-bugs-list mailing

[issue15505] unittest.installHandler incorrectly assumes SIGINT handler is set.

2013-01-29 Thread Antoine Pitrou
Changes by Antoine Pitrou pit...@free.fr: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15505 ___ ___ Python-bugs-list

[issue17076] shutil.copytree failing on xattr-less filesystems (like NFS)

2013-01-29 Thread Hynek Schlawack
Hynek Schlawack added the comment: Could you add regression tests to your patch please? -- assignee: - hynek priority: high - normal type: crash - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17076

[issue16694] Add pure Python operator module

2013-01-29 Thread Zachary Ware
Zachary Ware added the comment: Since the older Windows project files were removed, v10 removes the patches to them. Everything else still applies cleanly. Also, in the spirit of what Brett said in 16651 about not re-implementing blindly, I did just look up what Jython, IronPython, and PyPy

[issue17078] string.Template.safe_substitute hard-wires braces as {}

2013-01-29 Thread Adam Kellas
New submission from Adam Kellas: If you use safe_substitute and try to use a variable reference style other than ${foo}, you will find that it assumes ${foo} style. In particular, when evaluating $[foo] (square braces) and 'foo' is not defined, safe_substitute will put the string back

[issue16968] Fix test discovery for test_concurrent_futures.py

2013-01-29 Thread Zachary Ware
Zachary Ware added the comment: I failed to mention; v4 also removes setUpModule() which was present in the first 3 patches. With 16935 fixed, setUpModule would be unnecessary. -- ___ Python tracker rep...@bugs.python.org

[issue17071] Signature.bind() fails with a keyword argument named self

2013-01-29 Thread STINNER Victor
STINNER Victor added the comment: self doesn't need to have a name, you can use: def bind(*args, **kw): self = args[0] args = args[1:] To accept any name ;-) -- nosy: +haypo ___ Python tracker rep...@bugs.python.org

[issue17071] Signature.bind() fails with a keyword argument named self

2013-01-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: Indeed, there were several solutions to this. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17071 ___ ___

[issue16795] Patch: some changes to AST to make it more useful for static language analysis

2013-01-29 Thread Sven Brauch
Sven Brauch added the comment: Hm, I'm still getting the same error messages from the review tool which I described earlier; I can neither comment nor add patches. So, I'll have to abuse the bug report again: Thanks for the review. Is it possible you selected the wrong patch file for the

[issue17078] string.Template.safe_substitute hard-wires braces as {}

2013-01-29 Thread R. David Murray
Changes by R. David Murray rdmur...@bitdance.com: -- nosy: +barry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17078 ___ ___ Python-bugs-list

[issue17079] Fix test discovery for test_ctypes.py

2013-01-29 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- components: Tests files: test_ctypes_discovery.diff keywords: patch nosy: brett.cannon, ezio.melotti, zach.ware priority: normal severity: normal status: open title: Fix test discovery for test_ctypes.py type: behavior versions: Python

[issue17028] launcher does not read shebang line when arguments are given

2013-01-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0880e0f859e0 by Vinay Sajip in branch 'default': Closes #17028: Allowed Python arguments to be supplied to launcher. http://hg.python.org/cpython/rev/0880e0f859e0 -- nosy: +python-dev resolution: - fixed stage: patch review -

[issue15505] unittest.installHandler incorrectly assumes SIGINT handler is set.

2013-01-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7e4c5914ba76 by Michael Foord in branch '2.7': Issue 15505. unittest.installHandler and non callable signal handlers http://hg.python.org/cpython/rev/7e4c5914ba76 -- nosy: +python-dev ___ Python tracker

[issue15505] unittest.installHandler incorrectly assumes SIGINT handler is set.

2013-01-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 48c5c632d212 by Michael Foord in branch '3.2': Closes issue 15505. unittest.installHandler and non-callable signal handlers. http://hg.python.org/cpython/rev/48c5c632d212 -- resolution: - fixed stage: patch review - committed/rejected

[issue17036] Implementation of the PEP 433: Easier suppression of file descriptor inheritance

2013-01-29 Thread STINNER Victor
STINNER Victor added the comment: I tested bc88690df059.patch on Solaris 9: test_os failed on openpty(cloexec=True). It looks like setting close-on-exec on master_fd must be done after grantpt(). -- ___ Python tracker rep...@bugs.python.org

[issue17078] string.Template.safe_substitute hard-wires braces as {}

2013-01-29 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: See PEP 292 and the section titled Why `$' and Braces? http://www.python.org/dev/peps/pep-0292/ -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17078 ___

[issue14037] Allow grouping of argparse subparser commands in help output

2013-01-29 Thread Bartosz S
Changes by Bartosz S tosz...@gmail.com: -- nosy: +toszter ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14037 ___ ___ Python-bugs-list mailing

[issue14037] Allow grouping of argparse subparser commands in help output

2013-01-29 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- nosy: +chris.jerdonek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14037 ___ ___

[issue14039] Add metavar argument to add_subparsers() in argparse

2013-01-29 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- nosy: +chris.jerdonek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14039 ___ ___

[issue15633] httplib.response is not closed after all data has been read

2013-01-29 Thread Nikolaus Rath
Nikolaus Rath added the comment: Alright, it *finally* happened again. Attributes of the response object are: ._method: GET, .chunked: 0, .length: 9369540 .chunk_left: UNKNOWN, .status: 200 .reason OK, .version: 11, .will_close: False -- ___

[issue14039] Add metavar argument to add_subparsers() in argparse

2013-01-29 Thread Chris Jerdonek
Chris Jerdonek added the comment: Have you tried setting the metavar property on the return value of add_subparsers()? I tried this, and it seems to work. It looks like the logic for _metavar_formatter() is the same no matter what the action type (specifically _SubParsersAction in this

[issue14039] Add metavar argument to add_subparsers() in argparse

2013-01-29 Thread Chris Jerdonek
Chris Jerdonek added the comment: Actually, it looks like add_subparsers() may already support passing a metavar argument, but it's just not documented? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14039

[issue8491] Need readline command and keybinding information

2013-01-29 Thread Mitchell Model
Mitchell Model added the comment: Ping. I just noticed that this is still unresolved in the Python 3.3 docs. This should be closed, with or without my suggested change. -- versions: +Python 3.3 ___ Python tracker rep...@bugs.python.org

[issue6057] sqlite3 error classes should be documented

2013-01-29 Thread Mitchell Model
Mitchell Model added the comment: I still think the Exception class hierarchy should be described in the sqlite3 module documentation. Someone should decide one way or another and close this issue. -- ___ Python tracker rep...@bugs.python.org

[issue12883] xml.sax.xmlreader.AttributesImpl allows empty string as attribute names

2013-01-29 Thread Ramchandra Apte
Ramchandra Apte added the comment: bump... -- nosy: +ramchandra.apte ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12883 ___ ___ Python-bugs-list

[issue17077] Fix test_tools hangs

2013-01-29 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: On what platform it hangs? Note that communicate() currently works only with bytes on 3.2 (issue16903). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17077

[issue9536] defaultdict doc makes incorrect reference to __missing__ method

2013-01-29 Thread Ezio Melotti
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti status: pending - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9536 ___

[issue15633] httplib.response is not closed after all data has been read

2013-01-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: length: 9369540 indicates you haven't read the whole advertised Content-Length. Is it possible the server shuts down the TCP connection even before the whole Content-Length has been sent? -- ___ Python tracker

<    1   2