Change by hai shi :
--
pull_requests: +19941
pull_request: https://github.com/python/cpython/pull/20732
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
Thanks, Inada :)
--
___
Python tracker
<https://bugs.python.org/issue40898>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
keywords: +patch
pull_requests: +19907
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/20692
___
Python tracker
<https://bugs.python.org/issu
New submission from hai shi :
redundant if statements in itertools、_functools、_io, so remove it.
--
components: Extension Modules
messages: 370883
nosy: shihai1991
priority: normal
severity: normal
status: open
title: Remove redundant if statements in tp_traverse
versions: Python 3.10
Change by hai shi :
--
pull_requests: +19903
pull_request: https://github.com/python/cpython/pull/20689
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40521>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from hai shi :
petr have write a PR(adding a method: _PyType_GetModuleByDef) to supply pep573
in
https://github.com/encukou/cpython/pull/4/commits/98dd889575cf7d1688495983ba791e14894a0bb8
So I try to use pep573 in functools again in:
https://github.com/shihai1991/cpython/pull
Change by hai shi :
--
pull_requests: +19850
pull_request: https://github.com/python/cpython/pull/20625
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +19731
pull_request: https://github.com/python/cpython/pull/20482
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +19728
pull_request: https://github.com/python/cpython/pull/20479
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +19712
pull_request: https://github.com/python/cpython/pull/20459
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +19609
pull_request: https://github.com/python/cpython/pull/20344
___
Python tracker
<https://bugs.python.org/issue38
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40703>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +19549
pull_request: https://github.com/python/cpython/pull/20263
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +19504
pull_request: https://github.com/python/cpython/pull/20207
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
> Hai: do you want to work on a PR?
Oh, Looks like I am late, Christian have crated a PR ;)
--
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
pull_requests: +19436
pull_request: https://github.com/python/cpython/pull/20131
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
After PR20128, the import modules from 132 to 123.
--
___
Python tracker
<https://bugs.python.org/issue40275>
___
___
Python-bug
hai shi added the comment:
OK, I continue to reduce the import module in test.supports.
--
___
Python tracker
<https://bugs.python.org/issue40275>
___
___
Pytho
Change by hai shi :
--
pull_requests: +19433
pull_request: https://github.com/python/cpython/pull/20128
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
> It seems like there is coverage on both C and Python code.
Great, MAYBE we can use this coverage result to improve our testcases.
--
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
Hi, folks.
If there have no other imports should be improved, I suggest to close this bpo
;)
--
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
> I guess I'll need to clarify the documentation here.
> Call `PyType_GetModule` on the *defining class*, not on type(self).
+1, I didn't notice this detail until I got the error.
> The associated module is not inherited; each class in the MRO can be >
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40601>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
In PR19982, petr have mentioned that `PyType_GetModule` can not worked if the
type is the subtype.
I try to use pep573 in functools, I get the error info from testcases:
==
ERROR
Change by hai shi :
--
pull_requests: +19364
pull_request: https://github.com/python/cpython/pull/20055
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
> Note that __dictoffset__ and __weaklistoffset__ are also exposed as members
> (in PyMemberDef type_members) and documented (Doc/c-api/structures.rst). A
> new __vectorcalloffset__ should have that as well.
Thanks for your comment, petr. And I update
Change by hai shi :
--
keywords: +patch
pull_requests: +19336
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/20026
___
Python tracker
<https://bugs.python.org/issu
New submission from hai shi :
some typeobject using `tp_vectorcall_offset`, if we use
`PyType_FromModuleAndSpec` to create the the typeobject, it will be faild due
to `PyType_FromModuleAndSpec` lack the process of `tp_vectorcall_offset`.
so we should adding some process like
https
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40574>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
> That redirect just didn't exist yet :). It now does, and I went ahead and
> added it for 3.9 ahead of time.
Thanks, Zachary. It worked.
--
___
Python tracker
<https://bugs.python.org/i
Change by hai shi :
--
keywords: +patch
pull_requests: +19305
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19989
___
Python tracker
<https://bugs.python.org/issu
New submission from hai shi :
update the links of buildbot in CONTRIBUTING.rst.
I don't know why I can not visit `http://buildbot.python.org/3.8.stable/`
--
assignee: docs@python
components: Documentation
messages: 368422
nosy: docs@python, shihai1991
priority: normal
severity: normal
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40549>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +19296
pull_request: https://github.com/python/cpython/pull/19980
___
Python tracker
<https://bugs.python.org/issue38
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue38787>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40533>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40512>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
Thanks, Dong-hee Na ;)
--
___
Python tracker
<https://bugs.python.org/issue40520>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
Got it, thanks for your explanation, victor ;)
--
___
Python tracker
<https://bugs.python.org/issue40520>
___
___
Python-bugs-list m
Change by hai shi :
--
pull_requests: +19246
pull_request: https://github.com/python/cpython/pull/19931
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
keywords: +patch
pull_requests: +19245
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19930
___
Python tracker
<https://bugs.python.org/issu
New submission from hai shi :
Nick left a comment in `pydebug.h`
/* These global variable are defined in pylifecycle.c */
/* XXX (ncoghlan): move these declarations to pylifecycle.h? */
I have checked those global variables are not only debug variables and they are
defined in `Python
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40513>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +19220
pull_request: https://github.com/python/cpython/pull/19905
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
The easy way to fix this test case is that don't define the shared memory
block's name. `test_shared_memory_basics` has tested against the shared memory
block's name, so canceling the shared memory block'name has no side-effect
Change by hai shi :
--
keywords: +patch
nosy: +shihai1991
nosy_count: 1.0 -> 2.0
pull_requests: +19203
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19892
___
Python tracker
<https://bugs.python.org/i
Change by hai shi :
--
pull_requests: +19194
pull_request: https://github.com/python/cpython/pull/19882
___
Python tracker
<https://bugs.python.org/issue39
hai shi added the comment:
> Sadly (again), closing/reopening a PR re-runs all CIs. At the first run, GH
> Action macOS job passed. At the second run, the "Tests" step of GH Action
> macOS job, but I'm clueless with its logs: (...)
Oh, I encountered the same tro
Change by hai shi :
--
pull_requests: +19102
pull_request: https://github.com/python/cpython/pull/19761
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
> "since we are going to delete the threading.Thread object with its
> _tstate_lock object anyway" sentence is a description of the current
> _PyThreadState_DeleteExcept() implementation.
Oh, got it. thanks f
Change by hai shi :
--
pull_requests: +19041
pull_request: https://github.com/python/cpython/pull/19716
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
>since we are going to delete the threading.Thread object with its _tstate_lock
>object anymore.
Do we have any pep or discuss record about this plan?
> * Modify release_sentinel() to not use the lock: avoid
> PyThread_release_lock() call.
Hm, I
hai shi added the comment:
>It seems to behave as expected
+1. This is an interesting test;)
--
___
Python tracker
<https://bugs.python.org/issue40338>
___
_
hai shi added the comment:
> The historical background is code coverage of C code seemed like a good idea,
> so we set it up. :) Not much else to it.
Hm, code coverage of C code including two parts:
1) coverage of inner c code;
2) extension modules built by distutils;
If I unde
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40338>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +18952
pull_request: https://github.com/python/cpython/pull/19623
___
Python tracker
<https://bugs.python.org/issue39
hai shi added the comment:
I found this warning too(ps: my gcc is 9.3.0 ;)
Can we add a inner macro like `_unused(var) (void) var`?
Hi, serhiy, can you give us some advice?
--
___
Python tracker
<https://bugs.python.org/issue39
Change by hai shi :
--
keywords: +patch
nosy: +shihai1991
nosy_count: 2.0 -> 3.0
pull_requests: +18947
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19615
___
Python tracker
<https://bugs.python.org/i
hai shi added the comment:
> I used -X importtime.
copy that, thanks.
In master branch:
import time: 5011 | 133562 | test.support
After apply serhiy's patches:
import time: 4863 | 66940 | test.support
--
___
Python trac
hai shi added the comment:
> These three PRs combined reduce the number of imported modules from 179 to
> 105 (not including 24 modules imported by the bare interpreter) and reduce
> the hot import time from 160 ms to 80 ms.
Good job, serhiy. I tested your patches in my vm, t
Change by hai shi :
--
pull_requests: +18935
pull_request: https://github.com/python/cpython/pull/19599
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
> asyncio is now imported in unittest. Removing direct import from test.support
> does not help.
Oh, thanks, you are right. Looks like we need check which submodules should be
splitted.
--
___
Python tracker
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40284>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
> "import test.support" imports not less than 171... That's quite "heavy".
If we split some "heavy" modules to xxxutils, what benefits will we make in
fact(more exact module importing behavior)?
--
_
Change by hai shi :
--
keywords: +patch
nosy: +shihai1991
nosy_count: 1.0 -> 2.0
pull_requests: +18929
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19592
___
Python tracker
<https://bugs.python.org/i
hai shi added the comment:
> Hai: if you want to move on this issue, you have to find who uses this CI and
> how it should behave.
Copy that. I found PR7773 updated the travis' coverage ci and a discussion
issue in https://github.com/python/core-workflow/issues/2, so I add brett and
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40092>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40294>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
> It never prevented anyone to use a function of the C API :-)
Got it. If possible someone uses it, I will try to add a function to repalce
it(MAYBE udpate this docs too;) )
--
___
Python tracker
<
Change by hai shi :
--
pull_requests: +18889
pull_request: https://github.com/python/cpython/pull/19541
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
> Py_TRASHCAN_BEGIN() access directly PyTypeObject.tp_dealloc
Looks like this macro not recorded in docs. Do we need using function to
replace this macro?
--
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40255>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
If I understand correctly, `p->depth--` associated with `p->error` could be
removed?
--
___
Python tracker
<https://bugs.python.org/i
Change by hai shi :
--
keywords: +patch
nosy: +shihai1991
nosy_count: 2.0 -> 3.0
pull_requests: +18836
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19482
___
Python tracker
<https://bugs.python.org/i
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40221>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
Got some compiling error of _ssl extension module in my vm after PR19082 merged:
building '_ssl' extension
gcc -pthread -Wno-unused-result -Wsign-compare -g -Og -Wall -fPIC -I./Include
-I. -I/usr/local/include -I/temp/shihai/cpython/Include -I/temp/shihai/cpython
-c
hai shi added the comment:
FWIW, gcc Instrumentation Options in
https://gcc.gnu.org/onlinedocs/gcc/Instrumentation-Options.html
--
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
After `CFLAGS` replcaced by `CFLAGS_NODIST`, some extension module built
failed, some info like:
*** WARNING: renaming "_struct" since importing it failed:
build/lib.linux-x86_64-3.9/_struct.cpython-39-x86_64-linux-gnu.so: undefined
symbol: __gcov
Change by hai shi :
--
pull_requests: +18819
pull_request: https://github.com/python/cpython/pull/19464
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
> This macro should be converted to an opaque function
Can I try it?
--
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
> Looks like it worked.
Oh, sorry, I checked the wrong gate.
--
___
Python tracker
<https://bugs.python.org/issue40237>
___
___
Py
hai shi added the comment:
> Maybe CFLAGS_NODIST should be used instead of CFLAGS.
Looks like it worked.
> Python is built GCC with -ftest-coverage option.
More exact description is: Python is built GCC with --coverage option,
--coverage option including -ftest-coverage
Change by hai shi :
--
keywords: +patch
pull_requests: +18816
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19460
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40237>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +18792
pull_request: https://github.com/python/cpython/pull/19438
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40149>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40217>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
> I *think* the problem is that in the step where _save_and_remove_module is
> called on fresh_name (see here:
> https://github.com/python/cpython/blob/76db37b1d37a9daadd9e5b320f2d5a53cd1352ec/Lib/test/support/__init__.py#L328-L329)
Looks like deleting
Change by hai shi :
--
keywords: +patch
pull_requests: +18754
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19390
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40173>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40170>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +18708
pull_request: https://github.com/python/cpython/pull/19344
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +18705
pull_request: https://github.com/python/cpython/pull/19341
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +18669
pull_request: https://github.com/python/cpython/pull/19307
___
Python tracker
<https://bugs.python.org/issue1635
hai shi added the comment:
> The PR modify the resource module. Oh. H. I see :-D
Do I miss something?
--
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40144>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40137>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +18610
pull_request: https://github.com/python/cpython/pull/19252
___
Python tracker
<https://bugs.python.org/issue1635
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40077>
___
___
Python-bugs-list mailing list
Unsubscribe:
301 - 400 of 700 matches
Mail list logo