[issue24840] implement bool conversion for enums to prevent odd edge case

2015-08-11 Thread Mike Lundy
Mike Lundy added the comment: @serhiy.storchaka: It's somewhat of a special case, to be sure. However, I do think it's justified to put it into the base (rather than a user type) for three reasons: 1) It makes IntEnum and Enum consistent. IntEnum actually already handles this case just fine

[issue24840] implement bool conversion for enums to prevent odd edge case

2015-08-10 Thread Mike Lundy
New submission from Mike Lundy: There's a slightly odd edge case which can be summarized as follows: from enum import Enum class Bool(Enum): Yep = True Nope = False for value in Bool: print('%18r is %r' % (value, bool(value))) output

[issue24840] implement bool conversion for enums to prevent odd edge case

2015-08-10 Thread Mike Lundy
Mike Lundy added the comment: (I should note that I just recently signed the contributor agreement, not that this a particularly complex fix, but it hasn't propagated to my profile yet). -- ___ Python tracker rep...@bugs.python.org http

[issue24840] implement bool conversion for enums to prevent odd edge case

2015-08-10 Thread Mike Lundy
Mike Lundy added the comment: @r.david.murray man you're fast :) Sorry, realized I forgot to actually run the tests for 3.5 and 3.4, I'd only run them for master (I've now run them for 3.5 and 3.4 now, too). -- keywords: +patch Added file: http://bugs.python.org/file40160/issue24840

[issue17795] backwards-incompatible change in SysLogHandler with unix domain sockets

2013-04-21 Thread Mike Lundy
Mike Lundy added the comment: I've tested in our full dev setup, and it seems to work fine; I've also tested on my laptop, no problems there either. Unfortunately, that's python 2.7.4 in both cases. I don't really have a python3 setup I can bump up to test

[issue17795] backwards-incompatible change in SysLogHandler with unix domain sockets

2013-04-20 Thread Mike Lundy
Mike Lundy added the comment: It doesn't fix it unless I change the configuration (and in some cases the code) for every SyslogHandler across all of our projects, plus every single library we use. Google around For SysLogHandler /dev/log socktype and then compare with SysLogHandler /dev/log

[issue17795] backwards-incompatible change in SysLogHandler with unix domain sockets

2013-04-20 Thread Mike Lundy
Mike Lundy added the comment: On top of your patch? Yeah, I think so. (I wrote it the way I did so it could handle syslog configuration changes, but that's kind of an uncommon case). Thanks! -- ___ Python tracker rep...@bugs.python.org http

[issue17795] backwards-incompatible change in SysLogHandler with unix domain sockets

2013-04-19 Thread Mike Lundy
New submission from Mike Lundy: The changed merged from http://bugs.python.org/issue16168 causes a regression in SysLogHandler behavior. The socktype of /dev/log is dependent on syslog configuration, and the fallback behavior (trying SOCK_DGRAM and then SOCK_STREAM if the former failed