[issue39611] PyVectorcall_NARGS(): change return type to Py_ssize_t

2020-02-18 Thread Petr Viktorin
Petr Viktorin added the comment: The current return type already is Py_ssize_t, exactly for the reason you mention – compatibility with all other "argument count" values in Python. (It would be more correct to use unsigned, but that ship has sailed.) The *argument* type is unsig

[issue39245] Public API for Vectorcall (PEP 590)

2020-02-18 Thread Petr Viktorin
Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38644] Pass explicitly tstate to function calls

2020-02-11 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset f3fda374685dffa31ebda9e681e00ef7032b8a1d by Victor Stinner in branch 'master': bpo-38644: Rephrase What's New entry (GH-18461) https://github.com/python/cpython/commit/f3fda374685dffa31ebda9e681e00ef7032b8a1d -- nosy: +petr.viktorin

[issue39245] Public API for Vectorcall (PEP 590)

2020-02-11 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset ffd9753a944916ced659b2c77aebe66a6c9fbab5 by Petr Viktorin in branch 'master': bpo-39245: Switch to public API for Vectorcall (GH-18460) https://github.com/python/cpython/commit/ffd9753a944916ced659b2c77aebe66a6c9fbab5

[issue37207] Use PEP 590 vectorcall to speed up calls to range(), list() and dict()

2020-02-11 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +17837 pull_request: https://github.com/python/cpython/pull/18464 ___ Python tracker <https://bugs.python.org/issue37

[issue39245] Public API for Vectorcall (PEP 590)

2020-02-11 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +17834 pull_request: https://github.com/python/cpython/pull/18460 ___ Python tracker <https://bugs.python.org/issue39

[issue39432] Distutils generates the wrong export symbol for unicode module names

2020-02-11 Thread Petr Viktorin
Petr Viktorin added the comment: I'm with Stefan on "Definitely 3.8". It's a bug fix (for a rarely used feature). -- ___ Python tracker <https://bugs.python.o

[issue16776] Document PyCFunction_New and PyCFunction_NewEx functions

2020-02-04 Thread Petr Viktorin
Petr Viktorin added the comment: IMO, PyCFunction* should be a CPython-specific implementation detail: alternate implementations of the C-API don't need to support them, and extension authors should be fine without using them. (And if not, more efforts like PEP 590 Vectorcall should make

[issue31826] Misleading __version__ attribute of modules in standard library

2020-02-04 Thread Petr Viktorin
Change by Petr Viktorin : -- stage: patch review -> needs patch ___ Python tracker <https://bugs.python.org/issue31826> ___ ___ Python-bugs-list mai

[issue31826] Misleading __version__ attribute of modules in standard library

2020-02-04 Thread Petr Viktorin
Petr Viktorin added the comment: PR for removing __version__ from mock: https://github.com/python/cpython/pull/17977 -- nosy: +petr.viktorin ___ Python tracker <https://bugs.python.org/issue31

[issue39465] Design a subinterpreter friendly alternative to _Py_IDENTIFIER

2020-01-30 Thread Petr Viktorin
Petr Viktorin added the comment: > What is the problem between _Py_IDENTIFIER and multi-phase initialisation > modules? AFAIK there is no problem now, except possibly a race condition when initializing the identifiers. It seems it's too easy to conflate porting to multi-phase initiali

[issue38960] DTrace FreeBSD build fix

2020-01-28 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset aabdeb766b7fa581e7de01f3c953b12792f0736d by Petr Viktorin (David Carlier) in branch 'master': bpo-38960: DTrace build fix for FreeBSD. (GH-17451) https://github.com/python/cpython/commit/aabdeb766b7fa581e7de01f3c953b12792f0736d -- nosy

[issue39033] zipimport raises NameError: name '_boostrap_external' is not defined

2020-01-14 Thread Petr Viktorin
Petr Viktorin added the comment: Thank you, Mihail and Karthikeyan! -- nosy: +petr.viktorin stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/i

[issue39161] Py_NewInterpreter docs need updating for multi-phase initialization

2020-01-09 Thread Petr Viktorin
Change by Petr Viktorin : -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue39161> ___ ___ Pyth

[issue34033] distutils is not reproducible

2020-01-08 Thread Petr Viktorin
Petr Viktorin added the comment: > There is also one aspect where i586 builds end up with different .pyc files > than x86_64 builds. And then we randomly chose one of them for our "noarch" > python module packages and hope they work everywhere (including on arm and &

[issue39161] Py_NewInterpreter docs need updating for multi-phase initialization

2020-01-07 Thread Petr Viktorin
Change by Petr Viktorin : -- keywords: +patch pull_requests: +17312 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/17896 ___ Python tracker <https://bugs.python.org/issu

[issue37194] Move new vector private declarations to the internal C API

2020-01-07 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +17311 pull_request: https://github.com/python/cpython/pull/17893 ___ Python tracker <https://bugs.python.org/issue37

[issue37194] Move new vector private declarations to the internal C API

2020-01-07 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +17306 pull_request: https://github.com/python/cpython/pull/17896 ___ Python tracker <https://bugs.python.org/issue37

[issue39161] Py_NewInterpreter docs need updating for multi-phase initialization

2020-01-07 Thread Petr Viktorin
Petr Viktorin added the comment: Thanks for the report. I'll draft something better. -- ___ Python tracker <https://bugs.python.org/issue39161> ___ ___ Pytho

[issue39245] Public API for Vectorcall (PEP 590)

2020-01-07 Thread Petr Viktorin
Change by Petr Viktorin : -- keywords: +patch pull_requests: +17303 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17893 ___ Python tracker <https://bugs.python.org/issu

[issue39245] Public API for Vectorcall (PEP 590)

2020-01-07 Thread Petr Viktorin
Change by Petr Viktorin : -- components: +C API versions: +Python 3.9 ___ Python tracker <https://bugs.python.org/issue39245> ___ ___ Python-bugs-list mailin

[issue36974] Implement PEP 590

2020-01-07 Thread Petr Viktorin
Petr Viktorin added the comment: issue39245 tracks making the API public in Python 3.9. -- ___ Python tracker <https://bugs.python.org/issue36974> ___ ___ Pytho

[issue39245] Public API for Vectorcall (PEP 590)

2020-01-07 Thread Petr Viktorin
New submission from Petr Viktorin : As per PEP 590, in Python 3.9 the Vectorcall API will be public, i.e. without leading underscores. -- messages: 359506 nosy: petr.viktorin priority: normal severity: normal status: open title: Public API for Vectorcall (PEP 590

[issue39016] Negative Refcount in Python 3.8

2019-12-11 Thread Petr Viktorin
Petr Viktorin added the comment: Thanks! (note: unfortunately I'll probably not have time for CPython until next week, but further investigation is on my list.) -- ___ Python tracker <https://bugs.python.org/issue39

[issue39016] Negative Refcount in Python 3.8

2019-12-11 Thread Petr Viktorin
Petr Viktorin added the comment: The goal now should be to find a reasonably small reproducer. I'm trying to compile PySide to see what it does, but it's a big project and I'm a bit lost. Christian, you said in an e-mail that you have a workaround -- unsetting

[issue39016] Negative Refcount in Python 3.8

2019-12-11 Thread Petr Viktorin
Petr Viktorin added the comment: lookup_maybe_method should not return a borrowed reference. It increfs its return value. -- nosy: +petr.viktorin ___ Python tracker <https://bugs.python.org/issue39

[issue28866] Type cache is not correctly invalidated on a class defining mro()

2019-12-11 Thread Petr Viktorin
Petr Viktorin added the comment: Steve, I would like to add your reproducer (weird.py) to CPython's test suite, to make sure this doesn't happen again. Would you be willing to sign the contributor agreement, so we can use your code in Python? The instructions are here: https

[issue28866] Type cache is not correctly invalidated on a class defining mro()

2019-12-11 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +17047 pull_request: https://github.com/python/cpython/pull/17573 ___ Python tracker <https://bugs.python.org/issue28

[issue28866] Type cache is not correctly invalidated on a class defining mro()

2019-12-11 Thread Petr Viktorin
Petr Viktorin added the comment: A refcount problem possibly caused by the fix: https://bugs.python.org/issue39016 -- nosy: +petr.viktorin ___ Python tracker <https://bugs.python.org/issue28

[issue37096] Add large-file tests for modules using sendfile(2)

2019-12-05 Thread Petr Viktorin
Petr Viktorin added the comment: The test passes with a 8GB /tmp, but not a 6GB one. That could suggest the test needs 3*2GB disk space for temporary files, plus something extra. -- ___ Python tracker <https://bugs.python.org/issue37

[issue37096] Add large-file tests for modules using sendfile(2)

2019-12-05 Thread Petr Viktorin
Petr Viktorin added the comment: It seems that the test actually requires >4GB disk space, because it's copying a 2GB file from one place to another. Also, it's using a temporary directory. On Fedora /tmp is memory-backed by default, it doesn't use regular disk space. -- n

[issue38270] Tests: Avoid MD5 or check for MD5 availablity

2019-11-27 Thread Petr Viktorin
Petr Viktorin added the comment: The change silently disables 2 tests, see comment here: https://github.com/python/cpython/commit/66cd041df8dfadd001ae298292e16f0271c0d139#diff-ba7d7a4a1a0050e1f497b71b5cd50afcR365 (I think it's better to reopen this bug, than to open a new one, so all

[issue38421] email.utils.parsetime_tz does not return "None" as the tz offset

2019-11-12 Thread Petr Viktorin
Petr Viktorin added the comment: Thank you for the fix! -- nosy: +petr.viktorin resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38706] What should the error message in the exception raised by assertTrue and assertFalse be?

2019-11-07 Thread Petr Viktorin
Petr Viktorin added the comment: Generally, „true“ and „false“ refer to „truthiness“, while the actual ``True`` and ``False`` literals should be capitalized. And in monospace font if possible. I think this is a good convention, but it's quite subtle, and I don't think it's explicitly

[issue37645] Replace PyEval_GetFuncName/PyEval_GetFuncDesc

2019-11-06 Thread Petr Viktorin
Petr Viktorin added the comment: With this change, CPython no longer uses PyEval_GetFuncName/PyEval_GetFuncDesc internally. Shall we deprecate/discourage them? Shall we expose PyObject_FunctionStr publicly? -- ___ Python tracker <ht

[issue38159] PyState_AddModule docs should say that it's not necessary to call it.

2019-11-06 Thread Petr Viktorin
Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue35381] posixmodule: convert statically allocated types (DirEntryType & ScandirIteratorType) to heap-allocated types

2019-11-06 Thread Petr Viktorin
Petr Viktorin added the comment: The module still uses tp_new directly, so it's not limited to only stable ABI, but that's for another issue. Thanks for the contribution! -- nosy: +petr.viktorin resolution: -> fixed stage: patch review -> resolved status: open -&g

[issue38159] PyState_AddModule docs should say that it's not necessary to call it.

2019-11-01 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 9bc94eca0c69a551f928692364a99e9b67c4a45b by Petr Viktorin in branch 'master': bpo-38159: Clarify documentation of PyState_AddModule (GH-16101) https://github.com/python/cpython/commit/9bc94eca0c69a551f928692364a99e9b67c4a45b

[issue38007] Regression: name of PyType_Spec::slots conflicts with Qt macro

2019-10-22 Thread Petr Viktorin
Change by Petr Viktorin : -- nosy: +petr.viktorin ___ Python tracker <https://bugs.python.org/issue38007> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x

2019-10-15 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset eb1dda2b56f67f09352c303588c28880c471ae87 by Petr Viktorin (Victor Stinner) in branch 'master': bpo-38470: Fix test_compileall.test_compile_dir_maxlevels() (GH-16789) https://github.com/python/cpython/commit

[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x

2019-10-14 Thread Petr Viktorin
Petr Viktorin added the comment: If someone has access to Windows and can reproduce this (you need a more special setup than "just Windows"), and you want to spend some time debugging, please do. I'm shooting in the dark. My proposed patch limits the maximum path depth to 20 d

[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x

2019-10-14 Thread Petr Viktorin
Change by Petr Viktorin : -- keywords: +patch pull_requests: +16340 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16778 ___ Python tracker <https://bugs.python.org/issu

[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x

2019-10-14 Thread Petr Viktorin
Petr Viktorin added the comment: Oh! Sorry, I thought I saw green bots, and haven't looked since. I should have time for this tomorrow. If that's too late, remove/skip test_compile_dir_maxlevels on Windows. (The feature was untested before, and the 3.9 enhancement added test coverage, so I

[issue38140] Py_tp_dictoffset / Py_tp_finalize are unsettable in stable API

2019-10-08 Thread Petr Viktorin
Petr Viktorin added the comment: Thank you all! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37879] Segfaults in C heap type subclasses

2019-10-08 Thread Petr Viktorin
Petr Viktorin added the comment: Thanks to Stéphane and Eddie for fixing the refleak! -- resolution: -> fixed status: open -> closed ___ Python tracker <https://bugs.python.org/i

[issue33714] module can set an exception in tp_clear

2019-10-08 Thread Petr Viktorin
Petr Viktorin added the comment: Indeed, it can be closed. Thanks Serhiy for the better error message! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38160] Add a "PyInterpreterState *" field to PyTypeObject.

2019-09-27 Thread Petr Viktorin
Petr Viktorin added the comment: > only if PEP 573 makes it *compulsory* for heap types to contain a pointer to > their module And that's impossible without either breaking API (or some hackery). PyType_FromSpec doesn't get the information, and it can be easily outside module initiali

[issue38112] Compileall improvements

2019-09-26 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +15999 pull_request: https://github.com/python/cpython/pull/16419 ___ Python tracker <https://bugs.python.org/issue38

[issue38112] Compileall improvements

2019-09-26 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 4267c989e7fc6cd528e8a1d04a07fac5cca85ec7 by Petr Viktorin in branch 'master': bpo-38112: compileall: Skip long path path on Windows if the path can't be created (GH-16414) https://github.com/python/cpython/commit

[issue38112] Compileall improvements

2019-09-26 Thread Petr Viktorin
Petr Viktorin added the comment: Thanks! The buildbot complained in the pull request a while ago; I commented there that I'm looking into it. I'd appreciate a review for the fix; I don't have a good way to test it other than offer it to the buildbots

[issue38112] Compileall improvements

2019-09-26 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +15994 pull_request: https://github.com/python/cpython/pull/16414 ___ Python tracker <https://bugs.python.org/issue38

[issue38112] Compileall improvements

2019-09-26 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 8e7bb991de7c88583bc6663d8bbc541054ca8dc4 by Petr Viktorin (Lumír 'Frenzy' Balhar) in branch 'master': bpo-38112: Compileall improvements (GH-16012) https://github.com/python/cpython/commit/8e7bb991de7c88583bc6663d8bbc541054ca8dc4

[issue38140] Py_tp_dictoffset / Py_tp_finalize are unsettable in stable API

2019-09-25 Thread Petr Viktorin
Petr Viktorin added the comment: This line in _tesctcapimodule.c: {"__dictoffset__", T_PYSSIZET, -sizeof(void*), READONLY}, gives a legitimate-sounding warning on a Windows buildbot: d:\buildarea\3.x.ware-win81-release.nondebug\build\modules\_testcapimodule.c(6409)

[issue38273] Got an compile failed info about typeobject.c

2019-09-25 Thread Petr Viktorin
Petr Viktorin added the comment: How are you building Python? Could you share your configure/make commands? -- nosy: +petr.viktorin ___ Python tracker <https://bugs.python.org/issue38

[issue38140] Py_tp_dictoffset / Py_tp_finalize are unsettable in stable API

2019-09-25 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 468f8a6ee0d83e36795bbab6f20037b0e380f493 by Petr Viktorin in branch 'master': bpo-38140: Document offsets in PyMemberDef (GH-16354) https://github.com/python/cpython/commit/468f8a6ee0d83e36795bbab6f20037b0e380f493

[issue38140] Py_tp_dictoffset / Py_tp_finalize are unsettable in stable API

2019-09-24 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +15934 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/16354 ___ Python tracker <https://bugs.python.org/issu

[issue38140] Py_tp_dictoffset / Py_tp_finalize are unsettable in stable API

2019-09-24 Thread Petr Viktorin
Petr Viktorin added the comment: Thanks for the feature! This still needs documentation, however. -- resolution: fixed -> status: closed -> open ___ Python tracker <https://bugs.python.org/i

[issue38160] Add a "PyInterpreterState *" field to PyTypeObject.

2019-09-13 Thread Petr Viktorin
Petr Viktorin added the comment: PEP 573 already proposes adding a pointer to the *module* to heap types (well, those that opt in). We should rather add a pointer from *modules* to the interpreter state. -- ___ Python tracker <ht

[issue38159] PyState_AddModule docs should say that it's not necessary to call it.

2019-09-13 Thread Petr Viktorin
Change by Petr Viktorin : -- keywords: +patch pull_requests: +15720 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16101 ___ Python tracker <https://bugs.python.org/issu

[issue38159] PyState_AddModule docs should say that it's not necessary to call it.

2019-09-13 Thread Petr Viktorin
New submission from Petr Viktorin : I've seen extension modules calling PyState_AddModule on init, despite Python doing this automatically. It should be clarified that PyState_AddModule is for people who are writing alternative ways of creating/registering module objects

[issue18710] Add PyState_GetModuleAttr

2019-09-13 Thread Petr Viktorin
Petr Viktorin added the comment: PEP 573 proposes an alternative to PyState_FindModule. -- nosy: +petr.viktorin ___ Python tracker <https://bugs.python.org/issue18

[issue16690] Reference leak with custom tp_dealloc in PyType_FromSpec

2019-09-12 Thread Petr Viktorin
Petr Viktorin added the comment: This is fixed in Python 3.5+. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37012] Possible crash due to PyType_FromSpecWithBases()

2019-09-12 Thread Petr Viktorin
Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37090] test_gdb's test_pycfunction should test all calling conventions

2019-09-12 Thread Petr Viktorin
Petr Viktorin added the comment: Fixed here and in https://bugs.python.org/issue37499 ( https://github.com/python/cpython/pull/15776 ) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracke

[issue37879] Segfaults in C heap type subclasses

2019-09-12 Thread Petr Viktorin
Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37879] Segfaults in C heap type subclasses

2019-09-12 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 3562ae25402aad36583bc27d4d82c67554323d5e by Petr Viktorin in branch '3.8': [3.8] bpo-37879: Suppress subtype_dealloc decref when base type is a C heap type (GH-15323, GH-16004) (GH-15966) https://github.com/python/cpython/commit

[issue37879] Segfaults in C heap type subclasses

2019-09-12 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 5e9caeec76119a0d61c25f1466c27b7dbd5115bd by Petr Viktorin in branch 'master': bpo-37879: Fix warnings in _testcapimodule (GH-16004) https://github.com/python/cpython/commit/5e9caeec76119a0d61c25f1466c27b7dbd5115bd

[issue37645] Replace PyEval_GetFuncName/PyEval_GetFuncDesc

2019-09-11 Thread Petr Viktorin
Petr Viktorin added the comment: My bad, I didn't publish the comments. They should be there now. -- ___ Python tracker <https://bugs.python.org/issue37

[issue37879] Segfaults in C heap type subclasses

2019-09-11 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +15629 pull_request: https://github.com/python/cpython/pull/16004 ___ Python tracker <https://bugs.python.org/issue37

[issue37645] Replace PyEval_GetFuncName/PyEval_GetFuncDesc

2019-09-11 Thread Petr Viktorin
Petr Viktorin added the comment: I like PR 14890 better. I like the separation of representation for error messages (where it's clearer that this is a callable) and for __str__. Also, changing the __str__ of functions would need much wider discussion than on issues/PRs. I left some

[issue37879] Segfaults in C heap type subclasses

2019-09-11 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +15599 pull_request: https://github.com/python/cpython/pull/15966 ___ Python tracker <https://bugs.python.org/issue37

[issue38112] Compileall improvements

2019-09-11 Thread Petr Viktorin
New submission from Petr Viktorin : Hello, In Fedora, we've long used a Bash script to compile modules to bytecode, as the compileall module was historically unsuitable. Recently, Lumír re-wrote our enhancements to compileall, and published the result as compileall2 on PyPI. We'd like to get

[issue37151] Calling code cleanup after PEP 590

2019-09-11 Thread Petr Viktorin
Petr Viktorin added the comment: All linked PRs are merged, so I'm closing this. Feel free to reopen if there's more! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bug

[issue37151] Calling code cleanup after PEP 590

2019-09-11 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 7a6873cdb1f496447ac5d57ae457eacbb56b7972 by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-37151: remove special case for PyCFunction from PyObject_Call (GH-14684) https://github.com/python/cpython/commit

[issue37879] Segfaults in C heap type subclasses

2019-09-11 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset ff023ed36ea260ab64be5895f1f1f087c798987a by Petr Viktorin (Eddie Elizondo) in branch 'master': bpo-37879: Suppress subtype_dealloc decref when base type is a C heap type (GH-15323) https://github.com/python/cpython/commit

[issue37499] test_gdb.test_pycfunction should use dedicated test functions

2019-09-09 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +15429 pull_request: https://github.com/python/cpython/pull/15776 ___ Python tracker <https://bugs.python.org/issue37

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-02 Thread Petr Viktorin
Petr Viktorin added the comment: The traceback does have some ctypedescr_dealloc and cfield_dealloc from _cffi. Could you check what those are? -- ___ Python tracker <https://bugs.python.org/issue38

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-02 Thread Petr Viktorin
Petr Viktorin added the comment: > What downsides do we see raising an exception? Yeah, on second thought, that would probably be best. We still want PR #15641 as well, so the exception doesn't actually happen in practice. Note that _PyEval_EvalCodeWithName (the main use of func_glob

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-02 Thread Petr Viktorin
Petr Viktorin added the comment: I'm not sure adding a check would solve this. What should be done when a function with func_code=NULL is called? "Silently do nothing" is not really an option; raising an exception wouldn't help much in this case. I wonder if a function's tp_clear

[issue38006] _PyFunction_Vectorcall() can segfault on process exit

2019-09-02 Thread Petr Viktorin
Petr Viktorin added the comment: I don't understand how the function ended up with func_code=NULL. That shouldn't be a valid function to call, IMO. Do you have any info on how the function ended up in that state? -- ___ Python tracker <ht

[issue37645] Replace PyEval_GetFuncName/PyEval_GetFuncDesc

2019-08-15 Thread Petr Viktorin
Petr Viktorin added the comment: I am not convinced. I'm wary of making error messages depend on the str representation of a function; that would prevent us from changing it later. I'm wary of "%S" used in error messages. Those are for the programmer, not the user, so they sho

[issue34749] improve performance of binascii.a2b_base64()

2019-07-14 Thread Petr Viktorin
Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue26967] argparse: allow_abbrev=False stops -vv from working

2019-07-14 Thread Petr Viktorin
Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue26967] argparse: allow_abbrev=False stops -vv from working

2019-07-14 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset b1e4d1b6032d4c82b549233fa08a2c7cfe7e818b by Petr Viktorin (Miss Islington (bot)) in branch '3.8': bpo-26967: fix flag grouping with allow_abbrev=False (GH-14316) (GH-14759) https://github.com/python/cpython/commit

[issue37358] Use vectorcall for functools.partial

2019-07-13 Thread Petr Viktorin
Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37580] Markup typo in http.cookiejar doc

2019-07-13 Thread Petr Viktorin
Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37337] Add _PyObject_VectorcallMethod() function

2019-07-08 Thread Petr Viktorin
Petr Viktorin added the comment: Thank you, Jeroen and INADA-san! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37151] Calling code cleanup after PEP 590

2019-07-05 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 7b57c03a7cb63ccfb2b8dfa82a1bf169268d80ba by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-37151: remove _PyMethodDef_RawFastCall* functions (GH-14603) https://github.com/python/cpython/commit/7b57c03a7cb63ccfb2b8dfa82a1bf169268d80ba

[issue36974] Implement PEP 590

2019-07-05 Thread Petr Viktorin
Petr Viktorin added the comment: Buildbots are green, closing. Thank you for the implementation! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36974] Implement PEP 590

2019-07-05 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 0d722f3cd602e5f5492f9c65c8af57ea9d3743b6 by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-36974: separate vectorcall functions for each calling convention (GH-13781) https://github.com/python/cpython/commit

[issue37221] PyCode_New API change breaks backwards compatibility policy

2019-07-05 Thread Petr Viktorin
Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37221] PyCode_New API change breaks backwards compatibility policy

2019-07-01 Thread Petr Viktorin
Petr Viktorin added the comment: > https://github.com/cython/cython/pull/3009 was merged. (to master, so far) > Is it part of Cython 0.29.11 released yesterday? It should be, see: https://cython.readthedocs.io/en/latest/src/changes.ht

[issue37221] PyCode_New API change breaks backwards compatibility policy

2019-07-01 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 4a2edc34a405150d0b23ecfdcb401e7cf59f4650 by Petr Viktorin (Pablo Galindo) in branch 'master': bpo-37221: Add PyCode_NewWithPosOnlyArgs to be used internally and set PyCode_New as a compatibility wrapper (GH-13959) https://github.com/python

[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

2019-06-25 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset d917cfe4051d45b2b755c726c096ecfcc4869ceb by Petr Viktorin (Jeroen Demeyer) in branch '3.8': [3.8] bpo-37250: put back tp_print for backwards compatibility (GH-14193) https://github.com/python/cpython/commit

[issue36974] Implement PEP 590

2019-06-25 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 26fe6c35374fa32577b230b856a92a3b094e08ed by Petr Viktorin (Miss Islington (bot)) in branch '3.8': bpo-36974: inherit tp_vectorcall_offset unconditionally (GH-13858) (GH-14342) https://github.com/python/cpython/commit

[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

2019-06-24 Thread Petr Viktorin
Petr Viktorin added the comment: 1. If sdist consumers will need to regenerate an sdist? They would need to compile from the source, e.g. clone from Git and make an sdist (or install) from that. 2. How many sdist consumers will likely be impacted? I don't know. Depends on how fast people

[issue36974] Implement PEP 590

2019-06-24 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset a8b27e623d75377aabe50df27e97cab4e81a174a by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-36974: inherit tp_vectorcall_offset unconditionally (GH-13858) https://github.com/python/cpython/commit/a8b27e623d75377aabe50df27e97cab4e81a174a

[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

2019-06-21 Thread Petr Viktorin
Petr Viktorin added the comment: > scientific projects that depend on it may lag longer as rebuilds and releases > will need to happen on PyPI, conda, and conda-forge. Keep in mind that binary artifacts (wheels, Conda/distro packages) should not be affected. They need to be re

[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

2019-06-20 Thread Petr Viktorin
Petr Viktorin added the comment: I agree with Steve that renaming tp_print to tp_vectorcall_offset is well within our rights. For reference, the rationale for the replacing is the first section of: https://mail.python.org/pipermail/python-dev/2018-June/153927.html I hope Cython's

[issue37107] ensurepip --upgrade doesn't change the version of pip used by venv

2019-06-10 Thread Petr Viktorin
Petr Viktorin added the comment: Please don't forget that it is possible to use venv without PyPI. With my Fedora hat on: as a distro, we don't trust PyPI as a package delivery infrastructure. Lots of users do, and we allow the users to easily but explicitly opt in to trusting it by running

<    1   2   3   4   5   6   7   8   9   10   >