[issue5420] Queue deprecation warning patch

2014-04-15 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: No news for 2 years. -- nosy: +matrixise ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5420 ___ ___

[issue21189] Broken link to patch

2014-04-09 Thread LtWorf
@python, tiposchi priority: normal severity: normal status: open title: Broken link to patch type: enhancement ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21189

[issue21189] Broken link to patch

2014-04-09 Thread Georg Brandl
Georg Brandl added the comment: Barry, you run the list, so please change this to a link to bugs.python.org (and maybe docs.python.org/devguide). -- assignee: docs@python - barry nosy: +barry, georg.brandl ___ Python tracker rep...@bugs.python.org

[issue1814] Victor Stinner's GMP patch for longs

2014-04-07 Thread Hristo Venev
Hristo Venev added the comment: What about using PyVarObject of mp_limb_t and mpn instead of mpz_t? Addition: - Check signs and allocate. - Possibly compare absolute values. - Call mpn_(add|sub)_n and possibly mpn_(add|sub)_1 if the integers have different sizes. - Overhead for

[issue1814] Victor Stinner's GMP patch for longs

2014-04-07 Thread STINNER Victor
STINNER Victor added the comment: What about using PyVarObject of mp_limb_t and mpn instead of mpz_t? FYI this issue is closed, it's not a good practice to comment closed issue (for example, the issue is hidden in the list of recent issues). If you want to learn more about my old patch, you

[issue20284] patch to implement PEP 461 (%-interpolation for bytes)

2014-03-27 Thread Ethan Furman
Ethan Furman added the comment: PEP 461 has been accepted. I'll look over the code soon. -- assignee: - ethan.furman ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20284 ___

[issue21031] [patch] Add AlpineLinux to the platform module's supported distributions list

2014-03-23 Thread R. David Murray
Changes by R. David Murray rdmur...@bitdance.com: -- nosy: +lemburg ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21031 ___ ___ Python-bugs-list

[issue21031] [patch] Add AlpineLinux to the platform module's supported distributions list

2014-03-22 Thread Elizabeth Myers
New submission from Elizabeth Myers: This patch adds support for the AlpineLinux distrubtion (http://alpinelinux.org) to the platform.linux_distributions function, e.g.: platform.linux_distribution() ('alpine', '2.8.0_alpha2', '') Thoughts, feelings, and rotten tomatoes welcome

[issue21031] [patch] Add AlpineLinux to the platform module's supported distributions list

2014-03-22 Thread Elizabeth Myers
Changes by Elizabeth Myers elizab...@sporksmoo.net: -- type: - enhancement ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21031 ___ ___

[issue21018] [patch] added missing documentation about escaping characters for configparser

2014-03-21 Thread Arun Persaud
New submission from Arun Persaud: Couldn't find how to escape % and $ in the documentation, so I thought I add a short patch. -- assignee: docs@python components: Documentation files: mywork.patch keywords: patch messages: 214442 nosy: Arun.Persaud, docs@python priority: normal

[issue21018] [patch] added missing documentation about escaping characters for configparser

2014-03-21 Thread R. David Murray
Changes by R. David Murray rdmur...@bitdance.com: -- nosy: +lukasz.langa ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21018 ___ ___

[issue20594] [PATCH] fail to compile posixmodule due to name clash with posix_close

2014-03-17 Thread Roundup Robot
Roundup Robot added the comment: New changeset fd49c1d2fd6c by Benjamin Peterson in branch '3.4': merge 3.3 (#20594) http://hg.python.org/cpython/rev/fd49c1d2fd6c -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20594

[issue16296] Patch to fix building on Win32/64 under VS 2010

2014-03-17 Thread Max Naumov
Max Naumov added the comment: Wouldn't this be more correct? --- Lib/distutils/msvc9compiler.py 2013-08-03T16:17:08+04:00 +++ Lib/distutils/msvc9compiler.py 2014-03-17T18:36:50.078672+04:00 @@ -411,7 +411,11 @@ '/Z7', '/D_DEBUG']

[issue16296] Patch to fix building on Win32/64 under VS 2010

2014-03-17 Thread Martin v . Löwis
Martin v. Löwis added the comment: What is the procedure to test this patch? Under what circumstances exactly is it needed? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16296

[issue16296] Patch to fix building on Win32/64 under VS 2010

2014-03-17 Thread Max Naumov
Max Naumov added the comment: It allows to install numpy on windows python 3.4. Just like the patch in the original post. Actually my patch is merely the original patch refactored. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue1034] [patch] Add 2to3 support for displaying warnings as Python comments

2014-03-14 Thread Éric Araujo
Éric Araujo added the comment: (2to3 is an exception and can get improvements in stable versions.) -- nosy: +eric.araujo versions: +Python 2.7, Python 3.3, Python 3.4 -Python 3.2 ___ Python tracker rep...@bugs.python.org

[issue2704] IDLE: Patch to make PyShell behave more like a Terminal interface

2014-03-05 Thread Sean Wolfe
Sean Wolfe added the comment: I just tried this out on osx 10.9.0 and python 2.7.5 : * cursor persisting on the input line works * up/down history works This is much better! A big irritation gone for me and makes things much easier for beginners IMO -- one less thing to get surprised by.

[issue2704] IDLE: Patch to make PyShell behave more like a Terminal interface

2014-03-05 Thread Sean Wolfe
Sean Wolfe added the comment: installation steps for me: * apply PyShell.py patch (I had to do some bits manually) * add Terminal.py to idlelib directory * add changes to config-extensions.def as detailed in Terminal.py comments This was in the osx 10.9 system python directories, so

[issue20594] [PATCH] fail to compile posixmodule due to name clash with posix_close

2014-02-17 Thread Benjamin Peterson
Changes by Benjamin Peterson bp+pyb...@benjamin-peterson.org: -- nosy: +benjamin.peterson, georg.brandl priority: high - release blocker resolution: fixed - status: closed - open ___ Python tracker rep...@bugs.python.org

[issue20594] [PATCH] fail to compile posixmodule due to name clash with posix_close

2014-02-17 Thread Benjamin Peterson
Changes by Benjamin Peterson bp+pyb...@benjamin-peterson.org: -- assignee: - larry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20594 ___ ___

[issue20594] [PATCH] fail to compile posixmodule due to name clash with posix_close

2014-02-17 Thread Larry Hastings
Larry Hastings added the comment: I created a cherry-pick issue (#20665) to track that separately. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20594

[issue20594] [PATCH] fail to compile posixmodule due to name clash with posix_close

2014-02-11 Thread ncopa
Changes by ncopa nc...@alpinelinux.org: -- keywords: +patch title: fail to compile posixmodule due to name clash with posix_close - [PATCH] fail to compile posixmodule due to name clash with posix_close Added file: http://bugs.python.org/file34040/posix_close.patch

[issue20594] [PATCH] fail to compile posixmodule due to name clash with posix_close

2014-02-11 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thanks for the report! I think this should also make it into 3.4 final. -- nosy: +larry, pitrou priority: normal - high stage: - patch review versions: +Python 3.4 ___ Python tracker rep...@bugs.python.org http

[issue20594] [PATCH] fail to compile posixmodule due to name clash with posix_close

2014-02-11 Thread Larry Hastings
Larry Hastings added the comment: Yes, this can go in. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20594 ___ ___ Python-bugs-list mailing

[issue20594] [PATCH] fail to compile posixmodule due to name clash with posix_close

2014-02-11 Thread Roundup Robot
(closes #20594) http://hg.python.org/cpython/rev/021dd3c65198 New changeset 400a8e4599d9 by Benjamin Peterson in branch 'default': merge 3.3 (#20594) http://hg.python.org/cpython/rev/400a8e4599d9 -- nosy: +python-dev resolution: - fixed stage: patch review - committed/rejected status: open

[issue20284] patch to implement PEP 461 (%-interpolation for bytes)

2014-02-10 Thread Martin Panter
Changes by Martin Panter vadmium...@gmail.com: -- nosy: +vadmium ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20284 ___ ___ Python-bugs-list

[issue20516] Concurrent.futures base concurrency improvement (with patch)

2014-02-08 Thread Charles-François Natali
Charles-François Natali added the comment: Just a quick comment on the patch: in as_completed(), if the future is cancelled or finished, control is yielded back to the caller with the condition's lock held. As a general rule, libraries should not yield control to the caller with a lock held

[issue20516] Concurrent.futures base concurrency improvement (with patch)

2014-02-08 Thread Glenn Langford
Glenn Langford added the comment: if the future is cancelled or finished, control is yielded back to the caller with the condition's lock held. Hmmm...I don't agree. I assume you are looking at this code: with f._condition: # Lock the Future; yield if completed or add our Waiter

[issue20516] Concurrent.futures base concurrency improvement (with patch)

2014-02-08 Thread Charles-François Natali
Charles-François Natali added the comment: Note that the context manager will be called in this case to release the lock before f is yielded to the caller. class MiniContext(): def __init__(self): pass def __enter__(self): print('Hello') def __exit__(self,

[issue20516] Concurrent.futures base concurrency improvement (with patch)

2014-02-08 Thread Glenn Langford
Glenn Langford added the comment: Actually, I think what you're seeing here is the context manager being garbage collected Yes indeed, I am with you now. Thanks for identifying the problem, and for your explanation. The future should not be yielded while locked. --

[issue20516] Concurrent.futures base concurrency improvement (with patch)

2014-02-08 Thread Glenn Langford
Glenn Langford added the comment: Updated patch: Fixed bug where quick yield in as_completed() did not release lock on future. -- Added file: http://bugs.python.org/file33999/futures-base-v2.patch ___ Python tracker rep...@bugs.python.org http

[issue20516] Concurrent.futures base concurrency improvement (with patch)

2014-02-07 Thread Antoine Pitrou
Changes by Antoine Pitrou pit...@free.fr: -- stage: - patch review versions: -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20516

[issue20516] Concurrent.futures base concurrency improvement (with patch)

2014-02-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thanks for the patch. This will have to wait for 3.5, since 3.4 is currently in feature freeze stage. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20516

[issue1654367] [PATCH] Debuggers need a way to change the locals of a frame

2014-02-06 Thread Armin Rigo
Armin Rigo added the comment: Sorry to hijack CPython's bug tracker for that, but can you check if this makes sense to you? I added a function 'locals_to_fast()' to the __pypy__ built-in module which just calls the PyPy equivalent to PyFrame_LocalsToFast(). Your tests are passing, so I

[issue1654367] [PATCH] Debuggers need a way to change the locals of a frame

2014-02-06 Thread Fabio Zadrozny
Fabio Zadrozny added the comment: Hi Armin, That does make sense to me, but maybe it could be nice providing a standard API across Python implementations to make that call (even if the CPython version uses ctypes underneath and the PyPy version uses RPython), but I'll leave that up to

[issue1654367] [PATCH] Debuggers need a way to change the locals of a frame

2014-02-06 Thread Fabio Zadrozny
Fabio Zadrozny added the comment: Sure, no problems on my side :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1654367 ___ ___

[issue1654367] [PATCH] Debuggers need a way to change the locals of a frame

2014-02-06 Thread Armin Rigo
Armin Rigo added the comment: CPython 2.7 is in feature-freeze, so we need to add it to __pypy__. If people here decide to add it more officially to CPython 3.x, then we'll also add it into pypy3, obviously. I'm sure a debugger can cope with a few extra ifs to check on which platform it is

[issue20521] [PATCH] Cleanup for dis module documentation

2014-02-05 Thread Sven Berkvens-Matthijsse
New submission from Sven Berkvens-Matthijsse: The documentation for the dis module has a wrong opcode name in it (POP_STACK instead of POP_TOP). Furthermore, the patch fixes inconsistent use of markers for code and opcodes. -- assignee: docs@python components: Documentation files: dis

[issue20521] [PATCH] Cleanup for dis module documentation

2014-02-05 Thread Berker Peksag
Changes by Berker Peksag berker.pek...@gmail.com: -- nosy: +ncoghlan stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20521

[issue20521] [PATCH] Cleanup for dis module documentation

2014-02-05 Thread Antoine Pitrou
Changes by Antoine Pitrou pit...@free.fr: -- versions: +Python 2.7, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20521 ___ ___

[issue16296] Patch to fix building on Win32/64 under VS 2010

2014-02-04 Thread Paul Moore
Paul Moore added the comment: Is there any chance this can be included in Python 3.4? It would apparently allow numpy to be built with stock tools on Windows Python. -- nosy: +pmoore ___ Python tracker rep...@bugs.python.org

[issue16296] Patch to fix building on Win32/64 under VS 2010

2014-02-04 Thread Tim Golden
Tim Golden added the comment: Larry Hastings would have to rule on whether it could get into 3.4 at this stage. Paul: are you in a position to apply / test the patch? I've done no more than glance at it but it looks, from the comments, as though it doesn't apply cleanly

[issue16296] Patch to fix building on Win32/64 under VS 2010

2014-02-04 Thread Paul Moore
Paul Moore added the comment: Unfortunately not really - it's the numpy guys that need this, so hopefully the original poster can comment. I'll see if I can hand-patch the relevant files and do a pip install numpy to see if it fixes that specific scenario. I'll report back. I've added Larry

[issue16296] Patch to fix building on Win32/64 under VS 2010

2014-02-04 Thread Paul Moore
Paul Moore added the comment: Sigh. Looks like it doesn't fix the issue of building numpy - plus it doesn't apply cleanly. My apologies for the noise, I'll report the issues with the patch back on the numpy issue where I was told about this patch

[issue16296] Patch to fix building on Win32/64 under VS 2010

2014-02-04 Thread Larry Hastings
Larry Hastings added the comment: I'm not sure I need to be on this issue. As a rule, Windows build concerns for 3.4 are delegated to Martin von Lowis. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16296

[issue16296] Patch to fix building on Win32/64 under VS 2010

2014-02-04 Thread Tim Golden
Tim Golden added the comment: Thanks, Larry. Martin's already nosy this issue, but really we need to see if we have a viable patch before making decisions about 3.4. I'll take you off the nosy list. -- ___ Python tracker rep...@bugs.python.org http

[issue16296] Patch to fix building on Win32/64 under VS 2010

2014-02-04 Thread Tim Golden
Changes by Tim Golden m...@timgolden.me.uk: -- nosy: -larry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16296 ___ ___ Python-bugs-list mailing

[issue2704] IDLE: Patch to make PyShell behave more like a Terminal interface

2014-02-04 Thread Tal Einat
Changes by Tal Einat talei...@gmail.com: -- nosy: -taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2704 ___ ___ Python-bugs-list mailing

[issue16296] Patch to fix building on Win32/64 under VS 2010

2014-02-04 Thread Thomas Heller
Thomas Heller added the comment: Hm, what's the problem? For me, the patch applies cleanly (in Python 3.4.0b3, 32-bit and 64-bit on Windows), and py -3.4(-32) -m pip install numpy works correctly. At least py -3.4(-32) -c import numpy; print(numpy.__version__) prints 1.8.0

[issue16296] Patch to fix building on Win32/64 under VS 2010

2014-02-04 Thread Paul Moore
Paul Moore added the comment: Maybe it's not applicable to 3.3 somehow, which is what I tried. I applied the patch to the distutils in the system installed Python, then ran pip install numpy from a virtualenv. It's quite possible that a million things could have gone wrong in that process

[issue1654367] [PATCH] Debuggers need a way to change the locals of a frame

2014-02-04 Thread Fabio Zadrozny
Fabio Zadrozny added the comment: Just a note for anyone interested: ctypes can be used to access that function: http://pydev.blogspot.com.br/2014/02/changing-locals-of-frame-frameflocals.html So, I think that the changes I proposed shouldn't be applied (it'd only be worth if someone provided

[issue1654367] [PATCH] Debuggers need a way to change the locals of a frame

2014-02-04 Thread Armin Rigo
Armin Rigo added the comment: Hi Fabio! This is admittedly a corner-case use case, but if you think it would be worth it, we can very easily add this as a feature to PyPy (by making frame.f_locals writeable). Then we can add the write inside pdb, and you could do the same for PyDev when

[issue1654367] [PATCH] Debuggers need a way to change the locals of a frame

2014-02-04 Thread Armin Rigo
Armin Rigo added the comment: Also, can you provide a concrete case? Trying around in CPython 2.7, it seems that locals of the current frame can always be modified from a pdb.set_trace(). -- ___ Python tracker rep...@bugs.python.org

[issue1654367] [PATCH] Debuggers need a way to change the locals of a frame

2014-02-04 Thread Fabio Zadrozny
Fabio Zadrozny added the comment: Hi Armin, Sure, just attached the test case with tests failing (on the top, comment the save_locals(frame) which has a 'pass' to see it working). Mostly, it happens when editing something not in the top-frame (but sometimes I think it could fail there too,

[issue20516] Concurrent.futures base concurrency improvement (with patch)

2014-02-04 Thread Glenn Langford
given Futures, regardless of state). A demonstration patch is attached which - locks Futures one at a time for as_completed() and all variations of wait() - reduces the overhead in tracking the state of each Future - makes it easier to add other user APIs if desired later - consolidates the machinery

[issue2889] curses for windows (alternative patch)

2014-02-03 Thread Mark Lawrence
Changes by Mark Lawrence breamore...@yahoo.co.uk: -- nosy: -BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2889 ___ ___

[issue1439312] Patch for bug 1438185: os.renames deletes junction points

2014-02-03 Thread Mark Lawrence
Changes by Mark Lawrence breamore...@yahoo.co.uk: -- nosy: -BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1439312 ___ ___

[issue2057] difflib: add patch capability

2014-02-03 Thread Mark Lawrence
Changes by Mark Lawrence breamore...@yahoo.co.uk: -- nosy: -BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2057 ___ ___

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

2014-02-03 Thread Mark Lawrence
Changes by Mark Lawrence breamore...@yahoo.co.uk: -- nosy: -BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1755841 ___ ___

[issue1034] [patch] Add 2to3 support for displaying warnings as Python comments

2014-02-03 Thread Mark Lawrence
Changes by Mark Lawrence breamore...@yahoo.co.uk: -- nosy: -BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1034 ___ ___

[issue1653457] Python misbehaves when installed in / (patch attached)

2014-02-03 Thread Mark Lawrence
Changes by Mark Lawrence breamore...@yahoo.co.uk: -- nosy: -BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1653457 ___ ___

[issue1654367] [PATCH] Debuggers need a way to change the locals of a frame

2014-02-03 Thread Mark Lawrence
Changes by Mark Lawrence breamore...@yahoo.co.uk: -- nosy: -BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1654367 ___ ___

[issue16296] Patch to fix building on Win32/64 under VS 2010

2014-02-03 Thread Ralf Gommers
Changes by Ralf Gommers ralf.gomm...@gmail.com: -- nosy: +ralf.gommers ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16296 ___ ___

[issue20456] Argument Clinic rollup patch, 2014/01/31

2014-02-01 Thread Vajrasky Kok
print('' + ' '.join(c for c in legacy if c[0].isupper())) IndexError: string index out of range Unit test for exercising Tools/clinic/clinic.py using assert_python_ok would be good, but that deserves a dedicated ticket. Here is the patch to fix the bug. -- nosy: +vajrasky Added file

[issue18891] Master patch for content manager addition to email package

2014-02-01 Thread R. David Murray
R. David Murray added the comment: Opened issue 20477 with the proposed examples. -- stage: commit review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18891

[issue20456] Argument Clinic rollup patch, 2014/01/31

2014-01-31 Thread Larry Hastings
New submission from Larry Hastings: Probably the last rollup patch for a while; I need to move on to code reviewing. Here's a list of changes in this patch: * I added the oft-requested rename the C variable for a parameter functionality. That works as follows: os.rename path

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-31 Thread Roundup Robot
Roundup Robot added the comment: New changeset 06b4fbb09c93 by Larry Hastings in branch 'default': Issue #20390: Removing detritus from Argument Clinic file preset name change. http://hg.python.org/cpython/rev/06b4fbb09c93 -- ___ Python tracker

[issue20456] Argument Clinic rollup patch, 2014/01/31

2014-01-31 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- nosy: +brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20456 ___ ___

[issue20456] Argument Clinic rollup patch, 2014/01/31

2014-01-31 Thread Larry Hastings
Larry Hastings added the comment: Updated the patch. * The methoddef_ifndef template is now sent to the buffer destination by default. I expected posixmodule to have an #ifndef, I was surprised to find _import had one too. Both files touched to move the buffer to an appropriate spot

[issue20456] Argument Clinic rollup patch, 2014/01/31

2014-01-31 Thread Roundup Robot
Roundup Robot added the comment: New changeset 19d81cc213d7 by Larry Hastings in branch 'default': #Issue 20456: Several improvements and bugfixes for Argument Clinic, http://hg.python.org/cpython/rev/19d81cc213d7 -- nosy: +python-dev ___ Python

[issue20456] Argument Clinic rollup patch, 2014/01/31

2014-01-31 Thread Larry Hastings
Larry Hastings added the comment: Checked in! I think that's the last new feature for Argument Clinic until after 3.4 ships. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
New submission from Larry Hastings: Rollup patch with a bunch of small fixes in it. Can I get a quick turnaround review on this? I'd like it to go in before today's beta is cut. Definitely the core change has to go in, but that's uncontroversial. Core: * _PyType_GetDocFromInternalDoc

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Nick Coghlan
Nick Coghlan added the comment: LGTM, but I'm not familiar with Clinic's own code... -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20390 ___

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Don't forget to use hg mv to rename existing side files. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20390 ___

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: _PyType_GetDocFromInternalDoc and _PyType_GetTextSignatureFromInternalDoc declarations are too long. could you please wrap them around? First parameter of class methods (e.g. dict.fromkeys) now has a type of object (PyDictObject *) instead of PyTypeObject *

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: Thanks for the reviews, Nick and Serhiy, especially considering that the Rietveld link didn't work! Serhiy: I believe I fixed everything. There are no side files checked in yet. Can you give me another review? -- Added file:

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Changes by Larry Hastings la...@hastings.org: Removed file: http://bugs.python.org/file33710/larry.clinic.rollup.jan.25.diff.2.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20390 ___

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: Hang on, my tree was out of date. Which is why I didn't get a review link, duh. And if side files have appeared I'll fix 'em. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20390

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: Okay, here's my revised patch, for real this time, with hg mv for the side files and everything. -- Added file: http://bugs.python.org/file33711/larry.clinic.rollup.jan.25.diff.2.txt ___ Python tracker rep

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: Oops, I goofed up moving _lzamodule.clinic.c.h. I'll fix that locally, won't regenerate the patch just for that (unless you ask me to). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20390

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: No, wait, I think it's fine, it was just some detritus in my directory throwing me off. But hg stat looks correct. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20390

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: I don't know why it's refusing to generate the review link. The patch applies cleanly to trunk, even now, hours later. Maybe it doesn't like file moves? -- ___ Python tracker rep...@bugs.python.org http

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9c5b421cc7de by Larry Hastings in branch 'default': Issue #20390: Small fixes and improvements for Argument Clinic. http://hg.python.org/cpython/rev/9c5b421cc7de -- nosy: +python-dev ___ Python tracker

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Changes by Larry Hastings la...@hastings.org: -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20390

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1435d2fe8e34 by Larry Hastings in branch 'default': Issue #20390: Final fix, for generating NoPositional/NoKeyword for __init__ calls. http://hg.python.org/cpython/rev/1435d2fe8e34 -- ___ Python tracker

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Rietveld doesn't like patches against out of date tree. And unfortunately it doesn't like patches in git format. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20390

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: I don't know about diff #1, but diff #2 definitely applied cleanly against a fresh trunk at 8:22pm local time. I've turned off git format. -- ___ Python tracker rep...@bugs.python.org

[issue20284] patch to implement %-interpolation for bytes (roughly PEP 461)

2014-01-20 Thread Neil Schemenauer
Changes by Neil Schemenauer nas-pyt...@arctrix.com: Removed file: http://bugs.python.org/file33501/bytes_mod.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20284 ___

[issue20284] patch to implement %-interpolation for bytes (roughly PEP 461)

2014-01-20 Thread Neil Schemenauer
Changes by Neil Schemenauer nas-pyt...@arctrix.com: Removed file: http://bugs.python.org/file33505/bytes_mod_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20284

[issue20284] patch to implement %-interpolation for bytes (roughly PEP 461)

2014-01-20 Thread Neil Schemenauer
Changes by Neil Schemenauer nas-pyt...@arctrix.com: Removed file: http://bugs.python.org/file33506/bytes_mod_v3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20284

[issue20284] patch to implement %-interpolation for bytes (roughly PEP 461)

2014-01-20 Thread Neil Schemenauer
Changes by Neil Schemenauer nas-pyt...@arctrix.com: Removed file: http://bugs.python.org/file33516/bytes_mod_v4.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20284

[issue20284] patch to implement PEP 461 (%-interpolation for bytes)

2014-01-20 Thread Neil Schemenauer
Neil Schemenauer added the comment: I've updated my patch into a sequence, the first of which implements PEP 461. 02-code-a.patch adds support for %a (ascii() on arg) 03-py2-flag.patch makes %s and %r behave similar to Python 2 if a command line flag is provided to the interpreter 04-py

[issue20284] patch to implement PEP 461 (%-interpolation for bytes)

2014-01-20 Thread Neil Schemenauer
Changes by Neil Schemenauer nas-pyt...@arctrix.com: Added file: http://bugs.python.org/file33575/02-code-a.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20284 ___

[issue20284] patch to implement PEP 461 (%-interpolation for bytes)

2014-01-20 Thread Neil Schemenauer
Changes by Neil Schemenauer nas-pyt...@arctrix.com: Added file: http://bugs.python.org/file33576/03-py2-flag.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20284 ___

[issue20284] patch to implement PEP 461 (%-interpolation for bytes)

2014-01-20 Thread Neil Schemenauer
Changes by Neil Schemenauer nas-pyt...@arctrix.com: Added file: http://bugs.python.org/file33577/04-py2-eq.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20284 ___

[issue20284] patch to implement PEP 461 (%-interpolation for bytes)

2014-01-20 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20284 ___

[issue20284] proof for concept patch for bytes formatting methods

2014-01-17 Thread Neil Schemenauer
Neil Schemenauer added the comment: I'm attaching v2 of my proposed patch. This one is quite a bit better, IMHO. - Introduce __ascii__ as a special method, like __str__ but required to exist only if an ASCII-only format exists. - Extract PyString_Format from Python 2.7 and update

[issue20284] proof for concept patch for bytes formatting methods

2014-01-17 Thread STINNER Victor
Changes by STINNER Victor victor.stin...@gmail.com: -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20284 ___ ___ Python-bugs-list

[issue20284] proof for concept patch for bytes formatting methods

2014-01-17 Thread STINNER Victor
STINNER Victor added the comment: I reviewed your second patch on Rietveld. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20284 ___ ___ Python

[issue20284] proof for concept patch for bytes formatting methods

2014-01-17 Thread Neil Schemenauer
Neil Schemenauer added the comment: Uploading new patch with the following changes: - Allow length 1 bytes object as argument to %c. - Make %r an alias for %a. I will upload a draft PEP (proposed as a replacement for 461). Victor, thanks for the review. My reply is: - regarding duplicated

<    4   5   6   7   8   9   10   11   12   13   >