[Pywikipedia-bugs] [Maniphest] [Claimed] T101138: Certificate test can't fail as the certificate is valid

2015-06-02 Thread XZise
XZise claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T101138 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: Ricordisamoa, valhallasw, Aklapper, XZise, jayvdb, pywikipedia-bugs

[Pywikipedia-bugs] [Maniphest] [Claimed] T101185: replace.py fails to run because of incorrect number of arguments given to __init__()

2015-06-02 Thread XZise
XZise added a subscriber: XZise. XZise claimed this task. XZise added a comment. Yep https://phabricator.wikimedia.org/rPWBC5d83253686a3967e7c1fb603d8d5470da08d492c has introduced that bug. TASK DETAIL https://phabricator.wikimedia.org/T101185 EMAIL PREFERENCES https

[Pywikipedia-bugs] [Maniphest] [Commented On] T101214: Decommission compat

2015-06-03 Thread XZise
XZise added a comment. @Xqt: the priorities are used however they like. MW says only the assigned should use it but I personally don't know how this is helpful as the assigned should know how important it is to them. @Ladsgroup: Please don't say “X can do 2, Y can do 3” in case the e

[Pywikipedia-bugs] [Maniphest] [Lowered Priority] T100779: pywikibot api paraminfo should to recover from defective API modules

2015-06-03 Thread XZise
XZise lowered the priority of this task from "Unbreak Now!" to "Needs Triage". XZise set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T100779 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: XZi

[Pywikipedia-bugs] [Maniphest] [Commented On] T98592: Make older versions of pywikibot available for download

2015-06-03 Thread XZise
XZise added a comment. So we have now tags (at least ONE tag) so do we want to add these too? So that we have builds for each tag (in theory we only need to build them once). On the other hand all those are probably on pypi too (at least currently). TASK DETAIL https

[Pywikipedia-bugs] [Maniphest] [Commented On] T101228: [BREAKING] Change: Switch from httplib2 to requests

2015-06-03 Thread XZise
XZise added a subscriber: XZise. XZise added a comment. In https://phabricator.wikimedia.org/T101228#1333110, @jayvdb wrote: > The hint is there: install requests. > See also the email to the mailing list. I guess @xqt meant with “hint” a warning beforehand. TASK DETAIL

[Pywikipedia-bugs] [Maniphest] [Edited] T101255: redirect.py broken is non-functional.

2015-06-03 Thread XZise
XZise edited the task description. XZise set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T101255 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: Xqt, Betacommand, Aklapper, jayvdb, droid, pywikipedia-bugs

[Pywikipedia-bugs] [Maniphest] [Claimed] T101255: redirect.py broken is non-functional.

2015-06-03 Thread XZise
XZise added a subscriber: XZise. XZise claimed this task. XZise added a comment. Please note that the scripts are not copied 100 % from compat so different command line options are possible and especially required if they clash with others. For example https://phabricator.wikimedia.org/T76429

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T101218: https://github.com/pywikibot/core is very out of date

2015-06-03 Thread XZise
XZise added a subscriber: XZise. TASK DETAIL https://phabricator.wikimedia.org/T101218 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: XZise, Legoktm, valhallasw, jayvdb, Aklapper, pywikipedia-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T101255: redirect.py broken is non-functional.

2015-06-03 Thread XZise
XZise added a comment. Okay to be honest I'm inclined to decline this. It seems pretty clear: broken Tries to fix broken redirect to the last moved target of the br destination page. If this fails and -delete option is given it deletes redirects

[Pywikipedia-bugs] [Maniphest] [Commented On] T100707: Rename pywikipedia list prefixes to pywikibot

2015-06-03 Thread XZise
XZise added a subscriber: XZise. XZise added a comment. The e-mail list added as a subscriber to pywikibot bugs also needs to be renamed. TASK DETAIL https://phabricator.wikimedia.org/T100707 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: RobH

[Pywikipedia-bugs] [Maniphest] [Commented On] T101228: [BREAKING] Change: Switch from httplib2 to requests

2015-06-04 Thread XZise
XZise added a comment. Which basically means that the command `pip` couldn't be found. So the ONLY problem is actually that `requests` isn't packaged together with `pywikibot-core`? Couldn't we make it similar to how we packaged `httplib2` and use `requests` as a submodule

[Pywikipedia-bugs] [Maniphest] [Commented On] T100707: Rename pywikipedia list prefixes to pywikibot

2015-06-04 Thread XZise
XZise added a comment. @jayvdb: When you create a new bug request the -bugs mailing list gets added as a subscriber and that is currently using the old name. It may not be broken and maybe the old never will always work (at least as long as the new name works) and then it's not rea

[Pywikipedia-bugs] [Maniphest] [Commented On] T101228: [BREAKING] Change: Switch from httplib2 to requests

2015-06-04 Thread XZise
XZise added a comment. Well if git submodules are working correctly then there should be no issue with adding requests as a submodule. Nightly is also using git itself so these three routes are covered. Now I know you had problems with svn when we wanted to separate compat's and core&#

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T99368: UnsupportedOperation exceptions occured

2015-06-05 Thread XZise
XZise removed a subscriber: XZise. TASK DETAIL https://phabricator.wikimedia.org/T99368 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: pywikipedia-bugs, Xqt, Aklapper, Anshoe ___ pywikibot

[Pywikipedia-bugs] [Maniphest] [Commented On] T61686: fixing_redirects.py: move treat() to pywikibot/textlib

2015-06-05 Thread XZise
XZise added a comment. I don't know why gerritbot commented again but as you can see the same patch (which is still authored by you) was reported by @gerritbot a year ago. TASK DETAIL https://phabricator.wikimedia.org/T61686 EMAIL PREFERENCES https://phabricator.wikimedia.org/set

[Pywikipedia-bugs] [Maniphest] [Commented On] T100962: Dont use version detection for rawcontinue

2015-06-05 Thread XZise
XZise added a comment. Okay 1.19.24 doesn't complain about unknown parameters but at least 1.21.10: http://www.eierwiki.de/api.php?action=query&titles=Main%20Page&meta=siteinfo&rawcontinue= TASK DETAIL https://phabricator.wikimedia.org/T100962 EMAIL PR

[Pywikipedia-bugs] [Maniphest] [Created] T101557: Improve Page.title

2015-06-05 Thread XZise
XZise created this task. XZise added subscribers: XZise, valhallasw, jayvdb. XZise added a project: pywikibot-core. Restricted Application added subscribers: Aklapper, pywikipedia-bugs. TASK DESCRIPTION The `Page.title()` method should be reworked to be more flexible: * `allowInterwiki

[Pywikipedia-bugs] [Maniphest] [Commented On] T101557: Improve Page.title

2015-06-05 Thread XZise
XZise added a comment. I've written a patch many moons ago but it's quote complex because it's (mostly?) backwards compatible: https://gerrit.wikimedia.org/r/#/c/173672/ The question is whether we need such a complex `title()` method. Adding brackets could be done from the outs

[Pywikipedia-bugs] [Maniphest] [Edited] T101557: Improve Page.title

2015-06-05 Thread XZise
XZise edited the task description. XZise set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T101557 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: jayvdb, valhallasw, Aklapper, XZise, pywikipedia-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T71781: makecat uses http on import, causing deadlock

2015-06-06 Thread XZise
XZise added a subscriber: XZise. XZise added a comment. How does having it not in main() cause a deadlock? TASK DETAIL https://phabricator.wikimedia.org/T71781 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb, XZise Cc: XZise, gerritbot

[Pywikipedia-bugs] [Maniphest] [Commented On] T93364: Bot does not recognize EditConflict

2015-06-06 Thread XZise
XZise added a comment. Hmm weird. It now works for me too and it raises the EditConflict exception. Of course it's unusable without two accounts working at the same time though. TASK DETAIL https://phabricator.wikimedia.org/T93364 EMAIL PREFERENCES https://phabricator.wikimedi

[Pywikipedia-bugs] [Maniphest] [Created] T101601: Test failure in tests.http_tests.TestHttpStatus.test_follow_redirects

2015-06-06 Thread XZise
XZise created this task. XZise added a subscriber: XZise. XZise added a project: pywikibot-core. Restricted Application added subscribers: Aklapper, pywikipedia-bugs. TASK DESCRIPTION I got the following error

[Pywikipedia-bugs] [Maniphest] [Commented On] T101601: Test failure in tests.http_tests.TestHttpStatus.test_follow_redirects

2015-06-06 Thread XZise
XZise added a comment. I've 2.6.0 so 'redirect_cache' exists there apparently just returns None. TASK DETAIL https://phabricator.wikimedia.org/T101601 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: jayvdb, Aklapper, XZi

[Pywikipedia-bugs] [Maniphest] [Created] T101605: Make QueryGenerator and subclasses new style classes

2015-06-06 Thread XZise
XZise created this task. XZise added a subscriber: XZise. XZise added a project: pywikibot-core. Restricted Application added subscribers: Aklapper, pywikipedia-bugs. TASK DESCRIPTION At the moment these classes use old-style classes and can't use super. This should be changed (the differ

[Pywikipedia-bugs] [Maniphest] [Commented On] T101649: open_compressed fails on 2.7.0

2015-06-07 Thread XZise
XZise added a comment. Interestingly did it work on the 2.7.10 builds: - https://ci.appveyor.com/project/jayvdb/pywikibot-core/build/1.0.appveyor-more-versions.261/job/nln0p059s53jn6fc#L2181 - https://ci.appveyor.com/project/jayvdb/pywikibot-core/build/1.0.appveyor-more-versions.261/job

[Pywikipedia-bugs] [Maniphest] [Commented On] T101649: open_compressed fails on 2.7.0

2015-06-07 Thread XZise
XZise added a comment. Okay after installing Python 2.7, 2.7.1 and 2.7.3 I determined that only since 2.7.1 the with-statement is supported for BZ2File. For gzip it works since 2.7 (so there was never a bug with that). I can't find any bug or so for Python and according to

[Pywikipedia-bugs] [Maniphest] [Commented On] T101649: open_compressed fails on 2.7.0

2015-06-07 Thread XZise
XZise added a comment. So hopefully Python's documentation can reflect that in the future so that others know which versions they support: http://bugs.python.org/msg244962 TASK DETAIL https://phabricator.wikimedia.org/T101649 EMAIL PREFERENCES https://phabricator.wikimedia.org/set

[Pywikipedia-bugs] [Maniphest] [Created] T101657: Continue/finish file upload after warning

2015-06-07 Thread XZise
XZise created this task. XZise added a subscriber: XZise. XZise added a project: pywikibot-core. Restricted Application added subscribers: Aklapper, pywikipedia-bugs. TASK DESCRIPTION If a warning occurs after the file has been uploaded and you choose to ignore the warnings it is reuploading

[Pywikipedia-bugs] [Maniphest] [Claimed] T101657: Continue/finish file upload after warning

2015-06-07 Thread XZise
XZise claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T101657 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: pywikipedia-bugs, Aklapper, XZise, jayvdb ___ pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Retitled] T85322: APISite.siteinfo signature different between compact and core

2015-06-08 Thread XZise
XZise changed the title from "APISite.siteinfo" to "APISite.siteinfo signature different between compact and core". XZise claimed this task. XZise set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T85322 EMAIL PREFERENCES https://phabricator.wikimedi

[Pywikipedia-bugs] [Maniphest] [Commented On] T101698: category.py move ignores -namespace: generator

2015-06-08 Thread XZise
XZise added a subscriber: XZise. XZise added a comment. The category move option doesn't use a page generator to determine the pages to be moved afaik. TASK DETAIL https://phabricator.wikimedia.org/T101698 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailprefer

[Pywikipedia-bugs] [Maniphest] [Commented On] T101698: category.py move ignores -namespace: generator

2015-06-08 Thread XZise
XZise added a comment. On another note almost all page generators generate a list of pages and not act like a filter. So if I've got a list of pages in a category (which may be moved) and I now want those with pagelinks from another page (which is a type of page generator) than we need

[Pywikipedia-bugs] [Maniphest] [Unblock] T60941: [tracking] Missing unit tests

2015-06-08 Thread XZise
XZise closed blocking task T85322: APISite.siteinfo signature different between compact and core as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T60941 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: jayvdb,

[Pywikipedia-bugs] [Maniphest] [Closed] T85322: APISite.siteinfo signature different between compact and core

2015-06-08 Thread XZise
XZise closed this task as "Resolved". XZise added a comment. This should be fixed unless you specifically need the actual dict and not a deep copy. On the other hand dump=True exposes the actual cache. TASK DETAIL https://phabricator.wikimedia.org/T85322 EMAIL PREFERENC

[Pywikipedia-bugs] [Maniphest] [Commented On] T101228: [BREAKING] Change: Switch from httplib2 to requests

2015-06-08 Thread XZise
XZise added a comment. Did you try cloning recursively or updating the submodules? Are you using the 2.0 branch? TASK DETAIL https://phabricator.wikimedia.org/T101228 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: Kolega2357, JAnD

[Pywikipedia-bugs] [Maniphest] [Commented On] T101228: [BREAKING] Change: Switch from httplib2 to requests

2015-06-08 Thread XZise
XZise added a comment. Okay either use a recent version which uses requests or use the 2.0 branch and retest it. If the error still occurs could you paste the output of 'python pwb.py version'? And where did you get the version from? Also you can copy the contents into text and no

[Pywikipedia-bugs] [Maniphest] [Commented On] T101228: [BREAKING] Change: Switch from httplib2 to requests

2015-06-08 Thread XZise
XZise added a comment. Okay where did you get it? TASK DETAIL https://phabricator.wikimedia.org/T101228 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: Kolega2357, JAnD, Ladsgroup, valhallasw, gerritbot, XZise, Betacommand, jayvdb, Xqt

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T101801: "TypeError: 'dict_keys' object does not support indexing" in cosmetic_changes.py (Python 3)

2015-06-09 Thread XZise
XZise added a subscriber: XZise. TASK DETAIL https://phabricator.wikimedia.org/T101801 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: XZise, jayvdb, Aklapper, Dalba, 01tonythomas, pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T101829: make pwb.py cwd-insensitive

2015-06-09 Thread XZise
XZise added a subscriber: XZise. XZise added a comment. Why “case insensitive”? The file's name is 'generate_user_files.py'. TASK DETAIL https://phabricator.wikimedia.org/T101829 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Pywikipedia-bugs] [Maniphest] [Commented On] T101801: "TypeError: 'dict_keys' object does not support indexing" in cosmetic_changes.py (Python 3)

2015-06-09 Thread XZise
XZise added a comment. It seems that this code isn't actually used further down. TASK DETAIL https://phabricator.wikimedia.org/T101801 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: Ricordisamoa, XZise, jayvdb, Aklapper,

[Pywikipedia-bugs] [Maniphest] [Created] T101838: generate_user_files warns about unknown arguments with pwb

2015-06-09 Thread XZise
XZise created this task. XZise added a subscriber: XZise. XZise added a project: pywikibot-core. Restricted Application added subscribers: Aklapper, pywikibot-bugs. TASK DESCRIPTION When the `user-config.py` doesn't exist, `pwb.py` starts `generate_user_files.py` but passes all argu

[Pywikipedia-bugs] [Maniphest] [Updated] T56562: Support optional capturing groups in replaceExcept

2015-06-10 Thread XZise
XZise added a comment. Yes https://phabricator.wikimedia.org/rPWBCba6b671427fb3ca4c63f43412c8e418814c8abc3 should fix this one too. There is actually a test using `(x)?` (which would actually fail with `re.sub`). TASK DETAIL https://phabricator.wikimedia.org/T56562 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Updated] T101807: Run Pywikibot tests against Win32 using Appveyor

2015-06-10 Thread XZise
XZise added a subscriber: XZise. XZise added a comment. If we use https://github.com/pywikibot (see https://phabricator.wikimedia.org/T101218) we could run it using “our” github account. There might be just a problem with who can actually see the environmental variables (I guess the password

[Pywikipedia-bugs] [Maniphest] [Claimed] T101976: test_BlockEntry_old failure on wikia lyricwiki

2015-06-10 Thread XZise
XZise added a subscriber: XZise. XZise claimed this task. XZise added a comment. Okay that seems straight forward. It checked if flags was not empty to split it (because that would not result in an empty list but a list with one empty string. TASK DETAIL https://phabricator.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T89769: testQueryApiGetter timeout failure

2015-06-10 Thread XZise
XZise added a subscriber: XZise. XZise added a comment. Maybe the server is not actually returning 502 in the status code? Or if we are unlucky this is actually related to Requests not properly propagating the status code. TASK DETAIL https://phabricator.wikimedia.org/T89769 EMAIL

[Pywikipedia-bugs] [Maniphest] [Commented On] T89769: testQueryApiGetter timeout failure

2015-06-10 Thread XZise
XZise added a comment. Okay looking more closely at `error_handling_callback` it won't fail when the status code is not 200 or 207 but just emit a warning. That means our wikidataquery module is getting the response which is actually an error message but tries to parse it as JSON. Now we

[Pywikipedia-bugs] [Maniphest] [Unblock] T60941: [tracking] Missing unit tests

2015-06-10 Thread XZise
XZise closed blocking task T85322: APISite.siteinfo signature different between compat and core as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T60941 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: jayvdb,

[Pywikipedia-bugs] [Maniphest] [Closed] T85322: APISite.siteinfo signature different between compat and core

2015-06-10 Thread XZise
XZise closed this task as "Resolved". XZise added a comment. I'm not sure which tests you are expecting but the issue has been fixed in https://phabricator.wikimedia.org/rPWBCead5ee07f1f0ff7a99c2c79f6d00c3839dfa62fe. TASK DETAIL https://phabricator.wikimedia.org/T85322 EM

[Pywikipedia-bugs] [Maniphest] [Closed] T99032: pywikibot replace.py hangs on certain conditions

2015-06-10 Thread XZise
XZise closed this task as "Resolved". XZise added a comment. I've added quite a few corner cases to the tests so I don't think this has not been resolved. TASK DETAIL https://phabricator.wikimedia.org/T99032 EMAIL PREFERENCES https://phabricator.wikimedi

[Pywikipedia-bugs] [Maniphest] [Commented On] T101976: test_BlockEntry_old failure on wikia lyricwiki

2015-06-10 Thread XZise
XZise added a comment. Here's the corresponding result <http://lyrics.wikia.com/api.php?action=query&list=logevents&letype=block&format=jsonfm&lelimit=1&lestart=2015-06-10T14:13:11Z>: {

[Pywikipedia-bugs] [Maniphest] [Closed] T101601: Test failure in tests.http_tests.TestHttpStatus.test_follow_redirects

2015-06-12 Thread XZise
XZise closed this task as "Resolved". XZise claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T101601 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: gerritbot, jayvdb, pywikibot-bugs-list, Aklap

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T102365: test deprecation filename problems

2015-06-13 Thread XZise
XZise added a subscriber: XZise. TASK DETAIL https://phabricator.wikimedia.org/T102365 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: XZise, gerritbot, Aklapper, jayvdb, pywikibot-bugs-list

[Pywikipedia-bugs] [Maniphest] [Commented On] T102462: [break] request library isn't stable

2015-06-15 Thread XZise
XZise added a subscriber: XZise. XZise added a comment. Do you get a consistent traceback when you press Ctrl+C or does it get ignored? TASK DETAIL https://phabricator.wikimedia.org/T102462 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T102465: editor detection only supports a single argument

2015-06-15 Thread XZise
XZise added a subscriber: XZise. TASK DETAIL https://phabricator.wikimedia.org/T102465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: XZise, Aklapper, jayvdb, pywikibot-bugs-list ___ pywikibot

[Pywikipedia-bugs] [Maniphest] [Created] T102477: pass parameter in login script ignored

2015-06-15 Thread XZise
XZise created this task. XZise added subscribers: XZise, Shloub. XZise added projects: Pywikibot-login.py, pywikibot-core. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION The `-pass` parameter (in both variants) is ignored and the buffered password in the login script

[Pywikipedia-bugs] [Maniphest] [Updated] T102315: https only support

2015-06-16 Thread XZise
XZise added a subscriber: XZise. XZise added a comment. Okay looking through the https://phabricator.wikimedia.org/tag/pywikibot-core/ repository (excluding the tests): - There are three instances where links are used as documentation so they won't cause the bot to fail (patrol s

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T102734: rollback needs tests; revertbot mentions badtoken

2015-06-16 Thread XZise
XZise added a subscriber: XZise. TASK DETAIL https://phabricator.wikimedia.org/T102734 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: XZise, Aklapper, jayvdb, pywikibot-bugs-list ___ pywikibot

[Pywikipedia-bugs] [Maniphest] [Commented On] T60878: Report sensible error when family file cannot be loaded

2015-06-17 Thread XZise
XZise added a subscriber: XZise. XZise added a comment. I think it's catching the `ImportError` in case someone added their own family file to `config.family_files`. I actually think that we shouldn't even catching the `KeyError` there but doing that separately so that any `KeyErr

[Pywikipedia-bugs] [Maniphest] [Commented On] T85658: site.interwiki can be broken by a family that needs _get_path_regex

2015-06-17 Thread XZise
XZise added a comment. Okay I don't see how that is an issue of `_get_path_regex`? This is just an oversight in whoever added the second entry to all the dicts. We can nothing do about it without manually reading the file and interpreting it because that is just wrong code. TASK D

[Pywikipedia-bugs] [Maniphest] [Commented On] T85658: site.interwiki can be broken by a family that needs _get_path_regex

2015-06-17 Thread XZise
XZise added a comment. And regarding the encoding error: The HTML file was just simply encoded incorrectly (using latin-1 instead of utf-8) and I contacted the Wiki admin who fixed that. TASK DETAIL https://phabricator.wikimedia.org/T85658 EMAIL PREFERENCES https

[Pywikipedia-bugs] [Maniphest] [Commented On] T102365: test deprecation filename problems

2015-06-17 Thread XZise
XZise added a subscriber: XZise. XZise added a comment. Okay it seems that I've been able to reproduce this bug in Python 3.4.3 too. TASK DETAIL https://phabricator.wikimedia.org/T102365 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZi

[Pywikipedia-bugs] [Maniphest] [Commented On] T102365: test deprecation filename problems

2015-06-17 Thread XZise
XZise added a comment. Okay maybe false alarm but I got it because it actually didn't call the deprecated method but something that called the deprecated method (so the caller was no in the tests file). But maybe we have some code that wraps around the deprecated methods in certain case

[Pywikipedia-bugs] [Maniphest] [Commented On] T102365: test deprecation filename problems

2015-06-17 Thread XZise
XZise added a comment. Alternatively (if all the failures are related to SSL) it might be related to https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning TASK DETAIL https://phabricator.wikimedia.org/T102365 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Updated] T97535: In python 3 page objects are represented by bytes instead of Unicode strings

2015-06-17 Thread XZise
XZise added a subscriber: XZise. XZise added a comment. This seems similar to T95809: Page's repr returns invalid data causing Python to error <https://phabricator.wikimedia.org/T95809>. TASK DETAIL https://phabricator.wikimedia.org/T97535 EMAIL PREFEREN

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T102741: Python library for Wikibase data values

2015-06-17 Thread XZise
XZise added a subscriber: XZise. TASK DETAIL https://phabricator.wikimedia.org/T102741 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: XZise, Ricordisamoa, Yurik, Husky, mkroetzsch, Denny, jcreus, Legoktm, Pyfisch, johl, Lucie

[Pywikipedia-bugs] [Maniphest] [Commented On] T102734: rollback needs tests; revertbot mentions badtoken

2015-06-18 Thread XZise
XZise added a comment. We need to determine how the tokens are used. I can only check on one third party wiki using 1.24.2 but it supports tokens via `query+revisions` as well as `query+tokens`. And the latter one is independent of the revision while the former seems to depend on the author of

[Pywikipedia-bugs] [Maniphest] [Commented On] T89769: testQueryApiGetter timeout failure

2015-06-18 Thread XZise
XZise added a comment. Okay it now happened on Travis and the site properly returns a 502 status code as seen in line 1438 <https://travis-ci.org/wikimedia/pywikibot-core/jobs/67344236#L1438>: testQueryApiGetter (tests.wikidataquery_tests.TestApiSlowFunctions) Test that we can ac

[Pywikipedia-bugs] [Maniphest] [Updated] T103069: requests version on labs fails with (x, y) timeout argument

2015-06-19 Thread XZise
XZise added a subscriber: XZise. XZise added a comment. With https://phabricator.wikimedia.org/rPWBCd36788195fc07ac97b3e33a66dee3f71be497d10 the requests' timeout parameter is used and by default using a tuple. And it appears that older versions of requests or urllib3 don't suppor

[Pywikipedia-bugs] [Maniphest] [Commented On] T103069: requests version on labs fails with (x, y) timeout argument

2015-06-19 Thread XZise
XZise added a comment. Okay requests 2.4.0 <http://docs.python-requests.org/en/latest/community/updates/#id21> adds support for multiple timeouts although it's unclear if that is because of urllib3. Looking into urllib3's documentation it does support complex timeouts but doe

[Pywikipedia-bugs] [Maniphest] [Commented On] T103080: Link should recognise {{ns:Project}} in text

2015-06-19 Thread XZise
XZise added a subscriber: XZise. XZise added a comment. Hmm does something like this work: {{ns:Project}}{{ns:Project}}Bar In that case it could be a little more complicated and do we only want to support “ns”? TASK DETAIL https://phabricator.wikimedia.org/T103080 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Created] T103154: config parser shouldn't warn on allowed types

2015-06-19 Thread XZise
XZise created this task. XZise added a subscriber: XZise. XZise added a project: pywikibot-core. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION The config reader warns when the type has changed (under certain circumstances). Most values shouldn't change the typ

[Pywikipedia-bugs] [Maniphest] [Commented On] T103154: config parser shouldn't warn on allowed types

2015-06-19 Thread XZise
XZise added a comment. I'd suggest something like this: For each configuration variable there can be an callable that has a similar name (e.g. `_socket_timeout_type`) which takes the value and returns whether it's valid and it could be something like this then: _socket_timeout_typ

[Pywikipedia-bugs] [Maniphest] [Claimed] T103154: config parser shouldn't warn on allowed types

2015-06-19 Thread XZise
XZise claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T103154 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: Aklapper, pywikibot-bugs-list, XZise, jayvdb, Malyacko, Mjbmr, P.Copp

[Pywikipedia-bugs] [Maniphest] [Claimed] T103069: requests version on labs fails with (x, y) timeout argument

2015-06-19 Thread XZise
XZise claimed this task. XZise set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T103069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: gerritbot, XZise, Aklapper, valhallasw, pywikibot-bugs-list, jayvdb, Malyacko

[Pywikipedia-bugs] [Maniphest] [Updated] T78396: Load languages_by_size from the API or from WMF Labs

2015-06-21 Thread XZise
XZise added a blocked task: T89451: Reducing complexity of the Family class. TASK DETAIL https://phabricator.wikimedia.org/T78396 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, XZise Cc: jayvdb, Ladsgroup, Ricordisamoa, Aklapper

[Pywikipedia-bugs] [Maniphest] [Updated] T89451: Reducing complexity of the Family class

2015-06-21 Thread XZise
XZise added a blocking task: T78396: Load languages_by_size from the API or from WMF Labs. TASK DETAIL https://phabricator.wikimedia.org/T89451 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: Ricordisamoa, gerritbot, Omegat, jayvdb

[Pywikipedia-bugs] [Maniphest] [Updated] T103253: unicodeDecodeError occured

2015-06-21 Thread XZise
XZise added a subscriber: XZise. XZise added a comment. Are you working on a Python 3 or Python 2 installation? And it might be related to https://phabricator.wikimedia.org/T95809. Afaik repr() should return ASCII compatible bytes in Python 2. I'm not sure about Python 3 though. TASK D

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T103253: UnicodeDecodeError occured

2015-06-21 Thread XZise
XZise added a subscriber: jayvdb. XZise added a comment. Okay looking at it there may be several factors. For one `unicode_literals` (https://phabricator.wikimedia.org/rPWBC1e54a7d6886d56a21101900025038e25bab5ad03) adds that strings (using just quotes) are now unicode. Now this does not

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T103253: UnicodeDecodeError occured

2015-06-21 Thread XZise
XZise added a subscriber: valhallasw. XZise added a comment. Alternatively we could avoid this using @valhallasw's patch (gerrit 211646 <https://gerrit.wikimedia.org/r/#/c/211646/>) which would normalize the parameters before they are being written into `_params`. That way the lo

[Pywikipedia-bugs] [Maniphest] [Commented On] T103253: UnicodeDecodeError occured

2015-06-21 Thread XZise
XZise added a comment. No it has been broken with https://phabricator.wikimedia.org/rPWBC853e6b0bdce3e4fe60920c1c04f64d3a8eecde5e so since about a week. TASK DETAIL https://phabricator.wikimedia.org/T103253 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Pywikipedia-bugs] [Maniphest] [Commented On] T103284: wikibase edit tests fail loading family calendarmodel

2015-06-22 Thread XZise
XZise added a subscriber: XZise. XZise added a comment. Okay this is either a simple bug in our testing environment or a larger issue in the general framework, because the `WbTime` could know the site if it was associated with the claim on creation as it could use the claim's site. As a

[Pywikipedia-bugs] [Maniphest] [Updated] T74873: Family detection [tracking]

2015-06-22 Thread XZise
XZise added a comment. This intersects partially https://phabricator.wikimedia.org/T89451 as the bug tries to reduce the number of family features known beforehand. E.g. if the wikibase service could be determine via the API it is not necessary to detect it in generate_family_files.py. TASK

[Pywikipedia-bugs] [Maniphest] [Updated] T103207: Interwiki sorting order for West Frisian Wikibooks

2015-06-22 Thread XZise
XZise added a comment. Regarding https://phabricator.wikimedia.org/T89451 I submitted a patch which allows wikis to define their pywikibot settings dynamically: Gerrit 201446 <https://gerrit.wikimedia.org/r/#/c/201446/> In that the wiki could define their own sorting. We might have dif

[Pywikipedia-bugs] [Maniphest] [Reopened] T78125: Unexpected LogEntry.title() behavior

2015-06-22 Thread XZise
XZise reopened this task as "Stalled". XZise added a comment. I think stalled is appropriate as my patch does not solve this issue but just makes it easier in the future to resolve it properly (by returning the title string in title()). TASK DETAIL https://phabricator.wikimedia.

[Pywikipedia-bugs] [Maniphest] [Commented On] T78125: Unexpected LogEntry.title() behavior

2015-06-22 Thread XZise
XZise added a comment. Even if we delete it/replace it by a property this would be tracked by this bug. And I agree that properties sound more appropriate as afaik all parameters have no other parameters. And it seems like a reversed DotReadableDict. TASK DETAIL https

[Pywikipedia-bugs] [Maniphest] [Commented On] T103253: UnicodeDecodeError occured

2015-06-22 Thread XZise
XZise added a comment. What do you mean with “old implementation” and the original traceback doesn't make sense in close inspection. Did you change the files after starting the script? For example I can't explain why raising the error should cause an API request. And then a line

[Pywikipedia-bugs] [Maniphest] [Commented On] T103253: UnicodeDecodeError occured

2015-06-22 Thread XZise
XZise added a comment. I guess with Sun, Jun 21, 12:23 you mean https://phabricator.wikimedia.org/T103253#1385780 (it shows to me 10:23 which would make sense as I've afaik set it to UTC and you probably to CEST). And these work without any API. I've looked more closely in the erro

[Pywikipedia-bugs] [Maniphest] [Commented On] T69663: unsigned comments cause travis build breakage

2015-06-22 Thread XZise
XZise added a subscriber: XZise. XZise added a comment. @Mpaa: just a editorial note but using `>` you can quote someone, or click on the arrow pointing down and selecting “Quote”: > Hello World TASK DETAIL https://phabricator.wikimedia.org/T69663 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T103253: UnicodeDecodeError occured

2015-06-22 Thread XZise
XZise added a comment. Okay I've submitted https://gerrit.wikimedia.org/r/220002 which reproduces this failure (it's currently an expected failure so it won't be visible). TASK DETAIL https://phabricator.wikimedia.org/T103253 EMAIL PREFERENCES https://phabricator.wikimed

[Pywikipedia-bugs] [Maniphest] [Commented On] T103253: UnicodeDecodeError occured

2015-06-22 Thread XZise
XZise added a comment. In https://phabricator.wikimedia.org/T103253#1385869, @XZise wrote: > Alternatively we could avoid this using @valhallasw's patch (gerrit 211646 > <https://gerrit.wikimedia.org/r/#/c/211646/>) which would normalize the > parameters before they ar

[Pywikipedia-bugs] [Maniphest] [Updated] T103253: UnicodeDecodeError occured

2015-06-22 Thread XZise
XZise added a blocking task: T95809: Page's repr returns invalid data causing Python to error. TASK DETAIL https://phabricator.wikimedia.org/T103253 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, XZise Cc: valhallasw, jayvdb, gerritbot,

[Pywikipedia-bugs] [Maniphest] [Updated] T95809: Page's repr returns invalid data causing Python to error

2015-06-22 Thread XZise
XZise added a blocked task: T103253: UnicodeDecodeError occured. TASK DETAIL https://phabricator.wikimedia.org/T95809 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: jayvdb, Dalba, pywikibot-bugs-list, Aklapper, XZise

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T103480: textlib.replace_links Fails with AttributeError

2015-06-23 Thread XZise
XZise added a subscriber: XZise. TASK DETAIL https://phabricator.wikimedia.org/T103480 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, XZise Cc: XZise, Aklapper, Xqt, pywikibot-bugs-list, jayvdb

[Pywikipedia-bugs] [Maniphest] [Closed] T103480: textlib.replace_links Fails with AttributeError

2015-06-23 Thread XZise
XZise closed this task as "Resolved". XZise added a comment. *sinks into ground ashamed* TASK DETAIL https://phabricator.wikimedia.org/T103480 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, XZise Cc: gerritbot, XZise, Aklapper, Xqt,

[Pywikipedia-bugs] [Maniphest] [Closed] T98690: Warning that the wikimedia family is named incorrectly

2015-06-23 Thread XZise
XZise closed this task as "Resolved". XZise assigned this task to Xqt. XZise set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T98690 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, XZise Cc: pywikibot-bugs-list

[Pywikipedia-bugs] [Maniphest] [Updated] T85658: site.interwiki can be broken by a family that needs _get_path_regex

2015-06-23 Thread XZise
XZise added a comment. Found it: T88928: Encoding error on the some sites of the IWM <https://phabricator.wikimedia.org/T88928> TASK DETAIL https://phabricator.wikimedia.org/T85658 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb, XZ

[Pywikipedia-bugs] [Maniphest] [Commented On] T95810: config does differ between unicode and str

2015-06-23 Thread XZise
XZise added a comment. With gerrit 219589 <https://gerrit.wikimedia.org/r/#/c/219589/> we might be able to do that separately and not just update all strings into unicodes. TASK DETAIL https://phabricator.wikimedia.org/T95810 EMAIL PREFERENCES https://phabricator.wikimedia.org/se

[Pywikipedia-bugs] [Maniphest] [Closed] T101838: generate_user_files warns about unknown arguments with pwb

2015-06-24 Thread XZise
XZise closed this task as "Resolved". XZise assigned this task to jayvdb. XZise set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T101838 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb, XZise Cc: gerritbot, pywi

[Pywikipedia-bugs] [Maniphest] [Unblock] T72936: Pywikibot 2.1 [tracking]

2015-06-24 Thread XZise
XZise closed blocking task T74503: pwb.py does not run scripts if user-config.py does not exist as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T72936 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: Xqt, jayvdb, Ri

  1   2   3   4   5   6   >