[Pywikipedia-bugs] [Maniphest] [Commented On] T278046: Convert epytext docstrings to reST (sphinx)

Huji added a comment. @Xqt for my own education as well as improving the task definition for future reference, can you put some links that describe the history of epytext or indicate that it is not maintained (since when) and about the sphinx-epytext conversion? TASK DETAIL https://phabri

[Pywikipedia-bugs] [Maniphest] [Commented On] T278046: Convert epytext docstrings to reST (sphinx)

Huji added a comment. Thanks. Updating task accordingly. TASK DETAIL https://phabricator.wikimedia.org/T278046 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, Huji Cc: jayvdb, Huji, Aklapper, Xqt, pywikibot-bugs-list, Jyoo1011, JohnsonLee01,

[Pywikipedia-bugs] [Maniphest] [Commented On] T278046: Convert epytext docstrings to reST (sphinx)

gerritbot added a comment. Change 673836 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [doc] convert epytext docstrings to sphinx format https://gerrit.wikimedia.org/r/673836 TASK DETAIL https://phabricator.wikimedia.org/T278046 EMAIL PREFERENCES ht

[Pywikipedia-bugs] [Maniphest] [Commented On] T278046: Convert epytext docstrings to reST (sphinx)

Xqt added a comment. I am not happy with `darglint` docstring checker. It introduces a new undocumented `yield(s)` Sphinx token and does not handle `*args` and `**kwargs` parameter correctly (needs the the stars for the parameter name) and finally it is not possible to keyword token (probabl

[Pywikipedia-bugs] [Maniphest] [Commented On] T278046: Convert epytext docstrings to reST (sphinx)

gerritbot added a comment. Change 673836 **abandoned** by Xqt: [pywikibot/core@master] [doc] convert epytext docstrings to sphinx format Reason: see task https://gerrit.wikimedia.org/r/673836 TASK DETAIL https://phabricator.wikimedia.org/T278046 EMAIL PREFERENCES https

[Pywikipedia-bugs] [Maniphest] [Commented On] T278046: Convert epytext docstrings to reST (sphinx)

atagar added a comment. Hi Xqt. I really like your CR 673836 and would love to move this along. Unfortunately your CI link no longer works - what kind of errors did you experience and can we reproduce them locally? > I am not h

[Pywikipedia-bugs] [Maniphest] [Commented On] T278046: Convert epytext docstrings to reST (sphinx)

atagar added a comment. > Currently the only check is made by sphinx but there is no code validation. If we don't have existing epytext lint checks then why is reST linting a requirement to proceed with your change? Or did we discard the change for reasons aside from darglint? TASK DETA

[Pywikipedia-bugs] [Maniphest] [Commented On] T278046: Convert epytext docstrings to reST (sphinx)

Xqt added a comment. In T278046#7110223 , @atagar wrote: >> Currently the only check is made by sphinx but there is no code validation. > > If we don't have existing epytext lint checks then why is reST linting a requirement to proce

[Pywikipedia-bugs] [Maniphest] [Commented On] T278046: Convert epytext docstrings to reST (sphinx)

atagar added a comment. >> If we don't have existing epytext lint checks then why is reST linting a requirement to proceed with your change? Or did we discard the change for reasons aside from darglint? > > rstcheck validates the reSt syntax. It does not validate the content. Hi Xqt.

[Pywikipedia-bugs] [Maniphest] [Commented On] T278046: Convert epytext docstrings to reST (sphinx)

Xqt added a comment. In T278046#7121516 , @atagar wrote: >>> If we don't have existing epytext lint checks then why is reST linting a requirement to proceed with your change? Or did we discard the change for reasons aside from darglint?

[Pywikipedia-bugs] [Maniphest] [Commented On] T278046: Convert epytext docstrings to reST (sphinx)

atagar added a comment. > Don't see any advantage. Isn't the advantage that epytext is unmaintained as of 2008 and reSt is the documentation format most python projects use? For my part I've extensively worked with Sphinx's reSt whereas pywikibot is the first time I've ever seen epytext

[Pywikipedia-bugs] [Maniphest] [Commented On] T278046: Convert epytext docstrings to reST (sphinx)

Xqt added a comment. In T278046#7122672 , @atagar wrote: >> Don't see any advantage. > > Isn't the advantage that epytext is unmaintained as of 2008 and reSt is the documentation format most python projects use? For my part I've exte

[Pywikipedia-bugs] [Maniphest] [Commented On] T278046: Convert epytext docstrings to reST (sphinx)

gerritbot added a comment. Change 673836 **restored** by Xqt: [pywikibot/core@master] [doc] convert epytext docstrings to sphinx format https://gerrit.wikimedia.org/r/673836 TASK DETAIL https://phabricator.wikimedia.org/T278046 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T278046: Convert epytext docstrings to reST (sphinx)

gerritbot added a comment. Change 673836 **merged** by jenkins-bot: [pywikibot/core@master] [doc] convert epytext docstrings to sphinx format https://gerrit.wikimedia.org/r/673836 TASK DETAIL https://phabricator.wikimedia.org/T278046 EMAIL PREFERENCES https://phabricator.wikimed