Re: [Qemu-block] [Qemu-devel] [PATCH] Revert "blockdev: add note that block_job_cb() must be thread-safe"

2015-10-14 Thread Fam Zheng
- Original Message - > On Tue, Oct 13, 2015 at 06:16:15PM +0800, Fam Zheng wrote: > > This reverts commit 723c5d93c51bdb3adbc238ce90195c0864aa6cd5. > > > > block_job_cb is called by block_job_completed, which is always called in > > a main loop bottom half in existing block jobs. So we d

Re: [Qemu-block] [PATCH v10 08/10] Implement new driver for block replication

2015-10-14 Thread Wen Congyang
On 10/14/2015 10:27 PM, Stefan Hajnoczi wrote: > On Tue, Oct 13, 2015 at 05:08:17PM +0800, Wen Congyang wrote: >> On 10/13/2015 12:27 AM, Stefan Hajnoczi wrote: >>> On Fri, Sep 25, 2015 at 02:17:36PM +0800, Wen Congyang wrote: +/* start backup job now */ +bdrv_op_unblock(s

Re: [Qemu-block] [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-14 Thread Peter Lieven
Am 08.10.2015 um 18:44 schrieb John Snow: > > On 10/08/2015 08:06 AM, Peter Lieven wrote: >> Hi all, >> >> short summary from my side. The whole thing seems to get complicated, >> let me explain why: >> >> 1) During review I found that the code in ide_atapi_cmd_reply_end can't >> work correctly if

Re: [Qemu-block] [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-14 Thread John Snow
On 10/14/2015 02:19 PM, Peter Lieven wrote: > Am 08.10.2015 um 18:44 schrieb John Snow: >> >> On 10/08/2015 08:06 AM, Peter Lieven wrote: >>> Hi all, >>> >>> short summary from my side. The whole thing seems to get complicated, >>> let me explain why: >>> >>> 1) During review I found that the cod

Re: [Qemu-block] [PATCH 3/3] block: use bdrv_lookup_bs() over blk_by_name() for BDS only results

2015-10-14 Thread Jeff Cody
On Wed, Oct 14, 2015 at 08:05:34PM +0200, Max Reitz wrote: > On 14.10.2015 15:16, Jeff Cody wrote: > > To find a BlockDriverState interface, it can be done via blk_by_name(), > > bdrv_find_node(), and bdrv_lookup_bs(). The latter can take the place > > of the other two, in the instances where we a

Re: [Qemu-block] [PATCH 3/3] block: use bdrv_lookup_bs() over blk_by_name() for BDS only results

2015-10-14 Thread Max Reitz
On 14.10.2015 15:16, Jeff Cody wrote: > To find a BlockDriverState interface, it can be done via blk_by_name(), > bdrv_find_node(), and bdrv_lookup_bs(). The latter can take the place > of the other two, in the instances where we are only concerned with the > BlockDriverState. > > In much of the

Re: [Qemu-block] [PATCH 1/3] block: Use bdrv_lookup_bs() instead of bdrv_find_node()

2015-10-14 Thread Jeff Cody
On Wed, Oct 14, 2015 at 07:34:43PM +0200, Max Reitz wrote: > On 14.10.2015 19:29, Max Reitz wrote: > > On 14.10.2015 15:16, Jeff Cody wrote: > >> This is a precursor to making bdrv_find_node() static, and internal > >> to block.c > >> > >> To find a BlockDriverState interface, it can be done via bl

Re: [Qemu-block] [PATCH 2/3] block: make bdrv_find_node() static

2015-10-14 Thread Max Reitz
On 14.10.2015 15:16, Jeff Cody wrote: > This patch does two things: it moves bdrv_find_node() up before the > first usage in block.c, and it makes the function static so that it > is only internal to block.c. > > Signed-off-by: Jeff Cody > --- > block.c | 30 +++

Re: [Qemu-block] [PATCH 1/3] block: Use bdrv_lookup_bs() instead of bdrv_find_node()

2015-10-14 Thread Max Reitz
On 14.10.2015 19:29, Max Reitz wrote: > On 14.10.2015 15:16, Jeff Cody wrote: >> This is a precursor to making bdrv_find_node() static, and internal >> to block.c >> >> To find a BlockDriverState interface, it can be done via blk_by_name(), >> bdrv_find_node(), and bdrv_lookup_bs(). The latter can

Re: [Qemu-block] [PATCH 1/3] block: Use bdrv_lookup_bs() instead of bdrv_find_node()

2015-10-14 Thread Max Reitz
On 14.10.2015 15:16, Jeff Cody wrote: > This is a precursor to making bdrv_find_node() static, and internal > to block.c > > To find a BlockDriverState interface, it can be done via blk_by_name(), > bdrv_find_node(), and bdrv_lookup_bs(). The latter can take the place > of the other two, in the i

Re: [Qemu-block] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default

2015-10-14 Thread Paolo Bonzini
On 14/10/2015 12:29, Cornelia Huck wrote: > Do we want to change anything for 2.5 about the default? > > Currently, we still default scsi to true, and you have to disable it > explicitly if you want to use virtio-1 compliant virtio-blk devices > (which is a bit annoying, as scsi passthrough is n

Re: [Qemu-block] [PATCH v6 25/39] blockdev: Pull out blockdev option extraction

2015-10-14 Thread Max Reitz
On 14.10.2015 17:12, Kevin Wolf wrote: > Am 12.10.2015 um 22:00 hat Max Reitz geschrieben: >> Extract some of the blockdev option extraction code from blockdev_init() >> into its own function. This simplifies blockdev_init() and will allow >> reusing the code in a different function added in a foll

Re: [Qemu-block] [PATCH v6 24/39] blockdev: Do not create BDS for empty drive

2015-10-14 Thread Max Reitz
On 14.10.2015 15:27, Kevin Wolf wrote: > Am 12.10.2015 um 22:00 hat Max Reitz geschrieben: >> Do not use "rudimentary" BDSs for empty drives any longer (for >> freshly created drives). >> >> After a follow-up patch, empty drives will generally use a NULL BDS, not >> only the freshly created drives.

Re: [Qemu-block] [PATCH v6 25/39] blockdev: Pull out blockdev option extraction

2015-10-14 Thread Kevin Wolf
Am 12.10.2015 um 22:00 hat Max Reitz geschrieben: > Extract some of the blockdev option extraction code from blockdev_init() > into its own function. This simplifies blockdev_init() and will allow > reusing the code in a different function added in a follow-up patch. > > Signed-off-by: Max Reitz

Re: [Qemu-block] [PATCH v6 23/39] block: Prepare for NULL BDS

2015-10-14 Thread Max Reitz
On 13.10.2015 17:37, Kevin Wolf wrote: > Am 12.10.2015 um 22:00 hat Max Reitz geschrieben: >> blk_bs() will not necessarily return a non-NULL value any more (unless >> blk_is_available() is true or it can be assumed to otherwise, e.g. >> because it is called immediately after a successful blk_new_w

Re: [Qemu-block] [PATCH v10 08/10] Implement new driver for block replication

2015-10-14 Thread Stefan Hajnoczi
On Tue, Oct 13, 2015 at 05:08:17PM +0800, Wen Congyang wrote: > On 10/13/2015 12:27 AM, Stefan Hajnoczi wrote: > > On Fri, Sep 25, 2015 at 02:17:36PM +0800, Wen Congyang wrote: > >> +/* start backup job now */ > >> +bdrv_op_unblock(s->hidden_disk, BLOCK_OP_TYPE_BACKUP_TARGET, > >> +

Re: [Qemu-block] [PATCH v10 02/10] Backup: clear all bitmap when doing block checkpoint

2015-10-14 Thread Stefan Hajnoczi
On Tue, Oct 13, 2015 at 05:13:14PM +0800, Wen Congyang wrote: > On 10/12/2015 09:45 PM, Stefan Hajnoczi wrote: > > On Fri, Sep 25, 2015 at 02:17:30PM +0800, Wen Congyang wrote: > >> Signed-off-by: Wen Congyang > >> Signed-off-by: zhanghailiang > >> Signed-off-by: Gonglei > >> Reviewed-by: Jeff C

Re: [Qemu-block] [PATCH] Revert "blockdev: add note that block_job_cb() must be thread-safe"

2015-10-14 Thread Stefan Hajnoczi
On Tue, Oct 13, 2015 at 06:16:15PM +0800, Fam Zheng wrote: > This reverts commit 723c5d93c51bdb3adbc238ce90195c0864aa6cd5. > > block_job_cb is called by block_job_completed, which is always called in > a main loop bottom half in existing block jobs. So we don't need to > worry about thread-safety

Re: [Qemu-block] [PATCH v6 24/39] blockdev: Do not create BDS for empty drive

2015-10-14 Thread Kevin Wolf
Am 12.10.2015 um 22:00 hat Max Reitz geschrieben: > Do not use "rudimentary" BDSs for empty drives any longer (for > freshly created drives). > > After a follow-up patch, empty drives will generally use a NULL BDS, not > only the freshly created drives. > > Signed-off-by: Max Reitz > --- > bloc

[Qemu-block] [PATCH 3/3] block: use bdrv_lookup_bs() over blk_by_name() for BDS only results

2015-10-14 Thread Jeff Cody
To find a BlockDriverState interface, it can be done via blk_by_name(), bdrv_find_node(), and bdrv_lookup_bs(). The latter can take the place of the other two, in the instances where we are only concerned with the BlockDriverState. In much of the usage of blk_by_name(), we can simplify the code b

[Qemu-block] [PATCH 2/3] block: make bdrv_find_node() static

2015-10-14 Thread Jeff Cody
This patch does two things: it moves bdrv_find_node() up before the first usage in block.c, and it makes the function static so that it is only internal to block.c. Signed-off-by: Jeff Cody --- block.c | 30 +++--- include/block/block.h | 1 - 2 files chang

[Qemu-block] [PATCH 0/3] Prefer bdrv_lookup_bs() to find BDS nodes

2015-10-14 Thread Jeff Cody
This series is on top of Alberto's "Add 'blockdev-snapshot' command" series BlockBackend devices and BlockDriverState node-names occupy the same namespace. In addition, there are two methods that can be used in different circumstances to look up a BlockDriverState: blk_by_name() and bdrv_find_nod

[Qemu-block] [PATCH 1/3] block: Use bdrv_lookup_bs() instead of bdrv_find_node()

2015-10-14 Thread Jeff Cody
This is a precursor to making bdrv_find_node() static, and internal to block.c To find a BlockDriverState interface, it can be done via blk_by_name(), bdrv_find_node(), and bdrv_lookup_bs(). The latter can take the place of the other two, in the instances where we are only concerned with the Bloc

Re: [Qemu-block] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-14 Thread Paul Durrant
> -Original Message- > From: Fabio Fantoni [mailto:fabio.fant...@m2r.biz] > Sent: 14 October 2015 12:12 > To: Kevin Wolf; Stefano Stabellini > Cc: John Snow; Anthony Perard; qemu-de...@nongnu.org; xen- > de...@lists.xen.org; qemu-block@nongnu.org; Paul Durrant > Subject: Re: [Qemu-devel] Qu

Re: [Qemu-block] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-14 Thread Stefano Stabellini
On Wed, 14 Oct 2015, Kevin Wolf wrote: > Am 14.10.2015 um 13:06 hat Stefano Stabellini geschrieben: > > On Wed, 14 Oct 2015, Kevin Wolf wrote: > > > [ CC qemu-block ] > > > > > > Am 13.10.2015 um 19:10 hat Stefano Stabellini geschrieben: > > > > On Tue, 13 Oct 2015, John Snow wrote: > > > > > On 1

Re: [Qemu-block] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-14 Thread Kevin Wolf
Am 14.10.2015 um 13:06 hat Stefano Stabellini geschrieben: > On Wed, 14 Oct 2015, Kevin Wolf wrote: > > [ CC qemu-block ] > > > > Am 13.10.2015 um 19:10 hat Stefano Stabellini geschrieben: > > > On Tue, 13 Oct 2015, John Snow wrote: > > > > On 10/13/2015 11:55 AM, Fabio Fantoni wrote: > > > > > I

Re: [Qemu-block] [Xen-devel] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-14 Thread Ian Campbell
On Wed, 2015-10-14 at 12:06 +0100, Stefano Stabellini wrote: > > Can't you just teach SeaBIOS how to deal with your PV disks and then > > only add that to your VM and forget about IDE/AHCI? I mean, that's how > > it's done for virtio-blk, and it doesn't involve any insanities like > > ripping out n

Re: [Qemu-block] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-14 Thread Fabio Fantoni
Il 14/10/2015 11:47, Kevin Wolf ha scritto: [ CC qemu-block ] Am 13.10.2015 um 19:10 hat Stefano Stabellini geschrieben: On Tue, 13 Oct 2015, John Snow wrote: On 10/13/2015 11:55 AM, Fabio Fantoni wrote: I added ahci disk support in libxl and using it for week seems that was ok, after a rep

Re: [Qemu-block] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-14 Thread Stefano Stabellini
On Wed, 14 Oct 2015, Kevin Wolf wrote: > [ CC qemu-block ] > > Am 13.10.2015 um 19:10 hat Stefano Stabellini geschrieben: > > On Tue, 13 Oct 2015, John Snow wrote: > > > On 10/13/2015 11:55 AM, Fabio Fantoni wrote: > > > > I added ahci disk support in libxl and using it for week seems that was > >

Re: [Qemu-block] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default

2015-10-14 Thread Cornelia Huck
On Wed, 15 Jul 2015 16:45:52 +0200 Paolo Bonzini wrote: > On 15/07/2015 16:28, Michael S. Tsirkin wrote: > > On Wed, Jul 15, 2015 at 04:18:49PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 15/07/2015 16:14, Michael S. Tsirkin wrote: > >>> On Wed, Jul 15, 2015 at 02:47:24PM +0200, Paolo Bonzini

Re: [Qemu-block] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-14 Thread Kevin Wolf
[ CC qemu-block ] Am 13.10.2015 um 19:10 hat Stefano Stabellini geschrieben: > On Tue, 13 Oct 2015, John Snow wrote: > > On 10/13/2015 11:55 AM, Fabio Fantoni wrote: > > > I added ahci disk support in libxl and using it for week seems that was > > > ok, after a reply of Stefano Stabellini seems th