On 12/14/2015 06:49 PM, Cornelia Huck wrote:
> On Mon, 14 Dec 2015 16:41:19 +0100
> Christian Borntraeger wrote:
>
>> large volume DASD that have > 64k cylinders do claim to have
>> 0xFFFE cylinders as special value in the old 16 bit field. We
>> want to pass this "token" along to the guest, inst
On 06/01/2016 18:57, John Snow wrote:
> Ronnie: Thanks for the explanation!
>
> Zhu: In light of this, can the patch be reworked slightly to explicitly
> check *why* READCAPACITY16 failed and only attempt the READCAPACITY10 as
> a fallback if it receives INVALID_OPCODE?
>
> If it fails for any
On 29/12/2015 04:32, Zhu Lingshan wrote:
> When play with Dell MD3000 target, for sure it
> is a TYPE_DISK, but readcapacity16 would fail.
> Then we find that readcapacity10 succeeded. It
> looks like the target just support readcapacity10
> even through it is a TYPE_DISK or have some
> TYPE_ROM
On Wed, Jan 06, 2016 at 03:04:40PM +0100, Igor Mammedov wrote:
> On Wed, 30 Dec 2015 23:11:50 +0300
> Roman Kagan wrote:
>
> > Windows on UEFI systems is only capable of detecting the presence and
> > the type of floppy drives via corresponding ACPI objects.
> >
> > Those objects are added in pa
On Thu, Jan 07, 2016 at 12:56:09PM +0200, Michael S. Tsirkin wrote:
> On Wed, Jan 06, 2016 at 03:04:40PM +0100, Igor Mammedov wrote:
> > On Wed, 30 Dec 2015 23:11:50 +0300
> > Roman Kagan wrote:
> >
> > > Windows on UEFI systems is only capable of detecting the presence and
> > > the type of flop
Notably, patch 2 introduces blk_try_blockalign. If it is acked by
the block layer maintainers I can submit the patch myself for
inclusion.
Paolo
Paolo Bonzini (2):
nbd: do not check request length except for reads and writes
nbd: do not exit on failed memory allocation
block/block-backend.
The amount of memory allocated in nbd_co_receive_request is driven by the
NBD client (possibly a virtual machine). Parallel I/O can cause the
server to allocate a large amount of memory; check for failures and
return ENOMEM in that case.
Signed-off-by: Paolo Bonzini
---
block/block-backend.c
On Thu, 7 Jan 2016 12:56:58 +0200
"Michael S. Tsirkin" wrote:
> On Thu, Jan 07, 2016 at 12:56:09PM +0200, Michael S. Tsirkin wrote:
> > On Wed, Jan 06, 2016 at 03:04:40PM +0100, Igor Mammedov wrote:
> > > On Wed, 30 Dec 2015 23:11:50 +0300
> > > Roman Kagan wrote:
> > >
> > > > Windows on U
On 10 November 2015 at 14:09, Kevin Wolf wrote:
> From: Max Reitz
>
> Implement 'change' on block devices by calling blockdev-open-tray,
> blockdev-remove-medium, blockdev-insert-medium (a variation of that
> which does not need a node-name) and blockdev-close-tray.
>
> Signed-off-by: Max Reitz
On 01/04/2016 05:27 AM, Fam Zheng wrote:
> This makes sure we don't leak a dirty bitmap in any case.
>
> Signed-off-by: Fam Zheng
> ---
> block/dirty-bitmap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
> index 9cac794..60ee965 100644
>
On 7 January 2016 at 19:37, Max Reitz wrote:
> Compare floppy disks, for which we now have a "virtual" tray status:
> Whenever a medium is inserted, the "tray" is considered closed.
> Otherwise, it is open. This works pretty much like a physical tray would
> work; whenever the tray is closed, you
On 01/04/2016 05:27 AM, Fam Zheng wrote:
> From: Vladimir Sementsov-Ogievskiy
>
> Functions to serialize / deserialize(restore) HBitmap. HBitmap should be
> saved to linear sequence of bits independently of endianness and bitmap
> array element (unsigned long) size. Therefore Little Endian is c
On 07.01.2016 14:44, Paolo Bonzini wrote:
> Only reads and writes need to allocate memory correspondent to the
> request length. Other requests can be sent to the storage without
> allocating any memory, and thus any request length is acceptable.
>
> Reported-by: Sitsofe Wheeler
> Cc: qemu-block
On 07.01.2016 14:44, Paolo Bonzini wrote:
> The amount of memory allocated in nbd_co_receive_request is driven by the
> NBD client (possibly a virtual machine). Parallel I/O can cause the
> server to allocate a large amount of memory; check for failures and
> return ENOMEM in that case.
>
> Signe
On 01/04/2016 05:27 AM, Fam Zheng wrote:
> Two major features are added to block dirty bitmap (and underlying HBitmap) in
> this series: meta bitmap and serialization, together with all other supportive
> patches.
>
> Both operations are common in dirty bitmap migration and persistence: they
>
On 7 January 2016 at 20:14, Max Reitz wrote:
> On 07.01.2016 20:56, Peter Maydell wrote:
>> It looks like sd.c is the only one which implements a change_media_cb
>> but no is_tray_open, but it would be nice if we could implement this
>> in the default blk_dev_is_tray_open() method rather than in t
On 07.01.2016 22:42, Peter Maydell wrote:
> On 7 January 2016 at 20:14, Max Reitz wrote:
>> On 07.01.2016 20:56, Peter Maydell wrote:
>>> It looks like sd.c is the only one which implements a change_media_cb
>>> but no is_tray_open, but it would be nice if we could implement this
>>> in the defaul
On 7 January 2016 at 21:57, Max Reitz wrote:
> On 07.01.2016 22:42, Peter Maydell wrote:
>> Well, previously sd.c didn't need to have any state for this
>> to all work right (or indeed care about implementing a fake
>> tray status for a device that doesn't have a tray), so it seems
>> odd that we
On 07.01.2016 23:19, Peter Maydell wrote:
> On 7 January 2016 at 21:57, Max Reitz wrote:
>> On 07.01.2016 22:42, Peter Maydell wrote:
>>> Well, previously sd.c didn't need to have any state for this
>>> to all work right (or indeed care about implementing a fake
>>> tray status for a device that d
From: Paolo Bonzini
Since check-block.sh, the "check" script has learnt to find the source
path. On the other hand, it expects common.env to be in the build tree
(both changes made in commit 76c7560, "configure: Enable out-of-tree
iotests", 2014-05-24). So, it is wrong to invoke "check" from th
From: Fam Zheng
Raw is as qualified as qcow2 for this test case, add it for more
coverage.
Signed-off-by: Fam Zheng
Message-id: 1450851979-15580-1-git-send-email-f...@redhat.com
Signed-off-by: Max Reitz
---
tests/qemu-iotests/086 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
Kevin is on PTO this week, so I am filling in for him.
The following changes since commit a7e00e2536941a6e570b45b7ab4afec4505ff67e:
petalogix-ml605: Set the MicroBlaze CPU version to 8.10.a (2016-01-07
14:57:26 +0100)
are available in the git repository at:
git://github.com/XanClic/qemu.g
From: Paolo Bonzini
bdrv_close is used when ejecting a medium. Use a drained section to ensure
that all I/O goes to either the old medium or the bitbucket.
Signed-off-by: Paolo Bonzini
Message-id: 1450867706-19860-2-git-send-email-pbonz...@redhat.com
Signed-off-by: Max Reitz
---
block.c | 4
From: Fam Zheng
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
Message-id: 1450752561-9300-8-git-send-email-f...@redhat.com
Signed-off-by: Max Reitz
---
tests/qemu-iotests/037 | 5 -
tests/qemu-iotests/037.out | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/tes
From: Fam Zheng
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
Message-id: 1450752561-9300-6-git-send-email-f...@redhat.com
Signed-off-by: Max Reitz
---
tests/qemu-iotests/028 | 5 -
tests/qemu-iotests/028.out | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/tes
From: Fam Zheng
Since a5002d5 (block/qapi: allow best-effort query) we don't return at
this error, however err must be cleared before passing to
bdrv_query_snapshot_info_list below, as required by error API.
Signed-off-by: Fam Zheng
Message-id: 1450779107-26765-1-git-send-email-f...@redhat.com
From: Fam Zheng
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
Message-id: 1450752561-9300-4-git-send-email-f...@redhat.com
Signed-off-by: Max Reitz
---
tests/qemu-iotests/020 | 7 +--
tests/qemu-iotests/020.out | 2 +-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/t
From: Fam Zheng
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
Message-id: 1450752561-9300-2-git-send-email-f...@redhat.com
Signed-off-by: Max Reitz
---
tests/qemu-iotests/018 | 8
tests/qemu-iotests/018.out | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/
From: Bo Tu
Replace the remaining "-drive file..."
by "-drive file=...,if=none,id=$device_id", then x86 and s390x
can get the common output.
"if=ide, if=floppy, if=scsi" are not supported by s390x,
so these test cases are not executed for s390x platform.
Signed-off-by: Bo Tu
Message-id: 1451885
From: Fam Zheng
It's necessary to distinguish source and target before we can add
blockdev-mirror, because we would want a concrete type of operation to
check on target bs before starting.
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
Message-id: 1450932306-13717-2-git-send-email-f...@redhat
From: Fam Zheng
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
Message-id: 1450752561-9300-3-git-send-email-f...@redhat.com
Signed-off-by: Max Reitz
---
tests/qemu-iotests/019 | 13 +++--
tests/qemu-iotests/019.out | 4 ++--
2 files changed, 9 insertions(+), 8 deletions(-)
diff
From: Fam Zheng
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
Message-id: 1450752561-9300-9-git-send-email-f...@redhat.com
Signed-off-by: Max Reitz
---
tests/qemu-iotests/038 | 5 -
tests/qemu-iotests/038.out | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/tes
From: Fam Zheng
This is the part that will be reused by blockdev-mirror.
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
Message-id: 1450932306-13717-3-git-send-email-f...@redhat.com
Signed-off-by: Max Reitz
---
blockdev.c | 114 ++---
From: Fam Zheng
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
Message-id: 1450752561-9300-7-git-send-email-f...@redhat.com
Signed-off-by: Max Reitz
---
tests/qemu-iotests/034 | 6 +-
tests/qemu-iotests/034.out | 2 +-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/te
From: Fam Zheng
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
Message-id: 1450752561-9300-5-git-send-email-f...@redhat.com
Signed-off-by: Max Reitz
---
tests/qemu-iotests/024 | 10 --
tests/qemu-iotests/024.out | 4 ++--
2 files changed, 10 insertions(+), 4 deletions(-)
diff -
From: Fam Zheng
This will start a mirror job from a named device to another named
device, its relation with drive-mirror is similar with blockdev-backup
to drive-backup.
In blockdev-mirror, the target node should be prepared by blockdev-add,
which will be responsible for assigning a name to the
From: Fam Zheng
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
Message-id: 1450752561-9300-10-git-send-email-f...@redhat.com
Signed-off-by: Max Reitz
---
tests/qemu-iotests/050 | 9 +++--
tests/qemu-iotests/050.out | 4 ++--
2 files changed, 9 insertions(+), 4 deletions(-)
diff --gi
From: Fam Zheng
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
Message-id: 1450932306-13717-4-git-send-email-f...@redhat.com
Signed-off-by: Max Reitz
---
blockdev.c| 3 +++
include/block/block.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 2
From: Fam Zheng
Signed-off-by: Fam Zheng
Message-id: 1450752561-9300-11-git-send-email-f...@redhat.com
Signed-off-by: Max Reitz
---
tests/qemu-iotests/095 | 6 ++
tests/qemu-iotests/095.out | 4 ++--
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/tests/qemu-iotests/095
From: Fam Zheng
Signed-off-by: Fam Zheng
Message-id: 1450752561-9300-12-git-send-email-f...@redhat.com
Signed-off-by: Max Reitz
---
tests/qemu-iotests/095 | 4 ++--
tests/qemu-iotests/095.out | 2 --
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/tests/qemu-iotests/095 b/te
From: Fam Zheng
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
Message-id: 1450932306-13717-6-git-send-email-f...@redhat.com
Signed-off-by: Max Reitz
---
tests/qemu-iotests/041 | 100 ++---
tests/qemu-iotests/041.out | 4 +-
2 files changed, 79 i
On Thu, 01/07 16:32, John Snow wrote:
>
>
> On 01/04/2016 05:27 AM, Fam Zheng wrote:
> > Two major features are added to block dirty bitmap (and underlying HBitmap)
> > in
> > this series: meta bitmap and serialization, together with all other
> > supportive
> > patches.
> >
> > Both operation
The added parameter can be used to return the BDS pointer which the
valid offset is referring to. Its value should be ignored unless
BDRV_BLOCK_OFFSET_VALID in ret is set.
Until block drivers fill in the right value, let's clear it explicitly
right before calling .bdrv_get_block_status.
The "bs->
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Fam Zheng
---
block/qcow2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qcow2.c b/block/qcow2.c
index 7096a29..da74eb7 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1348,6 +1348,7 @@ static int64_t coroutine_fn
qcow2_co_get_block_st
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Fam Zheng
---
block/qcow.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qcow.c b/block/qcow.c
index 558f443..b59383f 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -509,6 +509,7 @@ static int64_t coroutine_fn
qco
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Fam Zheng
---
block/raw-posix.c | 1 +
block/raw_bsd.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index 6fc0b71..344272f 100644
--- a/block/raw-posix.c
+++ b/block/raw-posix.c
v6: Two more changes as suggested by Max:
- Fix comments of BDRV_BLOCK_OFFSET_VALID and BDRV_BLOCK_DATA;
- Really keep 102 working;
- Add rev-by in patch 11.
v5: Address Max's review comments:
- "It's" -> "Its" in commit message in patch 1;
- Retain the "bs->file" condition to
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
---
block/vmdk.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index f5a56fd..59e1ffe 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -1265,6 +1265,7 @@ static int64_t coroutine_fn
vmdk_
The "flags" bit mask is expanded to two booleans, "data" and "zero";
"bs" is replaced with "filename" string.
Refactor the merge conditions in img_map() into entry_mergeable().
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Fam Zheng
---
qapi/block-core.json | 27
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Fam Zheng
---
block/parallels.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/parallels.c b/block/parallels.c
index d83246b..129668b 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -273,6 +273,7 @@ static
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Fam Zheng
---
block/iscsi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/iscsi.c b/block/iscsi.c
index 2d1e230..8c7f1b3 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -625,6 +625,9 @@ out:
if (iTask.task
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Fam Zheng
---
block/qed.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/qed.c b/block/qed.c
index a6bbd8b..03af9c1 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -692,6 +692,7 @@ typedef struct {
uint64_t pos
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Fam Zheng
---
block/vdi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/vdi.c b/block/vdi.c
index 2199fd3..6b1a57b 100644
--- a/block/vdi.c
+++ b/block/vdi.c
@@ -550,6 +550,7 @@ static int64_t coroutine_fn
vdi_co_get_block_status(BlockDriv
Now all drivers should return a correct "file", we can make use of it,
even with the recursion into backing chain above.
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Fam Zheng
---
qemu-img.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-img.c b
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/059 | 10 ++
tests/qemu-iotests/059.out | 38 ++
2 files changed, 48 insertions(+)
diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059
i
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Fam Zheng
---
block/vpc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/vpc.c b/block/vpc.c
index 912f5d0..412ff41 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -588,6 +588,7 @@ static int64_t coroutine_fn
vpc_co_get_block_status(BlockDr
Now that all drivers return the right "file" pointer, we can use it.
Signed-off-by: Fam Zheng
---
block/io.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/io.c b/block/io.c
index c3bb7c5..1ca4e61 100644
--- a/block/io.c
+++ b/block/io.c
@@ -1550,13 +1550,13 @@ sta
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Fam Zheng
---
block/sheepdog.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 0f6789e..d5e7ff8 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -2740,6 +2740,9 @@ sd_co_get_block_status(BlockDriv
On Tue, 01/05 17:14, John Snow wrote:
>
>
> On 01/04/2016 05:27 AM, Fam Zheng wrote:
> > Following patches to refactor and move block dirty bitmap code could use
> > this.
> >
> > Signed-off-by: Fam Zheng
> > ---
> > include/qemu/typedefs.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> >
59 matches
Mail list logo
